aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-afp.c
AgeCommit message (Collapse)AuthorFilesLines
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-1/+1
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-06Move the status dissecting code to the AFP dissector.Guy Harris1-4/+502
The ASP and DSI dissectors had almost-identical dissection of the ASP and DSI "status" responses. What's being dissected is defined by the AFP specification (and might be different for protocols *other* than AFP running atop AFP or DSI), so move that dissection to the AFP dissector. Note that, at least for AFP-over-DSI, the spec isn't being followed in at least one capture. Change-Id: Idb1013483f3a3bdf2b7eb0618e48fc178a338642 Reviewed-on: https://code.wireshark.org/review/987 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-04Expose dissect_spotlight as its own dissector. Needed for DCE/RPC MDSSVCMichael Mann1-16/+19
Change-Id: I5c9dbd59b18eff5dc9cb9476f1883cb9fa9d9c02 Reviewed-on: https://code.wireshark.org/review/958 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-04Clean up some strings - "UTF8" to "UTF-8", etc..Guy Harris1-1/+1
Clean up the display of addresses a bit, and the use of verbs in some field descriptions. Change-Id: I3d2d4fc4cd13503924abecee55adfaa899385ffb Reviewed-on: https://code.wireshark.org/review/954 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-22Use tvb_get_string_enc() rather than tvb_get_string().Guy Harris1-10/+11
XXX - if we supported various MacXXX character encodings, we could use those; that might require a preference to specify the encoding. svn path=/trunk/; revision=54906
2013-12-22Don't use 'L' as a constant modifier.Bill Meier1-1/+1
svn path=/trunk/; revision=54358
2013-12-20Change G_GINT64_CONSTANT(xxxxU) to G_GUINT64_CONSTANT(xxxx)Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=54314
2013-12-13Rename spotlight_get_utf16_string_encoding() toGuy Harris1-19/+27
spotlight_get_utf16_string_byte_order(), and have it return ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN if it finds a BOM and 0xFFFFFFFF if it doesn't, to make it a bit clearer what it's doing. Use tvb_get_string_enc() rather than tvb_get_unicode_string(). svn path=/trunk/; revision=54075
2013-12-02Reject the packet if data is NULL.Chris Maynard1-7/+9
svn path=/trunk/; revision=53707
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-10-21Pass struct aspinfo "private data" into subdissectors instead of using ↵Michael Mann1-9/+11
pinfo->private_data. svn path=/trunk/; revision=52728
2013-09-22More emem -> wmem conversion:Pascal Quantin1-2/+2
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz() - tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc() - tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz() - tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str() - update docs accordingly svn path=/trunk/; revision=52180
2013-09-22emem -> wmem conversion:Pascal Quantin1-9/+9
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-12Convert a few more dissectors to wmem.Evan Huus1-3/+3
svn path=/trunk/; revision=51967
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-4/+4
svn path=/trunk/; revision=51852
2013-07-05Batch of filterable expert infos.Michael Mann1-12/+28
svn path=/trunk/; revision=50384
2013-04-01Typo's. That is all.Jaap Keuter1-1/+1
svn path=/trunk/; revision=48685
2013-03-12- [-Wmissing-prototypes]Anders Broman1-0/+4
- explicit casts. svn path=/trunk/; revision=48265
2012-12-26Squelch a (Y2.038K) warning.Guy Harris1-1/+1
svn path=/trunk/; revision=46756
2012-12-21Make some loop counters unsigned, so that we handle very large loopGuy Harris1-23/+19
counts by trying to iterate all over the items (and, presumably, failing when we go past the end of the packet). When assigning to the loop count, cast the value down, to avoid implicit 64-bit-to-32-bit conversion warnings. Write those loops as for loops - it makes it a bit clearer what's going on. svn path=/trunk/; revision=46657
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-23Comment out all but first value_string array entries with dup values:Bill Meier1-2/+2
kept: first dup since that's the one which would be found with a linear search. svn path=/trunk/; revision=44642
2012-08-10Make the corresponding packet_info available to each tree item. ThisGerald Combs1-8/+8
lets us pass a NULL pinfo to expert_add_info_format() and expert_add_undecoded_item(), which makes it possible to use those routines deep in the bowels of many dissectors. As a proof of concept remove the recent pinfo additions to packet-afp.c. This should also make it easier to fix bug 3884. svn path=/trunk/; revision=44435
2012-08-09Use wording that's more in line with other expert messages.Gerald Combs1-1/+1
svn path=/trunk/; revision=44402
2012-08-07Fix a large loop found by Stefan Cornelius of Red Hat Security ResponseGerald Combs1-7/+13
Team (bug 7603). Display the ACL entry count as decimal instead of hexadecimal. svn path=/trunk/; revision=44317
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-06From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7334 :Pascal Quantin1-6/+34
FPSpotlightRPC dates structure can contain multiple dates svn path=/trunk/; revision=43133
2012-06-04Get rid of a couple of warnings.Anders Broman1-3/+3
svn path=/trunk/; revision=43066
2012-05-19Fix some "warning: Value stored to '...' is never read" clang scan-build ↵Bill Meier1-11/+11
warnings. Also; Do some whitespace cleanup in a few cases. svn path=/trunk/; revision=42715
2012-05-15Spaces -> tabspascal1-2/+2
svn path=/trunk/; revision=42637
2012-05-15Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7261 :pascal1-12/+25
Add some sanity checks when dissecting SQ_TYPE_NULL svn path=/trunk/; revision=42636
2012-05-15From Alexander Lüders & Frank Lahm via ↵pascal1-8/+96
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7254 : Enhancements for FPSpotlightRPC AFP function svn path=/trunk/; revision=42633
2012-05-14From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7256 :pascal1-4/+9
Fix subquery_count loop variable updating svn path=/trunk/; revision=42624
2012-05-13From Frank Lahm via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7246 :pascal1-0/+18
Patch adding dissection of time data svn path=/trunk/; revision=42620
2012-05-11From Frank Lahm:pascal1-6/+14
In FPSpotlightRPC packets, check for elements with 0 childs (denoted by L in TLV is sizeof(TLV tag)) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7245 svn path=/trunk/; revision=42571
2012-05-08Remove unused hf entriespascal1-40/+3
svn path=/trunk/; revision=42516
2012-05-08From Frank Lahm:pascal1-0/+33
Display guids in FPSpotlightRPC AFP packets https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7237 svn path=/trunk/; revision=42515
2012-05-08From Frank Lahm:Anders Broman1-3/+2
Fixes for FPSpotlightRPC AFP dissector. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7235 svn path=/trunk/; revision=42508
2012-04-30Don't use tabs in string constants;Bill Meier1-4/+4
svn path=/trunk/; revision=42357
2012-04-27As suggested in ↵Jeff Morriss1-2/+2
http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html : Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no endianism, so ENC_NA is more appropriate. svn path=/trunk/; revision=42297
2012-04-13Remove doubled semicolons and semicolons outside function.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=42053
2012-02-20(Trivial) Fix a typo in a comment; Do some whitespace changes.Bill Meier1-352/+352
svn path=/trunk/; revision=41092
2011-12-04Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-8/+5
svn path=/trunk/; revision=40093
2011-10-19Fix Coverity ID #1288: UNUSED_VALUE in spotlight_dissect_query_loop:Stephen Fisher1-1/+1
"returned_pointer: Pointer ... is never used" due to break and end of function after the switch block. svn path=/trunk/; revision=39470
2011-10-19Fix Coverity ID 1300: UNUSED_VALUE in dissect_spotlight: "returned_pointerStephen Fisher1-6/+6
is never used" because of the return -1 at the end of this if block. Removed item_toc = assignment and fixed indentation. svn path=/trunk/; revision=39469
2011-10-17Cleanup AFP Version display filter name.Chris Maynard1-5/+5
svn path=/trunk/; revision=39448
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-24/+24
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-02Squelch some more warnings.Guy Harris1-2/+2
svn path=/trunk/; revision=39212
2011-10-02Squelch warnings (at that point, toc_offset has been determined to fitGuy Harris1-6/+6
into an int, as has offset + toc_offset + 8). svn path=/trunk/; revision=39211
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-26 23:16:33 +0000