aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/dcerpc
AgeCommit message (Collapse)AuthorFilesLines
2018-05-04autotools: remove more makefiles.Dario Lombardo4-22/+0
Change-Id: Ie0aa418e0515b56f0abfbab4f4c5ebc9edd7b81b Reviewed-on: https://code.wireshark.org/review/27314 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-18Remove autotools build system.Dario Lombardo1-50/+0
It has been replaced by cmake. Change-Id: I83a5eddb8645dbbf6bca9f026066d2e995d8e87a Reviewed-on: https://code.wireshark.org/review/26969 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07dissectors: more SPDX license convertions.Dario Lombardo2-26/+2
Change-Id: I96e1f1cdbaaf49d65705ecacc903f73cf0e47d7c Reviewed-on: https://code.wireshark.org/review/26334 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo7-91/+7
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-21CMake: Remove duplicate PIDL files from CMakeLists.txtJoão Valverde1-5/+0
Change-Id: I108a95aa4da80de6c96bf83d083b5ac4acd1a6ab Reviewed-on: https://code.wireshark.org/review/24528 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-11-20Revert "make-dissectors: Be more resilient with whitespace"João Valverde1-0/+2
This reverts commit ed9d08552049d061a8951f2dee5bc7b73173c14d. It's causing a segfault on our Windows buildbots. Change-Id: I3cdd31955bdec7be3ad91cff4af8dc3efdc9e8b7 Reviewed-on: https://code.wireshark.org/review/24510 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-20make-dissectors: Be more resilient with whitespaceJoão Valverde1-2/+0
Preemptively try to be more resilient for files with spaces in them (for Windows). Use newlines to separate file list. Clean up duplicate PIDL file entries. Change-Id: Ib506cca785836e05e4665e911de0d45ab4da1165 Reviewed-on: https://code.wireshark.org/review/24507 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15autotools: make maintainer-clean should allow rerunning 'configure'João Valverde1-3/+0
Change-Id: Iedae94ffefe27b13b1967d69cacb757b5aa4576d Reviewed-on: https://code.wireshark.org/review/23928 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-08-12Sync some CMake and Autotools install behaviors.Gerald Combs1-19/+0
Adjust the following CMake and Autotools behaviors in order to synchronize their respective install behaviors: - Disable tfshark by default in CMakeOptions.txt - Add profiles/Bluetooth/preferences to Makefile.am - Add missing captype and ciscodump entries to doc/Makefile.am - Install help/faq.txt on all platforms in CMakeLists.txt - Add BUILD_corbaidl2wrs, BUILD_dcerpcidl2wrs, and BUILD_xxx2deb options to CMake and use them to adjust the corresponding parts of the build. - Pull the DCERPC idl2wrs build steps into the top-level CMakeLists.txt. This change doesn't sync everything. Some installed content still diverges, including the following: - CMake installs a bunch of modules into lib/wireshark: FindGLIB2.cmake FindWireshark.cmake FindWSWinLibs.cmake LocatePythonModule.cmake UseAsn2Wrs.cmake UseMakeDissectorReg.cmake WiresharkConfig.cmake WiresharkConfigVersion.cmake Do we need any or all of these? If so, should the Autotools behavior be synced accordingly? - Autotools installs libtool .la files. It also installs wireshark-gtk.desktop unconditionally. Change-Id: I7846efe08f7139c31b6ceca6f08a1fa5168b3e22 Reviewed-on: https://code.wireshark.org/review/23041 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-13Fix call to ws_strtoi32().Guy Harris1-2/+2
Change-Id: I536ee3fbda563f4b544eea334c5d7e9a642c69e2 Reviewed-on: https://code.wireshark.org/review/18181 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-13idl2wrs: use ws_strtou function.Dario Lombardo1-1/+4
Missed from previous patch gb15079b. Change-Id: I3fce792608e989c8ac100f1f57cb11fdb7b35142 Reviewed-on: https://code.wireshark.org/review/18147 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-08idl2wrs: use ws_strtou function.Dario Lombardo1-4/+4
Change-Id: I696688088ae926e32ff6c4518c020537d8fe7597 Reviewed-on: https://code.wireshark.org/review/18115 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-30cmake: make WERROR_COMMON_FLAGS a normal stringPeter Wu1-7/+5
Instead of checking for the boolean "FALSE", just set an empty string. This avoids the need to check for WERROR_COMMON_FLAGS before using it. The transformation is the same for all files, remove "if (WERROR_COMMON_FLAGS)" and "endif()", reindent and add quotes (since we have a string here and not a list). Modelines have been added where missing. Change-Id: I0ab05ae507c51fa77336d49a99a226399cc81b92 Reviewed-on: https://code.wireshark.org/review/17997 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com>
2016-09-25idl2wrs: use ws_strtou functionDario Lombardo3-4/+8
Change-Id: I90173b0defc04ac80054170153afe9389def620b Reviewed-on: https://code.wireshark.org/review/17837 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-27cmake: add idl2wrs-dissectors target for DCERPCPeter Wu1-5/+53
Add a callable target such that dissectors can be generated without the AUTOGEN_dcerpc option. Modelled after the pidl CMakeLists.txt file and target. This approach has the advantage over the previous implementation such that the clean target does not remove the packet-dcerpc-X.c files. Change-Id: I3226937eaa76dffa253df9d4f989421d5faa3f3f Reviewed-on: https://code.wireshark.org/review/15989 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-06-17idl2wrs: fix more bad strndupsPeter Wu1-11/+11
Fixed another g_strndup case that truncated the name and replaced more by strdups when possible. Change-Id: Id7ce4d82da9fb1d0071bc7a6b4e7c2062bf77f55 Reviewed-on: https://code.wireshark.org/review/15988 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-15idl2wrs: fix code generationPeter Wu1-39/+39
Fixes a regression from v1.99.9rc0-470-g87f2bd4 which truncated function names to 26 characters. Test: cd epan/dissectors/dcerpc/budb make IDL2WRS=/tmp/wsbuild/run/idl2wrs diff packet-dcerpc-budb.c ../../packet-dcerpc-budb.c While at it, replace all g_strndup(X, strlen(X)) occurrences with g_strdup(X) since that is the same thing and less redundant. Change-Id: Id8da45792c830e2287cf8f14ff6245149751afd2 Reviewed-on: https://code.wireshark.org/review/15939 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-25Clean up modelines and indentation.Guy Harris1-5/+4
HT tab stops are set every 8 spaces on UN*X; UN*X tools that treat an HT character as tabbing to 4-space tab stops, or that even are configurable but *default* to 4-space tab stops (I'm looking at *you*, Xcode!) are broken. tab-width: 4, tabstop=4, and tabSize=4 are errors if you ever expect anybody to look at your file with a UN*X tool, and every text file will probably be looked at by a UN*X tool at some point, so Don't Do That. Adjust indentation to reflect the mode lines. Change-Id: Icf0831717de10fc615971fa1cf75af2f1ea2d03d Reviewed-on: https://code.wireshark.org/review/14150 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-21autotools: Use pkg-config autoconf macros for GLib/GTKJoão Valverde1-1/+3
Remove mostly obsolete aclocal macros. Make GTK build flags a strict superset of GLib flags. Use GTK build variables for GTK GUI and GLib elsewhere. Add dependency flags explicitly instead of using WS_CPPFLAGS. Some minor improvements and fixes for missing/unnecessary variables (no impact on our test builds). Change-Id: I3e1f067a875f79d6516c1fa7af986f17a7a6b671 Reviewed-on: https://code.wireshark.org/review/14005 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28autotools: Don't use "user variables" to set build flagsJoão Valverde1-0/+1
GNU coding standards recommend against it and automake is designed around it. This allows overriding the global build flags using AM_CFLAGS, etc., or per object flags, something that is difficult or impossible currently because of automake precedence rules. Change-Id: I3f1ea12e560af5a46b2f04b342b1882bbf123f12 Reviewed-on: https://code.wireshark.org/review/13455 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2015-11-09idl2wrs: fix some glibc calls in favour of glib.Dario Lombardo1-328/+345
This change should fix some complains from coverity. Change-Id: Ic46212e12892779b2aa0276e028fea2d9fbb6985 Reviewed-on: https://code.wireshark.org/review/10545 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-10-16CMake: Add /WXGerald Combs1-2/+2
Add "/WX" to the Visual C++ compiler flags if DISABLE_WERROR is off, similar to config.nmake. We haven't compiled C++ code with -Wshorten-64-to-32 for quite some time so there's no need to add -Wno-shorten-64-to-32 in ui/qt/CMakeLists.txt. Additionally, squelch ---- C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\algorithm(3050) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data (.\rpc_service_response_time_dialog.cpp) C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\algorithm(3065) : see reference to function template instantiation 'void std::_Median<_RanIt,bool(__cdecl *)(const QString &,const QString &)>(_RanIt,_RanIt,_RanIt,_Pr)' being compiled with [ _RanIt=QList<QString>::iterator , _Pr=bool (__cdecl *)(const QString &,const QString &) ] C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\algorithm(3127) : see reference to function template instantiation 'std::pair<_RanIt,_RanIt> std::_Unguarded_partition<_RanIt,bool(__cdecl *)(const QString &,const QString &)>(_RanIt,_RanIt,_Pr)' being compiled with [ _RanIt=QList<QString>::iterator , _Pr=bool (__cdecl *)(const QString &,const QString &) ] C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\algorithm(3157) : see reference to function template instantiation 'void std::_Sort<_Iter,int,bool(__cdecl *)(const QString &,const QString &)>(_RanIt,_RanIt,_Diff,_Pr)' being compiled with [ _Iter=QList<QString>::iterator , _RanIt=QList<QString>::iterator , _Diff=int , _Pr=bool (__cdecl *)(const QString &,const QString &) ] .\rpc_service_response_time_dialog.cpp(130) : see reference to function template instantiation 'void std::sort<QList<QString>::iterator,bool(__cdecl *)(const QString &,const QString &)>(_RanIt,_RanIt,_Pr)' being compiled with [ _RanIt=QList<QString>::iterator , _Pr=bool (__cdecl *)(const QString &,const QString &) ] C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\algorithm(3051) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data (.\rpc_service_response_time_dialog.cpp) C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\algorithm(3052) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data (.\rpc_service_response_time_dialog.cpp) C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLUDE\algorithm(3053) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data (.\rpc_service_response_time_dialog.cpp) ---- in both rpc_service_response_time_dialog.cpp and wireshark_application.cpp so that we'll compile successfully. Change-Id: I457bcede99dcb1f3c1001f1f559c4901bb000357 Reviewed-on: https://code.wireshark.org/review/10533 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-28Cosmetic tidy up for the projects in the Visual Studio solutionGraham Bloice1-0/+1
Change-Id: Ie4ed28ee7e59def2e8a15433334988b4d0225d1d Reviewed-on: https://code.wireshark.org/review/10675 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-09-02idl2wrs: fix clang analyzer Warning complains.Dario Lombardo1-8/+12
890:9: warning: Access to field 'str' results in a dereference of a null pointer (loaded from variable 'token_list') 3132:4: warning: Value stored to 'str' is never read 3155:4: warning: Value stored to 'str' is never read 3166:4: warning: Value stored to 'str' is never read 3183:4: warning: Value stored to 'str' is never read 3192:4: warning: Value stored to 'str' is never read 3203:4: warning: Value stored to 'str' is never read 3220:4: warning: Value stored to 'str' is never read Change-Id: If1a1acfc331e0648f95f6d6defe6533b6927ccaa Reviewed-on: https://code.wireshark.org/review/10357 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-02idl2wrs: Make Mac OSX buildbot happyAlexis La Goutte1-1/+1
Change-Id: I5f9c860bec0f8d323d9f3cd7cf55e348654c8b8b Reviewed-on: https://code.wireshark.org/review/10354 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-02idl2wrs: some code cleanups.Dario Lombardo3-229/+330
Code cleanups include: - sanity checks for malloc() - change forbidden APIs into g_* versions - minor indentation fixes - add modeline - add compilation for cmake and autotools Bug: 11052 Change-Id: I825f04d9703448f9165d188be2bdd185fce5ff5d Reviewed-on: https://code.wireshark.org/review/10030 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-03Eliminate e_uuid_t in favor of e_guid_t.Guy Harris1-1/+1
That eliminates a redundant and confusing data type, and avoids issues with one piece of code using e_uuid_t but wanting to use routines expecting an e_guid_t. Change-Id: I95e172d46d342ab40f6254300ecbd2a0530cde60 Reviewed-on: https://code.wireshark.org/review/7506 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-08DCERPC (DRSUAPI) Fix typo found on idl fileAlexis La Goutte1-1/+1
Change-Id: I79ad05122ae48de671c9c919bab6b3e8d94a50de Reviewed-on: https://code.wireshark.org/review/4554 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-07idl2wrs (DCERPC DRSUAPI): Fix Dead Store (Dead assignement/Dead increment) ↵Alexis La Goutte1-2/+12
warning found by Clang Add a check if the struct is not empty budb and butc are also regenerate but no change Change-Id: I0d8cfc827f5451f1cdbd924628a263af9d483a7b Reviewed-on: https://code.wireshark.org/review/4473 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-04DCERPC (butc): fix warning: no previous prototype for ... [-Wmissing-prototypes]Alexis La Goutte1-2/+2
Fix a typo in last patch and regenerate file Change-Id: Id9083edd797af97d72a872187a0d0b5750e04547 Reviewed-on: https://code.wireshark.org/review/4453 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-01idl2wrs (DCERPC): fix some warningAlexis La Goutte4-3/+12
* Fix -Wmissing-prototypes in * Fix unused variable for drusapi (using _U_) Need to fix indent and some unused function/variable to remove from DIRTY list Change-Id: Ib6f325f0b54e2eb254ec38a41199b4b60a4d90a1 Reviewed-on: https://code.wireshark.org/review/4398 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-19Update generated DCE/RPC dissectors.Michael Mann1-2/+1
Now all generated dissectors can successfully compile. Change-Id: I74728926915d5a9f1694cc49c753b80f213df767 Reviewed-on: https://code.wireshark.org/review/2598 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-31Continue to remove $Id$ from top of fileAlexis La Goutte6-12/+0
(Using sed : sed -i '/^\# \$Id\$/,+1 d') (start with dash) Change-Id: Ia4b5a6c2302f6a531f6a86c1ec3a2f8205c8c2dd Reviewed-on: https://code.wireshark.org/review/881 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte7-14/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-06Remove pinfo->private_data from DCERPC dissectors. Bug 9387 ↵Michael Mann4-96/+92
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387) This is the "Wireshark DCERPC" input file changes necessary to support removing pinfo->private_data from the DCERPC dissectors in favor of passing it through function parameters. I didn't regenerate the dissector source, so this is just a "good faith" effort to mimic the manual changes. svn path=/trunk/; revision=53099
2013-06-10tools/lemon/lemon.c: Fix an integer shortening issue. (CMake enablesGerald Combs1-1/+1
-Werror here but Autotools doesn't. Which is correct?) epan/dissectors/dcerpc: idl2wrs isn't an installed executable in Autotools so don't make it one in CMake. svn path=/trunk/; revision=49871
2013-06-01More constification.Guy Harris1-2/+2
svn path=/trunk/; revision=49681
2013-06-01More constification.Guy Harris1-5/+5
svn path=/trunk/; revision=49680
2013-06-01More constification.Guy Harris1-4/+4
svn path=/trunk/; revision=49678
2013-06-01More constification.Guy Harris1-5/+5
svn path=/trunk/; revision=49674
2013-06-01Note which *particular* IDL this is. (Actually, is that the OSF's DCEGuy Harris1-5/+5
RPC IDL, Microsoft's DCE RPC IDL, or Samba's DCE RPC IDL?) Constify some stuff to squelch warnings. svn path=/trunk/; revision=49672
2013-05-07Fix a c++ compat warning in the template and copy the resultingJörg Mayer1-1/+1
file to packet-dcerpc-drsuapi.c This seems to undo some (warning fix) changes made to the dissector directly instead of fixing the template (or generator). svn path=/trunk/; revision=49192
2013-04-16From Roland Knall via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8588Evan Huus1-12/+12
Add casts to that idl2wrs compiles with -Wc++-compat svn path=/trunk/; revision=48875
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss3-6/+0
svn path=/trunk/; revision=45017
2012-06-28Update Free Software Foundation address.Jakub Zawadzki9-9/+9
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-14Make the "idl-light"-to-dissector generator handle hex (and octal)Guy Harris1-1/+8
values in enums (and, while we're at it, add some error checking for valid values). (The regenerated dissectors don't differ usefully from the fixed dissectors, so we don't check them in.) svn path=/trunk/; revision=42626
2012-05-14Get rid of remaining Booleans-as-encoding-arguments inGuy Harris2-17/+8
proto_tree_add_item() calls. Change the "idl-light"-to-dissector generator to use ENC_NA for structures and ENC_LITTLE_ENDIAN for bitmasks (are they always little-endian, or should they check the data representation?). Also change it to properly set the display format for FT_ABSOLUTE_TIME fields (it now specifies whether to show local time, UTC, or UTC with a 1-origin day-of-year). Change one routine in the template for the DRSUAPI dissector to use ENC_UTF_16|ENC_LITTLE_ENDIAN with proto_tree_add_item() (the field it dissects is known to be a string, so there's no need to check its data type). Regenerate the BUDB, BUTC, and DRSUAPI dissectors. (The generated BUTC dissector handles pointers differently - either the old dissector was wrong, or the generator is wrong, or the IDL for the protocol is wrong, or the difference doesn't actually affect dissection.) The generator doesn't currently handle hex values in enums correctly; manually fix packet-dcerpc-drsuapi.h. svn path=/trunk/; revision=42625
2011-11-21Move generated dissctors that are causing problems to DIRTY.Jörg Mayer1-1/+1
packet-x11.c: hundreds of: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h: In function ‘xselinuxGetClientContext’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h:27994:9: warning: variable ‘f_resource’ set but not used [-Wunused-but-set-variable] /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/x11-extension-implementation.h: In function ‘xselinuxGetClientContext_Reply’: dissectors/packet-dcerpc-mapi.c: set but not used /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_req’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8592:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable] /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_Release_repl’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8617:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable] /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c: In function ‘mapi_dissect_struct_RecipSMTP’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-mapi.c:8848:14: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable] dissecots/packet-dcerpc-drsuapi.c: set but not used /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-drsuapi.c: In function ‘drsuapi_dissect_DsGetNCChangesCtr7’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-drsuapi.c:2920:17: warning: variable ‘tree’ set but not used [-Wunused-but-set-variable] Btw.: Does it really make sense to use an extra CMakefile for the dcerpc/ dir? I'd rather the the idl2wrs.c in tools/ and the generatorstuff in epan/CMake More files with the same problem. svn path=/trunk/; revision=39968
2011-08-16More misspellings of "unknown", for bug 6244.Guy Harris1-1/+1
svn path=/trunk/; revision=38565
2011-07-19Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the dataGuy Harris1-1/+1
representation. Use it rather than a raw 0x10. Add a DREP_ENC_INTEGER() macro that takes a pointer to the data representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN; use it for the encoding argument to proto_tree_add_item(), rather than just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean any more, and for string values we'll be supporting character encodings as well and thus won't be able to trust that the 0x10 bit will mean "little endian". Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the like. Fix a couple of places in the DCOM dissector where we were passing the byte-order bit rather than the field value to proto_tree_add_uint_format(). Clean up white space. svn path=/trunk/; revision=38128