aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/asn1/HI2Operations
AgeCommit message (Collapse)AuthorFilesLines
2021-11-02Lift restriction on upper case protocol display filter namesJoão Valverde1-1/+1
Unlike other header fields in filter expressions protocol names cannot contain upper-case letters. Remove that restriction. This should make start-up slightly faster as it remove an extra loop for each protocol filter name. This was added in 9ead15a6eb16be93559d71b4083948338ab9d26e but I don't see a reason to have different rules for protocols and fields, it seems the README.developer was just being vague and conflating PROTOABBREV with PROTOFILTERNAME. The recommendation for lower case is a style recommendation, and it's a good one, but it should be applied uniformly. As long as we are not enforcing this for all field filter values there is no point in enforcing it just for protocol names and actually it is detrimental, e.g: hi2operations HI2Operations.IRIsContent HI2Operations.UUS1_Content_element HI2Operations.iRIContent HI2Operations.iRISequence HI2Operations.IRIContent HI2Operations.iRI_Begin_record_element HI2Operations.iRI_End_record_element HI2Operations.iRI_Continue_record_element HI2Operations.iRI_Report_record_element (...) It's weird and unexpected to have this difference and there is no technical reason to require it. What we should probably do is not include the protocol name in the FIELDFILTERNAME and have the registration mechanism append it to the PROTOFILTERNAME. Also disallow leading '-' everywhere in filter names, not just protocol filter names. It's a universal requirement.
2020-12-15asn2wrs: Rename duplicated filter namesAnders Broman1-4/+13
2019-01-06H2Operations: Fix Dead Store (Dead assignement/Dead increment) Warning found ↵Alexis La Goutte1-1/+1
by Clang Change-Id: I9913b9653fedeb9cc119f10632f4c96fe54027b4 Reviewed-on: https://code.wireshark.org/review/31408 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-26No need to export a dissector for UUS1-Content_PDUs.Alexis La Goutte2-2/+1
Nothing else uses it. Change-Id: I1de8ced2ceeaf02f2c9eeeef9b6680d5ad7f4794 Reviewed-on: https://code.wireshark.org/review/31201 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06HI2Operations: update auto generated file and remove unused templatePascal Quantin1-32/+0
Change-Id: If31c0fdfac9c450871accba53715dc4d0e6468a6 Reviewed-on: https://code.wireshark.org/review/30939 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-05HI2Operations: Remove the not needed .h file.Anders Broman2-2/+0
Change-Id: Iabb24aae94814d4a10fdfa998f870b5e2cd3a8d8 Reviewed-on: https://code.wireshark.org/review/30921 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Add dissection of HI3CCLinkDataAnders Broman5-3/+177
Change-Id: I002c31972c4bcc231527eeaa2c6b21c3b1a9636a Reviewed-on: https://code.wireshark.org/review/30920 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-18Remove autotools build system.Dario Lombardo1-32/+0
It has been replaced by cmake. Change-Id: I83a5eddb8645dbbf6bca9f026066d2e995d8e87a Reviewed-on: https://code.wireshark.org/review/26969 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07dissectors: more SPDX license convertions.Dario Lombardo2-26/+2
Change-Id: I96e1f1cdbaaf49d65705ecacc903f73cf0e47d7c Reviewed-on: https://code.wireshark.org/review/26334 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-30Remove Makefile.common filesJoão Valverde2-46/+25
Now that nmake build system has been removed they are not needed anymore. Change-Id: I88075f955bb4349185859c1af4be22e53de5850f Reviewed-on: https://code.wireshark.org/review/16050 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-06-15Remove Nmake build systemPascal Quantin1-25/+0
Change-Id: I3bd474f3cda9667dec66426b5729449953df3e61 Reviewed-on: https://code.wireshark.org/review/15777 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de> Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2016-03-13Clean asn1 make/cmake whitespaceJoão Valverde4-4/+0
Add missing newline or remove extra newlines at the end of the file. Trim trailing whitespace. Change-Id: I73b7a4e20969bc13f72bf97e981fd5de89d8bb17 Reviewed-on: https://code.wireshark.org/review/14400 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-13Move /asn1 to /epan/dissectorsJoão Valverde11-0/+1982
Change-Id: I1208fe3c2ba428995526f561e8f792b8d871e9a9 Reviewed-on: https://code.wireshark.org/review/14388 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: João Valverde <j@v6e.pt>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-25 06:49:13 +0000