aboutsummaryrefslogtreecommitdiffstats
path: root/doc
AgeCommit message (Collapse)AuthorFilesLines
2020-04-05proto: Add a debug check to sanity-check range_stringMartin Mathieson1-1/+4
Check is enabled by #ifdef ENABLE_CHECK_FILTER Remaining issues found by this check are fixed here, along with a documentation note that the entries are checked in order and the first match is used. The only issue not yet fixed is in packet-isup.c, where the spec was not available to me. Change-Id: Ife747cda9b91a265bc2b81ce0a53f55f3389919e Reviewed-on: https://code.wireshark.org/review/36708 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-04-05Dumpcap manual: remove duplicate '-i' in synopsisJaap Keuter1-1/+0
Commit 3398c2898dcc95c83ab026d62d8a08290ad3cb0b duplicated the '-i' option in the synopsis. Remove this again. Change-Id: I85fb78515910b11e9dff9b3aa876746b2ff11fa4 Reviewed-on: https://code.wireshark.org/review/36678 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-01Document the -k option.Guy Harris1-0/+43
Change-Id: Ia695e3edcf673495eb8e61edfa72709fda2f99af Reviewed-on: https://code.wireshark.org/review/36663 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-02-23Use "must" instead of "should" to avoid ambiguity.Guy Harris1-2/+2
As I said in https://ask.wireshark.org/question/10361/how-to-properly-use-heuristic-dissector-for-tcp/?answer=10363#post-id-10363 "Should" has multiple meanings; there's "Used to indicate obligation, duty, or correctness, typically when criticizing someone's actions.", as in "I think we should trust our people more", and there's "Used to indicate what is probable.", as in "the bus should arrive in a few minutes". You're reading it in the latter sense; it was intended in the former sense. That sentence should probably be changed to "Wireshark must be then set up..." to avoid the ambiguity. Make it so (over half a year later, sigh), and change another case where "should" is meant in the first sense while we're at it. Change-Id: I90198d1616619c75802deeeb703ceee0c8bac1bf Reviewed-on: https://code.wireshark.org/review/36155 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-02-17doc: Apply proper capitalization to the Wireshark nameJaap Keuter11-35/+35
Change-Id: I9d29cd705c9af39bae6cffdefaba0b9c8b4bb2e6 Reviewed-on: https://code.wireshark.org/review/36081 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-17DOC: Remove lingering references to autotoolsJaap Keuter1-16/+10
In the README.plugins file there is still mention of autotools related items. This change removes those lingering references. Change-Id: I1fc7c6d478a6fc8bbe9481178d9f673aaebcad9f Reviewed-on: https://code.wireshark.org/review/35843 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-05[Automatic update for 2020-01-05]Gerald Combs3-4/+4
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I871629b91d38be26bfe448bf90dfbb47a97acdfa Reviewed-on: https://code.wireshark.org/review/35652 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-17WSUG: Update the Expert Information and Status Bar docs.Gerald Combs1-5/+0
Update the Expert Information section of the User's Guide. Use the term "Expert Information" to describe the dialog and "expert information item" to describe each generated item. Update related text elsewhere. Update the expert icon and other parts of the status bar docs. Change-Id: I0c2cba0cbb3c74a1f6e3a37d4a2a592faccb350f Reviewed-on: https://code.wireshark.org/review/35462 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-10More Qt minimum version updates.Gerald Combs1-1/+1
Update the minimum version in various documents. Remove some no-longer-needed code from scripts that call windeployqt. Change-Id: I16da4bced9780c9f1b1969aae7c52e2fce1968aa Reviewed-on: https://code.wireshark.org/review/35391 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-04README.dissector: Add a note about integer promotion.Gerald Combs1-0/+7
Change-Id: Ie3b6dfcea7b1cee3b0bda3d9ec2cc9a6857578fc Reviewed-on: https://code.wireshark.org/review/35308 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-02NSIS: The "Sshdump" option installs Ciscodump as well.Gerald Combs1-1/+1
Use consistent capitalization while we're here. Change-Id: I0591654b0e73d33528f9cfe990a1491ce6cccc8b Reviewed-on: https://code.wireshark.org/review/35278 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-30Documentation: update (long) cmd line optionsJaap Keuter2-131/+82
Documentation of the Tshark and dumpcap command line options between help text, manual page and user's guide diverged over time. One aspect of this is the implementation of more long options. This change tries to update all documentation to be complete and in sync again. Change-Id: Ie8bee013df8d209080fcf288072774f18f9ff51f Reviewed-on: https://code.wireshark.org/review/35261 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-11-28doc: add reordercap to editcap references.Dario Lombardo1-1/+1
Ping-Bug: 16231 Change-Id: Id4fb9bab7230561e64fcdc49c02bcb2016ed23e7 Reviewed-on: https://code.wireshark.org/review/35249 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-14tools: add automatic C skeleton dissector generator.Dario Lombardo2-2/+15
Generate a dissector based on doc/packet-PROTOABBREV.c. Change-Id: I9233c1212acb30f7166ba91e39d98bc3fb123731 Reviewed-on: https://code.wireshark.org/review/35062 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-11-11Documentation: update (long) cmd line options.Jaap Keuter1-110/+63
Documentation of the Wireshark command line options between help text, manual page and user's guide diverged over time. One aspect of this is the implementation of more long options. This change tries to update all documentation to be complete and in sync again. Bug: 16168 Change-Id: Id833fbeb14fdb7b3dbc1564504a25d96f4367c91 Reviewed-on: https://code.wireshark.org/review/35047 Reviewed-by: Jörg Mayer <jmayer@loplof.de> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-11-06Document long command line options.Dario Lombardo2-2/+22
Bug: 16168 Change-Id: Ifdfa9092b632171c461430bc3e9de32ec1ed46f4 Reviewed-on: https://code.wireshark.org/review/34996 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-05Fix find_conversation_pinfo() description in documentationPascal Quantin1-1/+2
Change-Id: I3956dd841ee29d1676dbe2d1927a31bae5249414 Reviewed-on: https://code.wireshark.org/review/34986 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-10-10Revert "CMake: Don't install HTML manuals twice"João Valverde1-26/+0
This reverts commit f1285fcf061669702ca1accd7b2c50ebc8198993. NSIS package is broken with this commit. Change-Id: Ief22a308edad188fa2d5fab79355f19493359fa6 Reviewed-on: https://code.wireshark.org/review/34758 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2019-10-09CMake: Don't install HTML manuals twiceJoão Valverde1-0/+26
HTML docs are installed to both $docdir and $pkgdatadir. Fix that to install to $docdir only. Change-Id: I115158585b6df9170d9a01249adbc8548df91f14 Reviewed-on: https://code.wireshark.org/review/34640 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2019-10-04QUIC: Add Follow QUIC Stream support to Qt and tsharkPeter Wu1-0/+6
The QUIC transport protocol provides a stream, similar to HTTP/2. Make it possible to look at the stream contents. This can be helpful while HTTP/3 support is not yet complete. Known issues that will be addressed in the future: - If a single packet contains multiple streams, then Follow QUIC Stream will wrongly include data from streams other than the selected one. This is tracked by bug 16093 and affects HTTP/2 as well. - The Substream index menu does not properly filter for available stream numbers. If a non-existing stream is selected, then changing to another (potentially valid) index results in the "Capture file invalid." error. As workaround, clear the display filter first. - Follow Stream always selects Stream ID 0 instead of the first or currently selected stream field in a packet. Users should manually update the stream index as needed. Change-Id: I5866be380d58c96f0a71a29abdbd1be20ae3534a Ping-Bug: 13881 Reviewed-on: https://code.wireshark.org/review/34694 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-27CMake: Fix sdjournal.html install destinationJoão Valverde1-1/+1
Change-Id: I0527a8ce19838c15811471eddce65310286eddb6 Reviewed-on: https://code.wireshark.org/review/34641 Reviewed-by: João Valverde <j@v6e.pt>
2019-09-22Qt, http2: Add Follow HTTP/2 Stream functionalityAlexander Gryanko1-2/+21
The HTTP/2 protocol multiplexes a single TCP connection into multiple independent streams. The Follow TCP output can interleave multiple HTTP/2 streams, making it harder to analyze a single HTTP/2 stream. Add the ability to select HTTP/2 Streams within a TCP stream. Internally, the HTTP/2 dissector now stores the known Stream IDs in a set for every TCP session which allows an amortized O(n) lookup time for the previous/next/max Stream ID. [Peter: make the dissector responsible for clamping the HTTP/2 Stream ID instead of the Qt code, that should permit future optimizations.] Change-Id: I5d78f29904ae8f227ae36e1a883155c0ed719200 Reviewed-on: https://code.wireshark.org/review/32221 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexander Gryanko <xpahos@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-20README.dissector: fix proto_tree_add_bitmask_len signatureDevan Lai1-1/+1
proto_tree_add_bitmask_len also expects an expert information field to display in the event that the decodeable length is less than the specified length. Bug: 16061 Change-Id: If8061b0754cd6862799ab76bf9c10e16ed5d8f38 Reviewed-on: https://code.wireshark.org/review/34567 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-09-17extcap: Fix type in exampleRoland Knall1-2/+2
Change-Id: Id76fde0786dde466a13adea423ff349a2b7400e1 Reviewed-on: https://code.wireshark.org/review/34554 Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-02tshark: Add "ip" as alias for "ipv4" in -z hosts option.Michael Mann1-2/+3
Make it consistent with -z conv,ip and -z endpoints,ip Bug: 15660 Change-Id: I9a3d2e95fed47231c0bab20e6cf069987eed142f Reviewed-on: https://code.wireshark.org/review/34426 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-25tshark: Complement manual page synopsisJaap Keuter1-1/+2
Add '-J' option to synopsis and reshuffle '-j' to correct place. Change-Id: I351b3ce464fca3b52a75614e1e8f8c91f9a30df2 Reviewed-on: https://code.wireshark.org/review/34352 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-07-29doc: document WIRESHARK_CONFIG_DIRPeter Wu3-12/+15
WIRESHARK_CONFIG_DIR was introduced with Wireshark 3.0 and is more cross-platform than WIRESHARK_APPDATA. The latter was presumably created for use by PortableApps. Let's consider that an internal, undocumented detail that might be change, and document WIRESHARK_CONFIG_DIR instead. Change-Id: I0042d607b282cc6dee4b017b1e80b44087bd62e9 Reviewed-on: https://code.wireshark.org/review/34113 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-20Documentation: convert http URLS to httpsPeter Wu4-6/+11
Remove some dead links or point them to archive.org while at it. All updated links have been verified. Change-Id: Icf02167a13d5fe9dfce39ea57525b3f185554c9d Reviewed-on: https://code.wireshark.org/review/34028 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-16Editcap: Allow floating point split intervals.Gerald Combs1-3/+4
Update the `-i` option to allow floating point values as suggested at https://stackoverflow.com/questions/57004719/split-wireshark-to-miliseconds Change-Id: I24028d409bc441ed3b45ac2179f7c42b2bc424bc Reviewed-on: https://code.wireshark.org/review/33938 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-26tap: add credentials tap.Dario Lombardo1-0/+7
This new tap collects credentials (username and paassword) from the dissectors. So far, few dissectors have been instrumented: - http (basic auth) - http (header auth) - ftp Others can be instrumented as well using the same technique. Tshark has a new option (-z credentials) and Wireshark a new "tools" menu: the documentation has been updated accordingly. Change-Id: I2d0d96598c85bb3ea4fb5ec090dd8dc28b481fc9 Reviewed-on: https://code.wireshark.org/review/33453 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-06-20Use I/O Graphs instead of IO graphs everywhere.Dario Lombardo1-1/+1
Change-Id: I6ce866b03632965dd1bad6eff361d91dd210c62b Reviewed-on: https://code.wireshark.org/review/33680 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-19sshdump: fix bug in --remote-sudo.Dario Lombardo1-0/+1
Fix documentation as well. Bug: 15845 Change-Id: I1b4e50c21887afa6a60b76de6cc169a1d0b5067a Reviewed-on: https://code.wireshark.org/review/33658 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17Add support for embedding WireGuard keys in a pcapng filePeter Wu1-1/+2
pcapng spec update is here: https://github.com/pcapng/pcapng/pull/62 Bug: 15571 Change-Id: I2f1921b1da70ac0bab8c38dd5138a9dfe7843fea Reviewed-on: https://code.wireshark.org/review/33300 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-12REAME.dissector: update the code snippet for Decode AsMartin Kaiser1-1/+1
We removed the "title" member from decode_as_t. Update the sample code snippet accordingly. Change-Id: I5d4ba979c955de50287f5b4deea7c64bf96f7d9b Reviewed-on: https://code.wireshark.org/review/33574 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-11Kill libwscodecs plugin library, just use pluginsJoão Valverde1-1/+1
Change-Id: I085d04840acb53b0b7681787429a2b4e10547cd5 Reviewed-on: https://code.wireshark.org/review/33068 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-09Document why extcap utilities can't be run "by hand" on WindowsMichael Mann1-2/+8
Bug: 15591 Change-Id: Icb8246ba196df026736ce1e54eb2ace2c7cd49b0 Reviewed-on: https://code.wireshark.org/review/33530 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-09REAME.dissector: remove double spaces.Dario Lombardo1-149/+149
Change-Id: I87b9748bb14b148cfc7ffdc5fd5d9059fa2d2299 Reviewed-on: https://code.wireshark.org/review/33522 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-07Improve handling of binary data that *might* be text.Guy Harris1-9/+17
Add a BASE_SHOW_ASCII_PRINTABLE flag for the "display" field, to use with FT_BYTES and FT_UINT_BYTES fields; it specifies that, if the field consists solely of printable ASCII characters, its value be displayed as a string, in quotes. Have a routine hfinfo_format_bytes() to do that formatting, depending on the display field value. Add routines to fetch the display value of string and FT_BYTES/FT_UINT_BYTES fields; for strings, it's the result of hfinfo_format_text(), and for byte arrays, it's the result of hfinfo_format_bytes(). Use BASE_SHOW_ASCII_PRINTABLE for extended attribute data in SMB and SMB2. Use the routines in question for extended attribute names (string) and data (bytes). That keeps us from displaying non-text extended attribute data as if it were text. Document BASE_SHOW_ASCII_PRINTABLE. Change-Id: I24dcf459c14f00985e4daaf9b58f5933964eabd8 Reviewed-on: https://code.wireshark.org/review/33517 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-05-31README.tapping: minor changes.Dario Lombardo1-14/+7
Change-Id: I0614d4c0cc8c9aada8660297b9d08f9d03129e29 Reviewed-on: https://code.wireshark.org/review/33433 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-05-29Use the HTTPS URL for our main site in a few places.Gerald Combs1-2/+2
Fixup the encoding of plugins/plugin.rc.in while we're here. Change-Id: I21b56ce68bc3d84298a846a991c72bf710b9ae8a Reviewed-on: https://code.wireshark.org/review/33414 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-05-20extcap: Fix Python 3 control data handling in exampleTomasz Moń1-1/+1
Decode received payload as utf-8 string, replacing any invalid characters with U+FFFD. Change-Id: If80fbbec5c369f1098dbc1e46e092928aa0b0eb9 Reviewed-on: https://code.wireshark.org/review/33252 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-05-07Update tshark man pages for -j and -JMoshe Kaplan1-10/+12
Change-Id: I221013d5948c4c699b1721441b54a05dc5ff2ce2 Reviewed-on: https://code.wireshark.org/review/33089 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-21wireshark-filter: clarifications and update links in manualPeter Wu1-5/+8
Clarify *display* filter, add link to User's Guide, and update to https. Change-Id: I9a2152213cf5b4cb3daf15e62c73074524d92f94 Reviewed-on: https://code.wireshark.org/review/32912 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-17extcap: Improve example multicheck valuesTomasz Moń1-2/+16
Multicheck values can be checkable or uncheckable depending on the "enabled" option. Moreover, multicheck values can be stacked into a tree by providing a "parent" option. Modify the example extcap to illustrate these possibilities. Bug: 13355 Change-Id: I0c50ff873c07eca5cc4ae8036b87cbb440d318b3 Reviewed-on: https://code.wireshark.org/review/32842 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-15extcap: Fix Python 3 bytes handling in exampleTomasz Moń1-2/+1
In Python 3 strings cannot be joined with bytes. This change has no effect for Python 2. Ping-Bug: 15694 Change-Id: I2eb62698ce323f8156ed98b7fe88e4e43e59c784 Reviewed-on: https://code.wireshark.org/review/32843 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs2-12/+12
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-03Document all the signed-integer tvbuff accessors.Guy Harris1-21/+90
Reorganize the lists of accessors, with a top-level heading for the byte order and subheadings for each size. Also document ENC_HOST_ENDIAN. Change-Id: I10131e399f6c90624a387c89340f77ea769ab33f Reviewed-on: https://code.wireshark.org/review/32701 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-26Update documentation of -G plugins.Guy Harris1-2/+2
Change-Id: Id057003924475c3c1241b156f7da3455b00a3560 Reviewed-on: https://code.wireshark.org/review/32590 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-23Clean up the new-file selection criteria in the GUI.Jeff Morriss2-2/+4
Inspired by looking into https://ask.wireshark.org/question/8009/wireshark-ring-buffer-settings-from-command-line/ ... in which the user was confused because a duration set on the command line was not reflected in the GUI. That's because I0180c43843f5d2f0c2f50153c9ce42ac7fa5aeae added the `interval` ring-buffer option and made the GUI use this rather than `duration`. This was not at all clear in the GUI, though. Since `duration` and `interval` have quite different use cases, expose both in the GUI. Try to clean up and unify the tooltips at the same time. I'm not entirely convinced the tooltips need to be on the checkbox, the spinbox, and the combobox but leave it that way for now. Add some to the man page description of the interval option to hopefully make it clearer what the option does. Change-Id: I3b45fe71c33af64d980dffb5e5ba93e2a15a6b96 Reviewed-on: https://code.wireshark.org/review/32526 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-01 13:12:04 +0000