aboutsummaryrefslogtreecommitdiffstats
path: root/debian
AgeCommit message (Collapse)AuthorFilesLines
2021-02-06Avoid exposing HAVE_PLUGINS in the public APIJoão Valverde2-0/+2
Instead *_register_plugin() is turned into a noop (with a warning). The test suit is failing with ENABLE_PLUGINS=Off (it was already failing before and this patch didn't affect that). Closes #17202.
2021-02-04RTP dissector: Removed unused functionsJirka Novak1-2/+0
Removed unused functions found by Martin Mathieson.
2021-02-01wiretap: redo the way we handle if_filter IDB options.Guy Harris1-3/+3
Change the data structure for that option to have a type field, indicating that it's either a pcap filter string or a BPF program, followed by a union with a string-pointer member for pcap filter strings and an instruction-count-and-pointer-to-instructions structure for BPF programs. Have routines to add, set, and fetch that option that handle that structure; discard the "generic structured option" routines. That means there's more type checking possible at compile time. Add more code to handle BPF programs. When writing pcapng files, check, both for that option and for string options, whether the option length is too big for the data to fit in a pcapng option, and don't write it if it is. (XXX - truncate the data? Report an error?)
2021-01-30epan: have a routine to register all tap listeners.Guy Harris1-1/+1
Pull the code to register plugin taps, and the loop to register built-in taps, into a single register_all_tap_listeners() routine. This leaves it up to libwireshark, not to the programs using it, to know how to register them.
2021-01-30wiretap: add wtap_block_set_nth_string_option_value_format().Guy Harris1-0/+1
We have wtap_block_set_string_option_value(), wtap_block_set_string_option_value_format(), and wtap_block_set_nth_string_option_value(); complete the collection and win valuable prizes.
2021-01-30Refer to options whose data isn't a simple data type as "structured".Guy Harris1-3/+3
"Custom", as in "requires custom handling of the option data, collides with "custom", as in pcapng custom options.
2021-01-28stat_tap_table_ui: create tables only once during initMartin Kaiser1-0/+1
If you load a capture file and open any statistics dialog, you'll see the list of collected items. Each time you press the Apply button (without entering a display filter) another list of items will be created as a top-level entry of the statistics tree. Only the first list will have the correct values, all subsequent lists will not be populated. Each statistic module defines a stat_tap_table_ui structure that contains a stat_tap_init_cb function. This init function is called by SimpleStatisticsDialog::fillTree before the tap listener is registered. This happens each time we collect the statistics. However, it seems that all init functions create a new stat_tap_table each time they are called, even if they already have an existing stat_tap_table of the same name. This patch adds a stat_tap_find_table function to find a table by name. As a first step, we update the ANSI A-I/F BSMAP Statistics to check if its table is already registered. If it is, the table will not be created again.
2021-01-11editcap: add support for epoch timestamps in `-A` and `-B` optionsChema Gonzalez1-0/+1
Inspired in https://gitlab.com/wireshark/wireshark/-/merge_requests/1618. Tested: Timestamps on file used for comparison: ``` $ tshark -r test/captures/snakeoil-dtls.pcap -T fields -e frame.time_epoch 1150121069.248818000 1150121069.249193000 1150121069.251152000 1150121069.251384000 1150121069.293686000 1150121069.319315000 1150121075.230753000 1150121105.510885000 1150121105.510934000 ``` Before: ``` $ ./build/run/editcap -B 1150121069.3 test/captures/snakeoil-dtls.pcap - editcap: "1150121069.3" isn't a valid date and time $ ./build/run/editcap -A 1150121069.3 test/captures/snakeoil-dtls.pcap - editcap: "1150121069.3" isn't a valid date and time $ ./build/run/editcap -A 1150121069 test/captures/snakeoil-dtls.pcap - editcap: "1150121069" isn't a valid date and time $ ./build/run/editcap -B 1150121069 test/captures/snakeoil-dtls.pcap - editcap: "1150121069" isn't a valid date and time ``` After: ``` $ ./build/run/editcap -A 1150121069.3 test/captures/snakeoil-dtls.pcap - | tshark -r - -T fields -e frame.time_epoch 1150121069.319315000 1150121075.230753000 1150121105.510885000 1150121105.510934000 $ ./build/run/editcap -A 1150121069 test/captures/snakeoil-dtls.pcap - | tshark -r - -T fields -e frame.time_epoch 1150121069.248818000 1150121069.249193000 1150121069.251152000 1150121069.251384000 1150121069.293686000 1150121069.319315000 1150121075.230753000 1150121105.510885000 1150121105.510934000 $ ./build/run/editcap -B 1150121069.3 test/captures/snakeoil-dtls.pcap - | tshark -r - -T fields -e frame.time_epoch 1150121069.248818000 1150121069.249193000 1150121069.251152000 1150121069.251384000 1150121069.293686000 $ ./build/run/editcap -B 1150121069 test/captures/snakeoil-dtls.pcap - | tshark -r - -T fields -e frame.time_epoch ```
2021-01-08Add iso8601_to_nstime() for editcap and nettraceDavid Perry1-0/+2
This adds a function to parse a string date-time in ISO 8601 format into a `nstime_t` structure. It's based on code from epan/tvbuff.c and wiretap/nettrace_3gpp_32_423.c and meant to eventually replace both. (Currently only replaces the latter.) Since most of Wireshark expects ISO 8601 date-times to fit a fairly strict pattern, iso8601_to_nstime() currently rejects date-times without separators between the components, even though ISO 8601 actually permits this. This could be revisited later. Also uses iso8601_to_nstime in editcap to parse the -A/-B options, thus allowing the user to specify a time zone if desired. (See #17110)
2021-01-05UAT: Adding support for uint64 (dec/hex), int64 (dec)Dr. Lars Völker1-0/+3
This patch adds 64bit support for uint and int to uats.
2020-12-29GitLab CI: Build merge-req:ubuntu-dpkg using Ninja.Gerald Combs1-6/+11
ubuntu-dpkg is currently the slowest of the merge-req pipelines. Newer versions of dh have a "cmake+ninja" buildsystem, so try using it instead.
2020-12-17GTPv2: Update IE 8.12 IndicationAnders Broman1-0/+1
2020-12-10Linux: rename metadata according to specPeter Eszlari1-1/+1
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s02.html#desktop-file-id
2020-12-08Lua: Add get_preference() and set_preference() utility functions.Stig Bjørlykke1-0/+1
Support uint, bool, enum, string, range, filename and directory preferences. Added apply_preferences() to write to file and apply changes.
2020-11-30wiretap: Convert ascend.y to Lemon.Gerald Combs1-1/+1
Convert wiretap/ascend.y.in from Bison/YACC to Lemon and rename it to wiretap/ascend_parser.lemon. Tighten up some of our scanning and parsing. Make the indentation in it and related files consistent. Aside from the recent IPv4 fragment offset changes, this produces identical output to the 3.4 branch for the Ascend trace files I have here. Remove the comment about supporting other commands. Another timeline might have an Ascend that successfully pivoted to DSL or 15625B+1D gigabit ISDN, but this one has neither. This was our last/only Bison/YACC file, so remove Bison/YACC as a development and packaging dependency and remove references to it from the documentation.
2020-11-13Qt+epan: Print better-looking values in the packet diagram.Gerald Combs1-0/+1
Pull the value-formatting code in proto_custom_set into proto_item_fill_display_label. Use that in FieldInformation::toString instead of fvalue_to_string_repr. Fixes #16911.
2020-10-22Version: 3.3.0 → 3.5.0.Gerald Combs1-1/+1
2020-10-22editcap, tshark: process IDBs in the middle of input files.Guy Harris1-0/+3
Instead of grabbing the set of IDBs found at open time, have a loop using wtap_get_next_interface_description() to read all unread IDBs run after opening the input file, after reading a packet from the input file, and after getting an EOF on the input file. Add a routine wtap_uses_interface_ids() to check whether the file type and subtype for a dump file uses interface IDs and requires IDBs. If so, in the aforementioned loop, add the IDBs to the dump stream. Add a routine wtap_dump_add_idb() to add IDBs to a dump stream. Have it call a file-format-specific routine to add the IDBs; the only file type that supports it is pcapng, and it 1) writes out the IDB and 2) adds it to the set of IDBs for the stream. Add a wtap_dump_params_init_no_idbs() routine that prevents the IDBs from the input file from being used to initialize the output file; use it in cases where we're using the aforementioned loop to copy over IDBs. Don't require any IDBs to be present when opening a pcapng file for writing; 1) the simplest pcapng file has just an SHB in it, 2) that requirement causes dumps that don't provide IDBs at open time to fail, and 3) the real issue is that we don't want packets with an interface ID not corresponding to a known IDB, and we already have a check for that. (There are some hacks here; eventually, when everything processes the IDBs in such a loop, we may be able to get rid of the "two favors of dump parameter initialization" hack.) Fixes #15844. Addresses the same issue in #15502, but there are other issues there that also need to be addressed. In addition, the merge code also needs to be changed to handle this.
2020-10-21Add a routine to make a newly-allocated copy of a block.Guy Harris1-0/+1
It currently wraps wtap_block_create() and wtap_block_copy(); if there are no remaining use cases for wtap_block_copy() at some point, it can just *replace* wtap_block_copy().
2020-10-21Add a routine to get the next as-yet-unfetched interface description.Guy Harris1-0/+1
In a wtap, keep track of the first interface description not yet fetched with wtap_get_next_interface_description() and, when wtap_get_next_interface_description() is called, have it return that description, as a wtap_block_t for its IDB. If there are no as-yet-unfetched interface descriptions, return NULL; there may, in the future, be more interface descriptions for the file, so this should be called: * after the file is opened; * after wtap_read() returns TRUE, indicating that it's returned a record (and *before* you process the record that wtap_read() returns, as it might be the interface description for the interface on which the packet in that record arrived); * after wtap_read() returns FALSE, indicating an EOF or an error return (as there might have been interfaces at the end of the file or before the error point). At each of those points, the caller should loop until wtap_get_next_interface_description() returns NULL. Not used yet (but tested with capinfos, which found a reason why you have to wait until the end of the file before processing the interface information - there's now a comment in the code giving that reason). This will probably be used in the future.
2020-10-21Use iconv to support GB 18030 and EUC-KR, allow future encodingsJohn Thacker1-0/+2
Add support internally to using iconv (always present with glib) to convert strings from various encodings to UTF-8 (using REPLACEMENT CHARACTER as recommended), and use that to support GB 18030 and EUC-KR. Replace call directly to iconv in ANSI 637 for EUC-KR to new API. Update comments and documentation around character encodings. It is possible to replace the calls to iconv with an internal decoder later. Tested on Linux and on Windows (including with illegal characters). Closes #16630.
2020-10-20Add an API to determine whether a file type uses interface IDs.Guy Harris1-0/+1
Currently, the only file types that use them are pcapng and IBM's iptrace; we don't support writing the latter, so this is mainly of interest for pcapng. This makes it a bit more obvious what some "is this pcapng?" tests are really trying to determine, and allows them to automatically support any new file types that use them. (With regard to interface descriptions, tere are three types of file: 1) files that contain no interface information; 2) files that contain "just FYI" interface information but that don't tie packets or other records to particular interfaces; 3) files that contain interface information and tie all packets (and possibly other records) to an interface. This tests for files of type 3.)
2020-10-15Replace ill-formed UTF-8 byte sequences with replacement characterJohn Thacker1-0/+2
Implement the Unicode Standard "best practices" for replacing ill-formed sequences with the Unicode REPLACEMENT CHARACTER. Add wmem_strbuf_append_len for appending strings with embedded null characters. Clarify why wmem_strbuf_grow() doesn't always ensure that there's enough room for a new string, and short-circuit some tests there. Related to #14948
2020-10-15debian: proto_tree_add_item_ret_ipv4() was introduced in 3.3.2Pascal Quantin1-1/+1
2020-10-11Add proto_tree_add_item_ret_ipv4().Guy Harris1-0/+1
Change some guint32's to ws_in4_addr while we're at it.
2020-10-02Clean up URLs.Guy Harris1-3/+3
Add ui/urls.h to define some URLs on various of our websites. Use the GitLab URL for the wiki. Add a macro to generate wiki URLs. Update wiki URLs in comments etc. Use the #defined URL for the docs page in WelcomePage::on_helpLabel_clicked; that removes the last user of topic_online_url(), so get rid of it and swallow it up into topic_action_url().
2020-10-01Version: 3.3.1 → 3.3.2.Gerald Combs1-1/+1
2020-09-28Add some more string encodings.Guy Harris1-3/+7
Add an encoding for "unpacked" 3GPP TS 23.038 7-bit strings, in which each code position is in a byte of its own, rather than with the code positions packed into 7 bits. Rename the packed encoding to explicitly indicate that it's packed. Add an encoding for ETSI TS 102 221 Annex A strings. Use the new encodings.
2020-09-15Version: 3.3.0 → 3.3.1.Gerald Combs2-2/+1
2020-08-22plugin_if: add plugin_if_get_frame_data() and plugin_if_get_capture_file()Tomas Kukosa1-0/+2
Change-Id: I7505d4185f18d13d6836c9c9bb8f400d12f2a524 Reviewed-on: https://code.wireshark.org/review/38217 Petri-Dish: Tomáš Kukosa <keksa@email.cz> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2020-08-21tvb: add tvb_get_bits_arrayFilipe Laíns1-0/+2
Change-Id: I2fad824ca417dcd089fabfdf06f28529c7ee9e87 Signed-off-by: Filipe Laíns <lains@archlinux.org> Reviewed-on: https://code.wireshark.org/review/37949 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-08-20wmem_array: make wmem_array_grow publicFilipe Laíns1-0/+1
There cases where we may want to pre-allocate some memory before appending all the fields. Change-Id: Ic46e83733d4338dbda45b2ca3ff2d533c5b44026 Signed-off-by: Filipe Laíns <lains@archlinux.org> Reviewed-on: https://code.wireshark.org/review/38122 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-08-20Add format_text_string(), which gets the length with strlen().Guy Harris1-0/+1
format_text(alloc, string, strlen(string)) is a common idiom; provide format_text_string(), which does the strlen(string) for you. (Any string used in a %s to set the text of a protocol tree item, if it was directly extracted from the packet, should be run through a format_text routine, to ensure that it's valid UTF-8 and that control characters are handled correctly.) Update comments while we're at it. Change-Id: Ia8549efa1c96510ffce97178ed4ff7be4b02eb6e Reviewed-on: https://code.wireshark.org/review/38202 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-08-17TFS: Add some commonly-defined string pairs to tfs.cMartin Mathieson1-0/+2
'check_tfs.py --common' can look for tfs values that appear multiple times. Current output prior to these dssector changes was: ('No Extension', 'Extension') appears 3 times in: ['epan/dissectors/packet-bssap.c', 'epan/dissectors/packet-camel.c', 'epan/dissectors/packet-gsm_map.c'] ('Optimised for signalling traffic', 'Not optimised for signalling traffic') appears 3 times in: ['epan/dissectors/packet-gsm_a_gm.c', 'epan/dissectors/packet-gsm_map.c', 'epan/dissectors/packet-gtp.c'] ('Data PDU', 'Control PDU') appears 3 times in: ['epan/dissectors/packet-pdcp-lte.c', 'epan/dissectors/packet-pdcp-nr.c', 'epan/dissectors/packet-rlc-nr.c'] ('Message sent to originating side', 'Message sent from originating side') appears 3 times in: ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c'] ('User', 'Provider') appears 3 times in: ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c'] The first and last ones were made common, the others seem a little too specialised. Checking some of the existing items in tfs.c (using QtCreator's 'Find Usages'), some of the common items are used a lot, but many of them are not referenced. Change-Id: Ia4006d2c4fa7cafbc3b004dc7a367a986dbeb0c4 Reviewed-on: https://code.wireshark.org/review/38177 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-08-11epan: Fixup proto_item_set_bits_offset_len.Gerald Combs1-0/+1
Export proto_item_set_bits_offset_len and fix In file included from ../epan/dfilter/dfilter.h:18: ../epan/proto.h:1113:11: warning: parameter 'bits_offset' is already documented [-Wdocumentation] * @param bits_offset The new length in bits. ^~~~~~~~~~~ ../epan/proto.h:1112:5: note: previous documentation * @param bits_offset The number of bits from the beginning of the field. ^ ~~~~~~~~~~~ Change-Id: Ib171ce38607b9656baea5eb7a3e6aee3b99ddbac Reviewed-on: https://code.wireshark.org/review/38115 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-29wiretap: add a routine to add a "fake" IDB.Guy Harris1-0/+1
It generates a fake IDB for files that don't have interface information and that have a per-file encapsulation type, snapshot length, and time stamp precision, and adds it to the file's list of IDBs. Use it for libpcap. We will use it later for other file formats, so that code such as the mergecap code to merge into a pcapng file can handle input files that don't have interface information. (We should have a way to indicate whether the IDBs are real or fake, so that capinfos and Statistics > Capture File Properties don't report meaningless IDB information and make it look as if it's known that the capture was done on one interface with the properties in question.) Change-Id: Iec124bf3c7cbd4c69ec2ac7d0dd776e5287f8576 Reviewed-on: https://code.wireshark.org/review/37982 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-07-22Add wmem_destroy_array()João Valverde1-0/+1
Change-Id: I00a0052a9c207692eddab7ac2d0f146201648f6c Reviewed-on: https://code.wireshark.org/review/13003 Reviewed-by: João Valverde <j@v6e.pt>
2020-06-29epan: Keep decode_as_list when changing profileStig Bjørlykke1-0/+1
The decode_as_list is built at startup and contains all protocols registered for "decode as". Do not clear this list on profile change, only on exit. Bug: 16635 Change-Id: I832a042327603ae0f01b10ab620fccc03d4fd3a3 Reviewed-on: https://code.wireshark.org/review/37579 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2020-06-25wslua: Add ability to query current temporary color filter textrbroker1-0/+1
The LUA API provides the "set_color_filter_slot" function, but without a corresponding "get_" function, it's very hard for two LUA dissectors to co-exist without one overwriting any color filters set by the other. It also looks like the documentation comment for "set_color_filter_slot" had an off-by-one error, which I've corrected as I was adding almost identical documentation for the new API. Change-Id: Ic54d23be555ec12e1830bbe6f84a1b04d04fd4f0 Reviewed-on: https://code.wireshark.org/review/37511 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-25dot11decrypt: Remove some unused codeMikael Kanstrup1-1/+0
Remove some unused defines, function parameters and functions. Change-Id: I1bbc3ff7e0a9d11e8521ddf24b35113d8e332f08 Reviewed-on: https://code.wireshark.org/review/37305 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-01Remove some single-SHB assumptions.Guy Harris1-0/+1
Make wtap_file_get_shb() take a section number argument, and update code that called it. In most cases, we convert the code to iterate over sections; in cases where a big code change would be required, we temporarily pass it 0 and mark the code as "needs to be updated for multiple sections". Eliminate cf_read_section_comment(); in calls outside file.c, other code directly calls the libwiretap routines it calls and, inside file.c, we just transplant the code and then fix it not to assume a single SHB. Change-Id: I85e94d0a4fc878e9d937088759be04cb004e019b Reviewed-on: https://code.wireshark.org/review/37000 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-04-28New dissector: Dynamic Link Exchange ProtocolUli Heilmeier1-0/+1
Code based on https://github.com/mit-ll/dlep-wireshark-dissector authored by Jeffrey Wildman <jeffrey.wildman@ll.mit.edu> Updated types according to https://www.iana.org/assignments/dlep-parameters/dlep-parameters.xhtml Changed: * removed some tvb_get_*() calls * updated expert info handling * changed registering the dissector Sample capture: https://wiki.wireshark.org/SampleCaptures#Dynamic_Link_Exchange_Protocol_.28DLEP.29 Change-Id: I13e0c918f46af036c1be4acf34acab838aeaf342 Reviewed-on: https://code.wireshark.org/review/36901 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-27Add string encoding values for various BCD encodings, and use them.Guy Harris1-0/+1
Add some ENC_ values for various flavors of packed BCD, and use that instead of explicitly calling tvb_bcd_dig_to_wmem_packet_str() and adding the result. Change-Id: I07511d9d09c9231b610c121cd6ffb3b16fb017a9 Reviewed-on: https://code.wireshark.org/review/36952 Reviewed-by: Guy Harris <gharris@sonic.net>
2020-04-25Add a routine to get the representation of a protocol tree item and use it.Guy Harris1-0/+1
Add proto_item_get_display_repr(), which returns a string, allocated with a specified wmem scope, containing the display representation of the value of a proto_item. Use it in the LLDP dissector, to append that string to the parent protocol tree item; use packet scope, so it doesn't hang around forever (the previous code used the NULL scope, meaning explicit freeing was required, but it wasn't explicitly freeing the value, so it was leaking). Change-Id: I146380118833b1daef9dea8bd9463001e5b9325f Reviewed-on: https://code.wireshark.org/review/36931 Petri-Dish: Guy Harris <gharris@sonic.net> Reviewed-by: Guy Harris <gharris@sonic.net>
2020-04-25Introduce tfs_get_string helperJaap Keuter1-0/+1
true_false_strings have no helper function to properly retrieve the string representing the true or false value, much like unit_strings, even though this is not uncommon in dissectors. This change introduces the helper function and modifies the dissectors, so that they use this helper i.s.o. their own expressions. Change-Id: I477ed2d90a9a529fc5dcfef7e3ea42ec180d27ae Reviewed-on: https://code.wireshark.org/review/36920 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-23OsmoTRX: Use units from unit_strings.{c,h}Pau Espin Pedrol1-0/+1
Change-Id: I79dd406fe34b623678bd8a13b2ec75930f886fe8 Reviewed-on: https://code.wireshark.org/review/36904 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-15epan: Add p_[gs]et_proto_depth.Gerald Combs1-0/+2
Add convenience routines for getting and setting a per-protocol, per-packet depth value, which can be used to limit recursion, nesting, cycling, etc. Use them in the BACapp, DAAP, Mongo, VLAN, and WBXML dissectors. Change-Id: I172514828169253ae7fcf9162c9d7eeb3041ff9c Reviewed-on: https://code.wireshark.org/review/36846 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-15debian: Ship codecs libraries in libwireshark0Balint Reczey1-0/+1
Bug: 16430 Change-Id: I2f9b07be780d39c75898bba06fa6fb66b9895c88 Signed-off-by: Balint Reczey <balint.reczey@canonical.com> Reviewed-on: https://code.wireshark.org/review/36433 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Petri-Dish: Balint Reczey <balint@balintreczey.hu> Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-03-12debian: speed up build by running asn1 and guides target in parallelPeter Wu1-3/+8
Speeds up the asn1 build from 133 seconds to 39 seconds, and guide builds from 40s to 33s (-j6). Extraction of parallel=x from DEB_BUILD_OPTIONS was borrowed from the debhelper Makefile. Switching to Ninja has even more potential speed ups and prevents interleaving build output, but requires debhelper 11.2 (Ubuntu bionic-backports, Debian stretch-backports). Change-Id: I2d403863adf5bfd692300642aad7df4b1cdb6e46 Reviewed-on: https://code.wireshark.org/review/36377 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-02-25Add ws_strtoi() and ws_strtoui() routines and use them.Guy Harris1-0/+4
Those fetch gint and guint values, respectively, rather than values with specified sizes in bits. This should squelch Coverity CID 1457357. Change-Id: Ia8f100bd3fe90c266e24a4346f80b2667c653b93 Reviewed-on: https://code.wireshark.org/review/36177 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>