Age | Commit message (Collapse) | Author | Files | Lines |
|
GTK_DISABLE_DEPRECATED
Also: # Enable GSEAL when building with GTK > 2.20
svn path=/trunk/; revision=48149
|
|
thousands grouping (') flag and use it in format_size if it's available.
As far as I can tell this translates to "everywhere except Windows and
OpenBSD". According to the various build logs at
https://build.opensuse.org/package/show?package=mingw32-glib2&project=windows%3Amingw%3Awin32
the OBS GLib packages enable GLib's internal printf implementation from
Gnulib which means we *should* be able to enable this on Windows.
Unfortunately this doesn't appear to be the case.
svn path=/trunk/; revision=48042
|
|
This reverts commit r48020.
svn path=/trunk/; revision=48022
|
|
svn path=/trunk/; revision=48020
|
|
Also remove old WS_VAR_IMPORT define and related Makefile magic
everywhere in the project.
svn path=/trunk/; revision=47992
|
|
This change replaces *.def and *.sym file usage following the
guideline at http://gcc.gnu.org/wiki/Visibility
svn path=/trunk/; revision=47938
|
|
svn path=/trunk/; revision=47907
|
|
svn path=/trunk/; revision=47777
|
|
Makefiles.
svn path=/trunk/; revision=47712
|
|
Makefile.
svn path=/trunk/; revision=47711
|
|
svn path=/trunk/; revision=47553
|
|
svn path=/trunk/; revision=47544
|
|
Add a (crude) check for the Qt version, making 4.6.0 the minimum.
The existing checks in configure.ac should be moved into into this new module.
svn path=/trunk/; revision=47537
|
|
Use them instead of repeating the same number several times.
AC_SUBST() them so we can pick them up in, for example, wireshark.spec.in .
svn path=/trunk/; revision=47481
|
|
are built with warnings.
Also add compiler-specific flags (in this case, just the flags to enable
ANSI C compilation) to CFLAGS_FOR_BUILD.
svn path=/trunk/; revision=47479
|
|
what. If we don't find them, and the user specified --with-qt, fail (if
we haven't already failed to find Qt at all); if we don't find them, and
the user *didn't* specify --with-qt, just set UIC and MOC to "uic" and
"moc", which will fail on "make dist" but will at least allow the user
to build.
svn path=/trunk/; revision=47475
|
|
svn path=/trunk/; revision=47471
|
|
svn path=/trunk/; revision=47467
|
|
moc are called uic-qt4 and moc-qt4. Look for them by names, plural.
svn path=/trunk/; revision=47457
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8202 :
AM_CONFIG_HEADER() is obsolete (and removed from automake 1.13 and later); use
AC_CONFIG_HEADERS instead.
svn path=/trunk/; revision=47091
|
|
exists by doing:
if test "x$3" != "x" ; then
because if the program contains quotes it breaks the shell's parsing.
Instead test for the existence of $4 (which is mandatory if $3 is given).
Fix up the test program for -Wlogical-op so that it actually compiles
warning-free (at least on my system) when the compiler doesn't have the bug
we're checking for.
svn path=/trunk/; revision=46926
|
|
worked OK before. In the test program, try declaring foo() before
defining it, in case the problem is that --enable-extra-gcc-checks
enables checking for functions that weren't declared before they were
defined, so the lack of that declaration may have caused a separate
warning.
svn path=/trunk/; revision=46924
|
|
operations always evaluating to the same value in (the expansion of)
strchr().
See: https://www.wireshark.org/lists/wireshark-dev/201212/msg00136.html
svn path=/trunk/; revision=46916
|
|
svn path=/trunk/; revision=46902
|
|
svn path=/trunk/; revision=46899
|
|
svn path=/trunk/; revision=46887
|
|
linking.
svn path=/trunk/; revision=46878
|
|
svn path=/trunk/; revision=46869
|
|
QtWidgets or QtPrintSupport.
svn path=/trunk/; revision=46867
|
|
svn path=/trunk/; revision=46859
|
|
together, and add a comment explaining what's being done.
svn path=/trunk/; revision=46854
|
|
svn path=/trunk/; revision=46848
|
|
svn path=/trunk/; revision=46759
|
|
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().
Change some data types to avoid those implicit conversion warnings.
When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.
Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers. Cast
away those warnings in some cases where an API we don't control forces
us to do so.
Enable a bunch of additional warnings by default. Note why at least
some of the other warnings aren't enabled.
randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.
If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.
svn path=/trunk/; revision=46748
|
|
svn path=/trunk/; revision=46642
|
|
Don't force 8-byte alignment on such systems.
svn path=/trunk/; revision=46641
|
|
svn path=/trunk/; revision=46610
|
|
Enable PIE (if the compiler supports it) when compiling dumpcap. Do this
regardless of whether we're configured to install dumpcap setuid-root because
some users will end up running dumpcap as root regardless of how we were
configured.
svn path=/trunk/; revision=46608
|
|
function actually *exist*.
Declare foo() before defining it - if we configure with
--enable-extra-gcc-checks, given that we're building with -Werror (so
that we find out whether the compiler issues a warning for a particular
construct), we have to avoid constructs that will provoke *other*
warnings.
svn path=/trunk/; revision=46488
|
|
Ubuntu 12 VM to figure out why -Wshadow was rejected, as it doesn't seem
to cause bogus errors.
svn path=/trunk/; revision=46477
|
|
to see whether it really doesn't work right (i.e., warns bogusly about
variables in prototype definitions of function pointers shadowing
variables) or if the test fails for some other reason.
svn path=/trunk/; revision=46476
|
|
it do an additional check, if it finds that a given compiler option is
supported by the compiler, to see whether it's supported but
undesirable. The arguments are a chunk of code to try to compile with
-Werror, and a string to be used in the "checking..." message printed
when trying to compile the cunk of code.
Try enabling -Wshadow again, but have it check whether
extern int atoi(char *p);
int
foo(char *p)
{
int (*fptr)(char *p) = atoi;
return fptr(p) * 2;
}
compiles with -Wshadow and -Werror, so that we don't use -Wshadow with
compilers that complain about that; some older versions of GCC complain
about that, and it's really not worth our effort to eliminate or rename
arguments in function prototypes to make -Wshadow work even with those
compilers.
svn path=/trunk/; revision=46475
|
|
It appears that the compiler on
the OSX-10.5-x86 buildbot must be pretty old.
All the other *nix buildbot compilers do not
check the dummy param names used in the definition
of 'xxx' below to see if they are shadowing
anything.
void foo(tvbuff_t tvb, ...) {
'void (*xxx)(tvbuff_t tvb, ....) = NULL;'
...
}
I do seem to remember reading that gcc once
had this issue but was fixed eventually.
svn path=/trunk/; revision=46430
|
|
svn path=/trunk/; revision=46429
|
|
svn path=/trunk/; revision=46383
|
|
QtWidgets and, if we find it, add its flags to CFLAGS and CXXFLAGS, so
that we find the include files for the widgets. (If we don't find it,
we assume it's Qt 4.)
svn path=/trunk/; revision=46382
|
|
svn path=/trunk/; revision=46381
|
|
so we can get a complete list of the -Wshadow warnings
seen by the buildbots.
svn path=/trunk/; revision=46380
|
|
Looks like this is not ready for prime time.
ToDo: determine why the OSX builds are finding issues that I don't see on Fedora.
svn path=/trunk/; revision=46378
|
|
AFAIK, all GTK Wireshark non-dirty sources now compile
without [-Wshadow] warnings.
(Altho I haven't tried the QT build or other possible
build variants), hopefully any remaining [-Wshadow] warnings for non-dirty
source can be fixed as they occur.
(Obviously this change can be reverted if there are many issues).
So: let's see if any of the automated builds break; :)
svn path=/trunk/; revision=46376
|