aboutsummaryrefslogtreecommitdiffstats
path: root/column.c
AgeCommit message (Collapse)AuthorFilesLines
2001-07-22"col_format_to_pref_str()" is used only in "prefs.c", and knows aboutguy1-53/+1
the format of string lists in a preferences file; rename it to "put_string_list()", make it take the list as an argument rather than working only on "prefs.col_list", and put it in "prefs.c". git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3776 f5534014-38df-0310-8fa8-9805f1628bb7
2001-07-22Check for valid column titles (non-zero-length) and valid column formatsguy1-2/+2
in preference settings. In the process of doing that, fix a memory leak (we were handing a null pointer, rather than a pointer to the list of strings in "column.format", to "clear_string_list()"). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3775 f5534014-38df-0310-8fa8-9805f1628bb7
2001-07-22Put in a comment noting that the format of a preferences string isguy1-2/+7
determined by the code in "prefs.c", so arguably "col_format_to_pref_str()" belongs there. Put in a comment noting that said format includes support for escaping quotation marks in quoted strings, and that we should handle that. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3774 f5534014-38df-0310-8fa8-9805f1628bb7
2001-07-11From Todd Sabin: cleaned up "get_column_format_matches()".guy1-54/+52
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3684 f5534014-38df-0310-8fa8-9805f1628bb7
2000-11-17Add #include <string.h>, to get prototypes for mem* and str* functions.gram1-1/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2654 f5534014-38df-0310-8fa8-9805f1628bb7
2000-11-01Add a fourth choice of time format in the packet list display, whichguy1-8/+19
shows the date (in YYYY-MM-DD format) as well as the time of day when the packet arrived. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2547 f5534014-38df-0310-8fa8-9805f1628bb7
2000-08-11Miscellaneous code cleaningdeniel1-1/+3
- add <stdarg.h> or <varargs.h> in snprintf.h and remove those inclusions in the other #ifdef NEED_SNPRINTF_H codes - remove the check of multiple inclusions in source (.c) code (there is a bit loss of _cpp_ performance, but I prefer the gain of code reading and maintenance; and nowadays, disk caches and VM are correctly optimized ;-). - protect all (well almost) header files against multiple inclusions - add header (i.e. GPL license) in some include files - reorganize a bit the way header files are included: First: #include <system_include_files> #include <external_package_include_files (e.g. gtk, glib etc.)> Then #include "ethereal_include_files" with the correct HAVE_XXX or NEED_XXX protections. - add some HAVE_XXX checks before including some system header files - add the same HAVE_XXX in wiretap as in ethereal Please forgive me, if I break something (I've only compiled and regression tested on Linux). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@2254 f5534014-38df-0310-8fa8-9805f1628bb7
2000-01-10Move the code in "column.c" that implements the column preferences tabguy1-357/+16
into "gtk/column_prefs.c". Get rid of "get_column_width()" - instead, export "get_column_longest_string()", and have "get_column_width()"'s callers make the GDK call to get the width of that string, so that "column.c" contains no GTK+/GDK code. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1447 f5534014-38df-0310-8fa8-9805f1628bb7
1999-12-29Get rid of the "(UDP)" and "(TCP)" in various NetBIOS-over-TCP protocolguy1-2/+2
columns. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@1392 f5534014-38df-0310-8fa8-9805f1628bb7
1999-10-17Fix typo in preferences-display name for COL_RES_NET_SRC.guy1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@869 f5534014-38df-0310-8fa8-9805f1628bb7
1999-09-12Add summary-vs-detail radio buttons to the print dialog box; detailguy1-25/+42
prints the protocol tree, and summary prints the fields in the summary clist, with a header line at the beginning of the printout. Print only packets selected by the current packet filter. Just have "ARP" and "RARP" in the "Protocol" field for ARP packets; whether it's a request or a reply can be seen in the "Info" field. Add to the "Frame" section of the protocol tree the time between the current packet and the previous displayed packet, and the packet number. Have FT_RELATIVE_TIME fields be a "struct timeval", and display them as seconds and fractional seconds (we didn't have any fields of that type, and that type of time fits the delta time above). Add an FT_DOUBLE field type (although we don't yet have anything using it). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@666 f5534014-38df-0310-8fa8-9805f1628bb7
1999-09-10Fix a comment, to reflect the demise of "ethereal.h".guy1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@648 f5534014-38df-0310-8fa8-9805f1628bb7
1999-09-10We need to catch a "window delete" event for the preferences dialog boxguy1-2/+8
- that event happens if, say, you nuke the dialog box from a window manager - and call "delete" routines for each of the preferences tabs, so that, for preferences tabs that include list widgets, we can set a flag on the preferences tab widget telling the selection callback for the list widget that the buttons it would normally set the sensitivity of, based on whether any row in the list is selected or not, have Joined the Choir Invisible, and therefore that we shouldn't change their sensitivity because GTK+ will whine at us if we do, just as is the case if we press the "OK" or "Cancel" button (which also cause the window to go away). Can we just do this in the "window delete" handler? I.e., does that get called if we explicitly destroy the widget? Or should we catch a "destroy" event instead? (There must be a better way to do this....) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@647 f5534014-38df-0310-8fa8-9805f1628bb7
1999-07-28Fix up the comment before "get_column_width()" to reflect currentguy1-6/+12
reality. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@397 f5534014-38df-0310-8fa8-9805f1628bb7
1999-07-28Have:guy1-1/+55
COL_INFO columns resize automatically even during a live capture; columns showing network addresses never resize automatically; other columns resize only when a capture is done; and make all columns resizeable by hand (once they've resized, for auto-resizeable columns). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@394 f5534014-38df-0310-8fa8-9805f1628bb7
1999-07-23Add a "File/Print" menu item, which prints *all* the packets in theguy1-3/+1
capture to a file or printer. This should eventually get the ability to print either all the packets or only the packets selected by the display filter, and possibly also the ability to print only packets M through N. Get rid of "cur" member of "capture_file" structure; nobody used it. There's no need to pass a pointer to a "dialog_button" variable to "simple_dialog()" for the error boxes displayed if a file copy or move fails; that dialog box is just a message box and has only an "OK" button. Put the declaration of "prefs" into "prefs.h". git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@378 f5534014-38df-0310-8fa8-9805f1628bb7
1999-07-22Revert to static sizing of columns.guy1-1/+66
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@377 f5534014-38df-0310-8fa8-9805f1628bb7
1999-07-22Added "Packet Length in bytes" as an optional column.gram1-3/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@375 f5534014-38df-0310-8fa8-9805f1628bb7
1999-07-13Since ethereal is now dependent on GTK+-1.2.x (because of proto_tree andgram1-5/+1
display filter code, which uses features in GLIB-1.2.x), I removed the vestigial code supporting old 1.0.x and 1.1.x GTK+ versions. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@360 f5534014-38df-0310-8fa8-9805f1628bb7
1999-07-13Added support for compiling on win32 with Visual C and 'nmake'. It compiles,gram1-1/+5
but does not link. Perhaps someone who understands the MS tools can help out. I made it link a few months ago, but with different version of glib/gtk+. I can't remember how I made it link. Most of the compatibility issues were resolved with adding #ifdef HAVE_UNISTD_H the the source code. Please be sure to add this to all future code. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@359 f5534014-38df-0310-8fa8-9805f1628bb7
1999-06-21Found some erroneous usages of gtk_signal_connect_object. I always wonderedgram1-2/+2
why I had to swap fields (data = w) in some of the callback functions when I added support for gtk+-1.1. Because of the use of gtk_signal_connect_object, the wrong value was being sent to the callback function. We were just lucky that with gtk+-1.0 it worked. gtk_signal_connect_object is for use with callbacks that take one argument. gtk_signal_connect is for use with callbacks that take two arguments. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@324 f5534014-38df-0310-8fa8-9805f1628bb7
1999-06-19Use "gtk_toggle_button_set_state()" rather thanguy1-63/+1
"gtk_toggle_button_set_active()" to set the state of radio buttions; "gtk_toggle_button_set_active()" doesn't exist in GTK+ 1.0[.x], and "gtk_toggle_button_set_state()" is an alias for it in GTK+ 1.2[.x]. Compute the column widths in the summary display based on the longest string in the column; recompute it whenever we update the columns. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@319 f5534014-38df-0310-8fa8-9805f1628bb7
1999-06-19Update the column widths if we change the time stamp format from theguy1-2/+2
"Display/Options" dialog box. "get_column_width()" should check "timestamp_type" against ABSOLUTE, not against COL_ABS_TIME. Clean up the code to check the state of the time stamp radio buttons in the "Display/Options" dialog box. Check in "timestamp.h", which we failed to check in on the previous commit. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@318 f5534014-38df-0310-8fa8-9805f1628bb7
1999-06-19Added "Capture" and "Display" menus; "Capture" has a "Start" item, whichguy1-15/+2
is the same as "Tools/Capture", and "Display" has an "Options" item, which pops up a dialog box to let you change the "default" time-stamp column display format on the fly (the "default" is what the "-t" command-line option sets), and have the display change when you do that. Made infrastructure changes to make the immediate display update work. Removed some unused functions, declared some functions used only in the file in which they're defined "static", and removed some unnecessary #includes. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@317 f5534014-38df-0310-8fa8-9805f1628bb7
1999-03-23Removed all references to gtk objects from packet*.[ch] files. They nowgram1-1/+2
reference the protocol tree with struct proto_tree and struct proto_item objects. That way, the packet decoding source code file can be used with non-gtk packet decoders, like a curses-based ethereal, e.g. I also re-arranged some of the information in packet.h to more appropriate places (like other packet-*.[ch] files). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@223 f5534014-38df-0310-8fa8-9805f1628bb7
1999-03-05IPX addresses in the Destination/Source fields of the "column" part of the GUIgram1-2/+2
are now written in NNNNNNNN.hhhhhhhhhhhh form, N=IPX network, h=hwaddr. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@211 f5534014-38df-0310-8fa8-9805f1628bb7
1999-01-04* Final commit for version 0.5.1gerald1-4/+5
* Added RPM .spec file (Martin Maciaszek) * Added Martin to AUTHORS git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@149 f5534014-38df-0310-8fa8-9805f1628bb7
1998-12-29* Added Joerg Mayer's Vines patchgerald1-9/+43
* Added Joerg to the AUTHORS file * Added Guy's bitfield decode patch * Fixed time output git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@142 f5534014-38df-0310-8fa8-9805f1628bb7
1998-12-22Fixed more bugs with dialogues and gtk+-1.1.x.gram1-1/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@137 f5534014-38df-0310-8fa8-9805f1628bb7
1998-12-17A patch spread across many files to let Ethereal compile under GTK+-1.1.x.gram1-1/+2
Tests for GTK versions are done during compilation, not during "./configure". The big problems have been taken care of in this patch (functional change in the packet clist and conversion of menu_factory to item_factory), but plenty of smaller problems with dialogue boxes abound. I have fixed a small problem with file_open*(), but have left 2 comments in just in case I'm not going about this the right way. Can someone verify? git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@127 f5534014-38df-0310-8fa8-9805f1628bb7
1998-12-16Note that wiring the current longest string in a column intoguy1-1/+5
"get_column_width()" is somewhat fragile, and suggest a possible alternative. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@126 f5534014-38df-0310-8fa8-9805f1628bb7
1998-11-18* Added patches from Laurent and Guygerald1-14/+11
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@103 f5534014-38df-0310-8fa8-9805f1628bb7
1998-11-17* Fixes for TCP and UDP port number display.gerald1-1/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@98 f5534014-38df-0310-8fa8-9805f1628bb7
1998-11-17* Added column formatting functionality.gerald1-0/+644
* Added check_col(), add_col_str() and add_col_fmt() to replace references to ft->win_info. * Added column prefs handling code. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@97 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 19:23:44 +0000