Age | Commit message (Collapse) | Author | Files | Lines |
|
especially given that we end up freeing what all of those pointers point
to.
svn path=/trunk/; revision=49542
|
|
svn path=/trunk/; revision=49497
|
|
it into a separate capture_session structure. capture_opts should
contain only user-specified option information (and stuff directly
derived from it, such as the "capturing from a pipe" flag).
svn path=/trunk/; revision=49493
|
|
number, and that string is what's appropriate for the -y command-line
argument, so just directly pass it to sync_pipe_add_arg(), and get rid
of the now-unnecessary sdlt variable.
svn path=/trunk/; revision=48546
|
|
using a gconstpointer creates a warning
capture_sync.c: In function ‘sync_pipe_open_command’:
capture_sync.c:823:13: error: passing argument 1 of ‘g_free’ discards ‘const’ qualifier from pointer target type [-Werror]
svn path=/trunk/; revision=48096
|
|
svn path=/trunk/; revision=48088
|
|
svn path=/trunk/; revision=47942
|
|
svn path=/trunk/; revision=47920
|
|
ws_read(), can return a negative number. If that were to happen, then assigning the return value to an unsigned variable and then comparing that variable against 0 will yield incorrect/unintended results. Fixes Coverity CID 761910: Negative array index write.
svn path=/trunk/; revision=47069
|
|
svn path=/trunk/; revision=46849
|
|
svn path=/trunk/; revision=46792
|
|
It has to be unsigned or else certain headers get misread due to signedness.
svn path=/trunk/; revision=46790
|
|
not. QtShark now builds warning-free (for me at least).
svn path=/trunk/; revision=46786
|
|
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().
Change some data types to avoid those implicit conversion warnings.
When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.
Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers. Cast
away those warnings in some cases where an API we don't control forces
us to do so.
Enable a bunch of additional warnings by default. Note why at least
some of the other warnings aren't enabled.
randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.
If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.
svn path=/trunk/; revision=46748
|
|
svn path=/trunk/; revision=46515
|
|
function name;
(At least some (gcc ?) compilers give a "shadow" warning for these).
svn path=/trunk/; revision=46402
|
|
code fails to check/test return value from select()
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7861
svn path=/trunk/; revision=45917
|
|
platforms. This ham-fistedly fixes a delay when moving from the
"Capture" item to the "Open" and "Learn" items on the welcome screen in
the Qt version.
svn path=/trunk/; revision=45475
|
|
svn path=/trunk/; revision=45407
|
|
Add breadcrumbs so that we can switch from g_get_current_time to
g_get_real_time when our minimum GLib version is >= 2.28.
svn path=/trunk/; revision=45399
|
|
svn path=/trunk/; revision=45015
|
|
on the GLib main loop which isn't portable (unless you want to want to
manage the main loop yourself).
svn path=/trunk/; revision=44655
|
|
svn path=/trunk/; revision=44644
|
|
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
|
|
unused parameters. Add the missing functions by applying the skipped patches
to capture_sync.[hc]
svn path=/trunk/; revision=43414
|
|
svn path=/trunk/; revision=43173
|
|
FormatMessage() calls where FORMAT_MESSAGE_FROM_SYSTEM is also specified. (Ref: http://blogs.msdn.com/b/oldnewthing/archive/2007/11/28/6564257.aspx)
svn path=/trunk/; revision=43172
|
|
svn path=/trunk/; revision=42057
|
|
out all 4 bytes we read, to provide more information about the message
that was sent so it's easier to see if something was spewing extra
output to the standard output or error in the child.
svn path=/trunk/; revision=41489
|
|
test scripts are passed.
Use a global list containing all interfaces and only change
properties of the entries when changes are made in the GUI.
Do not misuse the list of interfaces specified on the command
line anymore.
This patch does not provide any new functionality, it just
provides the base for future extensions like removing
remote interface, mulitple airpcap devices and multiple
pipes.
This patch was provided by Irene Ruengeler.
svn path=/trunk/; revision=40715
|
|
svn path=/trunk/; revision=40695
|
|
Use a global list containing all interfaces and only change
properties of the entries when changes are made in the GUI.
Do not misuse the list of interfaces specified on the command
line anymore.
This patch does not provide any new functionality, it just
provides the base for future extensions like removing
remote interface, mulitple airpcap devices and multiple
pipes.
This patch was provided by Irene Ruengeler.
svn path=/trunk/; revision=40693
|
|
the ui directory. (Perhaps some other files that would be used by all
flavors of Wireshark, for any GUI toolkit or for someting such as
ncurses, and not for any command-line tool such as TShark, should be
moved there as well.)
Shuffle some #includes to put the "ui/XXX.h" includes together.
svn path=/trunk/; revision=40529
|
|
the name in the definition of the function it calls.
svn path=/trunk/; revision=40367
|
|
value to the variable). Praise be to Clang Cat.
svn path=/trunk/; revision=39877
|
|
stdin and pipes.
svn path=/trunk/; revision=39498
|
|
properties of the entries when changes are made in the GUI.
Do not misuse the list of interfaces specified on the command
line anymore.
This patch does not provide any new functionality, it just
provides the base for future extensions like removing
remote interface, mulitple airpcap devices and multiple
pipes.
This patch was provided by Irene Ruengeler.
svn path=/trunk/; revision=39495
|
|
svn path=/trunk/; revision=38696
|
|
could fail to open the capture file.
svn path=/trunk/; revision=38695
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6256.
svn path=/trunk/; revision=38694
|
|
svn path=/trunk/; revision=38352
|
|
svn path=/trunk/; revision=38351
|
|
Fix obtained from Irene Ruengeler.
svn path=/trunk/; revision=38349
|
|
Remove our local strerror implementation.
Mark strerror as locale unsafe API.
This fixes bug 5715.
svn path=/trunk/; revision=37812
|
|
tshark -i en0 icmpp
returns a correct error message.
svn path=/trunk/; revision=37806
|
|
This patch is from Irene Ruengeler.
svn path=/trunk/; revision=37804
|
|
specifc. This finalizes the change of the infrastructure.
This patch is based on work by Irene Ruengeler.
svn path=/trunk/; revision=37794
|
|
pcap. Add a "-P" capture option which tries to use pcap instead of
pcap-ng ("-P" seemed to be the best option but we may want to use a
different letter).
Update the documentation and release notes.
svn path=/trunk/; revision=37696
|
|
Also: whitespace cleanup.
svn path=/trunk/; revision=37603
|
|
The next step is to retire the iface variable and use
the ifaces array only. This should simplify things and
fix the cases, where you start wireshark with command
line arguments and also use the GUI.
svn path=/trunk/; revision=37342
|