aboutsummaryrefslogtreecommitdiffstats
path: root/asn1/rrc
AgeCommit message (Collapse)AuthorFilesLines
2015-07-04asn1: split off cleanup routinesPeter Wu1-8/+11
General approach: 1. Split allocation (e.g. g_hash_table_new) from deallocation (g_hash_table_destroy) into functions named "init" and "cleanup". 2. Remove guards that test whether the hash tables are set as init is always called before cleanup. 3. Remove setting hash tables to NULL after destruction. 4. Copy register_init_routine function call and change init to cleanup. 5. Add cleanup function that calls reassembly_table_destroy if there is a reassembly_table_init function. Some templates were modified as follows: - snmp: split renew into init+cleanup, but keep renew for the uat_new callback. - ldap,ros: Rename init to cleanup as there was no initialization. - camel: remove init function from header, make it static. Remove debug print. - tcap: remove unused ssn_range assignment. Files in epan/ were regenerated using cmake && make asn1 Change-Id: Idac16ebf0ec304e0c8becaab5d32904e56eb69b9 Reviewed-on: https://code.wireshark.org/review/9136 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-26RRC: remove non ASCII characters from ASN.1 descriptionPascal Quantin5-498/+498
Change-Id: I7edb23651caa5ccf8e9989069803a8800e358670 Reviewed-on: https://code.wireshark.org/review/9172 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-05-09RRC: add domain and release cause information to the INFO column.Martin Mathieson1-0/+7
Change-Id: If0bee7f283d6c4dd44618221d528fb55e30f510a Reviewed-on: https://code.wireshark.org/review/8353 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-05-01Fix some cases where we're shifting a signed 1 left.Guy Harris1-8/+8
Shift 1U instead, to make sure it's unsigned; the result of, for example, the result of shifting a signed value left is undefined if the value times 2^{shift count} doesn't fit in the *signed* type of the shifted value. That means, in particular, that the result of shifting 1 left by {number of bits in an int - 1} is undefined. (In *practice*, it'll probably be -2^32, with the bit you want set, but that's not guaranteed, and GCC 5.1 seems not to like it.) Make some other left-hand operands of <<, and some variables holding results from shifts of that sort, unsigned, while we're at it. Change-Id: Ie72a9d0d518f59b35948267d10c80735d162e8bb Reviewed-on: https://code.wireshark.org/review/8264 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-04-10Remove depricated API tvb_length -> tvb_reported_lengthAndersBroman1-5/+5
Change-Id: I78b1d2accf4fd0b37eaa16cb8bf515422565e98a Reviewed-on: https://code.wireshark.org/review/8011 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-29RRC: add a missing mask forgotten in gf3d1e3cVincent Helfre1-1/+1
Change-Id: Ib62e15d17ea576f2180ac92d217869768225905d Reviewed-on: https://code.wireshark.org/review/7850 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-03-29RRC: add dissection of ims-Information IEVincent Helfre2-0/+57
Bug: 11096 Change-Id: I348726dcd3b62f75db67e63c07bcdc79e86657a7 Reviewed-on: https://code.wireshark.org/review/7842 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-28Removed duplicated #include linesDario Lombardo1-1/+0
Change-Id: I9cafa3cd5c74121168777d8c656e7e94e89efd3c Reviewed-on: https://code.wireshark.org/review/6065 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-23asn1 generated dissectors: cleanup #include usageBill Meier1-2/+0
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387 Reviewed-on: https://code.wireshark.org/review/6008 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-16Fix spelling: cant-->can't, wont-->won't, etcBill Meier1-2/+2
Change-Id: Ia6c3e7a25615bf8e052c3bacf096d76df775c9c2 Reviewed-on: https://code.wireshark.org/review/4126 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-30Add some files under asn1 to the distribution.Guy Harris1-1/+1
Include CMakeLists.txt files and the gnm subdirectory, along with the top-level Makefile.inc and Makefile.preinc files. Don't explicitly include Custom.make, as automake does that automatically given that it's included by asn1/Makefile.am. Add some files to EXTRA_DIST lists. Move some .asn files to EXTRA_DIST; they don't need to be in SRC_FILES, as SRC_FILES always includes EXTRA_DIST, and they *do* need to be in EXTRA_DIST so that they're in the distribution. Change-Id: Id91df577260fa57028d40fe098be1d79c59398e6 Reviewed-on: https://code.wireshark.org/review/3273 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-08RRC: fix ASN.1 description by manually adding CR5591Pascal Quantin2-4/+4
Without it, dual-band DF-3C feature does not work Change-Id: I95d4a7320b77c6093f5d51efdbb2b21af0deab11 Reviewed-on: https://code.wireshark.org/review/2942 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-22convert to proto_tree_add_subtree[_format] for ASN.1 dissectorsMichael Mann1-7/+6
Change-Id: I753ca95e2e1b38bad2c09955317e648c525e40ef Reviewed-on: https://code.wireshark.org/review/2509 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Update ASN.1 source files with the API changes done in g021e7af"Pascal Quantin1-5/+5
This reverts commit e308e7c4de81c2ff7159e444b865ac59de4faa2b. Change-Id: I079616d63f643f79f1bc03ef5fdf724f36df4071 Reviewed-on: https://code.wireshark.org/review/2435 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Update ASN.1 source files with the API changes done in g021e7afPascal Quantin1-5/+5
Change-Id: I52ecfccbce423206242e3cf99401a8c9e1655d88 Reviewed-on: https://code.wireshark.org/review/2385 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-26Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate ↵Bill Meier2-7/+7
dissectors. Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4 Reviewed-on: https://code.wireshark.org/review/412 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-18Remove $Id$ from the ASN.1 dissectors and regenerate them.Jeff Morriss12-21/+0
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954 Reviewed-on: https://code.wireshark.org/review/244 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-02-03Upgrade RRC dissector to v11.8.0Pascal Quantin6-10/+54
Change-Id: If43fc7ec8b5f997e573a9d84fda03f2ca2bf6dc7 Reviewed-on: https://code.wireshark.org/review/94 Tested-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2013-12-08Use STR_UNICODE display instead of proto_tree_add_unicode_string() in the ↵Pascal Quantin1-3/+2
remaining dissectors svn path=/trunk/; revision=53867
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann2-8/+8
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-09-24Upgrade RRC dissector to v11.7.0Pascal Quantin6-446/+499
svn path=/trunk/; revision=52202
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-18Remove all non-ASCII characters from all .asn files. I didn't see the harm ↵Chris Maynard2-437/+437
in replacing them all as opposed to only those not copied verbatim from other sources. svn path=/trunk/; revision=52132
2013-09-15emem -> wmem (don't forget about .cnf)Jörg Mayer2-1/+2
svn path=/trunk/; revision=52058
2013-07-23Try to differentiate a non filled private_data (pointer set to NULL) from an ↵Pascal Quantin1-9/+9
enum with value = 0 svn path=/trunk/; revision=50837
2013-07-03Check actx->private_data validity before using itPascal Quantin1-45/+51
svn path=/trunk/; revision=50339
2013-06-19Fet rid of a global variablePascal Quantin2-12/+17
svn path=/trunk/; revision=50034
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann2-2/+11
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman2-8/+8
svn path=/trunk/; revision=49259
2013-05-11I added EXPORT_FILES in too many places, remove themJörg Mayer1-4/+0
(via "copy - modify too little - paste" cycle) svn path=/trunk/; revision=49255
2013-05-10Some more protocols can be generated via cmakeJörg Mayer1-0/+35
svn path=/trunk/; revision=49233
2013-05-05Just whitespace changesJörg Mayer1-3/+3
svn path=/trunk/; revision=49167
2013-04-23Stub cmake support for generating the asn1 dissectors.Jörg Mayer1-0/+23
It doesn't do anything yet, it is just to make svn status readable again. svn path=/trunk/; revision=49007
2013-04-04Fix encoding arg for proto_tree_add_item() and friends.Chris Maynard1-5/+5
svn path=/trunk/; revision=48732
2013-03-20Upgrade RRC dissector to v11.5.0Pascal Quantin7-321/+743
svn path=/trunk/; revision=48444
2013-03-20svn path=/trunk/; revision=48440Anders Broman1-6/+10
2013-03-19From beroset:Anders Broman1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48429
2013-03-03Use explicit casts.Anders Broman1-14/+15
svn path=/trunk/; revision=48043
2013-01-11Upgrade RRC dissector to v11.4.0Pascal Quantin7-133/+2834
svn path=/trunk/; revision=47041
2012-11-26Add missing OPTIONAL keyword in RRCConnectionRequest messagePascal Quantin1-1/+1
svn path=/trunk/; revision=46202
2012-11-13Pacify OSX-10.5 buildbotsPascal Quantin1-4/+4
svn path=/trunk/; revision=46017
2012-11-12Fix detection of H-RNTI when it is given after the DL-TransportChannelType ↵Pascal Quantin3-27/+29
configuration (typically in case of handoverToUTRANCommand) svn path=/trunk/; revision=46012
2012-11-07Avoid accessing a no more valid tvbuffPascal Quantin2-2/+10
svn path=/trunk/; revision=45957
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45015
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki2-7/+7
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-15Fix field type for some 64 bits header fieldsPascal Quantin1-1/+0
svn path=/trunk/; revision=44513
2012-08-09From Jacob Nordgren and Rishie Sharma:Anders Broman2-25/+17
FP: fixed exotic bug where fakes counter was sometimes not reset, RRC: fixed bug where num_chans_per_flow was not properly cleared svn path=/trunk/; revision=44375
2012-08-08Various small changes:Pascal Quantin3-247/+235
- add a missing test on null pointer - always initialize rrc_nas_sys_info_gsm_map_type with a value from its associated enum - fix some typo errors - remove some useless directives from conformance file - detabify files (ASN.1 generated dissectors are indented with spaces) svn path=/trunk/; revision=44358
2012-08-08From Jacob Nordgren and Rishie Sharma:Anders Broman3-52/+248
- FP: added header CRC validation, added crc11.c and crc11.h in wsutil/ for EDCH 11 bit CRC, fixed bug in RRC, And also smaller bugfixes in umts_fp and rrc. svn path=/trunk/; revision=44349
2012-07-30Fix Coverity CID 712343: Wrong sizeof argument.Chris Maynard1-1/+1
svn path=/trunk/; revision=44136