aboutsummaryrefslogtreecommitdiffstats
path: root/asn1/h248
AgeCommit message (Collapse)AuthorFilesLines
2015-12-10Convert ASN.1 dissectors to remove "new" from "new-style" dissector function ↵Michael Mann1-1/+1
names that were generated from asn2wrs.py This includes: 1. new_create_dissector_handle -> create_dissector_handle 2. new_register_dissector -> register_dissector 3. new_register_ber_oid_dissector -> register_ber_oid_dissector 4. new_register_ber_syntax_dissector -> register_ber_syntax_dissector Also remove PDU_NEW, SYNTAX_NEW and REGISTER_NEW as there is no need for the distinction anymore. Change-Id: I82c7de7c8ffeeab3259d1b55bb4afc5f6a1e0329 Reviewed-on: https://code.wireshark.org/review/12491 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09"new" dissector API -> dissector API for ASN.1 dissectors.Michael Mann1-2/+2
Change-Id: I7b794cba2feda2cae40411e2b1cb9fb091d08220 Reviewed-on: https://code.wireshark.org/review/12480 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-22register_dissector -> new_register_dissector for ASN.1 dissectors.Michael Mann1-7/+9
Change-Id: I0476519c02ffdd426b4fdfe8a206d61b728c327a Reviewed-on: https://code.wireshark.org/review/12026 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-20More spelling fixes found by lintianBalint Reczey1-1/+1
Change-Id: Id218dec9e5a721d6c63fd34962ffe50b6ab8dd56 Reviewed-on: https://code.wireshark.org/review/11946 Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Diederik de Groot <dkgroot@talon.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-04Don't allow multiple registrations of a protocol in dissector tables.Michael Mann1-1/+1
The target here is the Decode As dialog where protocols have multiple registrations into a dissector table and that shows up as multiple entries in the Decode As dialog list with the same name so users are unsure which "dissector" they are choosing. The "default" behavior (done in this commit) is to not allow duplicates for a dissector table, whether its part of Decode As or not. It's just ENFORCED for Decode As. Bug: 3949 Change-Id: Ibe14fa61aaeca0881f9cc39b78799e314b5e8127 Reviewed-on: https://code.wireshark.org/review/11405 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-07H248: fix V712 warning reported by PVS-StudioPascal Quantin1-2/+3
Be advised that compiler may delete this cycle or make it infinity. Use volatile variable(s) or synchronization primitives to avoid this. Change-Id: I39104ec09f4c12994d62ed23e7a0cc00829b1255 Reviewed-on: https://code.wireshark.org/review/8818 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-02-18H.248: fix dissection of ServiceChangeReason for version 1Pascal Quantin3-45/+2
My understanding of RFC 3015 is that the encoding of this field was not different in version 1 compared to newer releases Bug: 10879 Change-Id: Iaa81679388860c0df4adc673ca6e56aff6f4591c Reviewed-on: https://code.wireshark.org/review/7195 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-07tvb_bytes_to_ep_str -> tvb_bytes_to_strMichael Mann1-1/+1
Change-Id: I79c613cbdd8dc939dd4c29ebc477fb6eefd5bfc4 Reviewed-on: https://code.wireshark.org/review/6371 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23asn1 generated dissectors: cleanup #include usageBill Meier1-2/+2
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387 Reviewed-on: https://code.wireshark.org/review/6008 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-17H248: Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-17/+19
Also fix some indent issue Change-Id: I262bdddd031fec6a0f91b7172bb2d67be3c33000 Reviewed-on: https://code.wireshark.org/review/5370 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-29Don't include ctype.h and replace isascii() with _ascii_isprint().AndersBroman2-4/+3
Remove deprecated APIs while at it. Change-Id: I002ed4a696782caaeeb70a3e4ced4ae81f3d5372 Reviewed-on: https://code.wireshark.org/review/4983 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-13ASN1: Register PDU-dissectors as NEWStig Bjørlykke1-1/+1
Change-Id: I1a317b19d8076588c9305dae6287bb80cc14da64 Reviewed-on: https://code.wireshark.org/review/4494 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-08-09Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.Michael Mann1-3/+8
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions. Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree. Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141 Reviewed-on: https://code.wireshark.org/review/3500 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-07-31Add more files to the distribution.Guy Harris1-0/+4
If it's checked into asn1 or a subdirectory thereof, put it into the distribution. (If it's not useful, why is it in Git?) Change-Id: I4dac8a0d19a770db1513729cf71069a37f1d83fc Reviewed-on: https://code.wireshark.org/review/3276 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-30Add some files under asn1 to the distribution.Guy Harris1-1/+1
Include CMakeLists.txt files and the gnm subdirectory, along with the top-level Makefile.inc and Makefile.preinc files. Don't explicitly include Custom.make, as automake does that automatically given that it's included by asn1/Makefile.am. Add some files to EXTRA_DIST lists. Move some .asn files to EXTRA_DIST; they don't need to be in SRC_FILES, as SRC_FILES always includes EXTRA_DIST, and they *do* need to be in EXTRA_DIST so that they're in the distribution. Change-Id: Id91df577260fa57028d40fe098be1d79c59398e6 Reviewed-on: https://code.wireshark.org/review/3273 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-20batch of tvb-length conversionsEvan Huus1-6/+6
Change-Id: I5e40df8af6841e3dad71c41d7e43c7971611b15f Reviewed-on: https://code.wireshark.org/review/2473 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Revert "Update ASN.1 source files with the API changes done in g021e7af"Pascal Quantin2-8/+8
This reverts commit e308e7c4de81c2ff7159e444b865ac59de4faa2b. Change-Id: I079616d63f643f79f1bc03ef5fdf724f36df4071 Reviewed-on: https://code.wireshark.org/review/2435 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Update ASN.1 source files with the API changes done in g021e7afPascal Quantin2-8/+8
Change-Id: I52ecfccbce423206242e3cf99401a8c9e1655d88 Reviewed-on: https://code.wireshark.org/review/2385 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-3/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-05Add the possibillity to add a string to the termination id.AndersBroman2-5/+23
Change-Id: I3b48b28273a8c1a1558045d2a4ab5104160840de Reviewed-on: https://code.wireshark.org/review/1510 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-27Add dissection of 3G Interface Type package and add some comments aboutAndersBroman1-4/+4
the usage of variables in the h248_package_t struct. Change-Id: Ic5419ab5c20051e56963fe8ea1728d78f95538f0 Reviewed-on: https://code.wireshark.org/review/846 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-26Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate ↵Bill Meier3-21/+21
dissectors. Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4 Reviewed-on: https://code.wireshark.org/review/412 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-22Fix Called function pointer is null (null dereference) found by ClangAlexis La Goutte1-3/+2
../../asn1/h248/packet-h248-template.c:1222:31: warning: Value stored to 'prop' is never read if (!prop->dissector) prop = &no_param; Change-Id: I6d380fbb5fef9dc548385b0b470aea1cb3c34df1 Reviewed-on: https://code.wireshark.org/review/301 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-18Remove $Id$ from the ASN.1 dissectors and regenerate them.Jeff Morriss9-20/+0
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954 Reviewed-on: https://code.wireshark.org/review/244 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-01-14Don't make claims of constness that can't be guaranteed in terms the CGuy Harris2-2/+2
compiler can verify. svn path=/trunk/; revision=54792
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-2/+2
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-12-17Make local functions static. Include *.h when needed.Anders Broman2-2/+5
svn path=/trunk/; revision=54201
2013-11-10Pass "wild_card" directly to dissector instead of using private_data. ↵Michael Mann1-2/+1
"h248term" dissector is not in Wireshark source, so third-party will need to update accordingly. svn path=/trunk/; revision=53241
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-05Get rid of a duplicated filter name.Anders Broman2-7/+2
svn path=/trunk/; revision=51792
2013-09-01More dissectors to wmem. There are no more dissectors using se_tree now, just aEvan Huus1-8/+8
few other places. svn path=/trunk/; revision=51622
2013-08-04Convert proto_item_set_expert_flags into filterable items.Michael Mann1-5/+18
svn path=/trunk/; revision=51140
2013-08-04Convert proto_item_set_expert_flags to "filterable" items in alcap ↵Michael Mann1-1/+1
dissector. Unfortunately it had a few tentacles, so they needed to be brought along for the ride. svn path=/trunk/; revision=51136
2013-07-06Use epan-scoped memory for h248 packages. Fixes another ~24KB of leaks.Evan Huus1-3/+3
svn path=/trunk/; revision=50414
2013-06-19Apparently one of our major global headers must include emem.h, because I justEvan Huus2-15/+15
found a bunch more asn1 dissectors using emem without ever directly including the header. Convert those to wmem as well, which involves add a number of #include directives since dissectors do *not* automatically pull in the wmem headers. svn path=/trunk/; revision=50066
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann2-2/+10
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-05-07Some moreJörg Mayer1-0/+28
svn path=/trunk/; revision=49203
2013-05-05Just whitespace changesJörg Mayer1-2/+3
svn path=/trunk/; revision=49167
2013-04-23Stub cmake support for generating the asn1 dissectors.Jörg Mayer1-0/+23
It doesn't do anything yet, it is just to make svn status readable again. svn path=/trunk/; revision=49007
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-8/+8
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-19From beroset:Anders Broman2-6/+5
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48429
2013-03-01Export libwireshark symbols using WS_DLL_PUBLIC defineBalint Reczey1-1/+3
Also remove old WS_VAR_IMPORT define and related Makefile magic everywhere in the project. svn path=/trunk/; revision=47992
2013-02-26its ==> it's & it's ==> its as needed.Bill Meier1-2/+2
svn path=/trunk/; revision=47892
2013-02-20Clean up white space - get rid of 4-space tabs.Guy Harris1-166/+176
Reformat the hf[] array to be consistent, and get rid of some bogus blurbs (probably copy-and-pasteos). svn path=/trunk/; revision=47759
2013-02-02Hack: disguise '/*' in text strings to prevent checkAPIs & etc seeing 'start ↵Bill Meier1-1/+1
of comment' within a text string. svn path=/trunk/; revision=47446
2013-01-19Use epan-scoped memory to clean up another 1Kb+ of valgrindEvan Huus1-3/+4
sorta-false-positive leaks. svn path=/trunk/; revision=47170
2012-12-13From John Batty via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8087 :Pascal Quantin1-1/+1
H.248 MEGACO PkgName property is poorly formatted svn path=/trunk/; revision=46526
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45015
2012-07-11Revert part of revision 43107 which broke sub dissection ofAnders Broman1-32/+38
Signal and events as a new tvb wasn't created. |BASE_EXT_STRING also removed. svn path=/trunk/; revision=43661
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-18 15:02:34 +0000