aboutsummaryrefslogtreecommitdiffstats
path: root/asn1/gsm_map
AgeCommit message (Collapse)AuthorFilesLines
2013-10-29From didier gautheron: remove redundant or use faster col_xxx functionsBill Meier2-3/+3
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster. - same for replace col_append_fstr and col_append_str - remove col_clear() when it's redundant: + before a col_set/col_add if the dissector can't throw an exception. - replace col_append() after a col_clear() with faster col_add... or col_set https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344 svn path=/trunk/; revision=52948
2013-10-28Pass tcap_private into the dissectors that need it rather than use ↵Michael Mann1-12/+12
private_data. Not sure if value_ptr is the "proper" place to pass tcap_private "internally" within the TCAP dissector, but it gets away from (potential) private_data (ab)use. svn path=/trunk/; revision=52916
2013-10-02Replace the 3 dissector tables (with a single entry in each) by a direct ↵Pascal Quantin2-13/+10
call to the GSM SMS dissector svn path=/trunk/; revision=52336
2013-09-22emem -> wmem conversion:Pascal Quantin1-2/+2
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-18Remove all non-ASCII characters from all .asn files. I didn't see the harm ↵Chris Maynard3-252/+252
in replacing them all as opposed to only those not copied verbatim from other sources. svn path=/trunk/; revision=52132
2013-09-15Fix checkapi warnings (missing id)Jörg Mayer1-5/+6
Replace Makefile.{am,nmake,common} that did not conform by their asn1/c133/ version. svn path=/trunk/; revision=52062
2013-09-09Change some internal dissector table UI names so it's clear which protocol ↵Chris Maynard1-6/+6
they pertain to and it's easier to find in the list. svn path=/trunk/; revision=51904
2013-08-08When dissecting IMSI handle the zero length tvb case, fixes "Malformed ↵Anders Broman1-0/+2
Packet: CAMEL (empty IMSI tag)" https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9015 svn path=/trunk/; revision=51208
2013-07-03expert_add_info_format_text + proto_tree_add_text = ↵Michael Mann1-11/+6
proto_tree_add_expert_format, where applicable. svn path=/trunk/; revision=50377
2013-07-03expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicableMichael Mann1-7/+3
svn path=/trunk/; revision=50337
2013-06-19Convert a batch of asn1 dissectors from emem to wmem.Evan Huus1-2/+2
svn path=/trunk/; revision=50057
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann1-12/+21
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-05-15Export CellGlobalIdOrServiceAreaIdOrLAI.Anders Broman1-0/+1
svn path=/trunk/; revision=49312
2013-05-07Make exports actaully workJörg Mayer1-2/+3
Add ansi_map as first generated file that uses exports (from gsm_map in this case). svn path=/trunk/; revision=49195
2013-05-07Move common code into UseAsn2Wrs.cmake.Jörg Mayer1-0/+78
Include the new file. Use the new file. Add cmake support to rebuild the gsm_map dissector. svn path=/trunk/; revision=49194
2013-05-05Just whitespace changesJörg Mayer1-1/+0
svn path=/trunk/; revision=49167
2013-04-23Stub cmake support for generating the asn1 dissectors.Jörg Mayer1-0/+23
It doesn't do anything yet, it is just to make svn status readable again. svn path=/trunk/; revision=49007
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-1/+1
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-28-Wmissing-prototypesAnders Broman1-0/+3
svn path=/trunk/; revision=48609
2013-03-27Fix another incorrectly duplicated display filter, this time for ↵Chris Maynard1-2/+2
hf_gsm_map_etsi_pdp_type_number. #BACKPORT(1.6,1.8) svn path=/trunk/; revision=48601
2013-03-27Fix the incorrectly duplicated display filter for hf_gsm_map_dlci.Chris Maynard1-1/+1
#BACKPORT(1.6, 1.8) svn path=/trunk/; revision=48597
2013-03-24Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8517 :Pascal Quantin1-6/+6
Do not tap an unknown Opration Code svn path=/trunk/; revision=48539
2013-03-08Update to V11.5.0 (2012-12).Anders Broman24-81/+317
svn path=/trunk/; revision=48195
2013-03-01Export libwireshark symbols using WS_DLL_PUBLIC defineBalint Reczey2-6/+8
Also remove old WS_VAR_IMPORT define and related Makefile magic everywhere in the project. svn path=/trunk/; revision=47992
2013-02-27Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8378 :Pascal Quantin1-3/+7
A detailed diagnostic information contains either a SMS-SUBMIT-REPORT or a SMS-DELIVERY-REPORT. Set P2P direction accordingly. svn path=/trunk/; revision=47927
2013-02-05Export TBCD-STRING.Anders Broman1-0/+1
svn path=/trunk/; revision=47496
2013-01-31Add an OID translation.Anders Broman1-0/+1
svn path=/trunk/; revision=47386
2013-01-19Fix for CID 280252.Jaap Keuter1-2/+2
We can be sure we've at least 0 bytes remaining in the TVB. svn path=/trunk/; revision=47162
2012-12-12"Fill" a couple of value_string(ext)Anders Broman1-0/+5
svn path=/trunk/; revision=46518
2012-11-29Make all enum_val_t's const.Jeff Morriss1-2/+2
svn path=/trunk/; revision=46292
2012-10-21AddressString can have a size of 1, fixes Bug 7882 -GSM_MAP show malformed ↵Anders Broman1-0/+3
Packets when two IMSI https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7882 svn path=/trunk/; revision=45687
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45015
2012-08-21Add dissection of locationInformation IE in Ericsson proprietary extensionPascal Quantin3-3/+57
svn path=/trunk/; revision=44605
2012-08-21Fix filter names for Ericsson proprietary extensionsPascal Quantin2-2/+3
svn path=/trunk/; revision=44604
2012-08-21Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7648 :Pascal Quantin4-5/+68
Add support for Ericsson proprietary extensions to GSM MAP dissector svn path=/trunk/; revision=44603
2012-08-20Remove unused hf_gsm_map_imsi_digits entry and fix filter name for ↵Pascal Quantin1-6/+1
hf_gsm_map_TBCD_digits (which is also used for IMEI, ASCI call reference, MS Group ID and MS Long Group ID on top of IMSI) svn path=/trunk/; revision=44596
2012-08-20Avoid defining 2 entries with incompatible types (FT_BYTES vs FT_NONE) and ↵Pascal Quantin1-0/+5
same filter svn path=/trunk/; revision=44595
2012-08-01Follow-up of r44162: gsm_a_gm dissector is used for both GPRS Mobility ↵Pascal Quantin1-6/+6
Management and Session Management protocols. Update filter names accordingly. svn path=/trunk/; revision=44183
2012-07-10Introduce a preference setting for application context version.Anders Broman1-8/+29
svn path=/trunk/; revision=43641
2012-06-28Update Free Software Foundation address.Jakub Zawadzki5-5/+5
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-04Fix 'lvalue required as left operand of assignment' error when compiling ↵Pascal Quantin1-1/+1
with gcc 4.3.2 svn path=/trunk/; revision=43059
2012-06-04Get rid of a couple of warnings.Anders Broman2-47/+47
svn path=/trunk/; revision=43057
2012-05-19Fix RVALS() macro usagepascal1-1/+1
svn path=/trunk/; revision=42720
2012-05-07Get rid of remaining Booleans-as-encoding-arguments inGuy Harris2-30/+30
proto_tree_add_item() calls. svn path=/trunk/; revision=42485
2012-04-14Set direction according to destination address field also (and not only ↵pascal1-0/+24
originating address). svn path=/trunk/; revision=42065
2012-03-07Location Number not decoded as per Q.763 ↵Anders Broman2-0/+117
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6781 svn path=/trunk/; revision=41393
2012-03-02Remove now unused variables.Anders Broman1-1/+0
svn path=/trunk/; revision=41319
2012-03-02Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-4/+0
svn path=/trunk/; revision=41296
2012-01-26From Mike Morrin:Anders Broman3-18/+18
Add dissectors for GSM and UMTS Cell Broadcast protocols. ( - the patch for gsmtap ) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6770 svn path=/trunk/; revision=40735
2011-11-29Wireshark crashes in gsm_map dissectorAnders Broman1-0/+1
For now use Jeff's fix: "The REAL problem is that the GSM_MAP dissector is using this value_string_ext in the hf without BASE_EXT_STRING: { &hf_gsm_old_localValue, { "localValue", "gsm_old.localValue", FT_INT32, BASE_DEC, &gsm_old_GSMMAPOperationLocalvalue_vals_ext, 0, "OperationLocalvalue", HFILL }}, This, in turn, appears to be caused because OperationLocalValue is an alias for/of GSMMAPOperationLocalValue and only the latter is defined with .USE_VALS_EXT. I can fix it by doing: Index: asn1/gsm_map/gsm_map.cnf =================================================================== --- asn1/gsm_map/gsm_map.cnf (revision 39628) +++ asn1/gsm_map/gsm_map.cnf (working copy) @@ -54,6 +54,7 @@ #.USE_VALS_EXT GSMMAPOperationLocalvalue +OperationLocalvalue #.EXPORTS AddressString But it seems to be that asn2wrs should arguably be figuring this out on its own." svn path=/trunk/; revision=40033