Age | Commit message (Collapse) | Author | Files | Lines |
|
svn path=/trunk/; revision=18059
|
|
svn path=/trunk/; revision=18058
|
|
svn path=/trunk/; revision=18057
|
|
dissector).
svn path=/trunk/; revision=18056
|
|
for ERR_BADOPTION which can be seen in the constrained-delegation.zip capture on the wiki sample captures page.
svn path=/trunk/; revision=18055
|
|
Declare "error", and properly terminate a string.
svn path=/trunk/; revision=18054
|
|
coverity showed this as a null dereference which was a false positive.
sp can never be null here.
there is a bug however since with this invalid test the memory release functions will never be called and we thus had a memory leak here.
svn path=/trunk/; revision=18053
|
|
dont need to test for it.
this unnecessary test for itlq==NULL was shown by coverity issue 151
svn path=/trunk/; revision=18052
|
|
programs, by reporting it with a dialog box that at least attempts to
indicate what the problem is, and by giving up early on running dumpcap.
svn path=/trunk/; revision=18051
|
|
"struct tcp_multisegment_pdu"; that lets it be used in one case where
the code in it was duplicated.
Make "desegment_tcp()" loop rather than recursing - not all compilers
will necessarily recognize the tail recursion.
Catch heuristic dissectors that reject a packet but also request
(whether deliberately or accidentally) that more data be added.
svn path=/trunk/; revision=18050
|
|
reassembly. UDP has no notion of reassembly - that's done at the IP
layer - and SCTP has its own notions of reassembly which it currently
doesn't provide. As such, TCP-style reassembly isn't possible for
JXTA-over-UDP or JXTA-over-SCTP.
As for TCP, a heuristic dissector for a TCP-based protocol can't request
more data if it's rejecting a packet; make it not do so. That should
fix the recent buildbot crash, although there are still some reassembly
problems with that capture (c05-http-reply-r1.pcap.gz in the menagerie
and on the SampleCaptures page of the Wiki) that aren't fixed yet.
svn path=/trunk/; revision=18049
|
|
svn path=/trunk/; revision=18048
|
|
expected.
svn path=/trunk/; revision=18047
|
|
use tcp_multisegment_pdu and se_tree_lookup32_le() to track pdu boundaries for tcp reassembly just as this structure is used for the same purpose when reassembly is not enabled.
get rid of a hashtable and two memchunks we no longer need
tcp_segment_table tcp_segment_key_chunk and tcp_segment_address_chunk
This makes tcp reassembly work for out-of-order segments as well as when reassembly completes in one segment and when the tail of the segment contains the head of the next pdu which we did not handle before.
tcp reassembly should be much better and efficient now modulo introduced regressions.
svn path=/trunk/; revision=18046
|
|
svn path=/trunk/; revision=18045
|
|
that isn't written const.
svn path=/trunk/; revision=18044
|
|
buildbot build, even though the code is #if 0'ed out).
svn path=/trunk/; revision=18043
|
|
svn path=/trunk/; revision=18042
|
|
Try leaving "dlg_utils.h" out.
svn path=/trunk/; revision=18041
|
|
svn path=/trunk/; revision=18040
|
|
svn path=/trunk/; revision=18039
|
|
svn path=/trunk/; revision=18038
|
|
svn path=/trunk/; revision=18037
|
|
header file.
#if 0 out some includes; if none of the builds have a problem with
that, I'll remove them.
svn path=/trunk/; revision=18036
|
|
svn path=/trunk/; revision=18035
|
|
it to capture_file_dlg.c, and rename its header file. We might want to
move the generic file dialog stuff to a file_dlg.c file (it's currently
in dlg_utils.c), and move the non-capture-file dialog stuff in
capture_file_dlg.c to another file.
svn path=/trunk/; revision=18034
|
|
enough to have a non-BVLC packet from or to port 47808, we're likely to
reject it and let another dissector try it. Fixes bug 855 (in which an
MS Messenger packet was unlucky enough to have come from that port).
Add value_string tables to some fields, and just use
proto_tree_add_uint() to add them to the protocol tree, rather than
generating our own text for them.
svn path=/trunk/; revision=18033
|
|
as an argument, rather than keeping the count to themselves, so the
count kept by the capturing program can be updated correctly - including
getting reset when files are switched. Fixes bug 895.
svn path=/trunk/; revision=18032
|
|
Save the media encoding name in the transport_info_t structure rather
than in a global variable. Allocate it with tvb_get_ephemeral_string()
so it's released after the packet is completely processed. Do *NOT*
assume it's necessarily non-null in decode_sdp_fmtp(), as the code flow
doesn't guarantee that to be true.
proto_tree_add_string() now suffices for adding a particular SDP item -
strings are now displayed "safely", with escaping of non-printable
characters done.
Update a comment (we no longer have the Big Transfer Vector to allow
plugins to call dissector functions in Windows, we have those functions
in a DLL).
svn path=/trunk/; revision=18031
|
|
Patch to fix:
[Bug 904] FIX protocol dissector missing some message types
svn path=/trunk/; revision=18030
|
|
want to have a dissector capable of rejecting packets, you need to
reject the packet before you call tcp_dissect_pdus() - once you're doing
reassembly, etc., it's too late to reject the packet.)
svn path=/trunk/; revision=18029
|
|
svn path=/trunk/; revision=18028
|
|
svn path=/trunk/; revision=18027
|
|
_T macros. Remove some extraneous comments.
svn path=/trunk/; revision=18026
|
|
our page size and OS version information once.
svn path=/trunk/; revision=18025
|
|
now that we have se_tree_lookup32_le we can do the tracking of pdu boundaries much more efficiently.
track pdu boundaries by a new tcp_multisegment_pdu structure that is indexed by sequence numbers and let this structure replace the older tcp_next_pdu structure.
with se_tree_lookup32_le we no longer need to track segment by segment and can get rid of the two hash tables
tcp_pdu_tracking_table
tcp_pdu_skipping_table
Neither do we need the tree tcp_pdu_time_table anymore so that one is gone as well.
remove various other functions that are no longer needed due to removing the structure and the tables/tree
this part of the code shoul;d be much more readable now and also a bit faster
svn path=/trunk/; revision=18024
|
|
- remove c2asn() which did not work exactly
svn path=/trunk/; revision=18023
|
|
IEEE80211_RADIOTAP_FLAGS.
svn path=/trunk/; revision=18022
|
|
svn path=/trunk/; revision=18021
|
|
the amount of data left in the radiotap header after the fields we've
processed so far, not the total length of the header, so it couldn't be
used to skip past the radiotap header and get a tvbuff of the packet
data. Fix that.
svn path=/trunk/; revision=18020
|
|
libraries with which we link libethereal, fixing the reopened bug 878.
svn path=/trunk/; revision=18019
|
|
svn path=/trunk/; revision=18018
|
|
svn path=/trunk/; revision=18017
|
|
Fix typo in menu item name
svn path=/trunk/; revision=18016
|
|
The code was incorrectly bounds checking AndXOffset. AndXOffset is only
relevant when AndXCommand is not 0xFF. This patch corrects erroneous
"Malformed packet" exceptions.
svn path=/trunk/; revision=18015
|
|
svn path=/trunk/; revision=18012
|
|
our guard pages.
svn path=/trunk/; revision=18011
|
|
svn path=/trunk/; revision=18010
|
|
svn path=/trunk/; revision=18009
|
|
Fixes coverity bug 159.
svn path=/trunk/; revision=18005
|