aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-01Cast the result of g_realloc().Guy Harris1-1/+1
That squelches warnings if C++ compatibility is being checked. Change-Id: Ia3dd9852df0fbf6353a84d299a385ef63c9f1acd Reviewed-on: https://code.wireshark.org/review/28920 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01Kafka: add info when we lack decompression supportTim Cuthbertson1-2/+8
Change-Id: I4c1b5d84bd1a6dfa811fd8ffbd576ac8dfd448af Reviewed-on: https://code.wireshark.org/review/28749 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01RFC 7468 is PEM-inspired, but it's not PEM.Guy Harris5-22/+22
Do some renaming. Change-Id: If8fa85370014f9618df38d97048dd1c52a4c389f Reviewed-on: https://code.wireshark.org/review/28918 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01No need to tell the BER dissector the file name for RFC 7468 files.Guy Harris1-2/+1
It's just a hack for "raw BER data" files, giving them a file name that includes the OID to use for the syntax. For RFC 7468 files, the syntax is determined from the label in the pre-encapsulation boundary. Change-Id: Ia656f20f123d2c6a85041f83714a3a1cfefb70b1 Reviewed-on: https://code.wireshark.org/review/28916 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01Don't hide dissected data under a "Data" item.Guy Harris1-7/+8
Only put otherwise-undissectable BER data under that item. That removes an extra layer that needs to be opened up. Change-Id: I6b025a782ff7199c84bad46160c7c286e79b0580 Reviewed-on: https://code.wireshark.org/review/28915 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01AT: Dissect commandsDarien Spencer1-29/+1672
This commit introduces dissection of the different parts of the command, showing of the command direction and origin entity, generic dissection of 'unsupported' commands, detailed dissection of several 'supported' commands and aggregated commands dissection. Most of the code has been taken from BT-HFP (A protocol of AT commands over bluetooth). Change-Id: I3516ec9c28581df8ef9c0c37f9b6ee9ec0c55938 Reviewed-on: https://code.wireshark.org/review/28699 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01radiotap: Add support for 0-length PSDUs.Richard Sharpe3-3/+55
Change-Id: I386c6cd84a74eda5dff32fb93b0a35eb54bc6b4b Reviewed-on: https://code.wireshark.org/review/28884 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01Do most of the RFC 7468 file processing in the dissector.Guy Harris9-120/+578
Have the Wiretap code just do a heuristic test to see if the file looks like a RFC 7468 file and just had the entire blob of raw file data to the caller, with an encapsulation type of WTAP_ENCAP_RFC7468. Have a file-rfc7468.c dissector that processes the lines of the file, displaying all of them. Have it extract the label from the pre-encapsulation boundary line, and, after it's decoded the base64-encoded data lines into a blob of data, try handing the tvbuff with the blob to dissectors that have registered in the "pem.preeb_label" dissector table with the appropriate label value, and hand it to the raw BER dissector only if that fails. This allows some files to have the content dissected as more than just a raw blob of BER-encoded data. Change-Id: I98db9f0beb86e5694fb8e886005a2df4fc96ba71 Reviewed-on: https://code.wireshark.org/review/28914 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01Revert "Have find_or_create_conversation() use pinfo->conv_endpoint if present."Guy Harris4-30/+32
This reverts commit ba202ef36225b59eb797c5a48b8d4a4665b479c7. Creating endpoints, and corresponding conversations, for protocols atop which TCP or UDP runs can potentially cause attempts to look up the conversation to find the conversation for that protocol rather than for TCP/UDP, which can confuse protocols running atop TCP or UDP. Change-Id: I3ca522e54e67cc4f996d0ee841c6bb40ee6a9976 Reviewed-on: https://code.wireshark.org/review/28912 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-01Get rid of a no-longer-used dissector handle.Guy Harris1-4/+0
Change-Id: I3e5bdc0339a0f229f40a6538f93c699106941e28 Reviewed-on: https://code.wireshark.org/review/28910 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Have find_or_create_conversation() use pinfo->conv_endpoint if present.Guy Harris4-32/+30
Add conversation_new_pinfo(), which uses the endpoint if present, and have find_or_create_conversation() use it rather than conversation_new(). Remove find_or_create_conversation_by_id() - it's no longer needed. Bug: 15018 Change-Id: Ib13e539751af0f071aede4ee0ed751d0cb72ba3f Reviewed-on: https://code.wireshark.org/review/28908 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Export some more conversation functions.Guy Harris2-4/+10
They're used by built-in dissectors; I see no reason whatsoever to forbid plugins from using them. See https://ask.wireshark.org/question/4366/compile-plugin-with-call-to-conversation_set_port2/ Change-Id: I6a04df961c164a09b88abd8f46a1fe3420a21661 Reviewed-on: https://code.wireshark.org/review/28906 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31For ISDN, don't create an endpoint by ID and then use it.Guy Harris4-3/+29
That isn't working, because it depends on the notion that for every "endpoint type" there's a "port type" for the packet_info structure; that's not true for ISDN channels. The whole point of "use the packet_info structure when trying to find a conversation and create it if it doesn't exist" is to use address information *already filled in by somebody for use by other dissectors*; we don't do that with the ISDN channel number, because there's no *need* to do so. So just add a new find_or_create_conversation_by_id() routine, which passes the packet_info structure to get the frame number, and explicitly passes the endpoint type and ID. Use that in the ISDN dissector. Bug: 15018 Change-Id: Id0e997254b0eaf7cbc9261a2adff639ecbf083c0 Reviewed-on: https://code.wireshark.org/review/28904 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Improve debugging messages.Guy Harris1-10/+36
For various attempted matches, print what we're matching against. Change-Id: Ib915aa9bc6e6e1ea6cc7a273f261db2a4952c0c4 Reviewed-on: https://code.wireshark.org/review/28900 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Frame numbers are unsigned.Guy Harris1-11/+11
Change-Id: I07641b0a759058fe5111e10c3ccd4c8f69eeccef Reviewed-on: https://code.wireshark.org/review/28894 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31Clean up white space.Guy Harris1-45/+46
Change-Id: Id1eb5ec743581a0d05b82e94c78f262e7dc33f7b Reviewed-on: https://code.wireshark.org/review/28892 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31radiotap: fix indent (use tab)Alexis La Goutte2-3/+3
Change-Id: I9fc2320ecd760f2be92b53d57fe1e12152edf198 Reviewed-on: https://code.wireshark.org/review/28890 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot
2018-07-31wmem_interval_tree: fix no previous prototype for ↵Alexis La Goutte1-1/+1
‘update_edges_after_rotation’ [-Wmissing-prototypes] Change-Id: I60085243d0e57ac072246bf3374ed3b7f6078497 Reviewed-on: https://code.wireshark.org/review/28889 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-31No need to initialize cursorname_len.Guy Harris1-1/+1
Not initializing it also means that we'll get an error from compilers with sufficiently good dataflow analysis if we use it in, or before, the call itself, which is a Good Thing as we *shouldn't* use it before we know it. Change-Id: I99aa3fedd2a04f5bb6e60e0f6f8b0a3682263351 Reviewed-on: https://code.wireshark.org/review/28888 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-31TDS: Fix bad proto_tree_add_item_ret_string_and_length call.Craig Jackson1-1/+1
I'm not sure why this compiled in all of the test environments. (Ubuntu and Windows, plus Buildbot.) Change-Id: I15d281010f3f463f3929aff8918ade8b71cffff7 Reviewed-on: https://code.wireshark.org/review/28887 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-31sccp: Make "lr" a generated item rather than hidden to make it obvious that ↵Vasil Velichkov1-2/+2
it exists. Similar to the TCAP transaction IDs - hf_tcap_tid, hf_tcap_dtid and hf_tcap_otid. Change-Id: Idf55c894f5c0e60844c03b7de89b56f632d0ed36 Reviewed-on: https://code.wireshark.org/review/28885 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-31tds: fix uninitialized var.Dario Lombardo1-1/+1
../epan/dissectors/packet-tds.c:2659:27: error: variable 'cursorname_len' is uninitialized when used here [-Werror,-Wuninitialized] tvb, cur + 1, cursorname_len, tds_get_char_encoding(tds_info)|ENC_NA, ^~~~~~~~~~~~~~ ../epan/dissectors/packet-tds.c:2653:29: note: initialize the variable 'cursorname_len' to silence this warning guint cursorname_len; ^ = 0 1 error generated. Change-Id: I21a1e34997af95097d3a916589f69b86a6fe0418 Reviewed-on: https://code.wireshark.org/review/28883 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-31Relax ERF heuristicStephen Donnelly1-2/+2
Allow forward timestamp deltas up to 1 year, up from 7 days. Surprisingly this was overly restrictive in some real cases. Change-Id: I8a4bd1ca791b978aa5d2be40f7f8dd8e23db8837 Reviewed-on: https://code.wireshark.org/review/28882 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30Add WTAP_ENCAP_RUBY_MARSHAL to the table of encapsulation names.Guy Harris1-0/+3
Change-Id: If7362bc4e1da3c3dc22df08b52c7cadcd43d3b81 Reviewed-on: https://code.wireshark.org/review/28886 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-30SCTPGraphDialog: fix displaying a single TSNVasil Velichkov1-3/+2
When the SCTP association contains a single DATA/SACK chunk in direction the max and min TSN values are equal and as a result the Y axis range is (maxTSN, maxTSN) or (0, 0) and the dots for the TSN are not visible To fix this always set the Y axis maximum to maxTSN + 1 similar to the X axis maximum of max_secs + 1 Also removed one unused local variable Change-Id: Id38eb4dbd13a8ebbba98d4df00f3707331bd1464 Reviewed-on: https://code.wireshark.org/review/28862 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30SCTPGraphArwndDialog: Detect max arwnd value when startArwnd is not setVasil Velichkov2-1/+6
When the capture does not contains SCTP INIT and INAT_ACK packets the startArwnd value is 0 (not set) and as a result the Y axis range is (0,0) and the dots are not visible Change-Id: Iafb1981e62f28fe09b106138836c866d0dbebb27 Reviewed-on: https://code.wireshark.org/review/28861 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30GMPLS extensions to OSPF-TEKhalifa NDIAYE1-4/+184
- optical spectrum occupation for fixed grid WDM links (RFC 7688) - optical spectrum occupation for flexi-grid WDM links (RFC 8363) Change-Id: I7a4d8f0bd0b863b51dde60bb4b04f4756a7ca99b Signed-off-by: khalifaND <khalifa.ndiaye@orange.com> Reviewed-on: https://code.wireshark.org/review/28751 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-30Add basic support for TDS 5 (Sybase) cursors.Craig Jackson1-11/+839
Change-Id: Ie04489b5445dc473d9bc6d772c1c33270da9b363 Reviewed-on: https://code.wireshark.org/review/28835 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-29ieee80211: don't print the mode and channel in CSA IE as HEXEmmanuel Grumbach1-2/+2
The channel and the mode are easier to read as a decimal number. Change-Id: Ia34901cb7e799ab1fbee3bd754b488f84c20274a Reviewed-on: https://code.wireshark.org/review/28876 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-07-29[Automatic update for 2018-07-29]Gerald Combs3-16/+119
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ifc25c5ee60d7c9e09ced92c45107e4ceba6c929f Reviewed-on: https://code.wireshark.org/review/28877 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-27Qt: Comment some of the sparkline code.Gerald Combs1-0/+10
Explain some of the magic numbers and other parts of the sparkline code. Change-Id: Idfad30e773bd852ac021326467cf03ada91f6efc Reviewed-on: https://code.wireshark.org/review/28874 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-27bootp: Add support for non-standard MS option 77Graham Bloice1-11/+26
MS DHCP Clients configured for the RRAS role make DHCP requests for RAS pool IP's using a non-standard user class (option 77). Add support for this, along with an expert info to indicate the item is non-standard. Change-Id: I2f18061c8635fde69cbf4c5d6d0548fadecc28cb Reviewed-on: https://code.wireshark.org/review/28863 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2018-07-27bthci_cmd: fix spelling-error-in-binary found by lintianAlexis La Goutte1-3/+3
advertisments -> advertisements Change-Id: I52e7e9cb316f97ac6b0e083df5c7a393f27e0a1d Reviewed-on: https://code.wireshark.org/review/28859 Reviewed-by: Allan Møller Madsen <almomadk@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-27debian: add lintian-overrides for libwireshark0 (spelling-error-in-binary)Alexis La Goutte1-0/+6
Change-Id: Ic5e2745c0245c343fd6aae13638768fd215d6d60 Reviewed-on: https://code.wireshark.org/review/28860 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-26test: do not silently ignore feature detection failuresPeter Wu1-19/+19
When ASAN memleak detection is enabled, any memory leak would result in an exception and subsequently all features are marked as missing. With the default profile, any Lua plugin or certain configurations could cause a memory leak. To avoid such interference, set the configuration path to a dummy location and warn whenever an error happens nonetheless. Do not call setProgramPath() immediately, there is no "tshark" binary in the current working directory anymore. Rely on test.py to set the path. Change-Id: Idccc3d68eb6f6bb64d3a0b32897acecc65e0dfb6 Reviewed-on: https://code.wireshark.org/review/28867 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-07-26Revert "Pass all arguments to options as --option=argument."Guy Harris1-5/+2
This reverts commit 137d45f52c6ff3deb56721a6e37be5c4ed8f095a. Don't. Make. The. Argument. To. Your. Extcap. Program. Specific. Options. Optional. (Unless they're Boolean, in which case we never pass an argument - we just pass the option if it's true and don't pass it if it's false.) Change-Id: I11e4ecaa196fd94c493d51e1f73e90267e1d9b1d Reviewed-on: https://code.wireshark.org/review/28866 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-26Pass all arguments to options as --option=argument.Guy Harris1-2/+5
For options with optional arguments, the only syntax that's *guaranteed* to be handled by getopt_long() is --option=argument, not --option argument. The BSD/macOS version of getopt_long() only supports the former, not the latter. Change-Id: Icfaec9eda49f5a947961251ebd377d7c1684c823 Reviewed-on: https://code.wireshark.org/review/28865 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-26commit-msg: quote the filename, fix printed messagePeter Wu1-2/+2
Quote the filename in case it contains spaces or other special chars. Change-Id: I5ff901de0839551c06bc73b8bef631b64aff5199 Fixes: v2.9.0rc0-1078-gc20432285a ("git hooks: prevent first commit message line to exceed 80 chars.") Reviewed-on: https://code.wireshark.org/review/28827 Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-07-26--extcap-version requires = if it has an argument.Guy Harris1-2/+2
The version argument to --extcap-version is optional, and some versions of getopt_long() require, for a flag whose argument is optional, that the argument be supplied as --flag=value, not --flag value. Change-Id: I5e34132d8bb729b845ac75ff94d6d548c1c35a3d Reviewed-on: https://code.wireshark.org/review/28864 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-26diameter: Update with some AVPs from TS 29.272Joakim Karlsson1-3/+19
Change-Id: Ia16c113821b3c48d48a193e67ae46c9b025e79aa Reviewed-on: https://code.wireshark.org/review/28858 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-26MAC-LTE: Add framing/heuristic support for SR entries.Martin Mathieson2-0/+27
Change-Id: Ibd1df6d904b164aec74afa7d6b259bf202808c8c Reviewed-on: https://code.wireshark.org/review/28854 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-07-26Add a preference to override the radiotap FCS bit.Guy Harris1-3/+33
This is separate from the 802.11 preference, which only affects packets where no file or packet metadata indicates whether there is an FCS (yes, that is intentional behavior). This is specifically for radiotap, in case some driver fails to set the FCS bit correctly (this is currently an issue with Npcap, which currently assumes that the packet has an FCS iff NDIS indicated the packet with the DOT11_RECV_FLAG_RAW_PACKET flag; that doesn't appear to be a reliable indicator, and it's not clear there *is* a reliable indicator, so Npcap might have to fall back on something really gross like a quirks database for particular adapters). Change-Id: Ia3b134d89004307442d42cfa5ed3cf8fb938235f Ping-Bug: 15010 Reviewed-on: https://code.wireshark.org/review/28855 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-25GSM SIM: Show length for 0x9f status wordDarien Spencer1-1/+1
Second byte, sw2, contains the amount of bytes in the response. Change-Id: I237ef5978e81a2f13b821c5601177dac26829df1 Reviewed-on: https://code.wireshark.org/review/28850 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-25GSM SIM: Fix special case for "Wrong length" swDarien Spencer1-1/+4
While TS 51.011 defines '67 XX' as "Incorrect param P3", TS 102.221 specifies a special case '67 00' which wasn't taken into account in the dissector Change-Id: I2f17bd0035b3a9f4cdd625523eef06be416d451e Reviewed-on: https://code.wireshark.org/review/28849 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-25msgpack: replace pow() with shift.Dario Lombardo1-1/+1
This removes all casting issues. Change-Id: I0377fe3fa31edf1e6c3f315d31dd01a728a3c173 Reviewed-on: https://code.wireshark.org/review/28852 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-07-25Don't remove a tap listener we didn't find in the first place.Guy Harris1-2/+4
If remove_tap_listener() doesn't find a tap listener with the specified data, print a warning message and skip the "remove the tap listener" steps. This means that the internal free_tap_listener() won't be called with a null listener; remove the now-unnecessary check (if anybody *does* call it with a null pointer, that's a bug). This prevents the crash in bug 15006, but that now produces a warning message; it doesn't fix the underlying bug, it just changes the symptom. Change-Id: Ia9a2bfa3d57b86eac0d6e0b0bad03a7b81e254e3 Ping-Bug: 15006 Reviewed-on: https://code.wireshark.org/review/28853 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-25GSM SIM: Parse 0x61 and 0x6C status wordsDarien Spencer1-1/+5
In accordance with TS 102.221 Change-Id: I749f1504693a15a13e4513948cdf2b8ec96b27d7 Reviewed-on: https://code.wireshark.org/review/28847 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-25nfapi: fix dissection of CONFIG.requestAlexis La Goutte1-1/+16
There is no Error Code field Bug: 14988 Change-Id: If6e8cf37d508c014b585bdb0cb4830ce7eb45588 Reviewed-on: https://code.wireshark.org/review/28797 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-07-25netlink: fix conflictAlexis La Goutte1-2/+2
'netlink-route.ifa_address' exists multiple times with NOT compatible types: FT_IPv4 and FT_IPv6 Change-Id: I3ba350cfc479a7733d48bc07b4102c8220126247 Reviewed-on: https://code.wireshark.org/review/28841 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-25docsis-macmgmt: fix spelling-error-in-binary found by lintianAlexis La Goutte1-2/+2
Comparision -> Comparison Change-Id: I13afe719a4efece15a27b6380f1021e5e84248c5 Reviewed-on: https://code.wireshark.org/review/28846 Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-22 17:23:10 +0000