aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2015-07-07Qt: Add initial Lua support.Gerald Combs28-57/+1255
Add a FunnelStatistics class, which is the main interface between the Qt UI and the Funnel API. Add FunnelTextDialog, which implements the text_window, ProgDlg, menu, and other routines. Add FunnelStringDialog, which implements dlg_new. We currently only support "Tools" menu items (MENU_TOOLS_UNSORTED, aka REGISTER_TOOLS_GROUP_UNSORTED). Add a disabled placeholder to the "Tools" menu in case we don't load any scripts. Use "struct progdlg" instead of needlessly casting to funnel_progress_window_t. To do: - Add support for MENU_STAT_UNSORTED, MENU_STAT_GENERIC, etc. - Make the firewall config generator a Lua script? - Add FunnelGraphDialog? It seems like it would be useful to make QCustomPlot accessible to Lua scripts. Ping-Bug: 9845 Change-Id: Iefff02e9032ed1853666f7902509ed08b431e7a7 Reviewed-on: https://code.wireshark.org/review/9523 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-07Added support for optional display of signed 16/32-bit integer Modbus ↵cbontje2-0/+34
register data Change-Id: I2a81fdf426fdc20db200596ccd2eae26936fc81a Reviewed-on: https://code.wireshark.org/review/9526 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-07Add #defines for various aggregation flags, and use them.Guy Harris1-13/+20
Fewer magic hex numbers, more readability. Change-Id: I698e0e9b28b75249c7dff5f1e1c7fbe0b4a93be2 Reviewed-on: https://code.wireshark.org/review/9543 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-07MySQL: use tvb_format_text instead of format_text/tvb_get_ptrHadriel Kaplan1-4/+4
Bug: 11344 Change-Id: Ibddbcce3e6e98bc3866cab9eb76e9762e4d19138 Reviewed-on: https://code.wireshark.org/review/9538 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2015-07-07Initialize the 11b presence flag to 0.Guy Harris4-0/+5
There were some cases where it wasn't getting initialized when we set the PHY to 11b, in addition to the one Pascal found. Change-Id: I127737cd29dc53c96342364de5cb722b135f23f3 Reviewed-on: https://code.wireshark.org/review/9540 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-07Next Windows Server version seems to be named Windows Server 2016 nowPascal Quantin1-1/+1
Change-Id: I31fb5495f5e17ccba1578a069ca33448a291923f Reviewed-on: https://code.wireshark.org/review/9539 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-07PPI: initialize optional presence flags bitmap when using 802.11BPascal Quantin1-0/+1
Bug: 11346 Change-Id: I3c80bda24af0c981c75e6d815dd2a1d328e9eb41 Reviewed-on: https://code.wireshark.org/review/9536 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-07ixveriwave: comment pcp_type variable as it is not used yetPascal Quantin1-3/+3
Change-Id: If4751f1044282579c8741b57579a5f2e8f9f393c Reviewed-on: https://code.wireshark.org/review/9535 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-07Actually, user_data *is* used there.Guy Harris1-1/+1
Change-Id: Ic22741e6551b5ec2eb76408ff8521067d9d40a88 Reviewed-on: https://code.wireshark.org/review/9534 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-07Use the NSS provided by the Ixia Veriwave hardware.Guy Harris4-12/+35
It doesn't appear to provide the FEC type, although radiotap does, so add a flag to indicate whether we have that. Change-Id: I298d79bc6b640ee2408c3d70075c32bf331a210c Reviewed-on: https://code.wireshark.org/review/9533 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-07Starting to get rid of Q_UNUSED declarations for unused function parameters.Joerg Mayer19-101/+39
The official C++ way is to leave out the variable name instead. This has the advantage to be reliable: In one case a variable declared unused was later used. Change-Id: I1c96636f7fa7a621d1594d1e9cacaec75c561faa Reviewed-on: https://code.wireshark.org/review/9532 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-07-07Revert "diameter: convert some GArrays to epan wmem_arrays"Evan Huus1-28/+23
This reverts commit 59017a22be9a5a86f5c365cc22a2f1e23205597b. As indicated by Michael on the original change, this breaks diameter rather badly for some reason I haven't been able to determine. Reverting until I can track down the root cause. Change-Id: Iedfab546a726395c546a88138cd45b6667913a11 Reviewed-on: https://code.wireshark.org/review/9531 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-07-07MySQL: dissector adds packet content to INFO column without scrubbing itHadriel Kaplan1-4/+9
Make the MYSQL protocol dissector scrub the strings from the packet content by putting it through format_text() to remove/replace CR, LF, TAB, etc. The fields affected are: query string, greeting version string, login username, and login schema. Bug: 11344 Change-Id: Ie1a593026c21720eecc77e7b3a7e63db11adf2a1 Reviewed-on: https://code.wireshark.org/review/9530 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2015-07-06Clean up a bunch of stuff.Guy Harris1-99/+157
The command byte values aren't FPGA-specific - if they were, the code wouldn't have worked. Provide #defines for the main ones and check for them, and use that to determine whether the packet is transmitted or received. Add a bunch of #defines, shuffle some defines to cluster related ones together and separate unrelated ones, get rid of duplicate #defines (where different FPGAs use the same value). Fix some typoes. Change-Id: Ic8adc589d7c36a4a91a81858de40c904743dd067 Reviewed-on: https://code.wireshark.org/review/9529 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-06Update a comment.Guy Harris1-1/+4
Change-Id: I71e66a8f6faf3b213ab6db2856a36c1d31897166 Reviewed-on: https://code.wireshark.org/review/9527 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-06GTP fixes: RAB setup and PDP context prioLuca Melette1-2/+6
Change-Id: Ie250eaf17136076dbb3e44ac15b222a8b2e367ac Reviewed-on: https://code.wireshark.org/review/9520 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-07-06[ieee80211] Fix proto_tree_add_item() reversed offset,length argsBill Meier1-1/+1
Change-Id: I2bb087138de662fd41301b93ef9804345c0875b8 Reviewed-on: https://code.wireshark.org/review/9521 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-07-06Rawshark calls init_process_policies() twiceHadriel Kaplan1-5/+0
Calling it twice won't make it work any better. Change-Id: I30fea0ba2ccf6ebfb6caf6a58333cee9b192e4cb Reviewed-on: https://code.wireshark.org/review/9513 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2015-07-06Add some comments.Guy Harris3-0/+13
OK, where's NSS for the presumably-one-and-only user hiding for 11ac? Change-Id: I53eb216c5d209dc5bb46c1d0aca7f8a200161e3e Reviewed-on: https://code.wireshark.org/review/9512 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-06Stub out the US public safety band.Guy Harris1-0/+9
OK, anybody know how to convert a frequency between 4.9 GHz and 5.0 GHz into a channel number, in a fashion that handles what's actually used in both the US and Japan? Change-Id: I95f4f9649e379b3d6651aadf8f62d8406b81b3b3 Reviewed-on: https://code.wireshark.org/review/9511 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-06Add a comment.Guy Harris1-1/+11
Why, oh why, are channel numbers used for 802.11? Change-Id: Ie26987dfeaad2ce0ead0eef72339f966aadeeecd Reviewed-on: https://code.wireshark.org/review/9510 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-06prefs: fix memory leak reading capture columnsEvan Huus1-3/+5
Change-Id: I925ec3329cc099a5f3d2ae66e43b06fc52309dc8 Reviewed-on: https://code.wireshark.org/review/9504 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-07-05Use space indentation consistently.Guy Harris1-7/+7
Change-Id: I1af52157a8c7383981c514d9dddea3b7186dbe6d Reviewed-on: https://code.wireshark.org/review/9509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-05Associate the file-mp4 dissector with the audio/mp4 MIME typeTyson Key1-0/+1
Bug:11338 Change-Id: Ied463ea5ef65bcc657e09c0d5f7983cb4dcd581a Reviewed-on: https://code.wireshark.org/review/9503 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-05rtd_table.h: fix parameter 'rtd_stat_table' not found in the function ↵Alexis La Goutte1-1/+1
declaration [-Wdocumentation] Change-Id: Ie31efc352b5f51808aa9f3d1e6b00734ccc38bfe Reviewed-on: https://code.wireshark.org/review/9507 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-05RPC: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-3/+0
Change-Id: Iea6529d8fb43d1cea723c92b3b348029c39c0c8d Reviewed-on: https://code.wireshark.org/review/9506 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-0580211 utils: free nl messages after useEvan Huus1-3/+14
Valgrind picked this up as a very large memory leak on systems with libnl, since the GUI polls this code regularly and was leaking several nl messages each time. Change-Id: Ie6b32e094d90183a16fb187adea430c4b43c208c Reviewed-on: https://code.wireshark.org/review/9502 Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-07-05Fix Windows CMake generated installer to include snmp mibsGraham Bloice1-0/+2
Wireshark.nsi requires SMI_DIR to point to the base of the SMI directory but FindSMI.cmake doesn't set it. Set it in the main CMakeLists.txt Change-Id: Id667341273d6abb0d2d64ef91cc62d1ce3f42a83 Reviewed-on: https://code.wireshark.org/review/9499 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-07-05[Automatic update for 2015-07-05]Gerald Combs14-3432/+3893
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I7c644cb36af2a5c81efc4c22f1355b1a5e599b49 Reviewed-on: https://code.wireshark.org/review/9500 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-04Mark another function as printf-like.Guy Harris1-1/+1
Change-Id: I2aa13265da1efbf7edfe693c9b434940462ca237 Reviewed-on: https://code.wireshark.org/review/9497 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-04diameter: convert some GArrays to epan wmem_arraysEvan Huus1-23/+28
Fixes ~30KB of memory leak on startup and a handful of "reachable" memory as well. Change-Id: Ia1c633b65fa282c7bbe9d3772dae58643ef15c0e Reviewed-on: https://code.wireshark.org/review/9495 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-07-04scsi-osd: initialize the entire extra_data structEvan Huus1-4/+1
Bug: 11337 Change-Id: If240b581c73e1cfb2aae1e85855170387677eb32 Reviewed-on: https://code.wireshark.org/review/9494 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-07-04Add support for dissecting Notify Responses based on the SMB2 spec. Tested withRichard Sharpe1-2/+80
a capture I have. Also add to small suggested changes. Change-Id: Iaa031f5e97e94778ea7fa00fab24b7c0dfadd4de Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-on: https://code.wireshark.org/review/9477 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-04Add "custom" dissector table tab to Internals->Dissector Tables dialogMichael Mann1-0/+26
Bug: 11334 Change-Id: I2af3e41643e4e92593ed0cfe070c4f7bcb450a06 Reviewed-on: https://code.wireshark.org/review/9493 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2015-07-04Add missing C++ headerMichal Labedzki1-0/+1
This fixes: ui/qt/wireshark_application.cpp:588:5: error: 'sort' is not a member of 'std' std::sort(sgi_list.begin(), sgi_list.end(), qActionLessThan); Change-Id: I70058f0fcbabb0279bed5c62d09d55d88bda0fd4 Reviewed-on: https://code.wireshark.org/review/9492 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-07-04store tcp/udp port names in epan scopeEvan Huus3-3/+3
This causes them to be freed on shutdown, cleaning up ~800KB of "reachable" memory according to valgrind. The fact that we even need to construct these as value_strings is questionable IMHO, but that's a problem for a later date. Switch epan_scope to the BLOCK allocator now that we're using it for so much more, this gives a small but measurable increase in startup time. Change-Id: I187460b769e28da3c6629abac1d9196727ae7dde Reviewed-on: https://code.wireshark.org/review/9483 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-07-04Lua: split init/cleanup routinesHadriel Kaplan1-1/+18
The epan init routines have been split up into init vs. cleanup, where the init routines are only invoked when a file is opened, and the cleanup ones are invoked multiple times, such as on a re-scan of packets. Since the Lua API's Proto.init() callback is supposed to be invoked at both init and cleanup times, the wslua code now invokes it in both of epan's init and cleanup routines. Change-Id: I51a4d8bc02630a4d2db5408c37f7eb8f6e0ce88c Reviewed-on: https://code.wireshark.org/review/9491 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Hadriel Kaplan <hadrielk@yahoo.com>
2015-07-04Do error checking on simple_error_message_box() calls and fix errors.Guy Harris2-3/+3
It's a printf-like routine, so give it the right declaration. Fix errors that this finds. Change-Id: I7e8c100ff9e16ba89743ce744cbf548aae705b77 Reviewed-on: https://code.wireshark.org/review/9487 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-04Squelch a compiler warning.Guy Harris1-3/+3
Some systems still offer the old V7 index()/rindex() routines, in addition to the standard strchr()/strrchr() routines, so don't use "index" as a variable. (Maybe the folks at Center 127 were thinking of the PL/I index() function, but that's more like strstr(), so it wasn't a good choice of name.) Change-Id: I6193a93684c0684c83357def3d76e0dbd808e29b Reviewed-on: https://code.wireshark.org/review/9485 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-04ansi_map: fix float literals missing f suffixEvan Huus2-4/+4
Should fix OSX buildbots Change-Id: I466d4cdc0c4b52a15cadb9b5d429561ca68cc913 Reviewed-on: https://code.wireshark.org/review/9484 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-07-04asn1: split off cleanup routinesPeter Wu34-251/+307
General approach: 1. Split allocation (e.g. g_hash_table_new) from deallocation (g_hash_table_destroy) into functions named "init" and "cleanup". 2. Remove guards that test whether the hash tables are set as init is always called before cleanup. 3. Remove setting hash tables to NULL after destruction. 4. Copy register_init_routine function call and change init to cleanup. 5. Add cleanup function that calls reassembly_table_destroy if there is a reassembly_table_init function. Some templates were modified as follows: - snmp: split renew into init+cleanup, but keep renew for the uat_new callback. - ldap,ros: Rename init to cleanup as there was no initialization. - camel: remove init function from header, make it static. Remove debug print. - tcap: remove unused ssn_range assignment. Files in epan/ were regenerated using cmake && make asn1 Change-Id: Idac16ebf0ec304e0c8becaab5d32904e56eb69b9 Reviewed-on: https://code.wireshark.org/review/9136 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03plugins: add cleanup routinesPeter Wu6-26/+40
Destroy the reassembly tables on exit, fix memleak in profinet dissector. Change-Id: Id34dbfde42fe715513997452f87cd4fdc328e294 Reviewed-on: https://code.wireshark.org/review/9229 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03ssl,dtls: split init/cleanup routinesPeter Wu4-32/+47
Minor functional change: instead of an empty hash table, now the ssl_session_hash and ssl_crandom_hash structures point will be set to NULL when files are closed. API change: drop the ssl_keylog_file parameter from ssl_common_init, add a new ssl_common_cleanup parameter instead. Change-Id: I65efe71f8347fe9685359f8ed70cfb9673712421 Reviewed-on: https://code.wireshark.org/review/9226 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Split more init routines into init/cleanup functionsPeter Wu13-176/+152
This patch is partially automatically generated, but are modified manually. In particular, assignments and function calls have been audited. Some debugging comments and ifdef'd prints have been removed. The lookup tables of the dcm and sip dissectors are now cleared. It is only called on reopening files anyway. The isakmp dissector is modified to use g_hash_table_new_full for destruction of its keys and values. Fix a memleak in ipsec dissector when libgcrypt is not enabled. Generated using https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=3c6128ee266024d164650955f93c7740484abd68 (with AUDIT = True). Change-Id: I3fd910bdee663842ac0196334fe0189b67e251b0 Reviewed-on: https://code.wireshark.org/review/9225 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Split init of misc dissectors into init/cleanup functionsPeter Wu11-82/+60
Convert remaining dissectors to use cleanup routines when possible. (Single-)linked lists require NULL, so do reset their pointers to NULL. Generated with https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=69af86e6c2cf965ba3d7f9636b647b195f0b7d57 (with AUDIT = ALWAYS_EMIT_CLEANUP_CODE = True) Remaining dissectors which did not need further changes: epan/dissectors/packet-aeron.c epan/dissectors/packet-bootp.c epan/dissectors/packet-brdwlk.c epan/dissectors/packet-drda.c epan/dissectors/packet-etch.c epan/dissectors/packet-fix.c epan/dissectors/packet-fw1.c epan/dissectors/packet-lbm.c epan/dissectors/packet-ldss.c epan/dissectors/packet-simulcrypt.c epan/dissectors/packet-spdy.c epan/dissectors/packet-starteam.c epan/dissectors/packet-udp.c Change-Id: Idcacfea6a5de38d40e67db4cdcd0452ad9f9a6a9 Reviewed-on: https://code.wireshark.org/review/9228 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Split four more init routines into init/cleanupPeter Wu4-103/+45
Three of them are trivial movements, the smb-sidsnooping is an odd one. Ronnie Sahlberg disabled the sid_name_snooping feature on 9 July 2007. There is a preference to override it though... For now add a TODO marker and ensure that the hash tables are always initialized. Change-Id: I61f5e215c9fa72a6785fb48eaa2d50c1975d7483 Reviewed-on: https://code.wireshark.org/review/9227 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Split init routine into init/cleanup for more dissectorsPeter Wu3-76/+44
This patch converts some dissectors using g_hash_table_foreach_remove. - 9p: drop no-op free func. - nfs: use g_hash_table_new_full such that a destructor function can be used. Drop NULL check since g_free can handle these just fine. - nlm: use g_hash_table_new_full such that a destructor function can be used. Simplify "matched" destruction by replacing the wrapper by a direct g_free call. Change-Id: I455e7f0ad4e47e70dae05af7233fdcdebf583f9f Reviewed-on: https://code.wireshark.org/review/9224 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Call reassembly_table_destroy and move g_hash_table_destroyPeter Wu36-199/+257
This patch moves g_hash_table_destroy calls from the init routine to the cleanup routine. Besides that, the conditional check for the hash table has been removed, assuming that init is always paired with a cleanup call. If reassembly_table_init is found, a reassembly_table_destroy call is prepended to the cleanup function as well. Comments have been removed from the init function as well as these did not seem to have additional value ("destroy hash table" is clear from the context). The changes were automatically generated using https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=4d11f07180d9c115eb14bd860e9a47d82d3d1dcd Manually edited files (for assignment auditing): dvbci, ositp, sccp, tcp. Other files that needed special attention due to the use of register_postseq_cleanup_routine: - ipx: keep call, do not add another cleanup routine. - ncp: remove empty mncp_postseq_cleanup. mncp_hash_lookup is used even if a frame is visited before (see dissect_ncp_common), hence the hash table cannot be destroyed here. Do it in cleanup instead. - ndps: add cleanup routine to kill reassembly table, but do not destroy the hash table as it is already done in ndps_postseq_cleanup. Change-Id: I95a72b3df2978b2c13fefff6bd6821442193d0ed Reviewed-on: https://code.wireshark.org/review/9223 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Call reassembly_table_destroy for some dissectorsPeter Wu49-8/+329
This patch adds reassembly_table_destroy calls as cleanup function for dissectors which have a simple init routine that just calls reassembly_table_init (comments are ignored). The changes were automatically generated using https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=4cc0aec05dc67a51926a045e1955b7a956757b5e (with the if and assignment parsers disabled). The only difference from the autogenerated output is that the XXX comments from the init routines in smb-pipe and tds dissectors are kept. Change-Id: I64aedf7189877247282b30b0e0f83757be6199e7 Reviewed-on: https://code.wireshark.org/review/9222 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03rpc: use direct hashing rather than malloced intsEvan Huus2-23/+19
Equivalent but saves some allocations and is slightly simpler. Change-Id: Id0fde980e11256018641d8fb39330c07f33ee3f5 Reviewed-on: https://code.wireshark.org/review/9474 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-25 23:04:07 +0000