aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-07-18Mark the file as having unsaved data if you change address resolution.Guy Harris5-14/+47
That information can, and will, get saved in some file formats, so mark the file as changed so it can and will get saved by "Save". XXX - we need to treat it as a type of data that can be discarded when saving in some file formats, just like comments. Bug: 12629 Change-Id: I1fd69b95f4f7345c339961b4c53c28b98b364e4e Reviewed-on: https://code.wireshark.org/review/16538 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-18block->options is never null; don't check for it.Guy Harris1-2/+1
A wtap_block_t always has an array of options, even if it's empty. Fixes CID 1364135. Change-Id: Ib1ba791ddcac078ec34def321d63d140c5576037 Reviewed-on: https://code.wireshark.org/review/16535 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-18Remove wtap_block_num_options_of_type().Guy Harris1-36/+0
It's not used; currently, everything that accesses instances of a multiple-instance-allowed option do so in a loop that iterates over option instances by fetching values of the Nth option until the attempt to fetch the option fails, making only one pass over the options. Change-Id: Ife9583a5d246027dbfc133ab58027ef6641d65ef Reviewed-on: https://code.wireshark.org/review/16534 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-18IPv6: Export ipv6_pinfo interface for sub-dissectorsJoão Valverde2-36/+38
Change-Id: If39838f6952356aa3417ea9241d974f4c64f9898 Reviewed-on: https://code.wireshark.org/review/16530 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-18IPv6: Remove unknown extension header dissectionJoão Valverde1-64/+1
It's not being used and makes some things more difficult so kill it. It's not possible in general to distinguish an unknown extension header from an unknown IP protocol and the concept is fuzzy anyway (for example ESP is officially an extension header but meh) so don't bother trying for now. Change-Id: I3bdfcc2b76b47e8c1588e91838225b14808e43a7 Reviewed-on: https://code.wireshark.org/review/16529 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-18ouch: fix indent (use 4spaces)Alexis La Goutte1-5/+5
Change-Id: Ifdfaa87cc1818768ca939ff93015fbb8d77cddc5 Reviewed-on: https://code.wireshark.org/review/16533 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-18SHIM6: fix no previous prototype for ↵Alexis La Goutte1-0/+3
'proto_register_shim6/proto_reg_handoff_shim6' [-Wmissing-prototypes] Change-Id: I148ecae8d2e9926fcfebab75b3b2f0a769813ef5 Reviewed-on: https://code.wireshark.org/review/16532 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-18[GTPv2] Extend MM Context dissection.AndersBroman1-9/+101
Change-Id: I24e9f8307ea199d5da0713f26aa075466c59bb1f Reviewed-on: https://code.wireshark.org/review/16528 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-18IPv6: Set (jumbo) length by inspecting hop-by-hop header, if existingJoão Valverde1-39/+56
Change-Id: I84bade7526ef3f094875eaf207b2650d734ed10f Reviewed-on: https://code.wireshark.org/review/16523 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-18IPv6: Dissect as much as possible in case of errorsJoão Valverde2-157/+129
Don't require 40 bytes upfront, do it by field. Miscellaneous cleanups. Change-Id: Ib40b43eb3cf9aa52aa490cdabc6de26b0e977483 Reviewed-on: https://code.wireshark.org/review/16522 Reviewed-by: João Valverde <j@v6e.pt>
2016-07-18[Diameter] Update with new AVPsAndersBroman1-0/+65
Change-Id: I6dfa43320ae3e02afb2b795dd352d492c75a0e60 Reviewed-on: https://code.wireshark.org/review/16526 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-18Add support for the U-bit in I-FORWARD-TSN chunks.Michael Tuexen1-15/+34
This adds support for the upcoming Internet Draft draft-ietf-tsvwg-sctp-ndata-07. Change-Id: Icb7c464504c41a743aa9c61d449f54bf400c1cd3 Reviewed-on: https://code.wireshark.org/review/16525 Petri-Dish: Michael Tüxen <tuexen@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2016-07-18Use follow_record_t in SSL follow stream.Jeff Morriss4-149/+16
... rather than a structure (SslDecryptedRecord) which looks (mostly) like a follow_record_t. (The biggest different is the former carries its data in a StringInfo while the latter uses a GByteArray.) With this change following SSL no longer needs its own special code. This also fixes a crash after saving a followed SSL stream (in the Qt UI). Bug: 12616 Change-Id: Ibdb2b85f8a6a30712743a5da420be1e6b78f5b92 Reviewed-on: https://code.wireshark.org/review/16516 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-07-18packet-smb2: add dissectors forHiroshi Ioka1-3/+104
FSCTL_GET_REPARSE_POINT/FSCTL_SET_REPARSE_POINT Change-Id: I3b6230aea2a0027d7b85d35d3aea6385cace569b Reviewed-on: https://code.wireshark.org/review/16511 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-18Rename iph->ip_p to iph->ip_nxtJoão Valverde7-14/+14
struct ws_ip is IP version agnostic. "ip_p" is too terse and less appropriate. Change-Id: I06b8740ab420e20781bf7b9efcf5dce19ad22ab2 Reviewed-on: https://code.wireshark.org/review/16519 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-18IPv6: Remove union from struct ip6_hdrJoão Valverde3-60/+59
The field macros are a particularly obnoxious form of namespace pollution. Change-Id: I9010a767625fd1c4b4a48c9d75481c577915fce6 Reviewed-on: https://code.wireshark.org/review/16520 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-17L2TP: Add dissectors for Ericsson specific L2TP AVPsHarald Welte1-0/+300
Ericsson's L2TP implementation uses some vendor-specific AVPs. Let's add some decoder/dissector support for these. Change-Id: I65d5527087a9c0f4e18ba17c9e7c63793ef6e995 Reviewed-on: https://code.wireshark.org/review/16507 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-17[Automatic update for 2016-07-17]Gerald Combs13-506/+865
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I0ca539cf81e1708a6ea8eafbdf91488086e9ee2d Reviewed-on: https://code.wireshark.org/review/16513 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-07-17Add osx/macos build for Travis CIAlexis La Goutte1-4/+20
Change-Id: Id6beedfbe909ac3639790cbb7471bd968bed5b82 Reviewed-on: https://code.wireshark.org/review/16496 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-17Fix printf style parameters complaints from VS Code AnalysisMichael Mann7-15/+16
Change-Id: I5669e2442582f899643fae4a9f86ab6d505dde07 Reviewed-on: https://code.wireshark.org/review/16505 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-17ciscodump.c - Address VS Code Analysis warnings.Michael Mann1-3/+12
1. Check sscanf return value 2. Take large "packet" byte array off of stack and onto heap. Change-Id: I8ade76359f1b0739ec31d7f3b688d212f21357ba Reviewed-on: https://code.wireshark.org/review/16498 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-17Update to support OUCH-4.2 as of 2016/02/29 releaseDavid Arnold1-54/+314
Bug: 12615 Change-Id: I7122ded30083dd85e7785a842c6dd62b459d9676 Reviewed-on: https://code.wireshark.org/review/16465 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-17Fix sscanf VS Code Analysis warnings.Michael Mann5-88/+95
Some needed to check return value, others were converted to use strtoul. Change-Id: I55aae216f95362b67e006f6e682abbd5ae2c8dcc Reviewed-on: https://code.wireshark.org/review/16502 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-16ISIS (LSP): Fix Malformed packetAlexis La Goutte1-6/+24
Coming from fetch too longer bytes... Rework the display for add some missing field (SubTLV indicator, prefix len) and for prefix IPv4 use the same code like BGP Issue reported by Garri Djavadyan Bug:12617 Change-Id: Ib40f1badf8e03fadacfbb0aff1ebd3eab8ca342b Reviewed-on: https://code.wireshark.org/review/16436 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-16androiddump.c - Address VS Code Analysis warnings.Michael Mann1-3/+3
1. Take large "packet" byte arrays off of stack and onto heap. 2. Cast away an shift operation that should have been identified as safe anyway. Change-Id: I159c4a7452744763f667336cf4824d5ac3472343 Reviewed-on: https://code.wireshark.org/review/16500 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-16Have extcap executables mirror the GTK's WinMain signature.Michael Mann4-8/+24
This is for appeasing VS Code Analysis. Change-Id: Ib7b3d8a3025dd764da283335051d0f77b45f6dee Reviewed-on: https://code.wireshark.org/review/16499 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-16wmem_map.c: Address some VS Code Analysis warnings.Michael Mann1-3/+4
size_t can vary on size, so you can't always mix it with guint. Change-Id: I7e2ea3a990dd4df99422f6113aa3ae53dbf2bc4f Reviewed-on: https://code.wireshark.org/review/16501 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-16IPv6: Improve offset handling for options sub-dissectorsJoão Valverde1-90/+134
We pass the Option Data offset to sub-dissectors. Change-Id: I4a20514f3f1c31179f93c86e251ba67d671844b3 Reviewed-on: https://code.wireshark.org/review/16484 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-16Use debian tools script for travisAlexis La Goutte1-3/+4
Change-Id: I0e3390048fe2723579cc108f5adf582f570a41e5 Reviewed-on: https://code.wireshark.org/review/16494 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-07-16Use timers instead of packet counts to update our UI.Gerald Combs3-136/+111
In file.c, update our UI based on the time elapsed since we last finished updating the UI instead of on the number of packets we've processed. Remove the timer code from progress_frame.cpp since it's now redundant. This makes the UI more responsive here for captures with large numbers of packets and it should mean that packets_bar_update spends less time repainting, at least on Windows. Change-Id: I9edfa944c44192350bef75b8c0c3ad63bae9c131 Reviewed-on: https://code.wireshark.org/review/16476 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-16Allocate data sources using wmem.Gerald Combs1-14/+2
Use wmem_strdup + the pinfo pool instead of g_strdup. Change-Id: I11fbb5ce31b7139421c558ee65ca43c8d8e85900 Reviewed-on: https://code.wireshark.org/review/16445 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-16always update the status bar at the end of a captureMartin Kaiser1-3/+5
We used to update the status bar when we get a stopCapture signal. This does not work for extcap interfaces like randpktdump which creates 1000 packets and then exits. The status bar message "Live capture in progress" is not deleted. For randpktdump, the only reliable indication to detect the end of the "capture" is when the pipe to dumpcap is destroyed. Update the status bar at this time. Change-Id: I59768e7f518625283b2c27c34c428bb115e27a61 Reviewed-on: https://code.wireshark.org/review/16479 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-16Another attempt to squash warnings from printf use in reassemble_test.cMichael Mann1-1/+1
Change-Id: Ieae9466c6785cf931fc96f8e216c0c1383a5b6a2 Reviewed-on: https://code.wireshark.org/review/16489 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-16Comment cleanups.Guy Harris1-9/+9
Change-Id: I995ba14cbd9bbe2c01b0770c16095084895498db Reviewed-on: https://code.wireshark.org/review/16486 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-16Add APIs to remove option instances from blocks.Guy Harris2-16/+128
That will allow deletion of comments, stripping of options when sanitizing captures, etc.. Change-Id: I9667ba2ccf4e548ff3b7d500796b260a437bcea0 Reviewed-on: https://code.wireshark.org/review/16485 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-15IPv6: Minor loop cleanupJoão Valverde1-3/+5
Change-Id: I73e11c353695a565d9c4222f2a3646d0530c3c40 Reviewed-on: https://code.wireshark.org/review/16482 Reviewed-by: João Valverde <j@v6e.pt>
2016-07-15IPv6: Register fragment header dissector handleJoão Valverde1-68/+76
Change-Id: Ie49c8cdc010630c8963a730562aaf33f61236058 Reviewed-on: https://code.wireshark.org/review/16443 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-15Use spaces rather than tabs for indentation.Guy Harris1-2/+2
Change-Id: I6028253f7c8c30804eaa4b23d2b09827aacb3c9d Reviewed-on: https://code.wireshark.org/review/16481 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-15Update comments, give option numbers in decimal.Guy Harris1-27/+27
The pcapng spec gives option numbers in decimal, not hex. Get rid of the "XXX if not available" comments - if an option isn't present in a block, it's not present, and doesn't have *any* value. Change-Id: I1bf0c9a5aaad7dfadf9248e22b67e172625bdd0d Reviewed-on: https://code.wireshark.org/review/16480 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-15Qt: Reserve packet list model vectors.Gerald Combs1-7/+15
Preallocate and hold onto the data in the various packet list model vectors. I'm not sure how much this will affect performance, but the documentation suggests that it's the right thing to do in our case. Change-Id: If2d5ad142bf2d61e0bc2302990bd288274447df5 Reviewed-on: https://code.wireshark.org/review/16475 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-07-15Squelch a compiler warning.Guy Harris1-1/+1
Explicitly cst the results of g_memdup(). Change-Id: I20fd1f355e68735d7cc9bbeb41717a1c2a74de37 Reviewed-on: https://code.wireshark.org/review/16477 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-15IPv6: Fix commentJoão Valverde1-1/+1
Change-Id: Ib5c44f806e5844e1eb1579ade4b92d2b719564c1 Reviewed-on: https://code.wireshark.org/review/16474 Reviewed-by: João Valverde <j@v6e.pt>
2016-07-15IPv6: Register extension headers ett/ei arraysJoão Valverde1-63/+102
Change-Id: I1208638580efe06a94a055613a0de3ecf2acdb26 Reviewed-on: https://code.wireshark.org/review/16442 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-15Move Shim6 dissector to packet-shim6.cJoão Valverde5-876/+952
Change-Id: Ia0bfbf48e8a4eb23d62c8c5cdccad350caedef9e Reviewed-on: https://code.wireshark.org/review/16425 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-15wtap_opttypes.c: Fix build error.Michael Mann1-1/+1
Change-Id: I3ee146d441e4d59701c72ed85dcb4efe97766df8 Reviewed-on: https://code.wireshark.org/review/16473 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-15reassemble_test.c: Fix checking macros with correct printf style arguments.Michael Mann1-172/+178
Complaints of VS Code Analysis Change-Id: Ib5a4649b78ae4c9109249e915c04481ae7fa5524 Reviewed-on: https://code.wireshark.org/review/16472 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-15IPv6: Check pinfo->layers for hop-by-hop exthdr orderJoão Valverde1-16/+17
Change-Id: I0467417c4d9a62013d8fe5cbcc03c09147f92cf1 Reviewed-on: https://code.wireshark.org/review/16435 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-15Bluetooth: GATT: Add services error codesMichal Labedzki1-15/+329
GATT Service may define own error code. Add them. Change-Id: I9e5c0d38b2dd01c16cfd47578f151cefdc9393fe Reviewed-on: https://code.wireshark.org/review/16467 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-15Bluetooth: RFCOMM: Fix CID 1364086Michal Labedzki1-3/+4
Fix null pointer dereferences. Change-Id: Id095fd0d7c9d70f79fd7367ef5c226f271a24cbe Reviewed-on: https://code.wireshark.org/review/16466 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-15IPv6: Remove null check (CID 1364087)João Valverde1-1/+1
Change-Id: Ia35a78ccaa4f61fbbbfff304f12d813fdbdd009d Reviewed-on: https://code.wireshark.org/review/16452 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-26 01:09:33 +0000