aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-08-27DCERPC: update mdssvc DCERPC dissector from upstream SambaRalph Boehme2-99/+278
Change-Id: I13871e093b294a1865be6c47cb86275165002855 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-on: https://code.wireshark.org/review/34365 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26Qt: Create Apply/Prepare in PacketlistRoland Knall2-20/+32
Create the menu for apply/prepare inside Packetlist. At the same time disabled the "..." methods if no filter has been set yet Move the action list to FilterAction as well Change-Id: Ia18a4021cc95562702ff516a24fb029063096f94 Reviewed-on: https://code.wireshark.org/review/34377 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Add Apply/Prepare to Packet DialogRoland Knall1-1/+20
Add the possibility to apply/prepare a field entry to the packet dialog. This works also if the corresponding source file had already been closed. Bug: 3537 Change-Id: I448ad6d5cb37f2cbb2c2f649512b1f3e5acde2de Reviewed-on: https://code.wireshark.org/review/34372 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Remove unnecessary code for context menusRoland Knall5-68/+59
This code is no longer required, as context menus should be bound to local events. As for "Reloading LUA plugins" - the keyboard shortcut would be able to trigger while the menu is open, except Qt explicitely prevents that Change-Id: Id18a3a17d62bae1ff547a6ef96772e12a2535219 Reviewed-on: https://code.wireshark.org/review/34371 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26Qt: Make Apply/Prepare filter independentRoland Knall5-22/+84
The context menu should only use information readily available at the point of creation. Copying actions from the mainwindow introduces a bunch of synchronization and consistency issues. This is a first step to move away from a centralized approach of managing actions, towards a distributed approach. As a side effect, this also solves the old issue of having the apply items greyed out in context menu Bug: 16001 Bug: 15323 Change-Id: I10c6df11cbab0a89386f5bf1d27759103df2a012 Reviewed-on: https://code.wireshark.org/review/34370 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26coap: Distinguish observe option for request and responseStig Bjørlykke3-11/+24
The observe option has different values for request and response. For request it identifies register or deregister, and for response it is a sequence number for reordering detection. RFC 7641 chapter 2. Change-Id: I09515864997a32f7259e344532ea770b74030b04 Reviewed-on: https://code.wireshark.org/review/34368 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26coap: Improve request/response trackingStig Bjørlykke2-23/+50
Use both Token and Message ID in request/response tracking and retransmission detection. The token is the same when using observables but the message id is increasing. Change-Id: I545416ce139328e6a8eb67258d7b51bddb6b278e Reviewed-on: https://code.wireshark.org/review/34367 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26Qt: Fix memory leak in ProfileModel constructorTomasz Moń1-0/+1
Change-Id: I4a0ccaebe7ab821a22b86ce1155328fd714caf50 Reviewed-on: https://code.wireshark.org/review/34376 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-26Qt: Fix copy from default profileRoland Knall1-1/+1
The default profile was available to be selected, even if it was the active profile. Bug: 16021 Change-Id: If08a563f243f18f32e17cb2169180ec0b1274a9a Reviewed-on: https://code.wireshark.org/review/34366 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-26SCTP: Use proto_tree_add_bitmask_list() for data chunk flags.Anders Broman1-11/+18
Change-Id: I9da080982d5ca85cbd3747008cd1f2b3670b6baa Reviewed-on: https://code.wireshark.org/review/34369 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26Qt (zip_helper): Fix Dead StoreAlexis La Goutte1-1/+2
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ib16fc6c0783adda8485056d5e20973cf078e7d7e Reviewed-on: https://code.wireshark.org/review/34321 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-26log3gpp: fix no previous prototype for functionAlexis La Goutte1-0/+6
log3gpp.c:459:10: warning: no previous prototype for function 'log3gpp_dump[|open|finish]' [-Wmissing-prototypes] Change-Id: I1d896f90d91dc04b68b12f48ae06526556a428d4 Reviewed-on: https://code.wireshark.org/review/33963 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26ISAKMP: Correct typos in new GDOI fieldsMichael Mann1-3/+3
Change-Id: I29872cb116dfc66c93d59b51a44161e627d3cfec Reviewed-on: https://code.wireshark.org/review/34363 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26ISAKMP: added support for GDOIGandharav Katyal1-64/+262
Bug: 15693 Change-Id: I790da95c1fa64596bd5131b491237fa084c0be49 Reviewed-on: https://code.wireshark.org/review/33382 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26Qt: Move CopyFrom from menu to buttonRoland Knall13-97/+126
Move the CopyFromProfile implementation from a menu to a button to ease integration in existing code Change-Id: I4fb4e952e89665eda99d162e891ac6d3516a6f02 Reviewed-on: https://code.wireshark.org/review/34266 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26NFS: Fix hash table key memory corruptionTomasz Moń1-1/+1
When the same (as determined by key_equal_func) key gets added to the GHashTable, old value gets freed and replaced with the new one. This is fine for hash tables where the key validity is not tightly coupled to the actual data. In the nfs_name_snoop_matched hash table the key becomes invalid once the value gets destroyed (because it shares the data pointed to by fh, which gets freed once the value is destroyed). A problematic capture includes packets such that the matching fh gets added twice to the nfs_name_snoop_matched hash table. Prior to this change the hash table would end up in a state where the new value is associated with the old key (which contains pointer to already freed memory). According to the nfs_name_snoop_matched_equal(), the old key was equal to the key intended for new value *at the time* of insertion. This change fixes the bug by using g_hash_table_replace() which does update the key in case it already exists in the GHashTable. Bug: 16017 Bug: 16019 Change-Id: Ib3943f1e27e82c05d9abaa1e436554b37a98488e Reviewed-on: https://code.wireshark.org/review/34360 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-26SIP: Ensure session-id is not emptyMichael Mann1-6/+14
Add expert info if session-id is empty. Bug: 15951 Change-Id: I48ffe4ca26fd94f522ad1a668c99ed8f1f5e2c01 Reviewed-on: https://code.wireshark.org/review/34356 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-25show interface name in frame line caption if setMartin Fesser1-1/+8
Change-Id: Ib6cb86bc20dae9f88fdeb469983c2380bcc9216d Reviewed-on: https://code.wireshark.org/review/34335 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-25usb-audio: fix conflictAlexis La Goutte1-3/+3
'usbaudio.as_if_gen.bmFormats.rsv' exists multiple times with NOT compatible types: FT_UINT32 and FT_BOOLEAN Change-Id: I908b815bfa0f96f2ec421367995d971040f423a1 Reviewed-on: https://code.wireshark.org/review/34283 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-25tshark: Complement manual page synopsisJaap Keuter1-1/+2
Add '-J' option to synopsis and reshuffle '-j' to correct place. Change-Id: I351b3ce464fca3b52a75614e1e8f8c91f9a30df2 Reviewed-on: https://code.wireshark.org/review/34352 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-25[Automatic update for 2019-08-25]Gerald Combs14-367/+402
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4ed4ada929881a78beefc34012a9898caa92d649 Reviewed-on: https://code.wireshark.org/review/34353 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-24tshark: Warn on overwriting protocol filterMoshe Kaplan1-0/+6
Change-Id: I41a56cf384cda91fa6ed217f7c292f325ec8c07f Reviewed-on: https://code.wireshark.org/review/34345 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-24ELF: do not create lots of tree items for Entry Size 1Peter Wu1-2/+4
Change-Id: Ief8db4a833099c53adb1695129d435c3b89c2680 Reviewed-on: https://code.wireshark.org/review/34347 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-24Modbus: Unit and Transaction Id for request/response identificationThomas Wiens4-28/+65
Use Unit and Transaction Identifier to identify the correct request to a response. The Transaction Identifier is only available in Modbus TCP. Bug: 15698 Change-Id: Ic3a279ce200bee9e9274aaec66bd9dc2f1c096b9 Reviewed-on: https://code.wireshark.org/review/34274 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-24mpeg(dsmcc): Fixed range valuesAnthony Crawford1-2/+2
Fixed range values in message_discriminator_vals and rsrc_attribute_vals. Bug: 16015 Change-Id: Ib04b0be32fb8d58138913e643a38b95e64cdad7f Reviewed-on: https://code.wireshark.org/review/34344 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-24ELF: update e_machine table, update linksPeter Wu1-7/+33
Use HTTPS for links when possible and update the e_machine entries by post-processing a copy from the table on the website: awk -F $'\t' '$1 ~ /^EM/ && $3 ~ /./ {printf " { %3d, \"%s\" },\n", $2, $3}' Manually added the reserved entries for 182 and 184. Additionally added Linux kernel BPF (247) and C-SKY (252). Change-Id: I28ad07377a20499014437919da8e6871db2b8e59 Ping-Bug: 16016 Reviewed-on: https://code.wireshark.org/review/34346 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-23WSUG: Clean up some menu item descriptions.Gerald Combs1-19/+71
Summarize and clean up some of the menu item text. Start sentences on a new line as recommended at https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line, although we wrap long lines. Change-Id: I778f278d8503153ec649c3f0a4b2ccb24512e701 Reviewed-on: https://code.wireshark.org/review/34341 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-08-23BLIP: Fix issues with message decompressionJim Borden1-42/+67
Due to the way the BLIP compresses its messages, it quickly falls apart when the messages are not examined exactly in order (as is the case when selecting random frames inside of a capture). The only solution I can see is to only decompress once and store the result somewhere that is persistent at the file level. Change-Id: I38c781222c8efbbcded2446ae02fa7cb57c71509 Reviewed-on: https://code.wireshark.org/review/33827 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-23Pegasus LSC: Added Status CodesAnthony Crawford1-0/+3
Comcast NGOD C1 LSC specification 'Comcast-SP-NGOD-SRM-S1C1_DSMCC-I03-100731', Page 25, Table 11, extends the list of status codes to include 0x01, 0x04, and 0x05. Change-Id: Ib208d1b409af62aa25cb5d7d6fee47ffc10dc880 Reviewed-on: https://code.wireshark.org/review/34342 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-23mpeg(dsmcc): Fix Dead StoreAlexis La Goutte1-2/+2
Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Iea244eac276f6e37590b04cfbb53c3d7c802c7ae Reviewed-on: https://code.wireshark.org/review/34320 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anthony Crawford <anthony.r.crawford@charter.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-08-22WSUG: Update Control Protocol dissection chapterJaap Keuter6-55/+25
With the design changes made in the Qt interface with respect to the Deocode as dialogs the Users Guide content is confusing. Update the graphics and text to accurately describe the current design. Update references in other parts of the document too. Change-Id: Iad6af555d2da3430230c7f176bf2ec1e808cc134 Reviewed-on: https://code.wireshark.org/review/34337 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-22Updated EVS packet description for Compact format with bitrate.Morten Tryfoss1-9/+9
Description for packet with length 480 was incorrent (EVS Primary 24.0 instead of AMR-WB IO 23.85) Change-Id: I1625635468ce06a0057beb32d9558cbb71d6583f Reviewed-on: https://code.wireshark.org/review/34338 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-22packet-ieee1722: Added TSCF and NTSCF control frames supportDmitry Linikov2-2/+1250
Only CAN, CAN_BRIEF and LIN messages supported. Change-Id: Id79574bcdab9f1ec66390357dd5860c73f194ccc Reviewed-on: https://code.wireshark.org/review/31765 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-21GSM A DTAP: Try to ensure that global variable sccp_assoc is cleared.Anders Broman2-1/+3
Change-Id: I970e9314724c55c19d0b98578e54a5d1b598e307 Reviewed-on: https://code.wireshark.org/review/34336 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20RTCP: fix reference time typeAlexis La Goutte1-2/+2
from draft-holmer-rmcat-transport-wide-cc-extensions-01 reference time field is a Signed Integer Bug: 16007 Change-Id: I5686e43f2817b626ef45b07dd9fcec0c9bcc1cfb Reviewed-on: https://code.wireshark.org/review/34330 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Qt: Allow deletion of personal system-profileRoland Knall1-1/+1
If a profile is being deleted, but a system profile with the same name exists, the dialog cannot be closed Change-Id: I2fbaa999617203816e21a8e4486abaf368b69919 Reviewed-on: https://code.wireshark.org/review/34331 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-20Kafka: include zstd compression in Kafka message batchesPiotr Smolinski16-6/+190
Change-Id: I1d06486ccf7b174ee9aa621fa3d8acb8b3673777 Reviewed-on: https://code.wireshark.org/review/34222 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20SCTP: Make association amalysis a prference defaulting to FALSE.Anders Broman1-32/+43
Association analysis causes long loops if there is a lot off associations or IMIT ABORTS. On a 679K packets trace loading with amalysis takes 3.31.660 without 0.3.275. The culprit is the for loop in find_assoc_index(). Change-Id: I07ae0e826c08aded3eb0e7dc3474dcf5cdd556f9 Reviewed-on: https://code.wireshark.org/review/34333 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: fix the name shadowingPiotr Smolinski1-4/+8
Post-merge fix. Change-Id: I712d275f90c5a1e425865654143ead7c3a04998b Reviewed-on: https://code.wireshark.org/review/34332 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Qt: Fix null pointer dereferenceRoland Knall1-45/+17
Rework existing code to avoid unsafe localtime Change-Id: I266ae7e006c6aeed42af39fea07c888874d0f588 Reviewed-on: https://code.wireshark.org/review/34329 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-20Kafka: add support for Kafka 2.3+ dissectionPiotr Smolinski1-516/+5318
Existing Apache Kafka support in Wireshark ends at version 0.10. The version 0.11 (June 2017) brought significant changes to the message format. This change makes the Wireshark Kafka dissector obsolete. The recently released Kafka 2.3 has a lot of additions to the wire protocol, which should be also addressed. Major changes: * Applied Kafka protocol changes since 0.10 * Zstd-packed message decompression (since Kafka 2.1) * Added support for Kafka over TLS decryption Bug: 15988 Change-Id: I2bba2cfefa884638b6d4d6f32ce7d016cbba0e28 Reviewed-on: https://code.wireshark.org/review/34224 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20ZigBee OTA: Fix GetProfileResponse end time decodingMartin Boye Petersen1-1/+5
Added missing time offset to GetProfileResponse end time. Change-Id: I47f31cea709ccc600c9ea182c4bf6cf96410ff78 Reviewed-on: https://code.wireshark.org/review/34322 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Boost the maximum packet size for LINKTYPE_USBPCAP in pcap/pcapng.Guy Harris3-34/+49
Bug: 15985 Change-Id: I8e043431bbf874d640d4407335d525a44815ee73 Reviewed-on: https://code.wireshark.org/review/34327 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-20USBLL: Use custom address dissector instead of usb oneKrzysztof Opasiak1-25/+142
Usage of USB address dissector creates several challenges. In order to improve user experience let's create a custom address dissector. This allows us to not only drop the busid parameter but also replace endpoint parameter with hub port for SPLIT transactions. The address may be one of 3 forms: - host - <device address>.<endpoint> - <hub address>:<hub port> (for SPLIT transactions) This also adds 3 new fields (source, destination and addr) with exactly the same meaning as in usb. It also renames current addr field to device_addr. Strongly based on initial work by: Maciej Purski <maciej.purski@gmail.com> Ping-Bug: 15908 Change-Id: I5702295d7ef9076c3e0373de35ea4ac3cb2a0709 Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com> Reviewed-on: https://code.wireshark.org/review/34279 Reviewed-by: Tomasz Moń <desowin@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-19MB-34017: Add HCS to SnapshotMarkerBen Huddleston1-7/+7
Add the optional HCS field to the snapshot marker (only send on when non-zero for disk snapshots). Also, remove the durability timeout field from DCP_PREPARE as it is not sent and the UI warns about invalid extras length. Change-Id: I46955e2a719d28a70377bc6addb65fa3356ea1d4 Reviewed-on: https://code.wireshark.org/review/34323 Reviewed-by: Jim Walker <jim@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-19Qt: Initialize PacketListHeader member variablesTomasz Moń1-1/+3
Coverity CID 1446258 Change-Id: Iffadb8be97dd6dbd75a97869cea54398eec16554 Reviewed-on: https://code.wireshark.org/review/34324 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-19Qt: Fix PacketListHeader dereferences before null checkTomasz Moń1-4/+19
Coverity CID 1446250, 14462554, 1446255, 1446256 Change-Id: I38ec9473dbee92a5bb3bc9635e2f6968db27b99e Reviewed-on: https://code.wireshark.org/review/34325 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-19Qt: Fix CredentialsModel::clear()Tomasz Moń1-7/+9
The last parameter to beginRemoveRows() is the last row index, not the number of rows. The QAbstractItemModel::beginRemoveRows() source code expliticly checks if the value is smaller than row count. Do not emit beginRemoveRows() if the model is empty as it does not make sense and it is impossible to pass the QAbstractItemModel assertions in such case. Emit endRemoveRows() when finished instead of endInsertRows(). Change-Id: I93be4820b1ea0fbb5c0f3cd28edca329b4017814 Reviewed-on: https://code.wireshark.org/review/34318 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-19NAS 5GS: decode LPP payloadPascal Quantin1-0/+7
Change-Id: I086370088e9ecf56e0871e2dbedb367a23633ce7 Reviewed-on: https://code.wireshark.org/review/34326 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-19tds: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I948f9cc9ef22798fd5e24d078e4749cb68548aec Reviewed-on: https://code.wireshark.org/review/34319 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-23 19:52:51 +0000