aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2008-06-28Get rid of some unused code warnings.Anders Broman2-69/+45
svn path=/trunk/; revision=25626
2008-06-28Add som missing extension IE's and try to get rid of som unused code warnings.Anders Broman3-79/+293
svn path=/trunk/; revision=25625
2008-06-28To handle 64 bit constraints we also need to change FT_UINT32 to FT_UINT64Anders Broman2-4/+10
svn path=/trunk/; revision=25624
2008-06-28Add FT_INT64 to IS_FT_INT and FT_UINT_64 to IS_FT_UINT.Anders Broman1-2/+2
svn path=/trunk/; revision=25623
2008-06-28Set the Info column.Guy Harris1-0/+6
svn path=/trunk/; revision=25622
2008-06-27If we find an invalid version number, at least put something into theGuy Harris1-2/+7
Info column and protocol tree to indicate that. If we find an invalid version number in the *second* switch statement, don't bother spewing out a warning - that's a "cannot happen", so just throw a dissector assertion. svn path=/trunk/; revision=25621
2008-06-27Have checkAPIs.pl print to stderr, so that its output is colored red inGerald Combs2-6/+6
Buildbot. Make capitalization more consistent. Look for abort functions in wsutil. svn path=/trunk/; revision=25619
2008-06-27Fix some warnings reported by gcc -Wshadow ... Bill Meier20-139/+135
Fix some spacing in packet-dcom.c svn path=/trunk/; revision=25618
2008-06-27Fix some checkAPIs warnings.Gerald Combs6-95/+87
svn path=/trunk/; revision=25617
2008-06-27Fix some warnings reported by gcc -Wshadow ...Bill Meier7-200/+197
svn path=/trunk/; revision=25616
2008-06-26Wiretap code probably shouldn't abort the application either.Gerald Combs1-1/+1
svn path=/trunk/; revision=25615
2008-06-26Add support for "API groups" in checkAPIs.pl. Make the "prohibited"Gerald Combs32-151/+183
and "deprecated" groups the default. Add an "abort" group for code that shouldn't exit the program. Update the makefiles to call "checkAPIs.pl -g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl. svn path=/trunk/; revision=25614
2008-06-26Fix a comment: the subdissector won't /assert/ out it will /except/ out if ↵Jeff Morriss1-1/+1
the MSU is truncated. svn path=/trunk/; revision=25613
2008-06-26From Abhik Sarkar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2647 :Jeff Morriss1-4/+15
The syslog dissector could crash if the "packlog" MSU is truncated such that the hex string ends in with a nibble. From me: Check if that will happen and chop off the nibble before giving it to convert_string_to_hex() so we'll dissect as much of the MSU as possible. svn path=/trunk/; revision=25612
2008-06-26Remove a lot of vestigal GTK-Wimp stuff. It's been included withGerald Combs6-98/+15
GTK+ since version 2.8, when its name was changed to the "GTK MS Windows-Engine." Simplify the Windows installer by removing the GTK-Wimp option (which means the "Wireshark" item can be an entry instead of a group). Move Rawshark to the "Tools" group. (If anyone wants to disable the MS Windows Engine they can still do so after installation by disabling or removing libwimp.dll.) svn path=/trunk/; revision=25611
2008-06-26Fix a missed "item" -> "item_local" in the previous checkin.Guy Harris1-1/+1
svn path=/trunk/; revision=25610
2008-06-26Make the default for HDLC traffic "Raw data", just as it is for otherGuy Harris1-1/+1
record types, so that people know they have to set the preference. svn path=/trunk/; revision=25609
2008-06-26Make the preference settings for the dissector to use for various ERFGuy Harris1-68/+52
link-layer types static. If the preference is set to "raw data" for any of those types, display the raw data with an indication that the preference in question has been set to "raw data", so people don't just wonder why ERF files aren't working right any more. (See bug 2641; I had the same surprise when I tried it on some ERF captures I have.) Pull the dissect_erf_header() code into dissect_erf() - it's dissecting the *payload*, not the *header*. Fill in the Info column with the record type. When using tvb_new_subset() to chop a header off of a tvbuff, just specify lengths of -1, so we go all the way to the end. Clean up the Infiniband dissector call. svn path=/trunk/; revision=25608
2008-06-26Fix some warnings reported by gcc -Wshadow ...Bill Meier7-62/+62
svn path=/trunk/; revision=25607
2008-06-25We last supported NT 4.0 with version 0.99.4 (according toGerald Combs1-1/+6
wireshark.nsi, at least). Drop it from the "supported" list and add a note about NT 4.0 and older Windows versions. svn path=/trunk/; revision=25606
2008-06-25We apper to spell it "TShark" rather than "Tshark", the fact that it'sGuy Harris1-32/+31
"Wireshark" rather than "WireShark" nonwithstanding. Say we run on NT 4.0 rather than "NT" - I don't know whether we run on NT 3.x (and 2000/2003/XP are really NT 5.x and Vista/2008 are really NT 6.x - that's why Microsoft are talking about "Windows 7" as the next big release). In the capture-privileges paragraph, note that it's dumpcap that needs to run as root, and suggest not only that Wireshark shouldn't be set-UID root, but that it shouldn't even be run as root, and that the same applies to TShark. Update "How to Report a Bug" to reflect that we're telling people to report bugs on Bugzilla, and that "wireshark -v"/"tshark -v" give almost all the version information we want. svn path=/trunk/; revision=25605
2008-06-25Update the document to the current state of affairs.Jaap Keuter1-5/+6
svn path=/trunk/; revision=25604
2008-06-25Make sip.msg_hdr a string field instead of FT_NONE.Martin Mathieson1-2/+3
svn path=/trunk/; revision=25602
2008-06-25Constify a bunch of stuff, to squelch -Wwrite-strings warnings. Guy Harris33-151/+157
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not ready to enable that warning by default yet. Throw in some casts to handle GLib routines that take arbitrary non-const pointers (they can later return the pointers, and some callers might want to modify or free up those pointers in cases where they're known to be writable or allocated). Use ep_tvb_memdup() rather than a combination of ep_alloc() and tvb_memcpy(). Clean up some indentation. svn path=/trunk/; revision=25601
2008-06-25Clean up indentation.Guy Harris1-69/+103
Make build_expert_data() take the size of "buffer" as an argument, and use that when doing g_snprintf() into the buffer, to ensure we don't overflow the buffer. Also, don't just assign to "buffer", as that doesn't put anything *in* the buffer. svn path=/trunk/; revision=25600
2008-06-25For for compressed DLMAP decode error.Martin Mathieson1-1/+1
From Frank Wang (bug 2640). svn path=/trunk/; revision=25599
2008-06-25From Max Ivanov:Jaap Keuter1-1/+1
The destination unreachable indication for external IP routes is at offset 24, not 4 as in internal IP routes. svn path=/trunk/; revision=25598
2008-06-25Update a comment.Guy Harris1-1/+1
svn path=/trunk/; revision=25597
2008-06-25Fix some warnings - declare some arguments, variables, and structureGuy Harris6-21/+15
members to be const pointers when that's possible, and throw in some casts when the GLib API fails to have properly consted arguments. Use ep_strdup_printf() in some cases. svn path=/trunk/; revision=25596
2008-06-24Make it obvious that this is a development version. Fix a makefileGerald Combs6-7/+2075
dependency on the splash images. svn path=/trunk/; revision=25594
2008-06-24Add TurboCap-related changes from /trunk-1.0:Gerald Combs5-17/+186
From Dustin Johnson: Add support for TurboCap. - packet-ppi.c: Add aggregation and 802.3 extended information. - capture-wpcap.c: Add support for pcap_list_datalinks and pcap_set_datalink. Make pcap_list_datalinks and pcap_set_datalink mandatory on Windows. svn path=/trunk/; revision=25593
2008-06-24Fix a logic problem.Gerald Combs1-1/+1
svn path=/trunk/; revision=25592
2008-06-24Make inet_ntop fix work for out-of-tree buildsJeff Morriss1-2/+2
svn path=/trunk/; revision=25590
2008-06-24Make -Wwrite-strings non-default for now.Guy Harris1-3/+8
Note what files are blocking some -W flags. svn path=/trunk/; revision=25589
2008-06-24Get rid of another unused variable.Guy Harris1-1/+0
svn path=/trunk/; revision=25588
2008-06-24Get rid of some code that fills in a string that's never used. Get ridGuy Harris1-18/+0
of the string, while we're at it. svn path=/trunk/; revision=25587
2008-06-24Highlight the whole hostname, even if we've truncated it in the display.Gerald Combs1-1/+1
svn path=/trunk/; revision=25586
2008-06-24We're not ready for -Wshadow by default yet.Guy Harris1-1/+1
svn path=/trunk/; revision=25585
2008-06-24Noam Rathus discovered that the RMI dissector was using g_strlcpyGerald Combs1-9/+7
incorrectly, which could lead to information disclosure or worse. Use tvb_format_text instead. This lets us get rid of a character array and avoids feeding raw packet data to the GUI. svn path=/trunk/; revision=25584
2008-06-24Assign pointers to strings to a const pointer.Guy Harris1-1/+1
svn path=/trunk/; revision=25582
2008-06-24Fix another variable named "index".Guy Harris1-6/+6
svn path=/trunk/; revision=25581
2008-06-24We don't check structure sizes elsewhere; don't check them here. (InGuy Harris1-11/+10
any case, the detailed error string is supposed to be g_malloced....) Fix some "snoop" to be "btsnoop", and note that this is Symbian btsnoop, not regular snoop. svn path=/trunk/; revision=25580
2008-06-24Fix *NIX builds where we need our own inet_pton.c or inet_ntop.c . This ↵Jeff Morriss2-2/+28
should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2607 svn path=/trunk/; revision=25579
2008-06-24Temporarily turn on some -W options, to provoke the buildbots to buildGuy Harris1-3/+3
with them to check whether we've cleaned those warnings up or not. svn path=/trunk/; revision=25578
2008-06-24One -Wcast-align suffices.Guy Harris1-1/+0
svn path=/trunk/; revision=25577
2008-06-24Have separate callback mechanisms in file.c and capture.c; pass theGuy Harris9-117/+253
capture callbacks the capture_options * as its second argument in all cases. This makes it a bit clearer what arguments callbacks take, and means we can get rid of all global_capture_opts references in gtk/main_statusbar.c. Put the interface between gtk/main.c and gtk/main_statusbar.c into a private header. svn path=/trunk/; revision=25576
2008-06-24Only include gtk/capture_globals.h if we're building with captureGuy Harris1-0/+2
support. svn path=/trunk/; revision=25575
2008-06-24Add gtk/capture_globals.h, to declare global_capture_opts, so files thatGuy Harris13-28/+66
don't need global_capture_opts don't need to have it declared and thus don't need capture_options defined. Include gtk/capture_globals in the files in question. Change some more capture_opts references to refer to global_capture_opts. Change some global_capture_opts references in routines with a capture_opts argument to refer to capture_opts. The structure type is capture_options, not capture_opts; fix some references. Include <sys/types.h>, if it's present, in capture_opts.h, so we get gid_t defined. Clean up indentation. svn path=/trunk/; revision=25574
2008-06-24Fix some references to the global loop_data structure that weren'tGuy Harris1-6/+8
changed in the previous checkin. svn path=/trunk/; revision=25573
2008-06-24For now, just refer to global_capture_opts, replacing references to theGuy Harris1-13/+12
now-defult global capture_opts pointer; we eventually should try to minimize the use of global variables. svn path=/trunk/; revision=25572