aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-11-13xml: fix list of default media types for XML.Guy Harris1-1/+1
One entry in the list of strings didn't have the comma at the end, so the entry after it was concatenated with it, forming a bogus entry and causing neither "application/vnd.3gpp.mcptt-info+xml" nor "application/vnd.3gpp.mid-call+xml" to be recognized by media type as XML. Should resolve Coverity CID 1355680.
2020-11-14Fix a few more item lengths.Martin Mathieson3-4/+4
2020-11-13Qt+epan: Print better-looking values in the packet diagram.Gerald Combs4-231/+333
Pull the value-formatting code in proto_custom_set into proto_item_fill_display_label. Use that in FieldInformation::toString instead of fvalue_to_string_repr. Fixes #16911.
2020-11-13NAS-EPS: remove an extra spare bitPascal Quantin1-2/+1
It has been replaced by the 15 bearers capability during R15 development
2020-11-133GPP NAS: upgrade dissector to v16.6.0Pascal Quantin1-18/+257
2020-11-13MBIM: fix mbim.control.ms_app_info.app_name displayPascal Quantin1-2/+2
2020-11-13xml: Add default media type application/vnd.3gpp.mcptt-info+xmlAnders Broman1-0/+1
2020-11-13TCP AO: Add dissection for RFC5925 TCP AOMichael Pergament1-1/+58
Add TCP AO option dissector based on RFC5925
2020-11-13MMRP: Fix wrong offset for service attribute typeAlexis La Goutte1-1/+1
Issue reported by Nils Andersen Close #17005
2020-11-12Qt: Fetch byte view text font metrics more often.Gerald Combs2-5/+14
Add ByteViewText::updateLayoutMetrics, which fetches the character width and line height. Call it whenever our font changes and when we're about to paint. Blind attempt at fixing #15819.
2020-11-12Fix a few spelling mistakes.Martin Mathieson6-7/+23
2020-11-12Protobuf: feature of adding missing fields with default valuesHuang Qiangxiong6-10/+774
Make Protobuf fields that are not serialized on the wire (missing in capture files) to be displayed with default values by setting the new 'add_default_value' preference. The default values might be explicitly declared in 'proto2' files, or false for bools, first value for enums, zero for numeric types. Default values are generated in epan/protobuf_lang_tree.c during the nodes of fields are created. The default_value_xxx() methods of field descriptor are added into epan/protobuf-helper.c/h and epan/protobuf_lang_tree.c/h files. close #17000
2020-11-11QUIC: fix handling of Key UpdateNardi Ivan1-99/+191
After a key update, we should update Packet Protection cipher but we shouldn't touch the Header Protection one. With the current code, PP and HP ciphers are quite entangled and we always reset both of them. Therefore, at the second key update we reset the used 1-RTT HP cipher too; no wonder even header decryption fails from that point on. To properly fix this issue, all the ciphers structures has been rewritten, clearly separating PP code from HP one. Close #16920 Close #16916
2020-11-11epan: BGP Prefix-SID attribute SRv6 SID supportHideaki HAYASHI1-42/+546
[Update] BGP Prefix-SID definition (from draft-ietf-idr-bgp-prefix-sid-05 to RFC8669). [Support] BGP Prefix-SID SRv6 SID (draft-ietf-bess-srv6-services-05)
2020-11-10RTPS: Fixup our coherent set map.Gerald Combs1-10/+8
coherent_set_tracking.coherent_set_registry_map uses a struct as a key, but the hash and comparison routines treat keys as a sequence of bytes. Make sure every key byte is initialized. Fixes #16994. Call wmem_strong_hash on our key in coherent_set_key_hash_by_key instead of creating and leaking a GBytes struct.
2020-11-10bt-dht: don't iterate on strings in valuesMartin Nyhus1-7/+21
Each peer in a get_peers response has its own entry in the list, unlike the way nodes are represented, so if we see a string_len we don't recognize (like 18 for IPv6 peers) treating it as several IPv4 peers doesn't make sense.
2020-11-10Qt: enable sorting for Help->About tablesChuck Craft1-0/+6
2020-11-10RTCP: try to continue dissection with partial SRTCP packetJaap Keuter1-1/+1
When due to limited capture length the tailing part of the SRTCP packet is missing it might be impossible to know the encryption status of this packet. Before retrieving that information make sure that's even possible, otherwise continue as if not encrypted.
2020-11-10parsing enterprises file: comment and slightly simplifyMartin Mathieson1-4/+14
This is roughly 10% of tshark startup time. - Enterprise string does not need to be trimmed at the beginning - No need to call g_hash_table_replace() as keys are just guint32
2020-11-09rlcmac: Fix EGPRS UL data block TLLI endianessPau Espin Pedrol1-1/+1
According to TS 44.060, figure 10.3a.2.1, note 2, the TLLI is encoded in little endian for EGPRS (while big endian is used in GPRS).
2020-11-09WSUG: Add a note about verifying downloads.Gerald Combs1-12/+14
2020-11-08Kafka: Fixup returned offsets and initialize variables.Gerald Combs1-19/+48
Many of the Kafka dissector's type dissection routines either returned an offset or -1 in the event of an error. We don't appear to check for errors anywhere, so ensure that those routines always return a valid offset. Make those routines always initialize their type offset and length variables. Fixes #16985.
2020-11-08Opensafety: fix some item lengthsMartin Mathieson1-3/+3
2020-11-08[Automatic update for 2020-11-08]Gerald Combs14-44/+126
Update manuf, services enterprise numbers, translations, and other items.
2020-11-08QUIC: improve migration supportNardi Ivan3-11/+36
We should keep track of CID reported in Preferred Address Transport Parameter Close #16915
2020-11-07epan: Limit our bits in decode_bits_in_field.Gerald Combs1-6/+5
Limit the number of bits we process in decode_bits_in_field, otherwise we'll overrun our buffer. Fixes #16958.
2020-11-07wiretap: Update pcapng systemd timestamp handling.Gerald Combs1-23/+17
It's easy to create systemd blocks with a missing or invalid __REALTIME_TIMESTAMP= field when fuzz testing. If that's the case, leave WTAP_HAS_TS unset instead of returning an error. Fixes #16965.
2020-11-07Fix some more item lengths.Martin Mathieson2-4/+4
2020-11-07IPv6: Try to fix CID 1468890João Valverde1-4/+6
Without a default swich case Coverity flags a possible divide by zero error. While at it remove unneeded initializers because it is a symptom of the same issue.
2020-11-06Fix some more item lengths.Martin Mathieson3-4/+4
2020-11-06SMB: Dissection of Dynamic Access Control specific ACEsJohn Bankier4-10/+876
Added dissection for Dynamic Access Control (DAC) specific ACEs. These are Conditional ACEs, System Resource Attribute ACEs and System Scoped Policy ID ACEs. A Condition ACE must be one of the following types: ACE_TYPE_ACCESS_ALLOWED_CALLBACK ACE_TYPE_ACCESS_DENIED_CALLBACK ACE_TYPE_ACCESS_ALLOWED_CALLBACK_OBJECT ACE_TYPE_ACCESS_DENIED_CALLBACK_OBJECT ACE_TYPE_SYSTEM_AUDIT_CALLBACK ACE_TYPE_SYSTEM_AUDIT_CALLBACK_OBJECT Such an ACE may include a conditional expression (that will, if present, be evaluated to determine whether or not the ACE allows or denies access). If a conditional expression is present the ACE data will start with the string "artx". The remainder of the ACE data will be the conditional expression which is simply a list of tokens (see MS-DTYP for details of each token type). With this change, filter "nt.ace.cond" can be used to find packets containing one or more Conditional ACEs and their details are dissected. A System Resource Attribute ACE has a name, value type and a list of values. The value types are: INT64, UINT64, STRING, SID, BOOLEAN and OCTET_STRING (i.e. binary data). With this change, filter "nt.ace.sra" can be used to find packets containing one or more System Resource Attribute ACEs and their details are dissected. System Scoped Policy ID is simply a new ACE type and it does not require any new dissection. The SID associated with a System Scoped Policy ID ACE will start with S-1-17 and identifies the "Central Access Policy" that should be used.
2020-11-05RPM+CI: Update and fix for Fedora 33, CentOS 8, OpenSUSE Leap 15.2John Thacker3-27/+101
Re-enable Fedora build and add CentOS 8 and OpenSUSE 15.2 builds. Fedora 33 does out of build tree cmake builds and needs spec file changes. CentOS 8 has some changes with cmake and other packages that are similar to older Fedora, and needs extra repositories enabled to get -devel packages (still missing -devel for some optional libraries). OpenSUSE Leap 15.2 also has some changes needed to build. Note that OpenSUSE Leap 15.1 is EOL at the end of November 2020. Fixes #16971
2020-11-05giop: free the buffer where its atJaap Keuter1-2/+2
Followup on commit 40ce72f1a8cfbc9df1fd0dd637f2b8f00b4f5042
2020-11-05RTCP: Initialize padding_itemJohn Thacker1-1/+1
Declare padding_item outside the while loop and initialize it, as we want the value from the previous loop iteration when using it for expert_info. Fixes clang build warnings.
2020-11-05giop: don't use packet scope for allocating a buffer at init timeJaap Keuter1-2/+3
Followup on commit 2c2ee172eb1eadda5a418558fe35d2e3e2c03317 Also when reading in lines from the file don't use packet scope. Fixes #16984
2020-11-05rlcmac: Handle properly LI=0 in GPRS data blocks and identify spare bitsPau Espin Pedrol1-32/+48
The previous handling of LI=0 was a confusion with the LI=0 meaning from EGPRS (see TS 44.060 B.8.2 Example 2) data block.
2020-11-05Protobuf: fix bug about parsing negative enum value numberHuang Qiangxiong2-11/+28
Change PT_DECIMALLIT, PT_OCTALLIT and PT_HEXLIT tokens to uint64 type, and make PT_IDENT excluding '-' numbers which will be parsed in protobuf_lang.y. That negative enum number and number type of constant can be correctly parsed. Note, intLit is uint32 for parsing fieldNumber and enumNumber, but might be uint64 as constant. close #16988
2020-11-05Tools+test: Call python3 explicitly.Gerald Combs41-84/+20
PEP 394[1] says, "In cases where the script is expected to be executed outside virtual environments, developers will need to be aware of the following discrepancies across platforms and installation methods: * Older Linux distributions will provide a python command that refers to Python 2, and will likely not provide a python2 command. * Some newer Linux distributions will provide a python command that refers to Python 3. * Some Linux distributions will not provide a python command at all by default, but will provide a python3 command by default." Debian has forced the issue by choosing the third option[2]: "NOTE: Debian testing (bullseye) has removed the "python" package and the '/usr/bin/python' symlink due to the deprecation of Python 2." Switch our shebang from "#!/usr/bin/env python" to "#!/usr/bin/env python3" in some places. Remove some 2/3 version checks if we know we're running under Python 3. Remove the "coding: utf-8" in a bunch of places since that's the default in Python 3. [1]https://www.python.org/dev/peps/pep-0394/#for-python-script-publishers [2]https://wiki.debian.org/Python
2020-11-05wslua: Return nil from Dissector.get() when not foundStig Bjørlykke1-9/+8
Return nil from Dissector.get() and DissectorTable.get() when the reference is not found. This can be used to check for existence of a dissector or dissector table before use. We already do this for DissectorTable.get_dissector().
2020-11-05IPv6: Add dissector for Compact Routing Header (CRH)ishaangandhi1-0/+112
2020-11-05RTCP: expert item on non-final packet padding flagJaap Keuter1-2/+10
RFC 3550, Section 6.4.1 describes that the padding flag may only be set on the last packet in a compound RTCP packet. Add an expert item if that is not the case.
2020-11-04giop: don't use packet scope for allocating a buffer at init time.Guy Harris1-5/+9
You can't use packet scope if you're not dissecting a packet; read_IOR_strings_from_file() is called from giop_init(), which is called when a file is opened, not when dissecting a packet. Use NULL as the scope, which just does a regular allocation, and free the buffer when we're done. Expand a comment to indicate that using dissection routines is *also* a bad idea in code that's not used when dissecting packets. Fixes #16984.
2020-11-04Tools: Allow cherry pick lines in validate-commit.py.Gerald Combs1-1/+5
Cherry picking tends to add an extra blank line to the commit message. Update the body check in validate-commit.py to allow for this.
2020-11-04Image: Add another icon library link.Gerald Combs1-0/+2
2020-11-04QT: progress UI: Fix TextLabel string to loadingUli Heilmeier1-1/+1
Change TextLabel to Loading for progress UI Fixes: wireshark/wireshark#16987
2020-11-04QUIC: Fix typoAlexis La Goutte1-1/+1
Reported by Martin Thomson
2020-11-03docbook: Fix example to run tests containing dumpcapStig Bjørlykke1-1/+1
2020-11-03Gitlab: Tweak Bug issue templateUli Heilmeier1-1/+1
Add request to use button "Copy To Clipboard".
2020-11-03Gitlab: Fix label for FeatureRequest issue templateUli Heilmeier1-1/+1
Remove quick action for label.
2020-11-03Gitlab: Add issue template for WebsitesUli Heilmeier1-0/+26
Template to report Websites related issues similar to product "Web sites" on bugs.wireshark.org.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 21:03:21 +0000