aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-02-20When any of our executables start on Windows create or open a "WiresharkGerald Combs14-6/+41
is running" mutex. Have the NSIS installer check for this mutex and ask the user to close Wireshark if it's found. While not perfect this makes the WinSparkle update process much less annoying. svn path=/trunk/; revision=47758
2013-02-20Swallow up tvb_set_real_data_no_exceptions() into tvb_new_real_data() -Guy Harris1-10/+4
the only caller is tvb_new_real_data(). svn path=/trunk/; revision=47757
2013-02-20Reflect that tvb_new() is now an internal routine.Guy Harris1-2/+1
svn path=/trunk/; revision=47756
2013-02-20Improve a comment - what matters is that tvb_new_real_data() can throwGuy Harris1-4/+1
an exception, not how it happens to be implemented currently. svn path=/trunk/; revision=47755
2013-02-20Fix Coverity CID 984638: Unused pointer value.Chris Maynard1-1/+1
svn path=/trunk/; revision=47754
2013-02-20No more tvb_new(), so no more need for tvb_set_real_data() orGuy Harris2-46/+10
tvb_set_subset(); code should use tvb_new_real_data() and various tvb_new_subset routines. (Neither tvb_new() nor tvb_set_real_data() nor tvb_set_subset() were exported in libwireshark.def, nor were they used outside tvbuff.c; tvb_set_real_data() and tvb_set_subset() weren't even being used *inside* tvbuff.c.) svn path=/trunk/; revision=47753
2013-02-19Make tvb_new() an internal routine to epan/tvbuff.c; we export variousGuy Harris2-6/+1
routines to create new tvbuffs that do what dissectors need to do, and those are the only routines that should be used. svn path=/trunk/; revision=47752
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris48-102/+76
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2013-02-19Register the gui.update.interval preference.Gerald Combs1-0/+6
svn path=/trunk/; revision=47750
2013-02-19Enable automatic updates for Win64. Fix a copy/paste error.Gerald Combs4-4/+9
svn path=/trunk/; revision=47749
2013-02-19Add automatic software update checks for Win32 using WinSparkle. AddGerald Combs14-4/+319
preferences (currently hidden) to disable updates, set the update frequency, and set the update "channel" (stable vs development). Add a "Help" menu item to manually check for updates. svn path=/trunk/; revision=47748
2013-02-19Remove experiment with global codeAnders Broman2-36/+4
svn path=/trunk/; revision=47747
2013-02-19Add the remaining asn1 files "CODE global" not handled yet.Anders Broman13-12/+1145
svn path=/trunk/; revision=47746
2013-02-19calc_checksum() should be passed the length of the block to beGuy Harris1-11/+42
checksummed, which is the length of the TPDU, not that length + 1. Calculate the TPDU length correctly - use tvb_reported_length_remaining(), not tvb_length_remaining() (we want the *actual* length, not the amount of captured data we have), and take the offset handed to the dissector routine into account. Don't take the length indicator into account for TPDUs with user data, as they run to the end of the lower-level packet containing the TPDU(s). The CLTP UD TPDU contains user data. Note that this dissects both COTP *and* CLTP (that's why it's "packet-ositp.c", not "packet-cotp.c"). Separate some groups of #includes with blank lines. svn path=/trunk/; revision=47745
2013-02-19According to wikipedia, the A6M was outdated by 1944. Let it rest in peace.Chris Maynard2-19/+15
svn path=/trunk/; revision=47744
2013-02-19Whitespace tweaks.Guy Harris1-5/+6
svn path=/trunk/; revision=47743
2013-02-19Don't call expert_add_info_format() from within an if (tree) {} block.Chris Maynard1-94/+93
Misc. whitespace changes, remove tabs, add modelines to match current scheme. svn path=/trunk/; revision=47742
2013-02-19Bugfix OSITP - Incorrect TP4 checksum calculation (ATN extended checksum) in ↵Michael Mann1-24/+31
case of multiple TPDU's per frame. Bug 8293 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8293) svn path=/trunk/; revision=47741
2013-02-18For each dynamic-payload hash table, keep a Boolean indicating whetherGuy Harris1-16/+36
it's been used in an rtp_set_address() or srtp_set_address() call and, if that Boolean is set, don't free the hash table; this fixes a case where the hash table was freed while it was in use. svn path=/trunk/; revision=47740
2013-02-18Use tcp_dissect_pdus for better dissection on TCP. Adjusted UDP dissection ↵Michael Mann1-149/+160
accordingly. Various cleanup to use proto_tree_add_item more often. svn path=/trunk/; revision=47739
2013-02-18Dissect more supplementarry servicesAnders Broman9-66/+2372
svn path=/trunk/; revision=47738
2013-02-18Enums aren't guaranteed to be able to hold a value that doesn't fit inGuy Harris1-1/+3
an int, so don't use enums for special values of the PLP length field. In addition, use G_GINT64_CONSTANT() to tag them as appropriate for a guint64. svn path=/trunk/; revision=47737
2013-02-18From Alex Gaertner via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8313Evan Huus1-19/+22
Misc. fixes to the SML dissector: - one more define added - removed data_handle (unused) - removed "check = tvb_get_guint8(tvb, temp_offset);" (value hasn't changed) - added PI_NOTE - CRC fixed, calculation now correct if CRC is transmitted as UINT8 From me: - clean up indentation - change modelines to actually match the indentation most commonly used svn path=/trunk/; revision=47736
2013-02-18Fix small typo in TPC Report IEAlexis La Goutte1-2/+2
svn path=/trunk/; revision=47734
2013-02-18Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=47733
2013-02-18From 802.11-2012.pdf Update Reason Code and Status Code fieldsAlexis La Goutte1-2/+36
svn path=/trunk/; revision=47732
2013-02-18Display Power Constraint in DEC (and fix a small typo)Alexis La Goutte1-2/+2
svn path=/trunk/; revision=47731
2013-02-18Add more ASN1 files.Anders Broman2-0/+106
svn path=/trunk/; revision=47730
2013-02-18Fix for bug 8321:Jaap Keuter1-4/+9
Feed the tap before trying to dissect the payload. This prevents a malformed payload from blocking the tap, resulting in incorrect RTP statistics. svn path=/trunk/; revision=47729
2013-02-18Revert SVN #47724, #47726 & #47727.Bill Meier1-1049/+1002
Some rethinking required since I failed to understand some of the details as to how proto_tree_write_fields() really works. :( svn path=/trunk/; revision=47728
2013-02-18Use consistent indentation & formatting style.Bill Meier1-992/+993
svn path=/trunk/; revision=47727
2013-02-18Don't use index as a variable name (i knew that..).Bill Meier1-6/+6
Fixes compiler warning. svn path=/trunk/; revision=47726
2013-02-18Bugfix data combined via ssl_desegment_app_data not visible via "Follow SSL ↵Michael Mann1-0/+1
Stream" From Joe McEachern, bug 6434 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6434) svn path=/trunk/; revision=47725
2013-02-18Implement proto_tree_write_fields without using ep_strbufs.Bill Meier1-18/+64
- Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8348: "tshark -T fields can't print the full value of fields where the value, as a text string, is longer than 65535 bytes" - Reduces ep memory allocation & string copies; svn path=/trunk/; revision=47724
2013-02-17Improve SSH state machine so IGNORED messages don't upset the dissection by ↵Michael Mann1-232/+162
throwing the "packet count" off. Bug 5064 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5064) svn path=/trunk/; revision=47723
2013-02-17Fix Coverity CID 981983: Unused pointer value.Chris Maynard1-268/+125
Additionally: 1) Remove check_col()'s 2) Don't call expert_add_info_format() from within an if (tree) {} block. 3) tvb_reported_length_remaining() can return -1; be sure to handle it. 4) Misc. whitespace changes. svn path=/trunk/; revision=47722
2013-02-17Remove C++ incompatibilities in c1222 dissector.Michael Mann4-41/+25
Also addresses an implicit cast in the epan/uat.h file Bug 8342 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8342) svn path=/trunk/; revision=47721
2013-02-17Update ITU-T E.212 to bulletin 1019 (01.I.2013)Pascal Quantin1-218/+398
svn path=/trunk/; revision=47720
2013-02-17Get rid of zero-length array - we allow Wireshark to be compiled withGuy Harris1-3/+5
compilers that don't support zero-length arrays. svn path=/trunk/; revision=47719
2013-02-17Add a macro to calculate, from the size of an AirpcapKeysCollectionGuy Harris2-4/+7
structure, the number of keys in the key list, and use it. svn path=/trunk/; revision=47718
2013-02-17Squelch some more warnings.Guy Harris2-2/+10
svn path=/trunk/; revision=47717
2013-02-17Squelch some warnings.Guy Harris3-73/+19
svn path=/trunk/; revision=47716
2013-02-17Support for SCU/SCP Role Selection and Asynchronous Operations Window ↵Michael Mann1-53/+377
Negotiation From Stefan Allers. Bug 8347 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8347) svn path=/trunk/; revision=47715
2013-02-17Try to fix merge problem.Anders Broman3-1846/+11
svn path=/trunk/; revision=47714
2013-02-17Add a preferense to the Q.932 dissector wether facility messages should be ↵Anders Broman6-23/+3543
dissected as QSIG or ETSI. Add the ISUP Supplementary services dissector. svn path=/trunk/; revision=47713
2013-02-17Oops, the list is of Makefiles, not of directories that should containGuy Harris1-1/+1
Makefiles. svn path=/trunk/; revision=47712
2013-02-17Add asn1/isdn-sup to the list of directories in which to generate aGuy Harris1-0/+1
Makefile. svn path=/trunk/; revision=47711
2013-02-17Give it an RCS ID.Guy Harris1-0/+3
svn path=/trunk/; revision=47710
2013-02-17Get rid of trailing CRs, set the usual svn properties to expand $Id$ andGuy Harris9-945/+945
use native line endings. svn path=/trunk/; revision=47709
2013-02-17Bugfix DoS in CIMD dissector. Bug 8346 ↵Michael Mann1-3/+3
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8346) svn path=/trunk/; revision=47708