aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-07-15Add AMT (Automatic Multicast Tunneling) RFC7450 dissectorAlexis La Goutte4-0/+353
Change-Id: Ic5e52b76e84e1d02d614b34980f94fd1288c9760 Reviewed-on: https://code.wireshark.org/review/22594 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-15MP2T: Add video/mp2t media-typeUli Heilmeier1-0/+1
Add video/mp2t media-type to dissect MP2T inside HTTP Bug: 13888 Change-Id: I8af9727bd69ab28a21811a807a1f631bde952926 Reviewed-on: https://code.wireshark.org/review/22623 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-14vsock: add missing vsockmon header reserved fieldStefan Hajnoczi1-0/+7
The vsockmon packet header is defined in <linux/vsockmon.h> as follows: struct af_vsockmon_hdr { __le64 src_cid; __le64 dst_cid; __le32 src_port; __le32 dst_port; __le16 op; /* enum af_vsockmon_op */ __le16 transport; /* enum af_vsockmon_transport */ __le16 len; /* Transport header length */ __u8 reserved[2]; }; The vsock dissector forgot to include the 2-byte reserved field. This caused the transport header and payload that follow the vsockmon header to contain junk data. Change-Id: I0e7e6f1d9ad96ab339bd070c1becf43bc7e6a6b1 Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-on: https://code.wireshark.org/review/22612 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-07-14vsock: add WTAP_ENCAP_VSOCK constantStefan Hajnoczi4-1/+17
A linktype was recently assigned to Linux vsock in libpcap commit cfdded36ddcf5d01e1ed9f5d4db596b744a6cda5 ("added DLT_VSOCK for http://qemu-project.org/Features/VirtioVsock"). The Wireshark vsock dissector can now be automatically applied when wtap_encap matches the new WTAP_ENCAP_VSOCK constant. This patch makes Wireshark dissect vsock packet captures without manually specifying the dissector. Change-Id: If252071499a61554f624c9ce0ce45a0ccfa88d7a Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-on: https://code.wireshark.org/review/22611 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-07-14SMB2: add sessionkey table in prefs for decryptionAurelien Aptel1-31/+162
Add table in SMB2 protocol options to store Session ID => Session Key mappings. If we find a matching session id while dissecting, use session key from the table to derive crypto keys used for decryption. Sample from https://wiki.wireshark.org/SampleCaptures#SMB3_encryption can be loaded as follows: tshark -ouat:smb2_seskey_list:3d00009400480000,28f2847263c83dc00621f742dd3f2e7b -r smb3-aes-128-ccm.pcap To obtain the session id and key you can compile your kernel with CIFS_DEBUG_KEYS enabled and all the info should be printed on the console when cifs.ko generates keys. The patch that adds this config option was merged recently and should appear in the not-yet-released 4.13 kernel. Alternatively you can read the keys from live memory on a x86_64 system by running a gdb script as root (see email [1] for usage and source [2]). [1]: https://lists.samba.org/archive/samba-technical/2017-May/120755.html [2]: http://lists.samba.org/pipermail/samba-technical/attachments/20170524/2950140e/cifs_dump_keys.py Change-Id: I2709bb5fb316a4a3614901efe967196c2925609a Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-on: https://code.wireshark.org/review/21711 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-14SIP: Add Status Code 607 (Unwanted)Uli Heilmeier1-0/+1
RFC 8197 defines the new status code 607 Unwanted Change-Id: I61299788b25f5ada460c88949bed3cabddc3908f Reviewed-on: https://code.wireshark.org/review/22618 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-14[print.c] g_slist_free_full requires #include <wsutil/glib-compat.h>AndersBroman1-0/+1
Change-Id: Iba3a95d67413d7f1a84436fc51dfdf13251bcece Reviewed-on: https://code.wireshark.org/review/22620 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-14Remove some unneeded includes.Gerald Combs1-5/+0
Change-Id: I513936a74fe96211153fdf35f1832608b2cd053d Reviewed-on: https://code.wireshark.org/review/22617 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-13[GTPv2] Use proto_tree_add_bitmask_with_flags() for ULI Flags.AndersBroman1-22/+31
Change-Id: I7c209eef0114e4453008b8e7d7f8c238578e4433 Reviewed-on: https://code.wireshark.org/review/22606 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-13GTK: add a comment better suiting GCC 7 parsingPascal Quantin1-1/+1
Change-Id: Iab1eb1b86a750f3dedce6b2bd467fb3ba98243df Reviewed-on: https://code.wireshark.org/review/22613 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-13[GTPv2] Make dissect_gtpv2_uli() external and add more info when callingAndersBroman2-3/+14
dissectors for private extensions. Change-Id: I5762fdff2b25bca8d29520780c55367b636a2871 Reviewed-on: https://code.wireshark.org/review/22604 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-13S1AP: upgrade dissector to v14.3.0Pascal Quantin10-297/+1264
Change-Id: Ib28228db70a23d6f73f3c1740abc2e6542818ff9 Reviewed-on: https://code.wireshark.org/review/22609 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-13LPPa: upgrade dissector to v14.2.0Pascal Quantin9-352/+1854
Change-Id: I534f6e480e0cd13f4592ff3ca6ecd7f769863927 Reviewed-on: https://code.wireshark.org/review/22608 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-13X2AP: upgrade dissector to v14.3.0Pascal Quantin8-17/+534
Change-Id: Idee26dcdfad15d9fb23e3fb8aeb8ad8afed747d5 Reviewed-on: https://code.wireshark.org/review/22607 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-13couchbase: fix decoding last lookup specSergey Avseyev1-1/+1
Change-Id: I96ae6225adee6875adad9e45c0543b9664b96e8a Reviewed-on: https://code.wireshark.org/review/22605 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-13M2AP: upgrade dissector to v14.0.0Pascal Quantin9-11/+179
Change-Id: If564a2cffead403dd3d06c1a031b8985fcde7e4b Reviewed-on: https://code.wireshark.org/review/22603 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-13IEEE 802.15.4: Support the MPX IE defined by IEEE 802.15.9Robert Sauter2-4/+284
Still open: Reassembly and support for KMP payload dissection besides EAPOL Bug: 13883 Change-Id: I48a1e6af5c6fb5594fb4e6a5258db0d8ebaf4a70 Reviewed-on: https://code.wireshark.org/review/22597 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-13NAS EPS: upgrade dissector to v14.4.0Pascal Quantin4-10/+159
Change-Id: I8b0ae56889f6a52ba7d8c0c95a6b8e6a31557fa3 Reviewed-on: https://code.wireshark.org/review/22601 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-12Correct the dissection of zero-length SSIDs to show them as Wildcard SSIDs asRichard Sharpe1-2/+16
per 802.11 2012 8.4.2.2 SSID Element. Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com> Change-Id: I3ee2fc45063bc1ee6cb1244771e6c1452f6704e4 Reviewed-on: https://code.wireshark.org/review/22591 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-07-12GTK: fix compilation with GCC 7Pascal Quantin2-2/+2
Change-Id: Ifde706f4705af406fd4eee61a312d8eb0976d972 Reviewed-on: https://code.wireshark.org/review/22598 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-11Qt: Move all utility widgets to widgets subdirectoryRoland Knall79-136/+155
Move all utility widgets to the widgets subdirectory and add separate source_group for their files Correct some alphabetization in ui/qt/CMakeLists.txt noticed during compare. Change-Id: I2d664edc2b32f126438fb673ea53a5ae94cd43d1 Reviewed-on: https://code.wireshark.org/review/22531 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-11IndigoCare iCall: Support for padded packetsErik de Jong1-5/+22
Fix to dissect packets from certain implementations of this protocol which have null padding at the end of otherwise valid packets. Change-Id: Ic7790d9bbcf9467a9de0aa738e65a597802ce494 Reviewed-on: https://code.wireshark.org/review/22593 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-11Organize Qt source files for Visual StudioMichael Mann1-0/+7
Organize source into 5 categories: moc Source Files - moc_* files ui Header Files - Header files generated by .ui files ui Files - .ui files qrc Files - graphics? files Header Files - Header files for Qt source headers Change-Id: If32b8331592a2c685131ea9592893b7add1124ec Reviewed-on: https://code.wireshark.org/review/22592 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-11QUIC: rename to G(oogle)QUICAlexis La Goutte4-644/+645
quic => gquic Change-Id: Ica9ae8cc77e09056507c9c4c5c798b613eb56194 Reviewed-on: https://code.wireshark.org/review/22589 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11QUIC: like Fbzero dissector check direclty offset_endAlexis La Goutte1-60/+10
and don't subtract tag_len Change-Id: I4dbae23614ecad0dc30e9c8581acdbf5b38b037f Reviewed-on: https://code.wireshark.org/review/22588 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11QUIC: move get length packet number to functionAlexis La Goutte1-24/+24
Change-Id: I272866b04aa7833812df9d4baae2f4fe9f47b6e9 Reviewed-on: https://code.wireshark.org/review/22587 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11QUIC: directly return lenAlexis La Goutte1-36/+28
Change-Id: I61fed177c85081e7067ce5245349ef673c31f6e1 Reviewed-on: https://code.wireshark.org/review/22586 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11Zbee ZCL se: fix typo found by conflict hfAlexis La Goutte1-1/+1
'zbee_zcl_se.met.publish_snapshot.payload_type' exists multiple times with NOT compatible types: FT_BYTES and FT_UINT8 Change-Id: I97bc7cb467508192a3597836b721778341bc756c Reviewed-on: https://code.wireshark.org/review/22590 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11[x509af] Make CertificateSerialNumber an unsigned integer to handle a 9AndersBroman4-10/+9
byte 64 bit BER encoded unsigned number. Change-Id: I43e4a7f3103fac458a528022e0fdf6f0947804dc Reviewed-on: https://code.wireshark.org/review/22585 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11Ethertype: Add 6LoWPAN Ethertype; register dissectorRobert Sauter3-0/+9
Change-Id: I3ba09b8ebc696b83531b998fcc3a0f521d86df41 Reviewed-on: https://code.wireshark.org/review/22581 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11packet-rsl.c: Adds dissection of Physical Context field.Piotr Tulpan1-3/+195
Added as option with the default value set to TRUE. Dissection is based on file generated from Tektronix Monitoring Solution for Mobile Networks. Change-Id: Iedb2e742d1d406bc68e41334cac4a15da443cf3f Reviewed-on: https://code.wireshark.org/review/22507 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11GSMTAP: add LTE RRC message supportMartin Heusse2-4/+43
This code is borrowed from a patch proposed by altaf329@gmail.com in june 2015 (Ice136a9cb950bb97a11bee4486071b6883a0cad7) and adapted to fit current wireshark code (and minus the LTE MAC frame dissector). Change-Id: Iaa1ea8b2d7a3e618f8aa14203449f2c77b4727f5 Reviewed-on: https://code.wireshark.org/review/22515 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-11etypes(.h): fix typoAlexis La Goutte1-1/+1
found by Robert Sauter Change-Id: I8099797ae52bdee512c7dff0423717a5acb2d36f Reviewed-on: https://code.wireshark.org/review/22582 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-07-11QUIC: Add new error code (98) about decompression failureAlexis La Goutte1-1/+4
Change-Id: I6a29e89eb18c737c257953f3dbe98727ad9815e9 Reviewed-on: https://code.wireshark.org/review/22556 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-11IEEE 802.15.4: Revise Payload IE dissectionRobert Sauter2-123/+157
Isolate dissection of individual IEs to capture out-of-bound errors and to continue with next IE on error. More consistent display. Use dedicated HFs and ETTs. More consistent code with fewer casts. Add warning if IE dissection consumes less content than the indicated length. Change-Id: I1481145b9248eaa9f3d3ddf6c0e32d39b4a63861 Reviewed-on: https://code.wireshark.org/review/22577 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11Expand register_decode_as_next_proto to include prompt string.Michael Mann18-226/+42
Many dissectors don't have an identifier to pass to a dissector table. When using Decode As they all have a "value" function that returns 0 just so something is returned. A first step to a cleaner refactor of the functionality is to allow dissectors to provide a "prompt" function when registering Decode As with register_decode_as_next_proto() so that the text exposed in the GUI can vary, but the function that returns 0 (nothing) can be consolidated under decode as registration functionality. This casts a wider net for register_decode_as_next_proto() use. Change-Id: I2995b3c251dae70f5f529b672473d25c6288ed5c Reviewed-on: https://code.wireshark.org/review/22562 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11Promote Expert preference UAT to main preference tree.Michael Mann3-3/+21
"Expert" has been treated as a protocol "internally", but I doubt users would consider it one. Since the only preference is a UAT, just make it its own leaf off of the main preference tree (similar to Filter Expressions UAT) and not have it buried with all of the protocols. Change-Id: I385314d8791440e6ced3dbd71305ee75bc373e52 Reviewed-on: https://code.wireshark.org/review/22580 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-10NBAP: fix Coverity CID 1414728Pascal Quantin2-2/+2
Change-Id: Ib64334f1fa8d7ff92dbfdf9bb805049f687836b7 Reviewed-on: https://code.wireshark.org/review/22579 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-10UMTS FP: Fix access violation in PCH heuristic dissectorDarien Spencer1-4/+12
The dissector was accessing NULL if the first frame in the PCH stream was a control FP. Change-Id: Icdf2fae57436fe59e16ebe0a5233675e7599f5f4 Reviewed-on: https://code.wireshark.org/review/22578 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-10NBAP: Moved all global variables togetherDarien Spencer2-99/+91
Hopefully if they are in one place replacing them with a non-static alternative will be easier Change-Id: I91dd47ea51a1435cea4e68d88d6afe240153fe69 Reviewed-on: https://code.wireshark.org/review/22539 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-10Fix missing geninfo in PDML export.Christoph Wurm1-2/+5
Change-Id: I02b6ff7f57f81f0ac6b54806a9325ebb16b40476 Reviewed-on: https://code.wireshark.org/review/22553 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-093GPP NAS: upgrade dissector to v14.4.0Pascal Quantin3-4/+211
Change-Id: Iae5627a53683de0b359a95c21866513461b5d559 Reviewed-on: https://code.wireshark.org/review/22572 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-09filter_expressions_preferences_frame -> uat_frameMichael Mann6-44/+41
There isn't anything "filter expression" specific about it and there are a few other things that could take advantage of a UatFrame. Change-Id: I0d04d176caebf0c2d8043c3bf89a81668580eae8 Reviewed-on: https://code.wireshark.org/review/22570 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-09Filter expressions: Rename UAT field to make it more obvious what it doesMichael Mann1-1/+1
"Enabling" a filter expression means putting it in the toolbar, so state that. Change-Id: Ifa4ef053cf741a5aa269031e6983c7989ca1e64c Reviewed-on: https://code.wireshark.org/review/22569 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-09Don't use uint_to_str_back when you need guint32_to_str_buf.Michael Mann5-16/+12
It will end up eventually crashing column buffers because memory behind the address is trounced. Change-Id: Id6b5a42effc503e4b8bf5e1deb2135241e2893f3 Reviewed-on: https://code.wireshark.org/review/22563 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-09Add support for dissecting UDT over DTLSSimon Graham4-26/+115
Includes adding per-conversation data to store whether we are over DTLS or UDP and registering as a heuristic sub-dissector for DTLS. Future changes will add more use of the conversation structure. Also included is a capture of UDT over DTLS in test/captures/udt-dtls.pcapng.gz, the associated private key for the session in test/keys/udt-dtls.key and a new test in the decryption suite to check this works. Change-Id: I76826d3b35768d0b58f5335063884616968e5784 Reviewed-on: https://code.wireshark.org/review/22533 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-09ZigBee: fix ZCL configure reporting response parsingJohn Keeping1-10/+30
If configure reporting succeeds for all attributes, then the response contains only a success status byte but if any attribute fails, then every record contains a direction byte and attribute identifier. By handling the "all successful" case specially, add an expert info message to indicate a problem if the message length indicates that we have hit this special case but the status is not "success". Change-Id: I3facae8ac07f1a249cc6ae1b2454f8381151355b Reviewed-on: https://code.wireshark.org/review/22557 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-09packet-dcerpc: move auth information into a subtreeStefan Metzmacher1-0/+31
Change-Id: I0e5d3967a26b79c899b0d219317e2963969cba6b Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/17809 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-09TLS13: Add draft 21 supportAlexis La Goutte1-0/+1
Release July 03, 2017 Bug: 12779 Change-Id: I527e83ccff6901688030dbcaf639878513a2ace2 Reviewed-on: https://code.wireshark.org/review/22564 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-09TLS13: Add Ticket nonceAlexis La Goutte2-1/+31
Add Ticket nonce added on Draft 21 Bug: 12779 Change-Id: I2891e1ffe700d85f703b29feacccdc6dd7ff376d Reviewed-on: https://code.wireshark.org/review/22565 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>