aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2002-07-30#ifdef out some variables not used on Windows.Guy Harris1-30/+32
If printing a single packet to a file, don't use the "print to a printer" code for Windows. Only free "print_args.dest" *after* the last usage. svn path=/trunk/; revision=5913
2002-07-29Code from Jan Berkel <jan.berkel@gmx.de> toUwe Girlich1-13/+541
* fully decode client->server packets (mouse movement, button press etc.) * start of decoding server->client packets (names of first command as text) svn path=/trunk/; revision=5912
2002-07-29From Didier Gautheron: add FPGetUserInfo.Guy Harris1-1/+107
svn path=/trunk/; revision=5911
2002-07-29From Joerg Mayer:Guy Harris1-2/+5
gtk/colors.c: Fix a memleak found by valgrind (Note that there are similar bugs in other functions that use the same construct with path!) svn path=/trunk/; revision=5910
2002-07-29From Joerg Mayer:Guy Harris19-165/+133
All files: - Replace types from sys/types.h by those from glib.h - Replace ntoh family of macros from netinet/in.h and winsock2.h by g_ntoh family from glib.h - Remove now unneeded includes of sys/types.h, netinet/in.h and winsock2.h wtap.h Move includes to the top svn path=/trunk/; revision=5909
2002-07-29Committing Kerberos NetBIOS address type stuff from Jim McDonough.Richard Sharpe1-1/+8
svn path=/trunk/; revision=5908
2002-07-27Changed the SMB dissector to put ALL command PDUs in one SMB in the summaryRonnie Sahlberg1-22/+30
line, separated by ; It only prints "Request"/"Response" for the first command to save space svn path=/trunk/; revision=5907
2002-07-27If conversations have already been created in lower layers, say TCP beforeRonnie Sahlberg1-8/+8
SMB sees the PDU, then SMB would forget to create the proper state variables and crash. SMB is changed to split the operation into 1, only create a conversation if it needs to. (as before) 2, detect if it needs to create the si.ct state variables independant of whether smb also created a conversation or not. Without this patch and with changes to say TCP to create conversations ethereal would crash at the first packet the SMB dissector would see. svn path=/trunk/; revision=5906
2002-07-25From Stefan Wenk: remove an unnecessary +1 from some offsetGuy Harris1-4/+3
computations. svn path=/trunk/; revision=5905
2002-07-25For connection-oriented DCE RPC, show the stub data if we can't actuallyGuy Harris1-2/+18
do anything else with a request or reply (e.g., because we haven't seen the bind request). svn path=/trunk/; revision=5904
2002-07-22Remove trailing space characters between a netbios name and the name type.Tim Potter1-1/+14
This makes the display look much nicer! svn path=/trunk/; revision=5903
2002-07-22Update from Anand V. Narwani:Guy Harris1-6/+54
fix a minor problem in which the Info colum was incorrectly defaulted to "Fragmentation Frame"; add 4 missing fields for the Extended header in Fragmentation frames. svn path=/trunk/; revision=5902
2002-07-21Fix up some comments.Guy Harris1-10/+9
Fix up a call to use the right byte-ordering routine (both routines have the same effect, but we want to use the right one to make it clearer what we're doing). svn path=/trunk/; revision=5901
2002-07-21Mention the "-h" flag.Guy Harris1-1/+6
Fix up the list of arguments to "-S" in the synopsis. svn path=/trunk/; revision=5900
2002-07-21"yyin" is from lex/flex, so it should be "extern", not "static" - weGuy Harris1-15/+19
have to modify lex/flex's input stream, not some private "FILE *". Fix up the usage message to: mention the "-h" flag; not mention the non-existent "-w" flag; fit within 80 columns. Add "-h" to the list of options in the "getopt()" call, as there's code to support it, and remove "-r" and "-w", as there wasn't any code to support them. svn path=/trunk/; revision=5899
2002-07-21Fix the problems WRT overwriting a capture file. From Joerg Mayer.Richard Sharpe1-2/+10
svn path=/trunk/; revision=5898
2002-07-21Offsets in packets should be "int", not "guint8", unless there is anGuy Harris1-3/+3
*inviolable guarantee* that the offset will *never* be bigger than 255. (The same applies for "guint16" and 65535.) Otherwise, you run the risk of an infinite loop (packets are not guaranteed to be valid, nor are the contents of capture files - and there's no guarantee that you're reading a DOCSIS file if you've turned on the "force interpretation as DOCSIS" flag.) svn path=/trunk/; revision=5897
2002-07-20From Anand V. Narwani: fix to the Info column for Request frames.Guy Harris1-3/+3
svn path=/trunk/; revision=5896
2002-07-20From Prabhakar Krishnan: add item to SMB protocol tree for time betweenGuy Harris4-6/+30
request and response. svn path=/trunk/; revision=5895
2002-07-19Include sys/types.h to provide the type size_t, which is neededUwe Girlich1-1/+6
further down in this file but must not be defined yet in the C source, which includes this header file. Example: without this change, packet-dcerpc-samr.c 1.51 could not be compiled under SINIX-M. svn path=/trunk/; revision=5894
2002-07-19From Richard Urwin: fixes for README.plugins.Guy Harris3-9/+16
Combine the two entries for Anand Narwani in the AUTHORS file and the Ethereal man page list of contributors. svn path=/trunk/; revision=5893
2002-07-17Change a "proto_tree_add_uint()" call to use "proto_tree_add_item()".Guy Harris1-2/+3
When dissecting a BYE packet, bump the chunk count when dissecting the SSRC/CSRC identifiers, so the loop terminates properly. svn path=/trunk/; revision=5892
2002-07-17Add an extra argument to "tvb_find_line_end()", which specifies what itGuy Harris19-74/+158
should do if it doesn't find an EOL; if FALSE, it behaves as before, returning values that treat the line as ending at the end of the tvbuff, and if TRUE, it returns -1, so its caller can do segment reassembly until it gets the EOL. Add an option to the SMTP dissector to do segment reassembly, and do segment reassembly of the first line. svn path=/trunk/; revision=5891
2002-07-17From Kan Sasaki:Guy Harris1-64/+210
1. Add some VSAs. 2. Modify the routines match_numval() and rd_match_strval_attrib() to use a null string pointer, rather than a 0 value, to signify the end of the attribute table, because some vendors are using an attribute with a value of 0. 3. Bug fix. svn path=/trunk/; revision=5890
2002-07-17From Joerg Mayer:Guy Harris66-345/+42
dftest.c: Remove #if-0-ed includes packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c, packet-wtp.c, ethereal_gen.py: Remove redundant include varargs (already in snprintf.h, and required only for snprintf.h) Remove unused include of snprintf.h from files not using "snprintf()". svn path=/trunk/; revision=5889
2002-07-17Get rid of some "unused variable" and "unused static function" warnings,Guy Harris3-30/+89
and some compile errors in Tethereal, when compiling without libpcap. If libpcap is missing (whether that's detected at compile time or, as on Windows, at run time), don't call any of the "capture_prefs" routines - the routine to create the capture preferences page wasn't called, so the other routines can try to refer to non-existent widgets and other items and crash. Get rid of the stub routines in "capture_prefs()" used when compiling without libpcap, as they're no longer called. svn path=/trunk/; revision=5888
2002-07-16From Joerg Mayer: add #includes of "snprintf.h" in modules that usedGuy Harris4-3/+16
"snprintf()" but weren't including "snprintf.h". svn path=/trunk/; revision=5887
2002-07-16Get rid of carriage returns.Guy Harris1-43/+43
svn path=/trunk/; revision=5886
2002-07-16Don't allocate structures to remember how to re-access a packet's data,Guy Harris1-12/+27
or the array to hold pointers to those structures, if we're only reading the file sequentially. svn path=/trunk/; revision=5885
2002-07-16From Graeme Hewson:Guy Harris22-157/+285
Allow "-" as the output file name in Wiretap, referring to the standard error. Optimize the capture loop. Fix some of the error-message printing code in Ethereal and Tethereal. Have Wiretap check whether it can seek on a file descriptor, and pass the results of that test to the file-type-specific "open for output" routine. Have the "open for output" routines for files where we need to seek when writing the file return an error if seeks don't work. svn path=/trunk/; revision=5884
2002-07-16From Graeme Hewson:Guy Harris1-6/+3
In sync mode, if the capture file written by the child can't be opened by the parent, ethereal will write two identical popup error messages. This patch fixes the problem. svn path=/trunk/; revision=5883
2002-07-15Update the "NT sucks for PPP capture" note to include NT 5.1 (XP andGuy Harris1-25/+24
.NET Server). Fix indentation. svn path=/trunk/; revision=5882
2002-07-15Added support for dissecting RSVP Bundle MessagesAshok Narayanan1-203/+290
svn path=/trunk/; revision=5881
2002-07-15From Joerg Mayer:Guy Harris1-10/+9
Replace our own definitions of TRUE/FALSE by their glib.h equivalents. Put sys/types.h into ifdefs. svn path=/trunk/; revision=5880
2002-07-15From Joerg Mayer:Guy Harris2-22/+8
Use the GLib macros to convert from network to host byte order. svn path=/trunk/; revision=5879
2002-07-15From Joerg Mayer:Guy Harris1-9/+9
Change struct addr to guint32 which is the way it is used anyway. Use the GLib macros to convert from network to host byte order. svn path=/trunk/; revision=5878
2002-07-15Fix a sample call to add an item to the subtree for a protocol to add itGuy Harris1-7/+17
there rather than to the top-level tree, and use "proto_tree_add_item()". Add a description of PROTOSHORTNAME, and give an example of the way PROTONAME, PROTOSHORTNAME, and PROTOABBREV would be set for a protocol. svn path=/trunk/; revision=5877
2002-07-15The mysterious two bytes were just the FCS. Use the length field fromGuy Harris1-2/+12
the IP header as the reported length again, but make the actual length be the minimum of the length of the tvbuff and the reported length, just to keep from having a weird tvbuff that has more data than the packet has. svn path=/trunk/; revision=5876
2002-07-15Clean up the setting of "id_offset" and "sd_offset"; this fixes a bug inGuy Harris1-68/+46
handling the first few packets in a file. svn path=/trunk/; revision=5875
2002-07-15SMTP and FTP response codes need more than 1 byte, as they can go up toGuy Harris2-6/+6
999; give them 4. svn path=/trunk/; revision=5874
2002-07-15Redo the way random access is handled. Save, for each packet, theGuy Harris1-120/+230
offset of the beginning of the first record containing data from that packet, and the offset from the first byte of data in that record of the first byte of data from that packet; to read a given packet, seek to the offset of the first record, and keep processing packets until we find one with the right direction. This fixes a problem where it wasn't correctly reading the packet, when doing random access, in cases where you have a sequence of records that stop in the middle of a packet. svn path=/trunk/; revision=5873
2002-07-15This seems to fix the problem of trying to save over the top of an existingRichard Sharpe1-9/+12
capture on some occassions. svn path=/trunk/; revision=5872
2002-07-14Add Booleans for the Ack and Srefresh messages, and move the Boolean forGuy Harris1-5/+13
the HELLO message to be in numerical message-code order. svn path=/trunk/; revision=5871
2002-07-14Add a Boolean field for the Bundle message type.Guy Harris1-1/+5
svn path=/trunk/; revision=5870
2002-07-14Clarify the octet-stuffed framing code, by adding comments and by usingGuy Harris1-5/+48
hex values rather than characters in a switch statement. svn path=/trunk/; revision=5869
2002-07-14Make the reported length of the VJ-uncompressed tvbuff the reportedGuy Harris1-2/+2
length of the data in the PPP packet, not the value from the IP header, just in case there's extra crap at the end. (That appears to be the case in at least one pppdump capture filel; that's probably either a bug in the version of pppdump that produced the capture or in the pppdump reading code, but, until we fix that, if we can, let's at least get this right, so that the reported length of the tvbuff won't be less than the length unless that was the case for the tvbuff handed to us.) svn path=/trunk/; revision=5868
2002-07-14From Anand V. Narwani: fix so that when a filter is applied to a DOCSISGuy Harris1-6/+2
management frame, the Info column isn't erased. Replace a call to "tvb_length_remaining()" with the value returned by a earlier identical call. svn path=/trunk/; revision=5867
2002-07-14Only put "smtp.req" into the tree for packets that contain requestGuy Harris1-3/+5
lines, and only put "smtp.rsp" into the tree for packets that contain reply lines; don't put either into the tree for packets that contain only message body text or an EOM. svn path=/trunk/; revision=5866
2002-07-14In FTP, a normal reply line has a 3-digit number at the beginning - aGuy Harris2-39/+115
line that doesn't is a middle line of a multi-line reply. Treat only lines with a 3-digit number at the beginning as reply lines with a response code and response argument. Provide filterable fields for the SMTP command and parameters, and the SMTP reply code and parameters, along the lines of what's done for FTP. svn path=/trunk/; revision=5865
2002-07-13Fix a typo.Guy Harris1-2/+2
svn path=/trunk/; revision=5864