aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-03-31Remove trailing whitespace.Guy Harris1-1/+1
Change-Id: I307f0185c4a82ba3a15b86c38a2431ba5efd9b28 Reviewed-on: https://code.wireshark.org/review/14738 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-31Update URLGuy Harris1-1/+5
Change-Id: I3774e8650557e6ac253fd8c4ad02aead0935326b Reviewed-on: https://code.wireshark.org/review/14736 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-31wslua: avoid memleak on duplicate names for Proto.newPeter Wu1-2/+2
luaL_error never returns, free memory before. Change-Id: Ibcdbdb6afea5d2dab7be6a16c4c2536dcf14220a Reviewed-on: https://code.wireshark.org/review/14734 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-31dtls: Fix ClientCertificateVerify dissectionPeter Wu1-1/+1
Pass the reassembled fragment instead of the current record. Bug: 11477 Change-Id: Id49fac8fa3f9e1b1904a75ab6c7512306f2071b0 Reviewed-on: https://code.wireshark.org/review/14727 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-03-31LPP: upgrade dissector to v13.1.0Pascal Quantin6-106/+213
Change-Id: Ibc7423858906c01023c6b8d0f3da7261747ebf32 Reviewed-on: https://code.wireshark.org/review/14723 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-31[Nettrace] Add parsing of some HSS records.AndersBroman2-11/+139
Change-Id: I7c2f6ebdb20f90533ee008e1b4557ef27d4672dc Reviewed-on: https://code.wireshark.org/review/14708 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-31Fix byte pane not showing up in Packet dialogPeter Wu1-2/+6
When a packet dialog is being constructed, the layout is apparently not fixed yet and the byte view is technically not visible. Fix the hidden byte pane by not hiding it when it is not (yet) visible. Bug: 11760 Change-Id: I0494fa16a5ed89ff31f934ba682a6bb884cc0e2e Reviewed-on: https://code.wireshark.org/review/14713 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-31replace dangerous tvb_get_ptr with safer string function.Jaap Keuter1-2/+2
Using tvb_get_ptr to get a string is always dangerous in the face of malformed packets. Instead using string functions allow for safe handling of these. Bug: 12242 Change-Id: I059c186032492aae9c90a69858ea3fc59e21313f Reviewed-on: https://code.wireshark.org/review/14714 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-31Add a NULL check: it's not sure we have a radius_call here.Jeff Morriss1-1/+1
Change-Id: I6037a02e6170d0ca8b978135f960213ed22bef97 Reviewed-on: https://code.wireshark.org/review/14710 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-31Revert "Trun on -Wused-but-marked-unused but only as warning, never as ↵Alexis La Goutte1-3/+0
error. (possibly clang only)" This reverts commit 9f40a75bbb9ea8e205bf0ebf9f0651971417cd6e. Change-Id: I4361f1101077643d10a86237e256ba28ed180a66 Reviewed-on: https://code.wireshark.org/review/14721 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-31Ensure our fields are registered before starting dissection--even when !tree.Jeff Morriss2-13/+14
(The check to ensure the delayed field registration had been done was still wrapped inside an if(tree) but a bunch of proto_add_*()'s had been pulled out from under if(tree)'s thus causing some hf's to be used before registered.) Also simplify the code to ensure the fields are registered since we're doing it potentially many times per frame: do an integer comparison rather than looking up an hf by name. Add a note to the docs for proto_register_prefix() to make it clear that the initializer routine may not be called before the dissector is asked to dissect something. Change-Id: I5dc1154638a290c3a94149184d56570c3abb836a Reviewed-on: https://code.wireshark.org/review/14711 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-31Correct 6LoWPAN NHC datagram size calculationsKevin Bracey1-2/+2
Length calculations updating "remaining datagram size" for fragmented 6LoWPAN packets with NHC headers were incorrect if there was any elided option padding. The current header's unpadded length was subtracted from dgram_size, when it should have been the padded length - the datagram size is uncompressed IPv6. This meant the final nhdr_list entry created to represent the remaining payload would have its "reported" field too large. Most visible result of this was that the IPv6 payload length written into the packet by lowpan_reassemble_ipv6() was too large. Error probably went unnoticed because the most typical 6LoWPAN options don't need padding - the RPL option is 6 bytes, and the MPL option is 6 bytes if using 16-bit seeds, making the HbH extension header an aligned 8 bytes. Bug: 12310 Change-Id: If94e9ca57f88c4ac41f002a689ce1da7097b5bd0 Reviewed-on: https://code.wireshark.org/review/14701 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-31Squelch a "not allowed in C++" warning.Guy Harris1-1/+1
Change-Id: I2accdb7fe02072853a5ec9cae84403f3224dfada Reviewed-on: https://code.wireshark.org/review/14718 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-31Clean up some stuff.Guy Harris1-22/+23
Have bin2hex() wmem_allocate the buffer, so it can be used the same way that tvb_get_string_enc() is used. Don't bother checking whether NIBBLE_2_ASCHEX() returns an ASCII hex digit character or not - it returns either a value in the ASCII range of '0' through '9' or in the range 'A' through 'F', all of which are ASCII hex digits. Fix get_bit() to set *length to 0 if the string we're returning is empty. Change-Id: Id331cfd0ab34d45892f98d228dc793a1e93d84e5 Reviewed-on: https://code.wireshark.org/review/14717 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-30Install GNU autotools even on Snow Leopard.Guy Harris1-6/+5
The Snow Leopard versions are too old for current Wireshark. Change-Id: I25936370164d69d6b0eaca4ac9e3253772e0ac73 Reviewed-on: https://code.wireshark.org/review/14712 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-30RTPS: Fixed ACKNACK mask processingJuanjo Martin1-1/+1
Change-Id: I81a83638c2318ba0d806263dbf692cd19b30ce9b Reviewed-on: https://code.wireshark.org/review/14707 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-30RTPS: Now PID_ENTITY_NAME and PID_ROLE_NAME use different filtersJuanjo Martin1-2/+10
Change-Id: I852aa09bff6a37ef03b5f55bdf8933ed181da2d0 Reviewed-on: https://code.wireshark.org/review/14705 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-30SPOOLSS: Try to avoid an infinite loop.Gerald Combs1-2/+3
Use tvb_reported_length_remaining in dissect_spoolss_uint16uni. Make sure our offset always increments in dissect_spoolss_keybuffer. Change-Id: I7017c9685bb2fa27161d80a03b8fca4ef630e793 Reviewed-on: https://code.wireshark.org/review/14687 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-30TCP: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-10/+1
packet-tcp.c:2155: warning: Value stored to 'relseq' during its initialization is never read packet-tcp.c:3511: warning: Value stored to 'assignedMetaId' is never read packet-tcp.c:3514: warning: Value stored to 'assignedMetaId' is never read Change-Id: I68d8088fc54da5ad52361510d43b893e58bf419f Reviewed-on: https://code.wireshark.org/review/14695 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Matthieu Coudron <matthieu.coudron@lip6.fr> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-30Qt: fix buffer alarm threshold parameter retrieval in multicast statistics ↵Benoit Grange1-1/+1
dialog Bug: 12309 Change-Id: Id67b676bfcb5b4497c48d4cd7ca7c8cc1cbda986 Reviewed-on: https://code.wireshark.org/review/14704 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-30[GSM MAP] Introduce dissector tables to be able to dirrectly call MSGAndersBroman3-10/+69
Arguments. Change-Id: I7e51e2a2b9fa98cf8ca44fb528f49aeae46d9b7c Reviewed-on: https://code.wireshark.org/review/14703 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-30Fix a typoPascal Quantin1-1/+1
Change-Id: I206c3f8ec860e92dce3f43b05f6695347d15398a Reviewed-on: https://code.wireshark.org/review/14706 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-30ws_load_library() is called with constant char reflect that.MSVC15 build.AndersBroman2-2/+2
Change-Id: I7d103c7316ee372b5cdb3aa9033a62eb75cd38b2 Reviewed-on: https://code.wireshark.org/review/14702 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-30Add support for National Language tables in GSM UDIgnacio Martínez1-1/+79
Change-Id: Idc375b468754ac1287401ebfb88f77a40f747a79 Reviewed-on: https://code.wireshark.org/review/14698 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-30Remove not needed initialisation breaking MSVC 15 nmake build.AndersBroman1-1/+0
Change-Id: Ia486209a8eef5bf02b5b3f6d793698c4cc802dc9 Reviewed-on: https://code.wireshark.org/review/14699 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-30make-taps.pl: Fix generated code indentationJoão Valverde1-8/+11
Change-Id: Ife25c519acb56b58819bc1aabfa069b5fbbc788d Reviewed-on: https://code.wireshark.org/review/14676 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-29[Exported PDU] Add the abillity to use dissector tables from the file.AndersBroman2-20/+84
Change-Id: I51ac8ce56641cf6eeda18c2a3f6d6952d3126415 Reviewed-on: https://code.wireshark.org/review/14693 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-29TCP: Remove double semicolonAlexis La Goutte1-1/+1
Change-Id: I77f96cfee089b8e6a26504279c7a6cd4b6e36a5c Reviewed-on: https://code.wireshark.org/review/14696 Reviewed-by: Matthieu Coudron <matthieu.coudron@lip6.fr> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-03-29EPL: Fix segmented transfer complete detectionChristoph Schlosser1-53/+96
In case of a segmented SDO transfer, the transfer complete response can contain additional data that should not be evaluated by the dissector. Change-Id: I7016eb88b93aac8c318e703fe60a90c3adbf9eeb Reviewed-on: https://code.wireshark.org/review/14692 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-03-29Remove an unused variable from both the Gtk and Qt UIs.Jeff Morriss2-18/+2
Change-Id: I4c7c5aeaa1fa452605cf02a5c86dfe161c451f65 Reviewed-on: https://code.wireshark.org/review/14654 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-03-29Update min. GLib version and add Qt version checksJaap Keuter1-5/+5
The document describes why and how to version check, but 1) is not up to date with respect to minimum GLib version 2) does not yet mention Qt version requirement and check. This change addresses both issues. Change-Id: Ibb56c02cf48f6a4c6270b20686ca4d6e8aaf99d1 Reviewed-on: https://code.wireshark.org/review/14669 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-03-29Use "old-style" moc options to ensure backward compatibility for Qt toolsJoão Valverde2-3/+6
Change-Id: Ic96df4ba521e0fbaf4ac34f23e3a89304ed5de5c Reviewed-on: https://code.wireshark.org/review/14662 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-29Add GLib version info to configure status messageJoão Valverde1-1/+2
Change-Id: I279996e6713cad809a9487a83dc9692e7673f604 Reviewed-on: https://code.wireshark.org/review/14663 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-29configure.ac: Fix bogus variable nameJoão Valverde1-4/+4
Change-Id: Iaca06400a337340b679f4b017103f28af7155535 Reviewed-on: https://code.wireshark.org/review/14684 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-29configure: fix cache var handlingMike Frysinger1-16/+15
Need to use the AC_CACHE_CHECK macro in order for the cache vars to be loaded+checked, otherwise the vars here are just plain variables. This also allows people to control the various tests when cross-compiling. Bug: 9912 Change-Id: I119eb87807098c84520954dd34cbd0ddd1b6ccb0 Reviewed-on: https://code.wireshark.org/review/14683 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-29Fix modeline definitionsPeter Wu3-6/+6
Fix mismatching emacs and vi modelines. Change-Id: I5cab8c5b7692746a5fa731c977cef903ad19a6f6 Reviewed-on: https://code.wireshark.org/review/14688 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-03-29GSM CBCH: fix an out of bounds accessPascal Quantin1-6/+6
As explained by Guy, we should use new_slots[i] and not new_slots[k] Bug: 12278 Change-Id: Ifae44f9d5948bed5c4ee0442510724016e307dee Reviewed-on: https://code.wireshark.org/review/14678 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-29Another round of extcap memleak fixesPeter Wu5-66/+97
Fix a bunch of memory leaks, mainly because extcap_base_cleanup is not called on most execution paths and because memory allocated for options were not freed. Additionally, randpkt will now fail if no option is given (it previously returned 0 if --capture was missing). Logic using "goto" is introduced with the idea that a program should fail (ret = EXIT_FAILURE) unless proven otherwise. Now none of the extcap programs are leaking: for what in ssh cisco; do for arg in '' --help --extcap-interfaces --extcap-interface=$what; do extcap/${what}dump $arg; done; done ./tshark -D Change-Id: I6df1027ed0c32bd53fe87e6c54d355bc8ddd01f5 Reviewed-on: https://code.wireshark.org/review/14671 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-03-29Assorted cleanups.Guy Harris1-17/+29
1) Handle the ASCII and Unicode magic numbers the same way - as static const char arrays. Note that Unicode specifically means little-endian UCS-2 (or UTF-16, but they probably use few if any characters outside of ASCII, much less the Basic Multilingual Plane). 2) Treat all seek errors as open errors rather than "not my file type". 3) Fix capitalization of "Unicode". Change-Id: I47b7e057ccada00347499a6b17f8f8fc44e7c503 Reviewed-on: https://code.wireshark.org/review/14689 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-28Trun on -Wused-but-marked-unused but only as warning, never as error.Joerg Mayer1-0/+3
(possibly clang only) Change-Id: I014b8f069515af6128177dfc5813380db445957c Reviewed-on: https://code.wireshark.org/review/14686 Petri-Dish: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix out-of-tree "gen-authors" targetPeter Wu3-11/+10
Change directory to the source tree before invoking `git shortlog`, otherwise it fails on build directories outside the source tree. Alexis suggested to move the git invocation to the perl script, this is done now and also avoids writing AUTHORS.git in the source tree. Change-Id: I5905ebf40d8d32a586c88671b52f28c542ca33ba Reviewed-on: https://code.wireshark.org/review/14660 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-03-28Fix -Wused-but-marked-unused warning/errorJoerg Mayer1-1/+6
Change-Id: I9e0a6766aa443907505889e392ea9a7d6c07b94b Reviewed-on: https://code.wireshark.org/review/14685 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix more -Wused-but-marked-unused warnings/errors.Joerg Mayer26-138/+138
Change-Id: Ieb3e70a23c1a55b7ba60b1b32f159341adfe65b7 Reviewed-on: https://code.wireshark.org/review/14682 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28configure: fix non-POSIX testMike Frysinger1-1/+1
The == operator is not in POSIX -- it's an extension some shells support. Change-Id: Idb2be90307de783b4220cc7d91222b462c98dee4 Reviewed-on: https://code.wireshark.org/review/14680 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-28wslua: handle parameters with const keyword when generating tapsPascal Quantin1-0/+2
Change-Id: I46148b6454a501035d86fa8f1eb767687f68aa42 Reviewed-on: https://code.wireshark.org/review/14670 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-28Qt: Make conversation menu items static.Gerald Combs14-105/+323
Add a ConversationAction and ColorizeAction classes which respectively handle conversation filtering and colorization. Move conversation menu initialization to initConversationMenus and call it once at startup. This keeps us from leaking quite a bit of memory each time we select a packet or proto tree item. Bug: 12044 Change-Id: I32e8cedaba08a419d5da6a7a9db31c910909f450 Reviewed-on: https://code.wireshark.org/review/14516 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-03-28Fix warnings/errors of type -Wused-but-marked-unusedJoerg Mayer15-24/+34
Change-Id: I34c2d9953272822da0745d1b24c64d8466e43b37 Reviewed-on: https://code.wireshark.org/review/14668 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix some warnings/errors of typeJoerg Mayer25-179/+143
git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used [-Werror,-Wused-but-marked-unused] proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown")); ^ Added manual change id because file-jpeg.c forced the use of commit -n Change-Id: Iffff53d6253758c8454d9583f0a11f317c8390cb Fix warnings/errors of type: git/epan/dissectors/packet-ax25-kiss.c:205:52: error: 'pseudo_header' was marked unused but was used [-Werror,-Wused-but-marked-unused] return capture_ax25( pd, l_offset, len, cpinfo, pseudo_header ); Fix checkhf warnings: Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_netswitch Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_subswitch Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_poll_reply_trailer Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_rdm_universe Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_tod_data_universe Change-Id: Id1fa12afb97a8e9cd4ed0ea25351c3b2639c930e Reviewed-on: https://code.wireshark.org/review/14667 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix some warnings/errors of typeJoerg Mayer12-14/+38
git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used [-Werror,-Wused-but-marked-unused] proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown")); ^ Added manual change id because file-jpeg.c forced the use of commit -n Change-Id: Iffff53d6253758c8454d9583f0a11f317c8390cb Reviewed-on: https://code.wireshark.org/review/14666 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28NAS EPS: add a missing breakPascal Quantin1-0/+1
Change-Id: I71a32b831cdb8d7d07e48cabe2c6cd7204968c28 Reviewed-on: https://code.wireshark.org/review/14665 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-24 04:26:41 +0000