aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-12-13cmdline: cleanup option string definitionsJaap Keuter3-10/+10
Option string composition has grown organically over time and is depending on compilation options also. This results in somewhat complex macro definitions and the use of the string concatenation feature of the C compiler. This change tries to clean up some of this magic by removing definitions of empty strings and merging of adjacent strings. Change-Id: I968449ea9b564915bee468a0cac0e114983ceebe Reviewed-on: https://code.wireshark.org/review/35429 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-13m3ap: Info column lost at filtering.Anders Broman2-13/+9
Remove if (tree) Change-Id: I1bb38fd8cdea85e026837ea1dc9bcd72b7432f1e Reviewed-on: https://code.wireshark.org/review/35430 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13DCERPC: Add dissect_hresult helperGünther Deschner2-0/+27
Guenther Change-Id: I62bac46ac43189f7ea07aacf19147d85f6649a5d Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/35423 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13H.264: add dissection of SPS with seq_scaling_matrix_present_flag equal to 1.Xiaoxia Lang1-26/+37
H.264: fix dissection of se(v). Change-Id: I38ad153a3f8860726ea3f430433f5202f534a5fa Reviewed-on: https://code.wireshark.org/review/35419 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13html2text: Skip generating footnotes for self-links.Gerald Combs1-0/+4
Fixes the issue described at https://www.wireshark.org/lists/wireshark-users/201912/msg00003.html Change-Id: Ie3fd338ab1c6b216b05eeca002545868d3474bbb Reviewed-on: https://code.wireshark.org/review/35426 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13Uncrustify: Remove newline between for and braceOrgad Shaneh1-1/+1
Change-Id: Ib89a159bbc7125b3afcfd72d1a218cb6d7c4af39 Reviewed-on: https://code.wireshark.org/review/35421 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-13Uncrustify: Add spaces between else and bracesOrgad Shaneh1-0/+9
Change-Id: Ida8f8638ee226b99804293158e57f4be7a045be8 Reviewed-on: https://code.wireshark.org/review/35420 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-12PER: Add a couple of NULL checks.Gerald Combs1-3/+8
Check for NULLs in a couple of places found by scan-build. Fix a typo. Change-Id: Idde75db6031fa9f2ffa36b7fa10b37bf676e0904 Reviewed-on: https://code.wireshark.org/review/35427 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-12pcfp: add missing Usage Report Trigger indicationJoakim Karlsson1-0/+8
Oct7, Bit 2: TEBUR Change-Id: If3668ba53b163c692fe81163c5e895fcd38b9539 Reviewed-on: https://code.wireshark.org/review/35422 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-12couchbase: Fix Dead StoreAlexis La Goutte1-1/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Icd18de17e7564b946ea177df252dffd2370ff1a0 Reviewed-on: https://code.wireshark.org/review/35408 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-11NAS 5GS: fix LADN Indication ID in Registration RequestPavel Strnad1-1/+1
Change-Id: I46df64d47144eb943e8feee192d9bacb137b22c5 Reviewed-on: https://code.wireshark.org/review/35410 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-11Qt: Add some null checks.Gerald Combs2-13/+24
Add some null checks identified by scan-build. Switch some dynamic_casts to qobject_casts. Change-Id: I2b97ee8cb71db4fc883b4081568f9a5db8af85b3 Reviewed-on: https://code.wireshark.org/review/35403 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-11CMake: Fixup a variable in FindLZ4.cmakeGerald Combs1-1/+1
Set "LZ4_PDB" instead of "LZ4_pdb" in FindLZ4.cmake so that CMake 3.16 will convert "${LZ4_DLL_DIR}/${LZ4_PDB}" to the full path to the LZ4 .pdb instead of its parent directory. This in turn ensures that we don't pass a directory as a source argument to `cmake -E copy_if_different`, which causes it to crash. Bug: 16271 Change-Id: Id6f37584379bd07bc929bc5cb5e80cbe60a3c77e Reviewed-on: https://code.wireshark.org/review/35400 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-11radiotap: Detect 11ad based on the frequency.Guy Harris1-2/+22
This works around the lack of a defined radiotap field for 11ad. Bug: 16272 Change-Id: Ia851c644aee52ff9a138a36b16015d4112b5bf92 Reviewed-on: https://code.wireshark.org/review/35401 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-12-10Windows: update c-ares 1.15.0 packagePascal Quantin1-4/+4
Library was regenerated using g000e963fff596d817d03f366cd49b1fd2d6ec961 to have the proper version info. Change-Id: I33f26d70ba1ea244aa467e5121b6fb586d8ebd8a Reviewed-on: https://code.wireshark.org/review/35398 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-10LNET: fix malformed packet error on RDMA Read RequestJorge Mora1-1/+1
Check the number of remaining bytes before comparing the next four bytes to the LNet magic number to find out whether or not this is an LNet layer. In the case for an RDMA Read Request which does not have any payload data, the LNet dissector now gracefully will not process this packet as an LNet layer instead of labeling it as a malformed packet. Bug: 16269 Change-Id: I5d6abea8b79619849e8fbc1bc6b585995736b56e Reviewed-on: https://code.wireshark.org/review/35392 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-12-10Revert "extcap: Pass --extcap-version if extcap supports it"Gerald Combs2-66/+20
This reverts commit 9910d8c913d2a1874c7f98ef3bf3ad2921dd67e4. Reasons for revert: - We need to improve the reliability of extcap-version=x.y detection. - WSDG_chapter_capture.adoc needs to be more clear about extcap-version=x.y support. - Our extcap utilities need to be updated. Change-Id: Ic8dd2018489f5ec03c35b18e6b09faf69defd59b Reviewed-on: https://code.wireshark.org/review/35393 Reviewed-by: Rafał Kuźnia <rafal.kuznia@protonmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-12-10More Qt minimum version updates.Gerald Combs6-142/+77
Update the minimum version in various documents. Remove some no-longer-needed code from scripts that call windeployqt. Change-Id: I16da4bced9780c9f1b1969aae7c52e2fce1968aa Reviewed-on: https://code.wireshark.org/review/35391 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-10Qt: Remove a comment.Gerald Combs1-4/+0
Remove a comment that's no longer relevant as of g14e4759b56. Change-Id: I919631810c37e34ebc0cf5b78ab4dfbee5f5c687 Reviewed-on: https://code.wireshark.org/review/35390 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-10ZigBee: Maintain APS extended counter for nodesKenneth Soerensen2-47/+65
Each node maintains one APS counter and not one per conversation. Therefore, remove the conversation handling and maintain the counter for each node instead. Bug: 15021 Change-Id: I3a225db008f5dd716246674aafb9d3d04c7d402f Reviewed-on: https://code.wireshark.org/review/35371 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-10btatt: check the opcode against the current data.Dario Lombardo1-22/+30
While here: - some indentation fixes - add defines for missing ATT_OPCODEs Bug: 16258 Change-Id: I2cd8172bcff9c209bbddc4729573c008a8e81fec Reviewed-on: https://code.wireshark.org/review/35339 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-10extcap: Pass --extcap-version if extcap supports itRafał Kuźnia2-20/+66
This change makes the --extcap-version argument to be passed to the extcap script, if it is supported. If the extcap fails with --extcap-version argument, it is treated as legacy and will not receive the additional argument in all subsequent runs. Change-Id: I279aa38d9f39ed85ccb84ba2c09dd93a0492ca51 Reviewed-on: https://code.wireshark.org/review/34914 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-10Qt: Bump our minimum Qt version from 5.2. to 5.3.Gerald Combs5-16/+2
Change-Id: Id6b39125a56b95b94d6a0bb6436bf7b2d131f924 Reviewed-on: https://code.wireshark.org/review/35385 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-10Win32: Remove win32_save_as_statstree.Gerald Combs2-84/+0
win32_save_as_statstree was GTK+-only. Change-Id: Ief029cd1a702b0c17d9602bee8a2d75ee4c3c393 Reviewed-on: https://code.wireshark.org/review/35384 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-10Win32: Fixup our file dialog titles.Gerald Combs4-20/+27
Add a "title" argument to each of the Win32 file dialog routines, and pass in one constructed using wsApp->windowTitleString. Change-Id: I5ff862bd28cd16093d99ae1559ecbaca907350da Reviewed-on: https://code.wireshark.org/review/35383 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-10Qt: fix wrong checks.Dario Lombardo2-2/+2
If actions_ is NULL, it will be dereferenced in the next check. Found by clang. Change-Id: I11f1620fae0e330dbbb7e0cc57b398f473261899 Reviewed-on: https://code.wireshark.org/review/35373 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-10Win32: Remove some unused code.Gerald Combs1-122/+3
Remove some code that's been #if 0'ed out since 2006 and 2012. Include file.h instead of globals.h. Change-Id: Ib4a84c03e112d732b25df4b7b26b54e029f717a4 Reviewed-on: https://code.wireshark.org/review/35378 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-10Win32: Factor out win32_check_save_as_with_comments.Gerald Combs3-115/+9
Stop using win32_check_save_as_with_comments and just use the Qt equivalent on Windows. It started out as a static funtion in file_dlg_win32.c and using the native Windows event loop may have been required for GTK+, but neither of those apply now. Change-Id: I66d7f1c6346df65b0fadb3aa9cba823c0e457703 Reviewed-on: https://code.wireshark.org/review/35382 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-09NGAP: catch NAS 5GS dissection errorsPascal Quantin3-130/+154
This is useful when the NAS 5GS heuristic to decode 5G-EEA0 packets does a false detection, so as to dissect the rest of the NGAP PDU. Change-Id: I4eaa3caf06e0ed8923795470a2def7a73438110e Reviewed-on: https://code.wireshark.org/review/35380 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-09M3AP: Update to TS 36.444 V15.0.0 (2018-09) (No change except to ref)Anders Broman7-29/+29
Change-Id: I4d74b7d45058b620e653a22fc4b0c7501ba425dd Reviewed-on: https://code.wireshark.org/review/35377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-09pfcp: add warning of faulty FO flagJoakim Karlsson1-1/+15
* add warning of faulty FO flag * corrected offset of length extraction Change-Id: Ia5fcec64f5269a48f04999febdcee6076f50313d Reviewed-on: https://code.wireshark.org/review/35372 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-09RPC-over-RDMA: add reassembly of SEND first, middle and lastJorge Mora1-3/+86
Linux uses SEND first, middle and last for small NFS reads instead of using the write chunk list. Reassembly is done using the PSN (packet sequence number) to order the segments in case one or more segments are sent out of order. Reassembly uses a single message id per each direction of a given conversation so it is tied to the destination queue pair. Also, the PSN given in the SEND First packet is used as a base so fragment numbers are relative and start at zero. Furthermore, a previous incomplete reassembly is thrown away in the SEND First packet so any fragments previously added to the reassembly table are not included in the current reassembled message. Bug: 16225 Change-Id: I8de6a3123676e348d8e893f0f67d4b3ba38db27f Reviewed-on: https://code.wireshark.org/review/35224 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-09WSUG: Export, packet range+format, and other IO chapter updates.Gerald Combs11-176/+275
Add an "Export Specified Packets" section. Update the "Export Packet Dissections," "Packet Range," and "Packet Format" sections. Update some markup and text throughout the chapter. Change-Id: I7b7c6fcc41c4fdc684c86a34364ed9baa5123d15 Reviewed-on: https://code.wireshark.org/review/35359 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-09pfcp: Update to 3GPP TS 29.244 V16.1.0Joakim Karlsson1-95/+412
Change-Id: Iccc98a8f33d6de0ec466404a4f728442c8a58ea0 Reviewed-on: https://code.wireshark.org/review/35340 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-08TTLs are unsigned; format them with unsigned_time_secs_to_str().Guy Harris1-6/+6
Change-Id: I489c981e02b2ed0331981003777a5de54ba8221f Reviewed-on: https://code.wireshark.org/review/35367 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-12-08dns: Unify display of TTL with time_secs_to_str()Stig Bjørlykke1-3/+2
Use same format for "Time to live" as for other ttl values by appending the time_secs_to_str() output to the number of seconds. Ping-Bug: 16263 Change-Id: Ie55bbf27bf9c44554d391b395d23c478ad401d98 Reviewed-on: https://code.wireshark.org/review/35358 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-12-08SMB2: IOCTL response dissector minor fixesVolodymyr Khomenko1-3/+3
Fixed names of few reserved fields according to MS spec See [MS-SMB2] 2.2.32 SMB2 IOCTL Response Change-Id: I92926b93dd5086559b124497136e0c5979ab37aa Reviewed-on: https://code.wireshark.org/review/35342 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-08dns: Bring back TTL formatted with time_secs_to_str()Stig Bjørlykke1-1/+3
Display time to live as formatted by unsigned_time_secs_to_str(). This was removed in g42c52d8612 but the commit message for that change was "Add more filterable fields around EDNS(0)", with no indication of this change. Bug: 16263 Change-Id: Ic21f4a4b18d15efbd770c708e37d6e0c15eee6ce Reviewed-on: https://code.wireshark.org/review/35355 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-08Bugfix SMB IOCTL response with BUFFER_OVERFLOWVolodymyr Khomenko1-1/+2
In case if SMB IOCTL response packet (seen to happen for FSCTL_PIPE_TRANSCEIVE but applicable for others) has STATUS_BUFFER_OVERFLOW status code, dissection is done improperly (wrong offset to IOCTL response body is calculated so content is corrupted). Packet body with STATUS_BUFFER_OVERFLOW status should be handled in the same way as STATUS_SUCCESS packet. Bug: 16261 Change-Id: I05d05ed9fa16f8b128590cd505fe9b0270dd74ab Reviewed-on: https://code.wireshark.org/review/35341 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-08s7comm: Add decoding of some more SZL indicesThomas Wiens1-502/+2590
Add the decoding of some more SZL indices, so that all of the most common used SZL indices which occur in normal use are decoded. Also some fixes and extensiond of existing SZL indices. General code style cleanup, where unneccessary comments, blank lines and commas are removed. Change-Id: Ic7abfbe1cf3b9aa31380433d3286d111340a3893 Reviewed-on: https://code.wireshark.org/review/35335 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-08WSUG updates.Gerald Combs15-230/+150
Update a few screenshots and associated text. (The file open, save as, and merge images date back to the Ethereal era!) The interface options dialog no longer exists, so remove that screenshot and text. Mark GTK+ and outdated images as such in CMakeLists.txt. Change-Id: Ia01788434a1c96dd3f527c9d4ae34b1ca30f92d7 Reviewed-on: https://code.wireshark.org/review/35345 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-08Win32: Fix the Export Packet Dissections dialog title.Gerald Combs1-1/+1
Change-Id: I25c40511b369ce93e1be2887488fc5389fdafd07 Reviewed-on: https://code.wireshark.org/review/35346 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-08[Automatic update for 2019-12-08]Gerald Combs14-770/+3402
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0e2ac1a7ba3c512926a8a66255416ef74dc59591 Reviewed-on: https://code.wireshark.org/review/35348 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-07Docbook: Updates for Windows 7 and macOS.Gerald Combs3-34/+42
Update some of the FAQ and WSUG content for Windows 7's impending demise. Add supported releases for macOS and other updates. Change-Id: I5741ac631f39803fa060e9f5c2006a75cb54136f Reviewed-on: https://code.wireshark.org/review/35333 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-07Make the TTL field unsigned, but keep warning if the high-order bit is set.Guy Harris1-6/+44
See RFC 2181, section 8 (and RFC 1035 erratum 2130, which notes that section 3.2.1 says the TTL is signed but section 4.1.3 says it's unsigned); RFC 2181 section 8 says "unsigned, but avoid sending values that have the uppermost bit set, and treat values with the uppermost bit set as a value of 0". (STD 13 = RFC 1034, the "concepts and facilities" DNS RFC, plus RFC 1035, the "implementation and specification" DNS RFC.) Change-Id: I9be6ac4f190f62dafbc45d1923a95f8f21306a7d Reviewed-on: https://code.wireshark.org/review/35343 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-12-06recent.c: cfield might be NULLJim Young1-2/+6
Avoid crash in GUI when using Edit Column widget. Bug: 16245 Change-Id: Ic98be3f98144dcfa9796fadd142180e3aaf84a9e Reviewed-on: https://code.wireshark.org/review/35301 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Craig Jackson <cejackson51@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-06WSUG: Add a Wireless menu section.Gerald Combs6-7/+29
Add a section for the Wireless menu. Remove some unused images. It doesn't look like we ever used ws-*-preferences.png. They had ENTITY definitions in the original XML, but those weren't referenced anywhere. Change-Id: I7f027b48ef22c8680f6224f189d4e9d0bd8114c0 Reviewed-on: https://code.wireshark.org/review/35328 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-06tools: use better operators in package scripts.Dario Lombardo4-13/+13
Change-Id: I1de75829de5f77fa5fe6c8715b1df76148937bc5 Reviewed-on: https://code.wireshark.org/review/35326 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-12-06UDS: fix uds.rdbi.data_identifier filter lengthPascal Quantin1-1/+1
Bug: 16256 Change-Id: Icd4b04193f9ad858859de84cf2bddc6e46c5e1a7 Reviewed-on: https://code.wireshark.org/review/35329 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-06cirrus-ci: increase tasks timeout.Dario Lombardo1-0/+1
Ref: https://cirrus-ci.org/faq/#instance-timed-out Change-Id: I534404d943e29bb110ac2895c7d10df9c483fa1c Reviewed-on: https://code.wireshark.org/review/35325 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-01 16:41:03 +0000