aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-09-11Go back to using a #pragma directly.Guy Harris2-12/+26
See if *that* prevents us from failing with a warning; -Wno-error=unused-function doesn't seem to do the trick. Change-Id: If2dec4ca70451670d0181c6cd0c7bc714e856c95 Reviewed-on: https://code.wireshark.org/review/29613 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11More selectively prevent warnings from becoming errors.Guy Harris1-16/+20
Always use -Werror if it's supported, even with Apple's llvm-gcc, and only use -Wno-error= with llvm-gcc. Use -Wno-error= with all the errors we get in the buildbot. Change-Id: I6797f064d2d354f979e24fcb04f592e9313af721 Reviewed-on: https://code.wireshark.org/review/29612 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11Revert "Make versions of DIAG_OFF() and DIAG_ON() for GCC 4.2 through 4.5."Guy Harris1-72/+14
This reverts commit f6b8bc39c66c878ff25a4f48fff382f8775a2711. Reason for revert: prior to 4.6 or so, the pragmas didn't work as well, e.g. they couldn't be used inside a function; we depend on them being usable within a function. Change-Id: I7a7a0c08a2aca553233c237b8b6c43115095804e Reviewed-on: https://code.wireshark.org/review/29610 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11Don't use -Werror with llvm-gcc.Guy Harris1-3/+13
Apple's llvm-gcc appears not to support suppressing warnings with pragmas, so, if we're building on a Mac (we check for APPLE), and we're not using Clang, we don't turn on -Werror, because we rely on those pragmas to suppress otherwise-unremovable warnings in order to build warning-free. Change-Id: I43bd1ab42918c6ba22643b4a2d4cc3618c25434b Reviewed-on: https://code.wireshark.org/review/29609 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11ieee80211: Fix Dead Store (Dead assignement/Dead increment) Warning found by ↵Alexis La Goutte1-1/+1
Clang Change-Id: I27c82383987aa4da3bf86c5abc0d467252be5c80 Reviewed-on: https://code.wireshark.org/review/29599 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-11ieee80211: Fix some issues with the D3.0 support.Richard Sharpe1-7/+10
The ieee80211ax D3.0 support got merged accidentally with some issues. This fixes the remainder of those issues. Change-Id: I2a3a427e04cb1dca076fd761458de92d4d5e0df2 Reviewed-on: https://code.wireshark.org/review/29602 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-11QUIC: Remove draft-10 supportAlexis La Goutte1-143/+40
Bug: 13881 Change-Id: I11270c6be4304a5d37216cb2e09ae0d4149091b0 Reviewed-on: https://code.wireshark.org/review/29603 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-11nas5gs: 9.10.4.7 PDU address. IPv6 type is a 8 byte link local address.AndersBroman1-6/+11
Change-Id: Ic83fd7fe2480946201732b38f42596f346ba48f5 Reviewed-on: https://code.wireshark.org/review/29601 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-11Diameter: add ALU AVP 1016Pascal Quantin1-5/+11
Bug: 15129 Change-Id: I10114219841af8fe9789e03dbc29198ed4b5830e Reviewed-on: https://code.wireshark.org/review/29598 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-09-11Some older compilers don't allow diagnostic pragmas inside a function.Guy Harris1-3/+2
Change-Id: I7ed32cfdd1c7a308acf5ef2cca9fde28dda5563e Reviewed-on: https://code.wireshark.org/review/29600 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11Qt: Replace $HOME with ~ in window title %F variableStig Bjørlykke1-15/+30
Replace $HOME with ~ in window title %F variable. Optimize code to check if variable is used before doing replacement. Change-Id: I95ef8505e50379d98fdb1661e09394d1ded7ecca Reviewed-on: https://code.wireshark.org/review/29597 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-09-11Make versions of DIAG_OFF() and DIAG_ON() for GCC 4.2 through 4.5.Guy Harris1-14/+72
The macOS buildbot is currently using llvm-gcc, which is based on GCC 4.2. Change-Id: I8497243333410380e1d0bc7fa35bccbf841cada1 Reviewed-on: https://code.wireshark.org/review/29596 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11Use DIAG_OFF to suppress -Wunused-function.Guy Harris2-14/+10
Change-Id: I1846e4ef1be977553510ff1473d4c1a7e12cce18 Reviewed-on: https://code.wireshark.org/review/29594 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11Squelch more narrowing warnings.Guy Harris1-8/+8
Change-Id: I1bd9f8c048af29abc26eb85f814dd4ec8663501c Reviewed-on: https://code.wireshark.org/review/29593 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11"#if 0" out an unused variable.Guy Harris1-0/+2
Change-Id: I78cd22e7d7b43e072c71f21ba13aa56ce83afa15 Reviewed-on: https://code.wireshark.org/review/29592 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11sizeof isn't useful when calculating the size of data in the packet.Guy Harris1-8/+8
Srsly, you're dealing with *one-byte*, *two_byte*, and *four-byte* values, might as well say "1", "2", and "4" - either sizeof(guint8) is guaranteed to be 1, sizeof(guint16) is guaranteed to be 2, and sizeof(guint32) is guaranteed to be 4, in which case you might as well just use 1, 2, and 4, or they're *not* guaranteed to be 1, 2, and 44, in which case you *have* to use 1, 2, and 4, because a value other than 1, 2, or 4 is invalid. Change-Id: I49b354cd619f6fe8d625af0322f4861ad8f9b1f1 Reviewed-on: https://code.wireshark.org/review/29591 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11CMake: Remove some redundant and overly verbose codeJoão Valverde1-101/+81
The original reason for having a WARN_FLAGS set of variables has been lost. Change-Id: I3eae3cf9d0bad5f3895f6fee59c2c64183c8f244 Reviewed-on: https://code.wireshark.org/review/29526 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-11WIP:ieee80211.c: Add support for D3.0 of 802.11axRichard Sharpe1-333/+1312
This changeset merges in the changes that have been tested in a resent test event at the WFA. It will not dissect older D2.x packet captures. Change-Id: Id38a27a61a6a2a083575448e5c59a8e190827e6d Reviewed-on: https://code.wireshark.org/review/29512 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-11[packet-dnp.c] - Better solution for handling malformed messages containing ↵Chris Bontje1-29/+56
"empty objects" with misreported counts. - this change re-enables dissection of large lists of sequential objects lacking prefixes. - corrected some object/variation text in the comments Change-Id: Ia410f53198e9918509208739c94dbb4df4ecfc25 Reviewed-on: https://code.wireshark.org/review/29582 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-11Squelch a narrowing warning.Guy Harris1-1/+1
Change-Id: Ibe75903250dd9cccd2b4a80d1215f5ea6fd0cce2 Reviewed-on: https://code.wireshark.org/review/29590 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11Squelch a narrowing warning.Guy Harris1-1/+1
Change-Id: I5ff9095208956b9e40e5820986e0253ec2a76116 Reviewed-on: https://code.wireshark.org/review/29589 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11Avoid collision between parameter names and function names.Guy Harris2-4/+4
Change-Id: I206d05c47c9f9089a201783ae2d0856c97a5e502 Reviewed-on: https://code.wireshark.org/review/29588 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11MGCP: Ignore case for command headerUli Heilmeier1-9/+9
Bug: 15008 Change-Id: Ibfd9bd8d9d93ddac8c5441be9f5e27c3e095c11b Reviewed-on: https://code.wireshark.org/review/29502 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-11docsis: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-0/+2
Change-Id: I2d7e2d2c83dddc666c7ef85727af986b65b12a13 Reviewed-on: https://code.wireshark.org/review/29567 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Andrii Vladyka <a.vladyka@ukr.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-11Don't fill in a variable if you don't use the value.Guy Harris1-2/+1
Change-Id: I50c9cf5daa22c9d53e6ca642e6651948a04e8e64 Reviewed-on: https://code.wireshark.org/review/29587 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11sizeof isn't useful when calculating the size of data in the packet.Guy Harris1-2/+2
Srsly, you're dealing with *four-byte* value, might as well say "4" - either sizeof(guint32) is guaranteed to be 4, in which case you might as well just use 4, or it's *not* guaranteed to be 4, in which case you *have* to use 4, because a value other than 4 is invalid. Change-Id: I6deb106f326e9402744a2e728468b3ce4c220b02 Reviewed-on: https://code.wireshark.org/review/29586 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-11sizeof isn't useful when adding to an offset into the packet.Guy Harris1-1/+1
Srsly, you're fetching a *two-byte* value, might as well say "2" - either sizeof(guint16) is guaranteed to be 2, in which case you might as well just use 2, or it's *not* guaranteed to be 2, in which case you *have* to use 2, because a value other than 2 is invalid. Change-Id: I9da8dc66d3a77e98cb0a0a5501655594c509eb87 Reviewed-on: https://code.wireshark.org/review/29585 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-10Fix the build on the OSX buildbotJoão Valverde1-2/+3
Change-Id: Ia3efd8d4fb002cffadeb86620eea4bdceb1357b6 Reviewed-on: https://code.wireshark.org/review/29584 Reviewed-by: João Valverde <j@v6e.pt>
2018-09-10f5ethtrailer: Add some casts to squelch narrowing warning.João Valverde1-3/+3
Change-Id: If8cef41c69f397af2e36bb35ffa596fa656e8401 Reviewed-on: https://code.wireshark.org/review/29583 Reviewed-by: João Valverde <j@v6e.pt>
2018-09-10Avoid using -Werror with generated code.João Valverde1-2/+3
Change-Id: I5812eeedd1c6f53b62417a53f3613c2af476634c Reviewed-on: https://code.wireshark.org/review/29510 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-09-10rtp-ed137: squelch checkAPI warning about shadowed variableGraham Bloice1-3/+3
Change-Id: If9ae00895f12eeeda7590be62e1057397cc88c51 Reviewed-on: https://code.wireshark.org/review/29581 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2018-09-10MBIM: Dissect UUID_MS_UICC_LOW_LEVEL/MBIM_CID_MS_UICC_ATRJano Svitok1-0/+55
Change-Id: Ie2d4f2d7a4f38e9f56d8c35cdbddfef20a61ef23 Reviewed-on: https://code.wireshark.org/review/29577 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-09-10MBIM: MBIM_CID_MS_PROVISIONED_CONTEXT_V2 Query is legalJano Svitok1-2/+2
InformationBuffer must be empty Change-Id: I78367fc540122af099c3d9ab020b210ba112d997 Reviewed-on: https://code.wireshark.org/review/29576 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10Remove the probes.Guy Harris1-28/+0
(It's llvm-gcc, and appears to be a version too old to support _Pragma("gcc diagnostic ...").) Change-Id: I220997890636d5a5c33889d2e6c640feee155deb Reviewed-on: https://code.wireshark.org/review/29580 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-10Maybe we have to treat llvm-gcc specially.Guy Harris1-2/+2
Change-Id: I73aa608a31a79fa58cb5a86aceaaa778adf0aa2c Reviewed-on: https://code.wireshark.org/review/29579 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-10Test with (llvm-)GCC pragmas, as the buildbot builds with llvm-gcc.Guy Harris1-1/+12
Change-Id: Ic1dd2e4d17cabb1cd62f8b1ad211dc6915835359 Reviewed-on: https://code.wireshark.org/review/29578 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-10Test what kind of compiler we have running on the macOS buildbot.Guy Harris1-6/+14
Change-Id: Ib1a14256ce0fbcfa357368e8431705606a8412e0 Reviewed-on: https://code.wireshark.org/review/29574 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-10Qt: Add some window title variablesStig Bjørlykke2-4/+32
Add some new variables to be used in custom window title. %F = file path of the capture file %S = a conditional separator (" - ") that only shows when surrounded by variables with values or static text Change-Id: I20a60a3018cc86236f4991030eadb7f51681cc32 Reviewed-on: https://code.wireshark.org/review/29534 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-09-10Try directly using _Pragma if building on/for macOS.Guy Harris1-0/+9
Change-Id: Ib7a48c06a1244b26a9f9a8b733ca4769385603e8 Reviewed-on: https://code.wireshark.org/review/29573 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-10Manuf fixups.Gerald Combs3-255/+139
Remove some entries from manuf.tmpl that are either redundant or less informative that their corresponding IEEE entries. Add a missing '"' to make-manuf.py. Change-Id: Ia69f4529c5fa1b39f1662b94d072c65bd2d969ea Reviewed-on: https://code.wireshark.org/review/29568 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-10release-notes: add new features and remove known bugs listPeter Wu1-19/+8
The "known bugs" list is rarely updated. Remove it and add more helpful and up-to-date references. Change-Id: I5aea57c66c6645b5c903ebcebcb1676af5204ce2 Reviewed-on: https://code.wireshark.org/review/29048 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-09-10release-note: Add EVS dissectorAlexis La Goutte1-0/+1
Change-Id: Iab3804d70df4d0eb0b9698407121aa477b0caa27 Reviewed-on: https://code.wireshark.org/review/29559 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10evs: fix headerAlexis La Goutte1-3/+3
Change-Id: Iae4fc9289a6480430588c2de522f79b10b8cf6b1 Reviewed-on: https://code.wireshark.org/review/29558 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10evs: add modelines infoAlexis La Goutte1-0/+14
Change-Id: I48f2c730b1eebb26fee53dcf22d20e3a9b9f536b Reviewed-on: https://code.wireshark.org/review/29557 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10Diameter: Add ALU AVP 1139 from Ask.AndersBroman1-1/+3
Change-Id: Ia2a72bca2c790fb9ad066608484e99e029830998 Reviewed-on: https://code.wireshark.org/review/29556 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10prefs: pacify checkAPIs by using ws_g_warningPeter Wu1-1/+1
Change-Id: I15ead09ed5b8df33d795d2c6ed75cd911790113b Reviewed-on: https://code.wireshark.org/review/29560 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-10evs: remove unused var and set unused param.Dario Lombardo1-7/+1
Change-Id: Ia9815af5e4cdecf4a2a25ed226acacfdd9dd38c0 Reviewed-on: https://code.wireshark.org/review/29554 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10proto.c: Increase number of preallocted fields to 205000AndersBroman1-1/+1
Change-Id: Id0590e5c860697a4a70278cec6ec8231203ab40b Reviewed-on: https://code.wireshark.org/review/29552 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10EVS: Add a dissector for RTP payload type EVS.AndersBroman2-0/+670
Change-Id: I00dee6f16684ec8116d1ef8cf278e889ffebaabf Reviewed-on: https://code.wireshark.org/review/29550 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-10prefs,ui: properly migrate old filter expressionsPeter Wu6-16/+45
When legacy filter expressions preferences are present, be sure to (1) save the dfilter_buttons file when updating the preferences file and (2) save the preferences file after updating the dfilter_buttons file. Without doing (1), the old buttons will be lost. Without (2), restarting Wireshark will result in duplicate buttons. Only write the files if the user actually made other changes to avoid breaking profiles by just opening Wireshark. Bug: 15114 Bug: 15121 Change-Id: I5b9417c34146c4450526781a20308c9c98fb44a1 Reviewed-on: https://code.wireshark.org/review/29488 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 14:21:27 +0000