aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-09-26coap: Added dissection for LWM2M JSON inside CoAP protocolAnton Butenko2-0/+3
Change-Id: I29429f731b7e2f25568d44de455816ac70e079b6 Reviewed-on: https://code.wireshark.org/review/23740 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-26plugins: Build the description string while loadingJoão Valverde1-45/+18
Change-Id: Ia67133c1c9d005fc4a81b0727a7b1849571ab29c Reviewed-on: https://code.wireshark.org/review/23742 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-26Add GRPC dissectorHuang Qiangxiong5-0/+441
GRPC dissector register it self to media_type dissector table using patterns "application/grpc", "application/grpc+proto" and "application/grpc+json". GRPC stack (at least in grpc-java) can send JSON over GRPC using content-type = "application/grpc" which normally means default protobuf format. A preference is added to detect the message body, if it starts with '{', and ends with '}', will force to use JSON subdissector instead of searching in 'grpc_message_type' table. Ping-Bug: 13932 Change-Id: I910961ca06370e678d19b78cac533ca566d87628 Reviewed-on: https://code.wireshark.org/review/22891 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-26ZigBee ZCL SE Events: Dissect commands within ZCL SE Events ClusterMartin Boye Petersen1-10/+304
Change-Id: I6baf02fc0a194a776fb02fc265902b0eafd710e9 Reviewed-on: https://code.wireshark.org/review/23734 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-09-26plugins: Sort the descriptionsJoão Valverde2-20/+36
Change-Id: I8113ba9782962856ce86475cddf40d69ed267fb4 Reviewed-on: https://code.wireshark.org/review/23733 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-26plugins: Use hash table for book-keepingJoão Valverde1-98/+55
Avoid having to walk the list to check for existence on every file load. Now the binary plugin description list in About Wireshark is randomized instead of sorted by load order. We may want to change that. Add missing "const" to plugin->version. Fix an apparent trivial leak where the GModule handle was not closed on exit. Change-Id: I774215a84b080bbe889f88cc6a9b777bcf60b335 Reviewed-on: https://code.wireshark.org/review/23732 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-26HTTP2: Store all packets' header indexes in header_stream_info structHuang Qiangxiong2-8/+100
Store all packets' headers indexes of oneway stream in its header_stream_info struct. (Just store pointers refer to each HEADERS or CONTINUATION packets' header arrays) Add http2_get_header_value() function to allow other dissectors to get HTTP2 headers of this stream later in DATA frames. Ping-Bug: 13932 Change-Id: I9f623f66045845c338cd6233d4c6da3f6875fc69 Reviewed-on: https://code.wireshark.org/review/22859 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-26ZigBee PP Dissector: Increase number of subtreesMartin Boye Petersen1-2/+2
Increase number of subtrees from 10 to 30 for PublishTopUpLog and PublishDebtLog. Before the total APS size of PublishDebtLog could only be about 132 bytes. Same goes for PublishTopUpLog. Change-Id: I7e70977526de2f6d6e84af178bee91eabb132962 Reviewed-on: https://code.wireshark.org/review/23731 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-26Editcap: Don't treat plain -F and -T as errors.Gerald Combs2-15/+15
The editcap man page says that you can pass in -F and -T without arguments in order to get a list of valid capture and encapsulation types. Instead of treating these as errors just print the information to stdout and return 0. Adjust the docbook _tools_help targets accordingly. Change-Id: I590cbd59059dd8965299bef4434f522eff8a4e2c Reviewed-on: https://code.wireshark.org/review/23741 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-25Qt: Free MainWindow at shutdownMikael Kanstrup2-0/+11
MainWindow is allocated on heap on startup but not freed on shutdown. Free the object at shutdown mainly to silent Valgrind. When at it also fix two problems with the MainWindow destructor: - Deleting main_ui_ triggers a currentChanged signal which in turn calls mainStackChanged that references the freed main_ui_ object. Prevent use after free error by disconnecting from the signal before freeing. - Explicitly free file_set_dialog_ as no rparent perform the cleanup. Bug: 14071 Change-Id: I9c1fbef04cf68bfffffea57ef298f4896d6583f9 Reviewed-on: https://code.wireshark.org/review/23739 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-25Docbook: Automatically generate the tools help output.Gerald Combs16-689/+792
Add a CMake target that dumps the help output for our command line tools to individual files. Include those files in the tools appendix instead of pasting them in manually. Fixup the output of some tools so that they pass the pre-commit checks. Change-Id: I925f24818422a190927a96531c21f4d16d3fe5b5 Reviewed-on: https://code.wireshark.org/review/23737 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-09-25Qt: Fix leaked interfaces array in Wireless frameMikael Kanstrup1-0/+1
The array of ws80211_interface:s is not freed when the wireless frame is destroyed causing minor leaks. Fix leaks by freeing the array using appropriate utility function. Bug: 14071 Change-Id: I35ec578062bfee4a4f0d0ac05a6d7613996a8822 Reviewed-on: https://code.wireshark.org/review/23738 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-09-25NAS EPS: upgrade dissector to v14.5.0Pascal Quantin2-30/+11
Change-Id: I0cf79dc37804db60b50cfb87355d0537361e214f Reviewed-on: https://code.wireshark.org/review/23736 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-253GPP NAS: upgrade dissector to v14.5.0Pascal Quantin2-6/+109
Change-Id: Ibf45c6b5930ee122004afc8d2ac84a751491f3a4 Reviewed-on: https://code.wireshark.org/review/23735 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-25plugins: Fix crash loading binary module twiceJoão Valverde2-30/+29
If a plugin is repeated we destroy the GModuleHandle in plugins_scan_dir() but we have already added the entry points to the list of registered plugins. Check for repeated plugins before adding it to the list of registered plugins, not after. Don't check for both name and version, check only for repeated names. Give the plugin callback a more descriptive name. Change-Id: I22cbbb059b8029877580fc33517310496c93e5d5 Reviewed-on: https://code.wireshark.org/review/23726 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-25udpdump: Add missing include for timeval struct.Jakub Zawadzki1-0/+4
struct timeval is defined in <sys/time.h>, include it. It should fix building with musl: udpdump.c: In function 'setup_listener': udpdump.c:126:9: error: variable 'timeout' has initializer but incomplete type struct timeval timeout = { 1, 0 }; Change-Id: Id9be579e50ea2845ca609708e8ec4d1a3858ecc0 Reviewed-on: https://code.wireshark.org/review/23728 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2017-09-25macOS: Fixup plugin signing.Gerald Combs1-1/+1
Use `find` to find plugins. Change-Id: I6df8877547ecbd19644a846e5cb02e8b65f19e61 Reviewed-on: https://code.wireshark.org/review/23730 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-09-25text2pcap: fix crash when there is no argumentPascal Quantin1-3/+10
Bug: 14082 Change-Id: Ifd8b2bf9bee817967e3b00e01b8b4ae90970e984 Reviewed-on: https://code.wireshark.org/review/23727 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-25Add toy plugin to doc/ as an out-of-tree build exampleJoão Valverde6-2/+151
Change-Id: I9b7abb27d30dbe83996a01b7f722693a974948c5 Reviewed-on: https://code.wireshark.org/review/23665 Reviewed-by: João Valverde <j@v6e.pt>
2017-09-25Docsis: fix an infinite loopPascal Quantin1-0/+14
Add missing decrement of concatlen based on master-2.2 version. Bug: 14080 Change-Id: I00f7e34f8e599718316a4ce8916d91b780ec7c14 Reviewed-on: https://code.wireshark.org/review/23663 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-25packet-brcm-tag: Add Broadcom tag dissectionFlorian Fainelli6-0/+210
Add support for dissecting the old-style Broadcom tag with Ethertype 0x8874, this was supported by switches like Broadcom BCM5325. Newer switches use a different tag format (with no Ethertype) which will be supported later. Change-Id: Iec26f8d13058399a35fb258ccadc48f7f5ac8474 Reviewed-on: https://code.wireshark.org/review/23592 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-25pidl: fix field2name wireshark dissector test.Guy Harris1-1/+1
Pick up change from Samba: commit 82778a6d04580fc05f3f83d44f57f221ad4e8ac4 Author: Günther Deschner <gd@samba.org> Date: Tue Sep 6 22:37:12 2016 +0200 pidl: fix field2name wireshark dissector test. Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Wed Sep 7 16:05:26 CEST 2016 on sn-devel-144 Change-Id: Ia02de7d36b2fcb0e7a5145361548acae844f73ed Reviewed-on: https://code.wireshark.org/review/23724 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl: Fix array range checks in python outputGuy Harris1-3/+6
Pick up change from Samba: commit 67040cf61232dd1cdcc820237919ac1e073c31c2 Author: Volker Lendecke <vl@samba.org> Date: Tue Jun 20 15:31:18 2017 +0200 pidl: Fix array range checks in python output Without this, we generated code like if (ndr_table_dnsserver.num_calls < 0) { PyErr_SetString(PyExc_TypeError, "Internal Error, ndr_interface_call missing for py_DnssrvOperation_ndr_pack"); return NULL; } call = &ndr_table_dnsserver.calls[0]; This does not really make sense, and Coverity found comparing the unsigned num_calls against <0 a bit pointless. Should fix 138 Coverity findings and make the code a bit more correct. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Change-Id: I401e3771e6f3c1125ff847749073693af23884fc Reviewed-on: https://code.wireshark.org/review/23723 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25python3: Use "y#" instead of "s#" for binary data in PyArg_ParseTupleGuy Harris1-3/+3
Pick up change from Samba: commit 40e409bf9e89a163c771b2a58493d2c1b496fae7 Author: Petr Viktorin <pviktori@redhat.com> Date: Wed May 3 16:57:07 2017 +0200 python3: Use "y#" instead of "s#" for binary data in PyArg_ParseTuple The "s#" format code for PyArg_ParseTupleAndKeywords and Py_BuildValue converts a char* and size to/from Python str (with utf-8 encoding under Python 3). In some cases, we want bytes (str on Python 2, bytes on 3) instead. The code for this is "y#" in Python 3, but that is not available in 2. Introduce a PYARG_BYTES_LEN macro that expands to "s#" or "y#", and use that in: - credentials.get_ntlm_response (for input and output) - ndr_unpack argument in PIDL generated code Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Change-Id: If4d9cdabc5016127f60682caf300f6801a360083 Reviewed-on: https://code.wireshark.org/review/23722 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl: Fix Coverity warnings from duplicate NULL checks.Guy Harris1-25/+38
Pick up change from Samba: commit 9703464b942fdddbf7bc4380cbd26d1803f9bc00 Author: Jeremy Allison <jra@samba.org> Date: Tue May 2 08:10:40 2017 -0700 pidl: Fix Coverity warnings from duplicate NULL checks. Pair-Programmed-With: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat May 6 16:03:17 CEST 2017 on sn-devel-144 Change-Id: I25c6ae984c6a963c05f33d9a649b64f9795c7292 Reviewed-on: https://code.wireshark.org/review/23721 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25python: pidl: Port Python interface generatorGuy Harris1-23/+34
Pick up change from Samba: commit 2de5fa45e0abfdb50f604f87e494bf334c39003a Author: Lumir Balhar <lbalhar@redhat.com> Date: Mon Jan 23 21:03:17 2017 +0100 python: pidl: Port Python interface generator Port PIDL generator of Python interfaces to generate interfaces in Python 3 compatible form. Python 2.7 is now required, so we can use PyCapsule in both versions. Signed-off-by: Lumir Balhar <lbalhar@redhat.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Pair-programmed-by: Andrew Bartlett <abartlet@samba.org> Change-Id: I981993e326132a1911bfbb686ca5ae033dd1df49 Reviewed-on: https://code.wireshark.org/review/23720 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: use of pytalloc_GenericObject_reference*() for ↵Guy Harris1-78/+7
pyrpc_{ex,im}port_union() wrapping Pick up change from Samba: commit 2170f556299c6ab4ce33f22169ca26ecad3440e3 Author: Stefan Metzmacher <metze@samba.org> Date: Mon Feb 20 18:02:09 2017 +0100 pidl:Python: use of pytalloc_GenericObject_reference*() for pyrpc_{ex,im}port_union() wrapping BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Feb 25 06:33:33 CET 2017 on sn-devel-144 Change-Id: I4d3cb70c79531e5faf5249b67948cc6d354c1bd0 Reviewed-on: https://code.wireshark.org/review/23719 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: replace pytalloc_CObject_FromTallocPtr() with ↵Guy Harris1-9/+11
pytalloc_GenericObject_reference_ex() Pick up change from Samba: commit 1ee0c0f8280393c708f23361ebcba0776e8b4d33 Author: Stefan Metzmacher <metze@samba.org> Date: Wed Feb 22 09:07:54 2017 +0100 pidl:Python: replace pytalloc_CObject_FromTallocPtr() with pytalloc_GenericObject_reference_ex() BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Change-Id: I19d04a1a248d35799ec41a79113fe588cd05e3de Reviewed-on: https://code.wireshark.org/review/23718 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601Guy Harris1-1/+7
Pick up change from Samba: commit d62eb3cc9f97b203d21ec6e75c48c739a43bc163 Author: Stefan Metzmacher <metze@samba.org> Date: Wed Feb 22 10:08:46 2017 +0100 pidl:Python: make sure print HASH references for STRUCT types BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Change-Id: Ieef766844ce66160eaaacecc73a51f94f69319fb Reviewed-on: https://code.wireshark.org/review/23717 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: add PyTypeObject objects for function structsGuy Harris1-1/+477
Pick up change from Samba: commit 57539c84416aeb8fc8e3a8653f790b329e6fa9a1 Author: Stefan Metzmacher <metze@samba.org> Date: Mon Sep 12 09:20:44 2016 +0200 pidl:Python: add PyTypeObject objects for function structs They provide get/set methods for the in_* and out_* elements and the magic __ndr_{push,pull,print}_{in,out}__ hooks to enable the marshalling via ndr_{push,pull,print}_{in,out}(). This provides an easy way to generate and parse the payload of DCERPC requests and responses, which is very useful for writing tests. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: I8f0e70fb771a91ba9590e2e92b5713b48313d2de Reviewed-on: https://code.wireshark.org/review/23716 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: split out a PythonElementGetSet() helper functionGuy Harris1-29/+35
Pick up a change from Samba: commit a546124f10d1e2bee29bc06c0b8754257d2bdc23 Author: Stefan Metzmacher <metze@samba.org> Date: Mon Sep 12 09:20:04 2016 +0200 pidl:Python: split out a PythonElementGetSet() helper function Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: Ica8b699189b69833abfa6049dd3c4e489788ce54 Reviewed-on: https://code.wireshark.org/review/23715 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: the py_{import,export}_*() functions can be static now.Guy Harris1-4/+2
Pick up change from Samba: commit 40175613519e7405a16e8f896dfdc2949430bc4b Author: Stefan Metzmacher <metze@samba.org> Date: Tue Sep 13 01:06:18 2016 +0200 pidl:Python: the py_{import,export}_*() functions can be static now. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: I6e06c97b44a04cab36d134916eddf4c501ccc35d Reviewed-on: https://code.wireshark.org/review/23714 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: make use of the pyrpc_{import,export}_union() functionsGuy Harris1-7/+25
Pick up a change from Samba: commit f7707c04a5e039e757b288ad67a0c3cac9c6466a Author: Stefan Metzmacher <metze@samba.org> Date: Mon Sep 12 16:33:38 2016 +0200 pidl:Python: make use of the pyrpc_{import,export}_union() functions This avoids the linking problems at C shared object level. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: I62c1d03b10e965552a4d598fa2370692ee0cd12a Reviewed-on: https://code.wireshark.org/review/23713 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: provide a PyTypeObject with METH_CLASS __import__() and ↵Guy Harris1-0/+214
__export__() hooks Pick up a change from Samba: commit e0324c0cf7e7c363a5791c2e35c8820b79640a47 Author: Stefan Metzmacher <metze@samba.org> Date: Mon Sep 12 16:33:38 2016 +0200 pidl:Python: provide a PyTypeObject with METH_CLASS __import__() and __export__() hooks These are wrappers around the currently public C functions 'py_import_*() and 'py_export_*(). In order to let other python module use these function, we should resolve the needed type object and call the __import__() or __export__() hooks instead of linking to the other shared module at C level. We already do the same for structs. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: I47813a544365085407a31d174ee180778674e42b Reviewed-on: https://code.wireshark.org/review/23712 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: provide the abstract syntax as <module>.<interface>_abstract_syntaxGuy Harris1-12/+34
Pick up change from Samba: commit 3a0ce3e41d9fdab58273c239955862b03396ea19 Author: Stefan Metzmacher <metze@samba.org> Date: Sun Sep 25 00:48:29 2016 +0200 pidl:Python: provide the abstract syntax as <module>.<interface>_abstract_syntax The <module>.abstract_syntax alias is only kept as legacy for the first interface in a module. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: Ie6d3d48ea3012bd328eb20e2e6693928fe24ead8 Reviewed-on: https://code.wireshark.org/review/23711 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: prettify names of constantsGuy Harris1-2/+2
Pick up change from Samba: commit 1bebccaeb93f7fb7b6e2538d63223f01587ed14d Author: Stefan Metzmacher <metze@samba.org> Date: Fri Sep 23 06:49:13 2016 +0200 pidl:Python: prettify names of constants Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: If9905b914c0d559bd6e7808fadbd154ae56ae2b1 Reviewed-on: https://code.wireshark.org/review/23710 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: improve the .doc string for the get/set elementsGuy Harris1-1/+1
Pick up change from Samba: commit a560116aa5228885e5f52fc46fa92151357de69c Author: Stefan Metzmacher <metze@samba.org> Date: Tue Sep 13 09:07:32 2016 +0200 pidl:Python: improve the .doc string for the get/set elements Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: I8ecb22fd88298ecd4e350b1815d8720b493aac27 Reviewed-on: https://code.wireshark.org/review/23709 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: make use of NDR_ERR_CODE_IS_SUCCESS()Guy Harris1-2/+2
Pick up change from Samba: commit 47b40ac96afbd4fb28e519b9658256ecaa304e71 Author: Stefan Metzmacher <metze@samba.org> Date: Mon Sep 12 15:12:24 2016 +0200 pidl:Python: make use of NDR_ERR_CODE_IS_SUCCESS() Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: I550b83596fe27bad5ba4f7d91eb0ac62380f4eac Reviewed-on: https://code.wireshark.org/review/23708 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: __ndr_print__ functions don't get arguments and need METH_NOARGSGuy Harris1-1/+1
Pick up change from Samba: commit d4660e869790c7da1cb97e9d95a995e5a32b34ef Author: Stefan Metzmacher <metze@samba.org> Date: Sun Sep 25 01:07:14 2016 +0200 pidl:Python: __ndr_print__ functions don't get arguments and need METH_NOARGS Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: Ic0648f65b8c3f60e614361778d2c0bf72d61be35 Reviewed-on: https://code.wireshark.org/review/23707 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:Python: check the return values of talloc_ptrtype()Guy Harris1-0/+18
Pick up change from Samba: commit b728c63bcb5860aed2db43139d191bc149ceba83 Author: Stefan Metzmacher <metze@samba.org> Date: Mon Sep 12 15:12:50 2016 +0200 pidl:Python: check the return values of talloc_ptrtype() Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: Icfe8837b5b998e3c5c4ea98df21cf620f53cdcd7 Reviewed-on: https://code.wireshark.org/review/23706 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25lib: modules: Change XXX_init interface from XXX_init(void) to ↵Guy Harris1-2/+2
XXX_init(TALLOC_CTX *) Pick up change from Samba: commit 306783d6f5d577a0b8bd31d659d8c802f22f0333 Author: Jeremy Allison <jra@samba.org> Date: Thu Apr 20 12:24:43 2017 -0700 lib: modules: Change XXX_init interface from XXX_init(void) to XXX_init(TALLOC_CTX *) Not currently used - no logic changes inside. This will make it possible to pass down a long-lived talloc context from the loading function for modules to use instead of having them internally all use talloc_autofree_context() which is a hidden global. Updated all known module interface numbers, and added a WHATSNEW. Signed-off-by: Jeremy Allison <jra@samba.org> Signed-off-by: Ralph Böhme <slow@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Apr 22 01:17:00 CEST 2017 on sn-devel-144 Change-Id: I549e24e2e1fec12d8e7d3f3304cdac29882892a5 Reviewed-on: https://code.wireshark.org/review/23705 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25s4-rpc_server: Allow each interface to declare if it uses handlesGuy Harris1-8/+13
Pick up change from Samba: commit ffb8b50e3c07c833fb7b1a583d21f9dc1166a0a6 Author: Andrew Bartlett <abartlet@samba.org> Date: Mon Nov 14 11:24:03 2016 +1300 s4-rpc_server: Allow each interface to declare if it uses handles This will allow the NETLOGON server in the AD DC to declare that it does not use handles, and so allow some more flexibility with association groups Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Change-Id: Ic09452d27493ff913f5a5c064a038e3783e91df2 Reviewed-on: https://code.wireshark.org/review/23704 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25s4-rpc_server: Add back support for lsa over \\pipe\\netlogon optionallyGuy Harris1-1/+4
Pick up change from Samba: commit 31d625bcd2b0cb33dd98a37c202f5b371b871362 Author: Andrew Bartlett <abartlet@samba.org> Date: Tue Dec 13 09:06:25 2016 +1300 s4-rpc_server: Add back support for lsa over \\pipe\\netlogon optionally The idea here is that perhaps some real client relies on this (and not just Samba torture commands), so we need a way to support it for the 4.6 release. If no such client emerges, it can be deprecated and removed in the normal way. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Change-Id: Id20f98ffbc5eb4752bebee455e7b2b2c0f5017e0 Reviewed-on: https://code.wireshark.org/review/23703 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl: Make dcesrv\_$name\_interface "static const"Guy Harris1-1/+1
Pick up change from Samba: commit 50dff7e094d48793b432992a28571a6f7e5cc73c Author: Andrew Bartlett <abartlet@samba.org> Date: Mon Nov 21 11:21:50 2016 +1300 pidl: Make dcesrv\_$name\_interface "static const" This moves it out of the global namespace Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Dec 8 13:25:57 CET 2016 on sn-devel-144 Change-Id: Ifa9fca377dc217b131f87cef4463624a679660f9 Reviewed-on: https://code.wireshark.org/review/23702 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl: Use a static const initialised struct in dcerpc_server_$name_init(void)Guy Harris1-9/+8
Pick up change from Samba: commit 778fc58eb281e38eb1a3346b58cfdf9682f104c4 Author: Andrew Bartlett <abartlet@samba.org> Date: Mon Nov 21 11:38:24 2016 +1300 pidl: Use a static const initialised struct in dcerpc_server_$name_init(void) Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Reviewed-by: Garming Sam <garming@catalyst.net.nz> Change-Id: I5bbc8cfdd94f4c13250fc3b1cb0a61351220116c Reviewed-on: https://code.wireshark.org/review/23701 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25libndr/compression: pass down compressed length in ndr_pull_compression_startGuy Harris1-1/+2
Pick up change from Samba: commit a44bce6dfab59a6440ccc30ef0968d59b9f43fd3 Author: Günther Deschner <gd@samba.org> Date: Tue Sep 20 00:18:43 2016 +0200 libndr/compression: pass down compressed length in ndr_pull_compression_start Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Change-Id: I038c28cafce1248f4208119ba47f1c94ce970067 Reviewed-on: https://code.wireshark.org/review/23700 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:NDR/Parser: add missing {start,end}_flags() to ParseElementPrint()Guy Harris1-0/+4
Pick up change from Samba: commit 81bbfb010599b65308aca89cc50532372ca4cb00 Author: Stefan Metzmacher <metze@samba.org> Date: Mon Jun 12 18:58:49 2017 +0200 pidl:NDR/Parser: add missing {start,end}_flags() to ParseElementPrint() BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Change-Id: Iaf4192083c49a15eaf722da1a3b55ad987bdbc82 Reviewed-on: https://code.wireshark.org/review/23699 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:NDR/Parser: initialize [skip] values in ndr_pull_*Guy Harris1-0/+3
Pick up change from Samba: commit 823bc4c07add242a5a1d0cd25942ebaab3cd0e23 Author: Stefan Metzmacher <metze@samba.org> Date: Tue Jun 13 09:57:33 2017 +0200 pidl:NDR/Parser: initialize [skip] values in ndr_pull_* It's too dangerous to leave values uninitialzed! [skip_noinit] can be used if required. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Change-Id: I85a173e21fca509fc417ff2532097fd9a220ccd9 Reviewed-on: https://code.wireshark.org/review/23698 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:NDR/Parser: add "skip_noinit" elementGuy Harris2-6/+7
Pick up change from Samba: commit b922472fd683235fde3abc69ee09d9d8bfdb8644 Author: Stefan Metzmacher <metze@samba.org> Date: Wed Jun 21 15:05:35 2017 +0200 pidl:NDR/Parser: add "skip_noinit" element In future "skip" will be changed to initialize the element with ZERO_STRUCT() on ndr_pull_*. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Change-Id: I4b886c18c9eff27ae446e68fb7220e812721c4e0 Reviewed-on: https://code.wireshark.org/review/23697 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-25pidl:NDR/Parser: fix "skip" for pointersGuy Harris1-10/+30
Pick up change from Samba: commit 3bc6b55385894691792962ecc15978a3b158eca4 Author: Stefan Metzmacher <metze@samba.org> Date: Mon Jun 19 12:15:21 2017 +0200 pidl:NDR/Parser: fix "skip" for pointers We should handle the "skip" at the element level before we traverse trough the element levels. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Change-Id: I8b52e1ad0e0ad2c8a4fc20b94f07441b458e5638 Reviewed-on: https://code.wireshark.org/review/23696 Reviewed-by: Guy Harris <guy@alum.mit.edu>