aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-09-10Qt: Fix PacketTree copy ValueStig Bjørlykke1-2/+2
Use edt from cap_file_ in case this is valid. This is a regression from 806bef47a2. Change-Id: I60150f50056b63346a1510505ffca22347ad4ba0 Reviewed-on: https://code.wireshark.org/review/34491 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-10DLT: Fix uint64 printf formatStig Bjørlykke1-2/+2
Use G_GUINT64_FORMAT for uint64. Change-Id: I3c86dad0f045092e4292899c473ff32bb1fe82a8 Reviewed-on: https://code.wireshark.org/review/34490 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-09-10DLT: Adding support for the DLT protocolDr. Lars Völker3-0/+1374
The Diagnostic Log and Trace protocol (DLT) is a commonly used and standardized protocol in the automotive industry used to retrieve log data. This patch adds the protocol to Wireshark. Keep in mind that ports have to be configured before the dissector can be used. Change-Id: I24592705476fb0c3bb83a1cc10b3dae8867523f4 Signed-off-by: Dr. Lars Völker <lars.voelker@bmw.de> Reviewed-on: https://code.wireshark.org/review/34462 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10TDS: Improve handling of scale for TDS numeric and decimal fields.Craig Jackson1-12/+52
For numeric and decimal fields, we can use doubles to display many decimal and numeric fields exactly. It only starts to fall down when we get more than 15 decimal digits. Bug: 16041 Change-Id: Idae1790ade7106d7557739220756ef9e9281378c Reviewed-on: https://code.wireshark.org/review/34471 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10ieee80211: fix dissection of HE Phy Capabilities InformationAlexis La Goutte1-27/+9
Wrong bitmask and duplicate field for same byte Issue reported by Helge Mangus Keck Change-Id: Ibc5a914fc2ecc05b9b5f6d0025c52c80af23d9f4 Reviewed-on: https://code.wireshark.org/review/34483 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10DIS: Support for the EntityStateUpdate PDUJean-Philippe Lebel1-1/+131
Updated the DIS protocol dissector to support the EntityStateUpdate PDU. The EntityStateUpdatePDU is part of DIS 7 and was already "semi-handled" by the dissector. Change-Id: I3221520e0260dc836d373fa590b3941de45a2dcc Reviewed-on: https://code.wireshark.org/review/34463 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09rsl: Add support for non-standard RSL_MSG_TYPE_OSMO_ETWS_CMDHarald Welte1-1/+49
3GPP sadly has forgotten to specify how the ETWS Primary Notification is to be communicated over Abis to the BTS. Osmocom has introduced a non-standard RSL message type "RSL_MSG_TYPE_OSMO_ETWS_CMD" for this purpose to the OsmoBTS and OsmoBSC implementations. It contains a single Information Element which in turn contains the 56-byte primary notification of the Earthquake and Tsunami Warning system. This patch adds wireshark dissector support to it. Change-Id: Icce5b06bfd00c0a7ef0f21283cc57473fa34f034 Reviewed-on: https://code.wireshark.org/review/34464 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-09Kafka: Fix Dead StoreAlexis La Goutte1-1/+1
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I013c1bdc943033550f497b1be0dfc7979ca49517 Reviewed-on: https://code.wireshark.org/review/34484 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09nvme-tcp: Add C2H/H2C TermReq dissectionDmitry Radivonchik1-0/+165
Section 7.4.10.4 and 7.4.10.5 of the spec. Change-Id: I175f98ca8265eb369344d5dcaff7bdf0943372c3 Signed-off-by: Dmitry Radivonchik <mitya@oktetlabs.ru> Reviewed-on: https://code.wireshark.org/review/34470 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09Kafka: Fix Dead StoreAlexis La Goutte1-5/+5
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I3ac2e2b6a1ed7621f65f1a98e8b7b3704e8b299d Reviewed-on: https://code.wireshark.org/review/34481 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-08BACNET: Update vendor ID listJaap Keuter1-1/+80
Update build-in vendor ID list with last years additions. Change-Id: I1916e160f6bcea5e94ce203b50f4a27a6ca1d261 Reviewed-on: https://code.wireshark.org/review/34460 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-08QUIC: fix connection tracking with empty Initial SCIDPeter Wu1-16/+22
Fix linking of new Initial packets after a Retry packet in case the client Initial packet has an empty SCID. Update a comment to drop "Stateless" from "Stateless Retry" to match newer QUIC drafts. Tested with quic-go-b083fd6f0e36-d22-dsb.pcapng. Bug: 13881 Change-Id: Idc8b1ad6283ace95ae059a6ef6ee268c1ffb4097 Reviewed-on: https://code.wireshark.org/review/34469 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-08[Automatic update for 2019-09-08]Gerald Combs14-820/+1593
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ifff2c6116b57d189f564986caa40e0a25de5233c Reviewed-on: https://code.wireshark.org/review/34472 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-08Qt UI: Warn about not saving non-PCM encoded audioJaap Keuter1-3/+13
When saving audio data from RTP stream(s) in Sun AU format we (still) do not harness the build-in codec framework. This results in empty Audio files for all but PCM encoded RTP streams. At least warn the user about the codec not being supported for saving in Audio file. Change-Id: Ia76caf71d0d5319a66dbf1cee517c0922bf7a561 Reviewed-on: https://code.wireshark.org/review/34466 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-08Qt UI: remove empty jitter buffer label tooltipJaap Keuter1-3/+0
The jitter buffer label in the RTP player dialog has an effectively empty tooltip. Since on the label itself there's little to tell this tooltip can be removed. Change-Id: I9429e4f02991734b800280e2cae73a27f71c3663 Reviewed-on: https://code.wireshark.org/review/34467 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-08erf: Use g_get_real_time() to get real timeStig Bjørlykke1-3/+3
Use g_get_real_time() to get real time because GTimeVal and g_get_current_time() was deprecated in glib 2.62. Change-Id: I78fee34e2f5b634c91c6420b01915cfc070f38a4 Reviewed-on: https://code.wireshark.org/review/34468 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-06wsjson.c: do not leak memory when checking input buffer in json_validate()Pascal Quantin1-5/+5
Bug: 16039 Change-Id: Id3c22fbee87b5a8f5d2e4bc488ad902098fa5f05 Reviewed-on: https://code.wireshark.org/review/34459 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-09-05Windows: upgrade Npcap to 0.9983Pascal Quantin2-5/+5
Change-Id: I05a0eb274d8890711d47c95db1b925682baa63cd Reviewed-on: https://code.wireshark.org/review/34457 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-05NAS 5GS: enhance dissection of QoS rules IEPascal Quantin1-18/+162
Change-Id: I96d416744401d259b9205f5e8daaffe58673633f Reviewed-on: https://code.wireshark.org/review/34451 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-05kafka: Cleanup to use "native" APIs.Michael Mann6-157/+173
Add "native" support for the "zig-zag" version of a varint in proto.[ch] and tvbuff.[ch]. Convert the use of varint in the KAFKA dissector to use the (new) "native" API. Ping-Bug: 15988 Change-Id: Ia83569203877df8c780f4f182916ed6327d0ec6c Reviewed-on: https://code.wireshark.org/review/34386 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04Put the year field of the timestamp out in little-endian byte order.Guy Harris1-2/+2
Change-Id: I9de300b05e8d66e71359241fddfe10d90f3f8d33 Reviewed-on: https://code.wireshark.org/review/34454 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-04Wiretap: Write commview files with valid headersJaap Keuter1-2/+2
When writing a capture as a commview file the header written is two bytes longer than the specification. Even though we count 24, we actually write 26. This makes the commview file corrupt, as is apparent when reading such file, eg., after using Save As... with this format. Replace writing 2 bytes for the last two fields in the header by 1 byte each, as per the header specification. Change-Id: I9436f7837b2e3617a389619884bf93ad146e95f3 Reviewed-on: https://code.wireshark.org/review/34450 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-04WSUG: Update docs on working with captured packetsMoshe Kaplan2-106/+133
Change-Id: Ic411028e4026618471fa9933bea0b5a78875e049 Reviewed-on: https://code.wireshark.org/review/34414 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04Load environment vars to globals for efficency.Anders Broman7-21/+49
These environment variables are read very frequently, read them once to globals for performance improvment. Change-Id: I4f05a5edca85b370674cc5f85fce40bd1af695cb Reviewed-on: https://code.wireshark.org/review/34449 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04Qt: fix compilation for enabled_protocols_model.Dario Lombardo1-2/+2
clang complains, gcc doesn't. Error: In file included from ../ui/qt/enabled_protocols_dialog.cpp:10: In file included from ../ui/qt/enabled_protocols_dialog.h:15: ../ui/qt/models/enabled_protocols_model.h:121:18: error: 'filterAcceptsRow' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const; Change-Id: Ifbba736158a841752da27349925a3b55556728ca Reviewed-on: https://code.wireshark.org/review/34447 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-04Qt: Fix override declarations for PacketListRoland Knall1-11/+12
Fix missing override declarations for packetlist header information Change-Id: If9d1cbcae20b5d098ff7b74cd263a6a21a296598 Reviewed-on: https://code.wireshark.org/review/34446 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-04Update tooltip text for applying display filterMoshe Kaplan1-1/+1
Change-Id: Iba1eb865eac1d22d1490769ae9509b1389594a09 Reviewed-on: https://code.wireshark.org/review/34418 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-04Qt: in EnabledProtocolsDialog handle protocol typeRoland Knall6-45/+157
Allow a selection of the list based on the protocol type. That way one can easily enable/disable for instance just heuristic protocols Change-Id: I1ee8df5d9887c764272ec55b33703855c0c91f5a Reviewed-on: https://code.wireshark.org/review/34442 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-03Qt: Make first column moveableRoland Knall1-0/+4
Due to changes in Qt 5.11, the first section is no longer moveable by default. This is due to internal storage mechanism. For strictly flat tables it is not an issue to make the first column moveable again. (see https://codereview.qt-project.org/c/qt/qtbase/+/207947) Bug: 15879 Change-Id: If4f1371404cd252ec9f65a27c25b1c68781a0c33 Reviewed-on: https://code.wireshark.org/review/34445 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-03NAS 5GS: fix dissection of Session-AMBR/GFBR/MFBR unitPascal Quantin1-7/+6
Change-Id: Iccbc89a586abd33db0dd8c16974ad8d9b5bd21f9 Reviewed-on: https://code.wireshark.org/review/34443 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-03OSC: Set UDP heuristic default off as this is a niche protocol.Anders Broman1-1/+1
The heuristic is a bit expensive, set default off. Change-Id: Ib0cb863810a1cbcae2fef0b5a035c63682246a0f Reviewed-on: https://code.wireshark.org/review/34441 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-03ETSI Card Application Toolkit Transport: Set heuristics default off.Anders Broman1-1/+1
RTP packets picked up by the dissector as it's a niche protocol set heuristics to default off. Change-Id: I33c6c3fc0f4a593cc4ed5866515cdcea669bee54 Reviewed-on: https://code.wireshark.org/review/34440 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-03Also don't treat an empty buffer as JSON.Guy Harris1-3/+7
That also keeps us from looking at the non-existent first octet of an empty buffer. Bug: 16031 Change-Id: I3fcf4201d21dc44ccd8815cb0637c1eae4995560 Reviewed-on: https://code.wireshark.org/review/34439 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-03Strengthen the JSON validator.Guy Harris1-0/+12
jsmn_parse() is handed a buffer and a count of octets in the buffer; it treats either running out of octets, as specified by the count, *OR* seeing a NUL as meaning "end of JSON string". That means that a buffer, of arbitrary size, the first octet of which is zero is a null string and considered valid JSON. That is clearly bogus; it messes up both tests for JSON files *and*, potentially, heuristic checks for JSON in packet payloads. Bug: 16031 Change-Id: I5ee78b613df3358f19787f2ce28ddc883368f03d Reviewed-on: https://code.wireshark.org/review/34438 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-03Strengthen the PacketLogger heuristics.Guy Harris1-20/+159
Check the time stamp microseconds field; it must be < 10^6. Check the first few packets, not just the first packet. Change-Id: I35a58a79d48db13daee937374caae40bc320e9e7 Ping-Bug: 16031 Reviewed-on: https://code.wireshark.org/review/34437 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-02What we're testing for is byte-swappedness, not raw endianness.Guy Harris1-17/+14
On a big-endian machine, if the upper 16 bits of the length are non-zero and the lower 16 bits are zero, that means that the length is *little*-endian. What we really care about is whether the file is in the reading host's native format, so we can just fetch integral values without swapping, or not in that format, in which case we have to byte-swap integral values. Rename the variable and redo the code to match. (This may have caused the PacketLogger reader to fail on big-endian machines.) Change-Id: Ie1a82a7d40e2c58c0b8d482d7c95ab60061ca980 Ping-Bug: 10861 Reviewed-on: https://code.wireshark.org/review/34434 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-02If we get a short read on the first packet in the open, don't check any more.Guy Harris1-37/+37
There's no point in trying to read more packets to check the file type. Change-Id: Ic2c5a7692b60fab8a0022503338a40befe00d358 Ping-Bug: 16031 Reviewed-on: https://code.wireshark.org/review/34433 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-02Strengthen the I4B heuristics.Guy Harris2-19/+89
Check some more field values, and fix some tests to check against the maximum possible value given in the i4b_trace.h file rather than against that value + 1. (> max, or >= max+1, are both reasonable, but > max+1 isn't.) Check the first few packets, not just the first packet. Make some header fields unsigned, as that's how we treat them in most cases; that way we treat them that way by default. Change-Id: I8c2d28af048c676a3dbae367bbb49c886e0dc566 Ping-Bug: 16031 Reviewed-on: https://code.wireshark.org/review/34432 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-02NAS 5GS: fix dissection of QoS flow description IEPascal Quantin1-39/+101
Do not reuse Session AMBR fields for MFBR and GFBR. Add averaging window and EPS bearer identity cases. Change-Id: I34fad0b5f38aa097bb968106de2bbb86278579b9 Reviewed-on: https://code.wireshark.org/review/34430 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-02NAS 5GS: display protocol identifier string in QoS Rule IEPascal Quantin1-2/+2
Change-Id: I9d5e1f099b9273b20bf335a5b29ef66cf112c928 Reviewed-on: https://code.wireshark.org/review/34429 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-02Qt: PacketList call DecodeAsDialog directlyRoland Knall2-30/+43
Calling the directly from the context menu and setting data just before the execute of the menu can lead to information not present. Furthermore for future changes, the move to have QMenu only as a local variable is being reverted Change-Id: I470da26e658ae81ca416b3864889a4317b865755 Reviewed-on: https://code.wireshark.org/review/34428 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-09-02couchbase: update command identifiersSergey Avseyev1-0/+8
Change-Id: Ic6eb59a26dc0a9edd216a985bbf94d13b4bc5094 Reviewed-on: https://code.wireshark.org/review/34427 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02tshark: Add "ip" as alias for "ipv4" in -z hosts option.Michael Mann2-4/+6
Make it consistent with -z conv,ip and -z endpoints,ip Bug: 15660 Change-Id: I9a3d2e95fed47231c0bab20e6cf069987eed142f Reviewed-on: https://code.wireshark.org/review/34426 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02Add number of comments in capture file to status barMichael Mann1-0/+5
Ping-Bug: 15799 Change-Id: Icad9c4de620c0ffc9c4aa1a0b1b0d1ea444f481f Reviewed-on: https://code.wireshark.org/review/34425 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02TCP: Provide display filters for "raw" SEQ/ACK.Michael Mann2-3/+21
Add hf_ fields for "raw" Sequence and Acknowledgment numbers. They will only be visible when "Relative sequence numbers" preference is TRUE. Bug: 15913 Change-Id: Icfbdc435e82723d663dce36c3a5cc513c837bdaf Reviewed-on: https://code.wireshark.org/review/34421 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-02IEEE802.11: Minor cleanupMichael Mann1-43/+42
1. he_mac_headers can be changed at runtime, so it is not "static" or "const" 2. Optimize out extended length calculation. Ping-Bug: 15866 Change-Id: Ibf8191a7043a22109ae8a3db481bfbbef583b110 Reviewed-on: https://code.wireshark.org/review/34424 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-09-01Clean up some formatting.Guy Harris1-32/+32
List syntax is *not* one of the more straightforward parts of AsciiDoc. Change-Id: Icfed27de84c8c11cad02c4ba4d359786cd480eea Reviewed-on: https://code.wireshark.org/review/34423 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-01Fix the section on Boolean fields to match reality.Guy Harris1-8/+12
Confusing though it might be, a patch-matching expression containing only the name of a Boolean field matches all packets containing that field, regardless of whether the field is true or false; you need to compare the field against 1 to check whether it's true. Change-Id: I615acc4d71964c8474e6f3655ade8814cbe07b22 Reviewed-on: https://code.wireshark.org/review/34422 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-01SMTP: Consider bytes seen as "data" until a command is seenMichael Mann1-2/+3
Create a state for the start of an SMTP conversation. If bytes seen don't match a command and conversation is still in the "start" state, treat bytes as message data, not a command. Bug: 16026 Change-Id: I229b316a77819b07bf8cf93bed72570a947c6cf3 Reviewed-on: https://code.wireshark.org/review/34412 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01net_dm: Add dissector for drop monitor netlink packetsIdo Schimmel3-0/+503
The Linux kernel includes a module called drop monitor which - unsurprisingly - monitors packet drops. Once enabled, the module will periodically send netlink notifications to user space over generic netlink. Historically, these notifications only included the program counter where the drop occurred and the number of packets that were dropped in this location in the last interval. Patches in net-next (queued for Linux kernel 5.4) extend drop monitor with another mode of operation where the dropped packets themselves are sent to user space along with relevant metadata as netlink notifications. This allows users to perform a more detailed analysis of the dropped packets. This patch adds a dissector for these netlink packets. The dissector is expected to be invoked by the generic netlink dissector and during its hand off routine it adds an entry in the 'genl.family' dissector table. The various netlink attributes are dissected by calling dissect_netlink_attributes(), in a similar fashion to the rtnetlink dissector. The dropped packet itself is encoded in the netlink attribute 'NET_DM_ATTR_PAYLOAD' and dissected by invoking a dissector from the 'sll.ltype' dissector table based on the packet's protocol which is encoded in the 'NET_DM_ATTR_PROTO' attribute. Bug: 16018 Change-Id: I10bfa4b9c9d8f5e82769c250f929f74693142a23 Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reviewed-on: https://code.wireshark.org/review/34351 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 07:03:46 +0000