aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2012-07-09The names "etherpeek" and "airopeek" are a bit misleading, as theGuy Harris8-224/+236
"etherpeek.c" file format is used by AiroPeek and the "airopeek9.c" file format is used by EtherPeek. Instead, use the names that WildPackets apparently uses for those formats - "classic" and "tagged". svn path=/trunk/; revision=43630
2012-07-09Update commentsPascal Quantin1-3/+3
svn path=/trunk/; revision=43629
2012-07-09Add LTE Positioning Protocol Extensions dissectorPascal Quantin19-61/+26015
Upgrade LTE Positioning Protocol to V10.5.0 svn path=/trunk/; revision=43628
2012-07-09As suggested by Richard Sharpe: rename VALS_GROUP_NAMES[] so it's not allJeff Morriss1-11/+11
upper case. Don't mark stat_group_name()'s 'group' parameter unused: it is unused. svn path=/trunk/; revision=43627
2012-07-09Minor formatting changes: Surround Clement Marrast's e-mail with <> like ↵Chris Maynard1-551/+551
everyone else's and no need to capitalize Clement's entire last name. Convert some spaces to tabs. Remove spaces surrounding " [AT] ", as it seems that initially that's how they were being written. svn path=/trunk/; revision=43626
2012-07-09Update AVP dissection.Anders Broman2-5/+41
svn path=/trunk/; revision=43625
2012-07-09Dissect Release 8 CDR:sAnders Broman8-391/+3238
svn path=/trunk/; revision=43624
2012-07-09From Evan Huus: Struct cleanup in packet-assa_r3.cBill Meier1-385/+342
Cleanup and simplify structures and arrays in packet-assa_r3.c as described in my email to the -dev list [1]. [1] http://www.wireshark.org/lists/wireshark-dev/201207/msg00050.html From me: Do the same as above for the commandDissectorParser_t struct mentioned in the EMail (but not fixed in the patch). svn path=/trunk/; revision=43623
2012-07-09From Michael Mann:Anders Broman2-8/+54
disable hide checkboxes with error messages Updated preference dialog to include text if hide checkbox is disabled. Used error message for "Local Interfaces" dialog. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2598 svn path=/trunk/; revision=43622
2012-07-09From Evan Huus:Anders Broman1-44/+39
IO Graph Fixes - Allow counting *any* type of field, FT_NONE, FT_PROTOCOL, whatever, by moving FT_NONE case to default case per Jakub's suggestion. - Fix get_it_value() for FT_PROTOCOL fields by breaking CALC_TYPE_COUNT_FRAMES and CALC_TYPE_COUNT_FIELDS out of the adv_type switch statement just like COUNT_TYPE_FRAMES. - Avoid an overflow in pixmap_clicked_event() that was causing crashes when clicking outside the data portion of the graph (when the capture hasn't enough files to fill the entire graph window), svn path=/trunk/; revision=43621
2012-07-09From Martin Kaiser:Anders Broman1-20/+67
DVB-CI/CI+: dissect the payload of LSC messages. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7440 svn path=/trunk/; revision=43620
2012-07-09From Martin Kaiser:Anders Broman1-3/+6
CID 280531: "Argument cannot be negative" in lemon https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7453 svn path=/trunk/; revision=43619
2012-07-09From Evan Huus:Anders Broman1-8/+8
Redundant conditions in iax2_analysis.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7456 svn path=/trunk/; revision=43618
2012-07-09From Evan Huus:Anders Broman7-13/+21
Fix leaks - don't g_strdup a string just to use it in a g_strdup_printf - clean up properly in error cases in lua bindings - misc. other missing g_free() calls - one missing fclose() in the new 80211_utils https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7454 svn path=/trunk/; revision=43617
2012-07-09From Evan Huus:Anders Broman7-41/+4
Grab-bag of unused variables. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7452 svn path=/trunk/; revision=43616
2012-07-09From Michael Mann:Anders Broman6-16/+65
GUI use external name resolver proliferation https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7380 svn path=/trunk/; revision=43615
2012-07-08[Automatic manuf, services and enterprise-numbers update for 2012-07-08]Gerald Combs3-5/+175
svn path=/trunk/; revision=43611
2012-07-08Add a function to packet-giop.c that does what the code that Jeff Morriss6-9889/+1272
template_get_CDR_string (in wireshark_gen.py) did. This eliminates another whole pile of function-local variables in packet-parlay.c. Unfortunately it doesn't seem to speed up compilation (or eliminate the variable tracking size limit problem). But it does eliminate a lot of lines of code... svn path=/trunk/; revision=43610
2012-07-08Eliminate a lot of function-local variables by not storing the result ofJeff Morriss5-9937/+8533
(several of the) get_CDR_*() functions: instead call the function directly in the proto_tree_add_text() calls. Eliminate a lot of global variables that are only later used in (a single) strcmp(). All the GIOP dissectors are built-in now; don't include the (#if'd out) plugin registration code in the generated dissector. Try to clean up the formatting of the generated code a bit. Regenerate the IDL dissectors; as noted in r39932, this seems to involve a lot of function re-ordering in packet-parlay.c (making the delta bigger). These changes decrease the time to compile packet-parlay.c by, on my system, about half. But it still complains: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without and it still takes "too long." svn path=/trunk/; revision=43609
2012-07-08Unless NL80211_BAND_ATTR_HT_CAPA is defined, assume we don't haveGuy Harris1-1/+5
channel-type-setting capabilities, and don't build the code to set the channel type or fetch any channel types other than "no HT". (It *looks* as if nl80211.h defines NL80211_BAND_ATTR_HT_CAPA as a member of an enum *and* as a #define, at least in the kernels I've looked at, so we can test for it with #ifdef - perhaps that's *why* it's #defined.) svn path=/trunk/; revision=43608
2012-07-08Don't bother printing the Description of STATIC_TEXT and UAT preferences:Jeff Morriss1-7/+10
they don't make it into the preferences file anyway... svn path=/trunk/; revision=43607
2012-07-08Keep the NL80211_CHAN_ and WS80211_CHAN_ values distinct; only theGuy Harris2-19/+26
Linux version of the platform-dependent 802.11 stuff should use the NL80211_CHAN_ stuff. Map from the WS80211_CHAN_ values to the corresponding NL80211_CHAN_ values in ws80211_set_freq(), and have the channel_types bitset use bits indexed by WS80211_CHAN_ values rather than NL80211_CHAN_. This won't fix the problem of building this on Linuxes with old nl80211.h headers that lack NL80211_CHAN_, but it narrows the set of code that needs the NL80211_CHAN_ values, perhaps allowing the fix to be a bit cleaner, as well as making it easier to make this work on platforms other than Linux. svn path=/trunk/; revision=43606
2012-07-08First phase of fixing https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7380 :Jeff Morriss8-50/+61
Add a new name resolution option: whether or not use the configured (in the OS) name resolver (e.g., DNS) to resolve network names. When this option is disabled but network name resolution is enabled then Wireshark will resolve only those names that it can from local sources. This includes (at least, AFAIK): - name resolutions that Wireshark picks up on from DNS packets it decodes - the "user hosts file" (~/.wireshark/hosts on *NIX) - what Wireshark reads out of capture file (the PCAPNG name resolution block) This new preference defaults to "use external resolvers" for backward compatibility (so people turning on network name resolution will get the old behavior). This option can be set via Edit->Preferences and on the command line; there remain several UIs (e.g., the "open capture file" dialog, the View->Name Resolution menu, etc.) that don't have the new option yet. Also expand on the "description" for the name resolution preferences: these are used not only in the tooltips but are also written to the preferences file. The previous text didn't include enough context when written do the preferences file. svn path=/trunk/; revision=43605
2012-07-08From Evan Huus:Guy Harris3-15/+64
Don't initialize GeoIP from epan_init(), as we probably haven't loaded the preferences for it yet (thanks to it's new use of the UAT framework). Instead, register a post_update callback with UAT and load it there. As a bonus, this also means that applying GeoIP preferences no longer requires restarting Wireshark - everything should Just Work with the new databases right away. Fixes bug 7446. svn path=/trunk/; revision=43604
2012-07-08UATs could be put into "categories". The categories were defined onlyGuy Harris36-113/+144
implicitly by the #define name and string they were defined to; not all UATs neatly fit into any of the categories, so some of them were put into categories that weren't obviously correct for them, and one - the display filter macro UAT - wasn't put into any category at all (which caused crashes when editing them, as the GUI code that handled UAT changes from a dialog assumed the category field was non-null). The category was, in practice, used only to decide, in the aforementioned GUI code, whether the packet summary pane needed to be updated or not. It also offered no option of "don't update the packet summary pane *and* don't redissect anything", which is what would be appropriate for the display filter macro UAT. Replace the category with a set of fields indicating what the UAT affects; we currently offer "dissection", which applies to most UATs (any UAT in libwireshark presumably affects dissection at a minimum) and "the set of named fields that exist". Changing any UAT that affects dissection requires a redissection; changing any UAT that affects the set of named fields that exist requires a redissection *and* rebuilding the packet summary pane. Perhaps we also need "filtering", so that if you change a display filter macro, we re-filter, in case the display is currently filtered with a display filter that uses a macro that changed. svn path=/trunk/; revision=43603
2012-07-07From Evan Huus:Guy Harris1-1/+1
There is no guarantee that uat->category is non-null, so check whether it's null before checking whether it's UAT_CAT_FIELDS or not. Fixes bug 7444. #BACKPORT svn path=/trunk/; revision=43602
2012-07-07Use -D_FORTIFY_SOURCE=2 only if the gc optimization level is greater than 0.Bill Meier2-5/+53
Fixes Bug #7449: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7449 ----- Issue: Building Wireshark with '-O0 -D_FORTIFY_SOURCE=2 ...' fails The warning [error] message: /usr/include/features.h:314:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp]` A bit of research shows that this warning was added to a recent version of glibc (on at least Fedora). See: http://sourceware.org/bugzilla/show_bug.cgi?id=13979 The warning message occurs if -D_FORTIFY_SOURCE=... is used and the gcc 'optimization level' == 0 (-O0). Unfortunately when building with -O0 this warning message: 1. Causes compiles to fail (if -Werror [stop on warning]) 2. Causes ./configure to fail with an (incorrect) message about the pcap header being older than the libpcap version. svn path=/trunk/; revision=43601
2012-07-07Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7445 :Jeff Morriss1-1/+1
"Find Next Mark" was duplicated in the Edit menu and "Find Previous Mark" was missing (the 2nd "Find Next Mark" would, if selected, find the previous mark). svn path=/trunk/; revision=43600
2012-07-07From Evan Huus: Fix "Useless null checks in packet-dcerpc*"Bill Meier2-3/+3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7448 svn path=/trunk/; revision=43599
2012-07-07From Evan Huus: fix "Unused variable in packet-ansi_a.c"Bill Meier1-2/+4
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7447 svn path=/trunk/; revision=43598
2012-07-07From Michael Mann:Guy Harris7-3/+170
Add a preference for the packet length statistics. Fixes bug 3239. svn path=/trunk/; revision=43597
2012-07-07Only one place is needed for creating preference panes; this clears upGuy Harris2-95/+49
some warnings from GTK+. For interior nodes in the preference module tree, we create a page even if the module itself has no preferences, so there's *something* we can show if the user clicks on it. (Showing the top-level protocols page is a bit weird, and requires us to keep track of it.) svn path=/trunk/; revision=43596
2012-07-07Ask about a possible simplification (by just handling all modules byGuy Harris1-0/+2
pathname, so that any module we create for a protocol is just created as being under "Protocols/"). svn path=/trunk/; revision=43595
2012-07-07Clean up mix of tabs and 4-space-tab indents.Guy Harris1-61/+59
svn path=/trunk/; revision=43594
2012-07-07Uniformly use two-space indents (most of the file uses it).Guy Harris1-31/+31
svn path=/trunk/; revision=43593
2012-07-07Get rid of most tabs (which cleans up mixed indenting with tabs andGuy Harris1-1031/+1030
4-tab spaces). svn path=/trunk/; revision=43592
2012-07-06As per Michael Mann's email:Guy Harris8-943/+0
Yes, the following files can now be deleted: \wireshark\ui\gtk\prefs_nameres.c \wireshark\ui\gtk\prefs_nameres.h \wireshark\ui\gtk\prefs_print.c \wireshark\ui\gtk\prefs_print.h \wireshark\ui\gtk\prefs_protocols.c \wireshark\ui\gtk\prefs_protocols.h \wireshark\ui\gtk\prefs_taps.c \wireshark\ui\gtk\prefs_taps.h I thought removing them was part of the patch for bug 7402, but they still show up in the SVN (perhaps I didn't create the patch correctly). Make it so. svn path=/trunk/; revision=43591
2012-07-06Display (and allow filtering on) the "reserved for national use" bit in the AI.Jeff Morriss1-9/+27
(This bit is already decoded as the "national indicator" bit in ANSI.) svn path=/trunk/; revision=43590
2012-07-06Gadu-Gadu: dissect more packets.Jakub Zawadzki1-1/+249
svn path=/trunk/; revision=43589
2012-07-06Fix logic typo, it should fix bug #7434Jakub Zawadzki1-2/+2
svn path=/trunk/; revision=43588
2012-07-06Fix compilation with gcc 4.3.2 and without GEOIPPascal Quantin3-7/+8
svn path=/trunk/; revision=43587
2012-07-06- remove no longer used #definesJakub Zawadzki2-6/+3
- prefs.name_resolve_concurrency is now just 'name_resolve_concurrency' - add notes about possible (?) integer overflows. svn path=/trunk/; revision=43586
2012-07-06Revert part of r43579, MSVC_VARIANT should be not defined.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43585
2012-07-06- e_addr_resolve is structure so pass it by pointer.Jakub Zawadzki6-7/+9
- name_resolve_concurrency must be only defined when used. svn path=/trunk/; revision=43584
2012-07-06Fix compilation of epan/oids.c without HAVE_LIBSMIJakub Zawadzki1-7/+3
svn path=/trunk/; revision=43583
2012-07-06Try to fix compilation on compilers != MSVC.Jakub Zawadzki1-2/+2
Note: we should get rid of this circular dependency. svn path=/trunk/; revision=43582
2012-07-06Add a few missing ENC_ASCII and remove a few unused hf entriesPascal Quantin1-32/+4
svn path=/trunk/; revision=43581
2012-07-06From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7407 :Pascal Quantin1-4/+772
Update ESTA manufacturer IDs and OEM code values svn path=/trunk/; revision=43580
2012-07-06From Michael Mann:Anders Broman25-398/+495
Generic preferences implementation - Printing and Name Resolution. svn path=/trunk/; revision=43579
2012-07-06Take yet more care not to be dividing by zero when calculating the bitMartin Mathieson4-3/+29
rate of the channel/UE. Times four... svn path=/trunk/; revision=43578