aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-10-15Remove superfluous null-checks before strdup/freeAhmad Fatoum89-564/+220
NULL checks were removed for following free functions: - g_free "If mem is NULL it simply returns" https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free - g_slist_free(_full)? "NULL is considered to be the empty list" https://developer.gnome.org/glib/stable/glib-Singly-Linked-Lists.html - g_strfreev "If str_array is NULL, this function simply returns." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strfreev - g_slice_free "If mem is NULL, this macro does nothing." https://developer.gnome.org/glib/stable/glib-Memory-Slices.html#g-slice-free - g_match_info_free "not NULL... otherwise does nothing" https://developer.gnome.org/glib/stable/glib-Perl-compatible-regular-expressions.html#g-match-info-free - dfilter_free defined in Wireshark code. Returns early when passed NULL epan/dfilter/dfilter.c They were also removed around calls to g_strdup where applicable: - g_strdup "If str is NULL it returns NULL." https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#g-strdup Change-Id: Ie80c2db89bef531edc3aed7b7c9f654e1d654d04 Reviewed-on: https://code.wireshark.org/review/23406 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15Fix commentJoão Valverde1-1/+1
Change-Id: Idebca52f2dbebbfc9edb132c3e8ca8d6e1ef79f4 Reviewed-on: https://code.wireshark.org/review/23926 Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15autotools: Make some installation hints more visibleJoão Valverde1-19/+6
Change-Id: I347f2983f5d8f11791d0ed0e51ba51de36b1d11f Reviewed-on: https://code.wireshark.org/review/23925 Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15Revert "autotools: dispense with some installation warnings/notes"João Valverde1-0/+44
This reverts commit 79cdf3a8201ca27abf2bea29e9b9c6b3107ea5db. Change-Id: I019a037e399859b613456283e35cf81f5932b21c Reviewed-on: https://code.wireshark.org/review/23924 Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15autotools: dispense with some installation warnings/notesJoão Valverde1-44/+0
These are not (easily) visible during installation and are better suited for documentation anyway, as implied in the Makefile comments. Change-Id: Id2581f6e8dfc05f1a6c0de918a0f687f025e6d12 Reviewed-on: https://code.wireshark.org/review/23910 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15[Automatic update for 2017-10-15]Gerald Combs2-4/+51
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ic0da94f81172212f1688ccb8213f3ee912256600 Reviewed-on: https://code.wireshark.org/review/23919 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-15ssl: assume everything after CCS is encryptedPeter Wu3-0/+16
After ChangeCipherSpec, record fragments are encrypted. Use this strong hint to fix misinterpreting the explicit nonce as a handshake message. One edge case remaing unsolved though, if an encrypted Finished message follows the CCS in the same TCP packet, then it could still be misinterpreted. Bug: 14117 Change-Id: Ie54bb5335f115d0fd8f05a13d1c826e3807cbbd3 Reviewed-on: https://code.wireshark.org/review/23900 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-10-15autotools: dispense with desktop-file-installJoão Valverde2-15/+1
Change-Id: I20717e669709bde6c7b1ff7d10f928e2ec2cc263 Reviewed-on: https://code.wireshark.org/review/23909 Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15autotools: dispense if-else shellcheck testJoão Valverde2-9/+2
Change-Id: I1fd63442b27460ef21b2aaf4e3639a7d12c72c6e Reviewed-on: https://code.wireshark.org/review/23908 Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15autotools: remove unused variablesJoão Valverde2-6/+0
Change-Id: I1636358f76c7c230b8b464a17dddf520b723b36b Reviewed-on: https://code.wireshark.org/review/23907 Reviewed-by: Guy Harris <guy@alum.mit.edu> Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-10-15Rename ui_util.h -> ws_ui_util.hPeter Wu36-37/+37
In preparation for possibly using AUTOUIC in CMake which treats "ui_*.h" files specially, rename ui_util.h. No other changes. Change-Id: Id026572c000b713ff0e9388dc7fff8d81d4df73e Reviewed-on: https://code.wireshark.org/review/23916 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-15Tshark: Optional packet summary for ElasticsearchChristoph Wurm4-52/+88
Currently, the Elasticsearch output exports the packet details and, if -x is specified, the raw hex data. This change adds the option of exporting the packet summary as well. The default stays the same (packet details only), but now the existing -P switch turns on printing of the packet summary. It also turns off printing packet details, which can be turned back on with -V to print both, and combined with -x to print all three: summary, details and raw hex. The packet summary is especially useful when exploring and visualizing the data in Kibana, e.g. by displaying the summary "Info" field/column in a table, as in the Wireshark GUI. Change-Id: I2030490cfdd905572397bc3d5457ba49d805a5c4 Reviewed-on: https://code.wireshark.org/review/22716 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-15FindPOD.cmake: look for pod2man.batPeter Wu1-0/+1
Strawberryperl 5.26.1.1 installs "pod2man.bat" but not "pod2man" so find_program cannot locate it. Change-Id: Iebfe2efec220085b15a4d73681da9cc7ea6a5360 Reviewed-on: https://code.wireshark.org/review/23913 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-14configure: Fix PCAP_LIBS without pcap-configJoão Valverde1-3/+3
Also remove XXX comment (answer: no, using package flags is preferable). Change-Id: I05e7c0a40db9f1e1931b0fc585fed49cd7409526 Reviewed-on: https://code.wireshark.org/review/23901 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-10-14Some trivial fixes from running cppcheck.Martin Mathieson3-3/+4
The packet-per.c intialisation of ext_length is not really needed - idx could be -1 with or without extension_flag being set. But it'd be best not to have someone need to think this through again. Change-Id: If07f98ac7d7f2619149e35a2a0d75b765839a7ba Reviewed-on: https://code.wireshark.org/review/23905 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-14Update comment.Guy Harris1-1/+2
Red Hat, at one point, provided a /usr/include/pcap/pcap.h without bothering to also provide a /usr/include/pcap.h that linked to it or included it, breaking source compatibility. That's what we're working around when we search in both the top-level include directories and, if they exist, pcap subdirectories of those directories. libpcap 1.0 and later also put pcap.h in a pcap subdirectory, but also provided a pcap.h in the top-level include directory that included pcap/pcap.h, preserving source compatibility, so that's not the reason we're searching in the top-level include directories and their pcap subdirectories. Change-Id: I8f427d46ce8293d278be9005ee623cda1ea5d691 Reviewed-on: https://code.wireshark.org/review/23902 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-10-14FP Fixed bug in heuristic dissectorDarien Spencer1-1/+1
Change-Id: I6960c7b9a2fa1b9f86e06df5036b4e0bcf1dcfe0 Reviewed-on: https://code.wireshark.org/review/23898 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-10-13CMake: Allow user build flags to override default build flagsJoão Valverde20-57/+42
Autotools has the very useful feature by design of allowing the user to override the default build flags (you break it you keep it). Apparently CMake applies COMPILE_OPTIONS target property after CMAKE_{C,CXX}_FLAGS so that doesn't work here. Prepend our flags to those variables instead to make it work then. Specific target flag overrides can still be added with COMPILER_OPTIONS (e.g: generated files with -Wno-warning) but this is less effective and then we're back at the point where this overrides user flags. It's less of a concern though. Change-Id: I44761a79be4289238e02d4e781fef0099628817b Reviewed-on: https://code.wireshark.org/review/23675 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-10-13docsis: fix ↵Alexis La Goutte1-6/+6
'docsis_vsif.gex.sav.spr.static_prefix_address/.gex.imja.imja_ssr_source_prefix_address/.imja.imja_ssr_group_prefix_address' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 Change-Id: I7c978870eb3cc54e718fe3c810f7b4e7f6ea67c9 Reviewed-on: https://code.wireshark.org/review/23897 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-13docsis: fixAlexis La Goutte1-1/+1
'docsis_vsif.gex.extended_cmts_mic_hmac_type' exists multiple times with NOT compatible types: FT_BYTES and FT_UINT8 Change-Id: Ic3a0f7f6edf5a28ffde6703276d4747d138081c7 Reviewed-on: https://code.wireshark.org/review/23896 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-13Add ptvcursor APIs that return the values it retrievesMichael Mann4-24/+296
ptvcursor_add_ret_uint ptvcursor_add_ret_int ptvcursor_add_ret_string ptvcursor_add_ret_boolean Change-Id: I41fa91b1ab805778d34a61215830b12a1331e864 Reviewed-on: https://code.wireshark.org/review/23895 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-13WiMAX ASN CP: Leak less memory.Gerald Combs2-59/+52
Replace some g_new()s, g_strdup()s and GArrays used in prefix registration with their epan_scoped wmem equivalents. This reduces the amount of memory we leak so that we come in below the Valgrind fuzzer's current threshold (102400). Bug: 14106 Change-Id: I7308ac89465316c06773552253dabc876b6c2425 Reviewed-on: https://code.wireshark.org/review/23891 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-12win-setup: Don't bother downloading UPX.Gerald Combs1-2/+0
We haven't used UPX since g85eec7f603 (2014). Don't bother downloading it. Change-Id: Id86ca6ae8f29adab3eb40a2ea3bd1de5ff45d868 Reviewed-on: https://code.wireshark.org/review/23894 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-12FTP: setup conversation properly for PASV sessionsMartin Mathieson1-36/+42
Also keep track of last frame of data response, and work out duration of ftp-data stream. Change-Id: I460aaa5c8736e044410eab428707651cede39d7e Reviewed-on: https://code.wireshark.org/review/23880 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2017-10-12IEEE 802.11: fix a segmentation fault introduced in gd6eda2a3Pascal Quantin1-1/+2
Bug: 14114 Change-Id: Ie377b1b3ccf29014935b9e5796567cdb8bb466a3 Reviewed-on: https://code.wireshark.org/review/23893 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-12[TCAP] Make "tid" a generated item rather than hidden to make it obviousAndersBroman2-4/+4
that it exists. Change-Id: I1986b7678193f3b4c9ed8cabff7e411cef5bf185 Reviewed-on: https://code.wireshark.org/review/23892 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-12infiniband: add PSN and RETH DMA length to infinibandinfo structJorge Mora2-8/+10
Expose the PSN (packet sequence number) and the RETH DMA length to protocol's dissectors. Change-Id: Ied53a8964d7cd5c3d148ec7c7642017951e56118 Reviewed-on: https://code.wireshark.org/review/23886 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-11IEEE 802.11: add missing breaksPascal Quantin1-0/+6
Change-Id: Ie26b0c869a778f7e27cb6d944c2e32ced0d3337e Reviewed-on: https://code.wireshark.org/review/23889 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-10-11Add --print as an alias for -P, to match tcpdump.Guy Harris2-3/+10
tcpdump just got a --print option, which causes packet information to be printed even if the raw packets are being saved to a file with -w. We have -P for the same purpose; make --print another name for it. While we're at it: document --help and --version; just speak of -P/--print as causing printing even of the packet details, even though -V forces printing with -w, for consistency with how --print is documented for tcpdump; fix the description of -h/--help. Change-Id: Idf650a202a09a2d1682edbd9d76123f1b1412b55 Reviewed-on: https://code.wireshark.org/review/23888 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-10-11ProtoBuf: Remove an unused variable.Gerald Combs1-9/+1
Remove protobuf_message_direction_type: ../epan/dissectors/packet-protobuf.c:125:20: error: unused variable 'protobuf_message_direction_type' [-Werror,-Wunused-const-variable] VALUE_STRING_ARRAY(protobuf_message_direction_type); ^ Have dissect_one_protobuf_field return a gboolean while we're here. Change-Id: I5d9d2e3414b5668ca26d5c0a450225c3cdf5da56 Reviewed-on: https://code.wireshark.org/review/23887 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-11Decode SNR in Compressed MIMO Beamforming report per ieee80211at_2013 ↵Jason Uher1-8/+30
sections 8.4.1.{29,48} Change-Id: I4f3af7e06169461a15507ed8ecce8f15075b9667 Reviewed-on: https://code.wireshark.org/review/23835 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-11[Solaredge] Fix SuSE 11.4 build packet-solaredge.c:1013: error:AndersBroman1-7/+7
declaration of rand shadows a global declaration Change-Id: I98f4edb14cd241bd709d50e8ac9151448773a658 Reviewed-on: https://code.wireshark.org/review/23884 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-10Start of adding Protobuf (Protocol Buffers) dissector.Huang Qiangxiong5-0/+763
1. Protobuf dissector supports the almost all basic protobuf types of varint, sint, string, and so on. 2. Protobuf messages are not self-described protocol, for example, varint in protobuf may be int32, int64, uint32, uint64, sint32, sint64, bool or enum. Currently dissector will dissect field without detail definition in common way, for numeric field it show uint32 or uint64, for length-delimited field it just show as bytes. But user turn the try_dissect_all_length_delimited_field_as_string or show_all_possible_field_types options on, that dissect will show all possible value for each field according to wire type. (for example, a numeric field will parsed in int32, uint32, sint32, sint64 and so on). Ping-Bug: 13932 Change-Id: Idfe49307b1c84fe461603756f75daeb3e410a905 Reviewed-on: https://code.wireshark.org/review/23814 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-10[GSM SMS] If the digits are E164 International number add an E.164AndersBroman1-1/+11
filter. Change-Id: Idcfa53d1db9e9f7b5501ca92592fb0fa0790ffe9 Reviewed-on: https://code.wireshark.org/review/23873 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-10Change FI_VARINT to account for FI_BITS_XXX flagsMichael Mann1-2/+2
FI_BITS_XXX were using bits 5-15 of the field_info->flags bitmask. Move FI_VARINT to be outside of that range. Change-Id: I92efcb5644cdbb562537d2813b611e583315874b Reviewed-on: https://code.wireshark.org/review/23871 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-10[gvcp] fix extendedblockids check and resend cmd parsingFelix Ruess1-3/+3
Change-Id: I9e0314ae2e975a1c50cfaf2b00e469ad7f640357 Reviewed-on: https://code.wireshark.org/review/23866 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-09Fuzz: Limit the number of packets we process with Valgrind.Gerald Combs1-7/+8
Estimating the effort required to process a capture based on its size isn't very reliable. Instead of rejecting files that are too large, just limit Valgrind fuzzing to the first 100,000 packets in each file. This should fix a timeout issue we're seeing on the master fuzzer. Change-Id: I0117735341d3a183c6131f5f05dbd1d559fc4b3f Reviewed-on: https://code.wireshark.org/review/23872 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-09infiniband: fix OpCodeMap string for UC_RDMA_WRITE_MIDDLEJorge Mora1-5/+1
Make string mapping for UC_RDMA_WRITE_MIDDLE consistent with all other mappings in the OpCodeMap table. Remove extra blank lines in the OpCodeMap table. Change-Id: Ifb3e242a89458103f3db3b5718d5d939dffb6dae Reviewed-on: https://code.wireshark.org/review/23867 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-09Fuzz: Write memory leak info to the error log.Gerald Combs1-0/+1
When we exit due to excessive memory leaks make sure we say so in the error log. Change-Id: I03f60271f3e4bb467fbaa5b9ac17431eed96f300 Reviewed-on: https://code.wireshark.org/review/23870 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-09[Diameter 3GPP] Fix bitmask in feature list B26 and add B27.AndersBroman1-3/+11
Change-Id: I0f035da3f5305ce6935c79e0c1b5f63f955d099d Reviewed-on: https://code.wireshark.org/review/23865 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-09Add ENC_VARINT_PROTOBUFMichael Mann6-41/+378
Encoding of integer datatypes of Protocol buffers https://developers.google.cn/protocol-buffers/docs/encoding Change-Id: I9f6d65ddca099c15c0634984e9394131f98d35a9 Reviewed-on: https://code.wireshark.org/review/23813 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-09packet.c: fix a control flow issue reported by Coverity (CID 1418671)Pascal Quantin1-6/+6
Let's perform the check before potentially breaking the loop. While we are at it, let's update the test to remove the last layer so as to match the one used to add it. Change-Id: I5807219de75c4e2c23b9435d6271ad60aec45783 Reviewed-on: https://code.wireshark.org/review/23844 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-08ftypes(.h): fix indent (use tabs)Alexis La Goutte1-15/+15
Change-Id: Ic824910d4ec8c9987e8deec8d61809feb9849b9b Reviewed-on: https://code.wireshark.org/review/23863 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-08proto(.h): fix indent (use spaces)Alexis La Goutte1-2/+2
Change-Id: I029a9db40c8ca5a67bb1db69c50d8f08b7f59ab2 Reviewed-on: https://code.wireshark.org/review/23864 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-08[Automatic update for 2017-10-08]Gerald Combs2-2/+36
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I700244d357bcb8d37866b296ea7c6bb671f983af Reviewed-on: https://code.wireshark.org/review/23859 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-10-07X2AP: fill gaps in extended value string arrayPascal Quantin2-0/+12
Change-Id: I6d8594de78dd46d679072cc17211e940155f0012 Reviewed-on: https://code.wireshark.org/review/23858 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-10-07S1AP: upgrade dissector to v14.4.0Pascal Quantin9-15/+25
Change-Id: I1124a691ec004507e6e144038b13f9d432d88c5f Reviewed-on: https://code.wireshark.org/review/23857 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-10-06tap-flow (ui): fix no previous prototype for ↵Alexis La Goutte1-1/+1
‘register_tap_listener_flow’ [-Wmissing-prototypes] Change-Id: I6031600ee3d764a7b2690ff88dbbfb01a1d6244b Reviewed-on: https://code.wireshark.org/review/23824 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-06RPC-over-RDMA: fix write list chunk countJorge Mora1-0/+1
Add the chunk_size to the offset to get the correct write list count, this issue was introduced by the fix for Bug: 13558 Change-Id: I306a9c0c9d601f7bdf4cc0e49eacd5466a6adb89 Reviewed-on: https://code.wireshark.org/review/23851 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-06DOCSIS: added vsif general extension dissectionBruno Verstuyft1-5/+614
Change-Id: Ic61815b967fac412fb1a324c470ff5171b97acbb Reviewed-on: https://code.wireshark.org/review/23840 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>