aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-09packet-nfs.c: Bugfix NFSv4 ACCESS replyJohn Bankier1-8/+17
Both NFSv3 and NFSv4 ACCESS reply dissection will be sensible when the ACCESS request is not available (because the packet containing the request was either not capture or truncated). Bug: 15343 Change-Id: I5bf7b9905e85b1c1eb30e2949b9b246b54f9ec68 Reviewed-on: https://code.wireshark.org/review/30965 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09Add tvb_get_token_lenMichael Mann3-0/+88
This is intended to be a replacement for get_token_len (from strutil.h) when its used on a tvb. It should be a little safer and remove the need for a dissector to use tvb_get_ptr. Change-Id: Ib2d4a79718b6fba4eb9acc0129b13be6c8199a43 Reviewed-on: https://code.wireshark.org/review/30892 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09BitTorrent:Add Fast Extension Message(Bep06) analysisLee Serin1-1/+26
Add message type named 'fast extension' to analyze unprocessed messages Bug: 15345 Change-Id: I62fce2b753899cb4f2ba833a58388906c9f0d2d3 Reviewed-on: https://code.wireshark.org/review/30954 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09CMake: allow nested structures to be initialized via { 0 }Peter Wu1-2/+7
This is already permitted since C89 and popular compilers seem to support it (including Clang 3.0 - 7.0, GCC 4.1.2 - 8.2 and MSVC 2015). GCC used to be buggy: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 C89 6.5.7. Initialization: "only enough initializers from the list are taken to account for the members of the subaggregate". Change-Id: Ic59b9fe71e2d3ce60b4b7d1074f8d84af01a817a Reviewed-on: https://code.wireshark.org/review/30968 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09proto: make ws_type_to_elastic static.Dario Lombardo1-1/+2
Change-Id: I15d1075a1447a6f550d600f765e6abc8dae862ad Reviewed-on: https://code.wireshark.org/review/30972 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-08cattp: use the version bits in the heristic checkMartin Kaiser1-1/+7
The CAT-TP specification says explicitly that the version bits must be zero. Fail the heuristic check if they aren't. I checked ETSI TS 102 127 V15.0.0 from https://www.etsi.org/deliver/etsi_ts/102100_102199/102127/15.00.00_60/ts_102127v150000p.pdf Bug: 15342 Change-Id: I05a886ccd5811f367abdb9faead4983d137c12c6 Reviewed-on: https://code.wireshark.org/review/30970 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-08Remove some unused images.Gerald Combs3-287/+0
Change-Id: Id53cf3f120af755e296262ee5caa9dbf84ea1194 Reviewed-on: https://code.wireshark.org/review/30964 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-07DOCSIS: bugfix: correct dissection of encrypted Mac Specific frameBruno Verstuyft1-6/+16
Change-Id: Id7e300cafe90c965f5eb94f035e872ff6a8231b7 Reviewed-on: https://code.wireshark.org/review/30960 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-07couchbase: Improve key decoderJim Walker1-5/+5
Using the recent updates occasional 'trailing' byte warnings occur if the key encodes a collection-ID, with these changes we now get much better key decoding, without the warnings with and without collections. Change-Id: I9fc1e0d807c8054065a7346a09b0ce99d05f1e63 Reviewed-on: https://code.wireshark.org/review/30956 Reviewed-by: Dave Rigby <daver@couchbase.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-07RTP: Check that we have p_conv_data before accessing it.Anders Broman1-1/+3
Bug: 15346 Change-Id: Ia6ad53423e674832ebb3ccd7c755dd60fecc2cb1 Reviewed-on: https://code.wireshark.org/review/30962 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07DOCSIS: better decoding for unknown tlvsBruno Verstuyft1-46/+95
Previous decoding showed "Unknown TLV: <TLV value>". This was confusing, because people interpreted the value as the type of the unknown TLV. Change-Id: Ia9259db547fca393c248f78ea7c758969b69548e Reviewed-on: https://code.wireshark.org/review/30959 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07dof: remove unnecessary uat_load callsPeter Wu1-5/+0
UATs are loaded at startup, no need to do it again. Call chain: epan_load_settings -> read_prefs -> init_prefs -> uat_load_all. Change-Id: I57caabafb16b0b46fcb6d1621dd6b503154c805c Reviewed-on: https://code.wireshark.org/review/30958 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07GTP: Use correct length for gtp.cgi_ci, gtp.sai_sac and gtp.rai_racAnders Broman1-3/+15
Change-Id: I405bdac11283b83672433995285988c43766e4ab Reviewed-on: https://code.wireshark.org/review/30957 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07PCAP/PCAPNG: Be consistent in documentation, etcJaap Keuter8-45/+61
1) The default build configuration is to select PCAPNG as output format, but it can be selected as PCAP. Some of the command line tools have the option to select the output format and default towards the build configuration. This has to be reflected in their help output also. 2) Various documentation files are still stating that PCAP is the default format of various tools. With the default build configuration being PCAPNG these have to be adjusted as well. (with lack of dynamic content the documentation can only refer to the default build configuration format). Change-Id: I51d19642a7ed8c99817971c1f25d20972095021e Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30951 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07WSMP: Make sure our PSID is initialized.Gerald Combs1-0/+1
Fixes a scan-build warning. Change-Id: I5e6b94240e87684fc41ef1a4daf4272d429f00d4 Reviewed-on: https://code.wireshark.org/review/30952 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07Revert "CMake: Fix Windows help install target"Peter Wu2-87/+75
This reverts commit 8992760c68f3e508a0e5a25307c246a75f7c2ae2. Breaks the "make clean" target as it tries to remove the "help" directory. Since this change, the macOS builds started failing tests as well (init.lua and colorfilters seems not to be applied). Change-Id: I3fce346e04875e667680a4ed9ba3beca8054a168 Reviewed-on: https://code.wireshark.org/review/30950 Reviewed-by: João Valverde <j@v6e.pt>
2018-12-06CMake: limit -Wextra-semi to C++ onlyPeter Wu1-1/+1
Saves a check and removes a GCC warning from CMakeError.log: cc1: warning: command line option ‘-Wextra-semi’ is valid for C++/ObjC++ but not for C Change-Id: I76d027e7b5703b06237ac70eb340c4a09322e09e Fixes: v2.9.0rc0-958-g866ddb1b18 ("Add -Wextra-semi to (clang) C and C++ flags to make sure the buildbots will find this.") Reviewed-on: https://code.wireshark.org/review/30948 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-06DOCSIS: Added Partial Service Downstream Channels TLV 49.6Bruno Verstuyft2-0/+31
Change-Id: Iac09d71a56024440a826ff9ca870c05eeee3a77b Reviewed-on: https://code.wireshark.org/review/30942 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-06Update comments, get rid of IMPORT_MAX_PACKET.Guy Harris4-10/+10
Get rid of the IMPORT_MAX_PACKET #define; just directly use WTAP_MAX_PACKET_SIZE_STANDARD, to match what text2pcap.c does. Update comments in text2pcap.c and ui/text_import.c to say the maximum packet size is WTAP_MAX_PACKET_SIZE_STANDARD. Change-Id: I34118f76426d1416fccf43b2a356ad8d200de19b Ping-Bug: 15292 Reviewed-on: https://code.wireshark.org/review/30945 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-06ieee80211: Fix the handling of A-Control and improve AP Tx Power.Richard Sharpe1-24/+68
1. Correctly print out the AP Tx Power level. 2. The A-Control UL MU Response field was renamed to the TR Response field. 3. Handle padding correctly in the A-Control field. Change-Id: I33000aa28b9e00ab97ca30d53907685e302c49c2 Reviewed-on: https://code.wireshark.org/review/30918 Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06Qt: Fix tooltip on import sizeJaap Keuter1-1/+1
Import size is increased to 256kiB, but tooltip says 64kB. Adjust text according to limit set bt code. Change-Id: I586248fd25a96e4ffe0936babc90b4150c14f118 Ping-Bug: 15292 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30940 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06DOCSIS: Added Modem Capabilities 54-62 and TLV 49.8Bruno Verstuyft2-0/+368
Change-Id: I24815d5ec5dc288066712318e12f75a9cc6a9495 Reviewed-on: https://code.wireshark.org/review/30938 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06packet-rsl: Show cause value string of Cause IEPau Espin Pedrol1-3/+66
Related: https://osmocom.org/issues/3705 Change-Id: Ib7f985c2107d33b01640f31673c23d7fb4e54627 Reviewed-on: https://code.wireshark.org/review/30934 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06packet-rsl: Move rsl_class_vals into its correct spec sectionPau Espin Pedrol1-4/+3
Change-Id: Ia7554ed4d9926159ab3dbcdc6fd64d5bd09efc67 Reviewed-on: https://code.wireshark.org/review/30933 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06packet-rsl: Parse missing Cause IE in ip.access specific messagesPau Espin Pedrol1-0/+3
Related: https://osmocom.org/issues/3705 Change-Id: I4c05387a952dd07344d373f4abe0f03b456439a5 Reviewed-on: https://code.wireshark.org/review/30932 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06packet-rsl: Fix parsing values of some IE in ip.access specific messagesPau Espin Pedrol1-6/+11
Those IEs have specific dissect methods that expect offset to point to the IE type, not to its value. Furthermore, those methods already add a subtree, so no need to create it for them. Related: https://osmocom.org/issues/3705 Change-Id: Ia63253b95678b799f59ed945d1381f4eb01be636 Reviewed-on: https://code.wireshark.org/review/30931 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06HI2Operations: update auto generated file and remove unused templatePascal Quantin2-35/+3
Change-Id: If31c0fdfac9c450871accba53715dc4d0e6468a6 Reviewed-on: https://code.wireshark.org/review/30939 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-06SIP: Try to fix ASAN build crash.Anders Broman1-8/+8
Bug: 15328 Change-Id: Iefc057c74f234592adca1f7816a3e9fac99b48be Reviewed-on: https://code.wireshark.org/review/30937 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06PROFINET: PDPortDataReal_block dissection is changed.Ba?ak Kalfa1-8/+52
According to specification, PortState is renamed and dissected as "LinkState.Link" and "LinkState.Port" which are both 8 bits. Change-Id: I1eff258f48d6fd76286ae08a7d2d80793ea23f12 Reviewed-on: https://code.wireshark.org/review/30913 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06Doc: add mentioning of ip link to get interfacesJaap Keuter4-4/+4
With the introduction of the ip command (from iproute2) on modern Linux systems it becomes common to see this tool available, gradually replacing tools like netstat and ifconfig. Change-Id: I1fb309e741c07c93271b61a35c4833d36bcc5cb8 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30924 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06OER: Always initialize a variable.Gerald Combs1-1/+3
Always initialize our length in dissect_oer_length_determinant. Its callers assume that this happens and doing so should fix some scan-build warnings. Change-Id: I67abc19417e6437b9302b880164140fb8a773204 Reviewed-on: https://code.wireshark.org/review/30935 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05packet-rsl: Use defines for ip.access value_stringPau Espin Pedrol1-38/+38
Change-Id: I447a30068e5a4b9a510abec75498691e17cbaa32 Reviewed-on: https://code.wireshark.org/review/30927 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Debian: Add a Lintian override for l16_mono.Gerald Combs1-0/+2
Add an override for: library-not-linked-against-libc usr/lib/x86_64-linux-gnu/wireshark/plugins/2.9/codecs/l16mono.so Change-Id: Id053892125301fcd66349c1a571ff6e3d64463c9 Reviewed-on: https://code.wireshark.org/review/30925 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Fix some spelling errors found by Lintian.Gerald Combs50-99/+99
Change-Id: If6fc3aab7ad4fc634567121f7b9541bc6f6c5766 Reviewed-on: https://code.wireshark.org/review/30926 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05text2pcap: extend snap lengthJaap Keuter1-3/+2
The snaplength as saved in the capture file is set to the original PCAP file length of 65535. In reality the package size can grow to 256kiB. Make use of the correct constant when writing the PCAP file. Bug: 15292 Change-Id: Ib7710e4151cdc712f3344c1436252f9b3bfb556c Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30923 Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-05HI2Operations: Remove the not needed .h file.Anders Broman5-58/+8
Change-Id: Iabb24aae94814d4a10fdfa998f870b5e2cd3a8d8 Reviewed-on: https://code.wireshark.org/review/30921 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05SIP: Use differtent hf variables for the "real" and generated Call-idAnders Broman1-2/+9
It's not allways good to pick up frames for related call legs when filtering. Make different hf:s for the two use cases. Change-Id: I33c640636a76173f3a7952f4a740491ccfac276d Reviewed-on: https://code.wireshark.org/review/30922 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Add dissection of HI3CCLinkDataAnders Broman9-13/+456
Change-Id: I002c31972c4bcc231527eeaa2c6b21c3b1a9636a Reviewed-on: https://code.wireshark.org/review/30920 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Diameter: add 3GPP MCPTT-Identifier and MCVideo-Identifier AVPsPascal Quantin1-0/+6
Change-Id: Iabc8d91a149b3dd20cd5ff1cebbeae505a3c55ca Reviewed-on: https://code.wireshark.org/review/30919 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-05Debian: Add missing symbols.Gerald Combs1-0/+3
Change-Id: Id05eb1e6060d60892ffdd65aa5a2e0aad42215f0 Reviewed-on: https://code.wireshark.org/review/30917 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Hart-ip: Add simple heuristic.Anders Broman1-0/+22
To stop accepting SIP messages on the hart-ip port. Change-Id: Ifc653f4a3defb823336914e8be6f20453aedb6fe Reviewed-on: https://code.wireshark.org/review/30914 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04wsutil: Rename DATAFILE_DIR variableJoão Valverde2-4/+4
Rename DATAFILE_DIR to be closer to CMake and avoid mixing with the staging dir path variable of the same name. Change-Id: I7b1e02152d8bde14cca210fbfae4acbdba7d78d7 Reviewed-on: https://code.wireshark.org/review/30916 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-12-04KRB5: update auto generated filePascal Quantin1-1/+1
Change-Id: Ie78cc2609cd117622eb0e0e900d6e4e1a29efd2b Reviewed-on: https://code.wireshark.org/review/30915 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-04DOCSIS: Added QAM modulation support tlvsBruno Verstuyft2-0/+258
Change-Id: I18dc306b23a042e137c703cc8b14c45c66de10d2 Reviewed-on: https://code.wireshark.org/review/30912 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04krb5: fix asn1 error when dissecting PA-FX-FAST in TGS requestIsaac Boukris2-0/+9
Change-Id: If42e54b05def7a09e37f7c0283103bb6db8126db Signed-off-by: Isaac Boukris <iboukris@gmail.com> Reviewed-on: https://code.wireshark.org/review/30910 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-04krb5: do not dissect PA-S4U-X509-USER inside encrypted-pa-dataIsaac Boukris3-34/+69
According to MS-SFU 2.2.2 PA_S4U_X509_USER checksum section; PA-S4U-X509-USER may be returned inside encrypted-pa-data, but it contains just the checksum data so do not try to dissect it. Quote: The padata of type 130 in the encrypted-pa-data field contains the checksum value in the S4U request concatenated with the checksum value in the S4U reply. Change-Id: Ia124f56914ef2fefd5b0a64fccd176911321f246 Signed-off-by: Isaac Boukris <iboukris@gmail.com> Reviewed-on: https://code.wireshark.org/review/30908 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04couchbase: Update for recent collection changesJim Walker1-14/+85
Add support for decoding a collection-ID from the key-bytes. Update DCP as collection_len is no longer in the protocol and the system events have changed. Change-Id: Ib910083d929a906729e2bba2b0f07ba23e093cf5 Reviewed-on: https://code.wireshark.org/review/30895 Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04RTPS: Added dissection of Support Type Object LBismaelrti2-2/+52
Added dissection of Support Type Object LB type. Change-Id: I7e654faed4874a87865f1d94a372eb8f00dde412 Reviewed-on: https://code.wireshark.org/review/30903 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04couchbase: Update FlexFrame dissector to include requestsJim Walker1-86/+267
Update the couchbase packet dissector with some re-factoring of the FlexFrame dissector and then extra functionality for: * FlexFrame on requests (magic 0x08) * Durability * Out-Of-Order requests * DCP Stream ID Additional checks are added to warn/error for invalid frame lengths and for the case where the FlexFrame byte0 is 0xff, which is not defined by the protocol. Change-Id: I5f1fec8293284dadbdef717d02fa1eef27da7a0c Reviewed-on: https://code.wireshark.org/review/30894 Reviewed-by: Dave Rigby <daver@couchbase.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04Clean up memory allocationJoão Valverde1-6/+7
Fixes an issue where sometimes datafile_dir is not freed before exiting. Change-Id: I2ff7d1b8ea4e20a1ce98e5e11965073eb479bb03 Reviewed-on: https://code.wireshark.org/review/30909 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>