aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-07-14s7comm: Adding and redesign of test and installation functionsThomas Wiens1-207/+1675
New decoded TIS-functions: Jobs, BSTACK, ISTACK, LSTACK, Forces, Variable status, block status, breakpoints Change-Id: I7902bfcfe8d622a3e19c0c3b77492e7ad4ddecf5 Reviewed-on: https://code.wireshark.org/review/33927 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-13AT: Remove copy-pasted commentDarien Spencer1-2/+0
Comment is about CME error, should be in ZPAS dissection func. Change-Id: Iad2bc3de564374b23ca60053d227e02219c2a8c4 Reviewed-on: https://code.wireshark.org/review/33926 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-07-13LoRaWAN: decode as for UDPerikdejong1-0/+1
Allow decoding of LoRaWAN in UDP payload. Change-Id: I23df8587b08423dd1c75a060edf87f41b675057b Reviewed-on: https://code.wireshark.org/review/33924 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-13RRC: Remove duplicate dissection of algorithm cap bitmapsDarien Spencer3-224/+55
This commit is effectively reverting I88ddc2aec6805a77fcb3f3d547efda4d513ec919 The dissection logic is now generated into the dissector following the changes I2f4258e2f4fd11c26bdc101e1375d0b5708610b7 and Iec2cb22e61e235a749c7d0f976bae8ad52e6c08f Change-Id: I871c2b00d7a72103da83d6e64091886a8e2b12ed Reviewed-on: https://code.wireshark.org/review/33923 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-13s7comm: Implement packet reassemblyThomas Wiens3-415/+596
Implemented packet reassembly of userdata telegrams. Modified existing functions which before had shown only raw data on fragmented telegrams. Change-Id: Ia8d02928c08ad5228da28ac6a4b4df7ed99ab47e Reviewed-on: https://code.wireshark.org/review/33920 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-13Qt: Fix our template icon appearance on LoDPI screens.Gerald Combs1-1/+0
When creating a pixmap for a template icon, don't bother setting its device pixel ratio. Otherwise it will interfere with QIcon's size calculations. Change-Id: I8c89ce49c57d558ae48baf9c31227898c0f7f9ca Reviewed-on: https://code.wireshark.org/review/33919 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-13Get rid of unused variable.Guy Harris1-8/+0
It's filled in, and modified, but never used after that. Change-Id: Id5e1e9e5bc3223b04bd77f94117388ec8aa274d6 Reviewed-on: https://code.wireshark.org/review/33922 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-12XnAP: get rid of duplicate bit string decodingPascal Quantin3-268/+72
After gca694eb078, no manual decoding is required Change-Id: I641ce984b08ec74d7075b9e7cdd0806ccd707a45 Reviewed-on: https://code.wireshark.org/review/33917 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12ULP: get rid of duplicate bit string decodingPascal Quantin3-99/+43
After gca694eb078, no manual decoding is required Change-Id: Ic23daf75c317df8b022e2e9911a6ad025dceaae8 Reviewed-on: https://code.wireshark.org/review/33916 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12LPP: get rid of duplicate bit string decodingPascal Quantin3-1354/+91
After gca694eb078, no manual decoding is required Change-Id: Ibe83becaea2f3587e770f6346ec71e775d25cf75 Reviewed-on: https://code.wireshark.org/review/33915 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12PER: Fixed named bitmap parsing of larger mapsDarien Spencer1-1/+28
Previous logic worked for bitmaps of 8 (and maybe less) bits. For maps crossing 2 or more bytes all fields were parsed incorrectly by the lower 8 bits values. Change-Id: Iec2cb22e61e235a749c7d0f976bae8ad52e6c08f Reviewed-on: https://code.wireshark.org/review/33904 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12LOG3GPP: misc fixesPascal Quantin1-1/+2
- register RR dissector - a string added to a column must be in pinfo scope Change-Id: I2eb0f91c7e505094b87193d277c55ce8a3c4483b Reviewed-on: https://code.wireshark.org/review/33913 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12wiretap: do not pollute debug builds with candump debug messagesPascal Quantin3-5/+33
Change-Id: I2f7c4c3d23d5be27c1fac704272b9e581a4de0f7 Reviewed-on: https://code.wireshark.org/review/33912 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12Qt: Fix profile copy and deleteRoland Knall5-30/+71
Delete lead to an issue with the sort model, where indeces where no longer correctly associated with the source model. Copy did not check if the name already existed in the dialog Change-Id: I3668dffb1e1956f04a5b9e21c3fcdac266e0cc0c Reviewed-on: https://code.wireshark.org/review/33911 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-12LOG3GPP: do not dereference a NULL pointer (CID 1450541)Pascal Quantin1-2/+32
Change-Id: Ic65f21bcc49657ac74bf2eb8d86cb59c29cc233e Reviewed-on: https://code.wireshark.org/review/33907 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12doxygen: Exclude files giving warnings.Anders Broman1-2/+5
Change-Id: I731b6bc6c9baf84930ce9ad935403ac40b6bec8f Reviewed-on: https://code.wireshark.org/review/33910 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-12ZigBee: Dissect Electrical Measurement clusterKenneth Soerensen4-0/+651
Bug: 15882 Change-Id: Iccd6b7d66b0ea87f57de8ae0fd4bedc296787749 Reviewed-on: https://code.wireshark.org/review/33901 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-12Fix Wpointer-sign warnings.Anders Broman3-6/+6
Change-Id: I58383b280a04ea0f0f8185298459e07e47bf25e4 Reviewed-on: https://code.wireshark.org/review/33908 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-12S1AP: upgrade dissector to v15.6.0Pascal Quantin10-109/+118
Change-Id: I87b7aba8abb69254f30429cdc1c84efac317b652 Reviewed-on: https://code.wireshark.org/review/33909 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-12Fix Wpointer-sign warnings.Anders Broman1-16/+11
Change-Id: I1ac6cfecf2ff4b12f75ed0214dc40983d3db3bc8 Reviewed-on: https://code.wireshark.org/review/33906 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-12Have the message data just be a raw FT_BYTES field.Guy Harris1-28/+21
If somebody wants it interpreted, they should submit code to do so, *along with a sample capture*, so we can see how it's *supposed* to be interpreted - the way it was being interpreted makes no sense for several reasons. Change-Id: I2dbcb3915fd7d7d1b4a27be627f395ac43bc4130 Reviewed-on: https://code.wireshark.org/review/33905 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11Squelch more -Wpointer-sign warnings.Guy Harris2-5/+5
Change-Id: Ib167b98df91bd741d83da7449ec52ac954d220af Reviewed-on: https://code.wireshark.org/review/33903 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-11Always use string routines to extract strings from packets.Guy Harris1-6/+15
*All* strings have a character encoding, so *all* calls to process strings should use routines that take encodings as arguments. In the case of ADB CS services, the encoding is ASCII, so ENC_ASCII. Change-Id: I1f0e72e1d6c86917d092358487c1df40cf4dec47 Reviewed-on: https://code.wireshark.org/review/33902 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-11wiretap: candump: Reset error info and fix scanner warningsMaksim Salau2-0/+28
candump_open() may be called with non-empty error code and string. The error code is not reset upon success in run_candump_parser() which may mislead the caller function thus affecting opening the file. yy_fatal_error(), yy_alloc(), yy_realloc() and yy_free() make no use of the yyscanner argument, which results in warnings on OSX. In order to get rid of those warning we provide our own implementations of memory allocation functions and hack YY_EXIT_FAILURE macro in order to pretend using the argument. Change-Id: I672d374b26970b2699b9d789b6118e97ba660bdf Reviewed-on: https://code.wireshark.org/review/33892 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-11Fix Wpointer-sign warnings.Anders Broman4-49/+7
Change-Id: Idf8c07d54096a5b172f063e4dca999a24cc797a3 Reviewed-on: https://code.wireshark.org/review/33899 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11Fix Wpointer-sign warnings.Anders Broman4-71/+71
Change-Id: Ia7893c4c78b1f5fc124a0bb56ae47ed6ab514f6b Reviewed-on: https://code.wireshark.org/review/33897 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11Qt: Fix warning and remove dead codeRoland Knall1-87/+4
Fix a "discard const qualifier" warning and remove code, which should be active in Qt5, but never made it to majurity Change-Id: I8d4dd526d07413ca30ab0b8430c6b8205e4e3063 Reviewed-on: https://code.wireshark.org/review/33896 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-11Qt: Fix various compiler warningsRoland Knall1-4/+4
Change-Id: I050b74a9d57c8d71a9373b6b4d5e942b7e55e8db Reviewed-on: https://code.wireshark.org/review/33895 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11Doxygen: Fix some warnings.Anders Broman10-7/+14
Change-Id: I0344d44d08d2e159c895d693500403c067039a44 Reviewed-on: https://code.wireshark.org/review/33894 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11Qt: remove semicolon from profile model.Dario Lombardo1-1/+1
This causes an error due to -Werror,-Wc++98-compat-extra-semi. ../ui/qt/models/profile_model.h:21:42: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi] Q_DECLARE_LOGGING_CATEGORY(profileLogger); ^ 1 error generated. Change-Id: I5c04f431ffc08e90efbee5763e0f7c9b10a039d2 Reviewed-on: https://code.wireshark.org/review/33893 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11Candump_parser: fix implicit declaration warningUli Heilmeier1-0/+1
Include string.h to fix implicitly declaring library function 'memcpy' with type 'void *(void *, const void *, unsigned long)' Change-Id: Ia6796f1966db606f946e0935ed0e5b70702c88c9 Reviewed-on: https://code.wireshark.org/review/33891 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11Qt: MainStatusbar and CopyFromProfileMenu to ModelRoland Knall4-90/+95
Remove the profile.? specific implementation and move both functions to profile model, makeing the class the single source for profile related parsing Change-Id: I61ecc2fc1f294e4e3943a00bb8522258c8ff8ec5 Reviewed-on: https://code.wireshark.org/review/33880 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11Qt: Move Profile Dialog to Model/ViewRoland Knall8-259/+1027
Move the profile dialog to a model/view based concept. Display and ordering works now, but nothing much else. Add possibility to filter for profiles, as well as group filters. Change-Id: I4740ad5aa10feeb31192f8131fb1204f5dca7232 Reviewed-on: https://code.wireshark.org/review/25141 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-11wiretap: Add support of candump logsMaksim Salau7-0/+889
The change adds ability to import text logs produced by the candump tool. E.g.: candump -L can0 -or- candump -l can0 The whole file is read and converted into a temporary PCAPNG file with Exported PDU packets containing SocketCAN frames. Bug: 15889 Change-Id: I5ad93dca96d6e955a4b21cf624f0553e60f060f6 Reviewed-on: https://code.wireshark.org/review/33800 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10s7comm: Additions and name corrections in programming/userdata functionsThomas Wiens1-124/+193
- Rename test and installation (tis) functions to the names used in official documentation - Add PI-Servicenames - Rename vartab to varstat - Variable status: add bit access, change display-style of datablock areas as used in programming software - Add subblock type "none" Change-Id: I465633cbb951311d1d1a59129fe5e3d8dac3f265 Reviewed-on: https://code.wireshark.org/review/33890 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10doxygen: Try to fix warnings.Anders Broman5-18/+16
Change-Id: I1517c968f05e7d9c6b561c0f5a7c6a059462d175 Reviewed-on: https://code.wireshark.org/review/33889 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10H265: Fix -Wpointer-sign warnings.Anders Broman1-12/+15
Change-Id: I7398216fcd03c619fe51182b5335ea47dd3fa110 Reviewed-on: https://code.wireshark.org/review/33888 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10Doxygen: Try to fix reported warnings.Anders Broman5-16/+17
Change-Id: Ia2e08265681c6700328a5782a70c3108eeb443bf Reviewed-on: https://code.wireshark.org/review/33887 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10doxygen: Try to fix warnings.Anders Broman4-5/+12
Change-Id: I2c104b159f8d4ee1993567c54578dcd695b06037 Reviewed-on: https://code.wireshark.org/review/33886 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10doxygen.cfg.in: Fix directories according to current reality.Anders Broman1-1/+2
Change-Id: If5d41c5530774e44228e791e657617f8dcbdfb3c Reviewed-on: https://code.wireshark.org/review/33885 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10airpcap.h: Try to resolve doxygen warnings.Anders Broman1-2/+2
Change-Id: I88078e6e8119984792e30e928a0fd15686a9fb0f Reviewed-on: https://code.wireshark.org/review/33884 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-10packet-ieee80211-radiotap-iter.h: Try to fix doxygen warnings.Anders Broman1-42/+23
Change-Id: Icca2505f933a43b218043055201b00a47e77bef8 Reviewed-on: https://code.wireshark.org/review/33883 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-09LOG3GPP: fix compilation with gcc 9.1.1Pascal Quantin1-11/+12
Change functions signature to avoid the cast. Change-Id: Ib4346526721538e9d793858ad8e1bd952de894e1 Reviewed-on: https://code.wireshark.org/review/33879 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-08wiretap: Add a phone log reader.Anders Broman8-2/+1733
Change-Id: I0b290df4783616f1eb15e6ad35fbd6d2b4c3dbdd Reviewed-on: https://code.wireshark.org/review/33865 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-08Netflow: Add decodes for Niagara Networks IPFIX information elements.Volodymyr Veskera2-1/+855
Change-Id: I2775bfb7d86a9c2dc257cf4d7a5bc2b6f9e68f35 Reviewed-on: https://code.wireshark.org/review/33851 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-08pfcp: Update to 3GPP TS 29.244 V16.0.0Joakim Karlsson1-5/+481
Change-Id: I92427cc5c5a2574faf2a592cd8ef5df90028229a Reviewed-on: https://code.wireshark.org/review/33864 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-08dumpcap: fix uninitialized memory read on dumpcap -d errorsPeter Wu1-0/+1
Reproduce with: dumpcap -pdf bad Change-Id: I8c1f80c9d88262bc57651e886740083ea8e6ad52 Fixes: 4d6cb744df ("Add a "-d" flag to dumpcap") Reviewed-on: https://code.wireshark.org/review/33863 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-07ieee802.11: Ensure optional sub-elements do not cause exceptions.Richard Sharpe1-0/+6
The original code was causing a malformed packet exception if there was one additional byte after the measurement pilot interval. Bug: 15903 Change-Id: Ibe3e7fab5ea5c3d18ea4792ff342a0d8b8d2533b Reviewed-on: https://code.wireshark.org/review/33858 Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-07-07[Automatic update for 2019-07-07]Gerald Combs7-39/+293
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ib32cb52cb8b439802b343ad62420055177ffc211 Reviewed-on: https://code.wireshark.org/review/33859 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-06gitlab-ci: use opensuse/leap:42.3 image.Dario Lombardo1-2/+2
The former official image has been deprecated in favor of opensuse/leap one. Change-Id: I92de89060f2d8f3a679f0c332eebb65e5c13ba41 Reviewed-on: https://code.wireshark.org/review/33852 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-01 22:23:15 +0000