aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-08-201722 extensions: code clean up, warning removedAndreas Leibold1-678/+943
code clean up dissector bugfixing 1722 / 61883 subtype: packet inspection enhanced regarding warnings 1722 / 61883-6 subtype: more detailed packet dissection Change-Id: I0d762f37402ca27ad33e0d22da50c184297bed57 Reviewed-on: https://code.wireshark.org/review/17110 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19Add a preference to byte-swap the CAN ID field.Guy Harris1-15/+20
This can be useful when dealing with 1) captures from versions of libpcap without the bug fix to use DLT_CAN_SOCKETCAN_HOSTENDIAN when appropriate and 2) DLT_CAN_SOCKETCAN_HOSTENDIAN captures if processed by a machine with a different byte order from the capturing machine with software that doesn't properly put the field into host byte order when reading and writing. Change-Id: Ia206e5c51aecccf2508cca01cff65a4feb379ac8 Reviewed-on: https://code.wireshark.org/review/17187 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-19LCSAP: fix indent (use 2 spaces) and modelinesAlexis La Goutte2-6/+20
Change-Id: I688c71a94703cecbf62b0e29f1e389551cedbeb9 Reviewed-on: https://code.wireshark.org/review/17171 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19NAS EPS: generate the consecutive TAC values when using the TAI list format 1Pascal Quantin1-3/+11
Change-Id: I79442a95c52c0ac334ad27b83b78af78d0d23dcc Reviewed-on: https://code.wireshark.org/review/17179 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19Do all data fetching in the appropriate byte order.Guy Harris1-8/+13
Change-Id: I481288b566c2b9888b3f068d2dbae1240fa2930e Reviewed-on: https://code.wireshark.org/review/17181 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-19[Diameter] Add subdissection of AVP 1242 location estimate and AVP 2516AndersBroman4-21/+45
EUTRAN-Positioning-Data. Change-Id: I8eebd94ab82889cff5ef3a209c485e8d2769a71d Reviewed-on: https://code.wireshark.org/review/17177 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19NLM: fix dissection of NLM_FREE_ALL messagePascal Quantin1-8/+1
The second parameter is the state, not the status as seen in C702 doc, page 159 Bug: 12764 Change-Id: I0a91a0e586c7663ace7c4c6b1044cafc1c0975ac Reviewed-on: https://code.wireshark.org/review/17178 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-08-19Answer a locale question in a comment.Gerald Combs1-7/+3
Change-Id: If2c287ed8d2a3b518ceff891f1e6d995d7a7daad Reviewed-on: https://code.wireshark.org/review/17182 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-08-19[Diameter] Add stray AVP "Pseudonym-Indicator" code="2519"AndersBroman1-3/+5
Change-Id: I050c27b7118fb98fea20fec697279dc68820763d Reviewed-on: https://code.wireshark.org/review/17176 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19[LCS-AP] Add decoding of Civic-Address, add expert info if wronglyAndersBroman3-9/+82
encoded. Change-Id: I2631fe5ae7f8e73f8f4067c73197ae4cd386b633 Reviewed-on: https://code.wireshark.org/review/17169 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19codecs/speex: add check in speex_resampler_init_frac/set_rate_frac (CID ↵Dario Lombardo1-1/+5
1355648). Add checks to avoid den_rate and num_rate to be set to 0. Change-Id: Ia4880521e7ab73d0fdc44377f4badadb09365471 Reviewed-on: https://code.wireshark.org/review/16963 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19netlink: fix flags dissectionPeter Wu1-6/+19
Flags are not in network byte order, use given encoding instead. Show both flags fields for GET and NEW requests since the netlink dissector cannot yet determine whether a request is for GET, NEW or something else. This has no effect for the sockdiag dissector but it will influence the route and netfilter netlink subdissectors. Change-Id: I472ff9e0498debbbceef657a14408c4e6a9df75b Reviewed-on: https://code.wireshark.org/review/17118 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19dissector ISAKMP: Added decryption using AES-GCM, AES-CCM and AES-CTRMichał Skalski1-14/+275
Added support for decryption of IKEv2 packets encrypted with PAED or CTR cipher mode. Verification of integrity requires libgcrypt 1.6.0 or later. If it is not the case, only decryption is performed Can easily be extended to other ciphers supported by libgcrypt. NOTE: There is long-term bug in handling UAT for IKEv2 - any change resulting in change count of IKEv2 UAT entries causes crash when matching key from UAT is found. Crash does not occur when UAT is read from user prefs file. I observed this bug also on stock 1.10.6 version from Ubuntu 14.04 LTS I have no knowledge, how to fix it. Change-Id: Ibdab979b5959eb561635cbcb446e17138baca87b Reviewed-on: https://code.wireshark.org/review/17078 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19RTPS: Added locator information to the parameter tree.Juanjo Martin1-4/+25
This makes the user avoid to click twice in order to see the info. Change-Id: Ib983c78634b1309f12ab29d673abc1195088f55c Reviewed-on: https://code.wireshark.org/review/17146 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19bfd: Fix a comment on Control packet version 1Francois-Xavier Le Bail1-2/+2
Bug:12761 Change-Id: I5877878f19be4907b9fc0c00f19601a3c7a67005 Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-on: https://code.wireshark.org/review/17163 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19mongo: set on subtree when Empty DocumentAlexis La Goutte1-1/+1
Change-Id: I2b6b7cf771ab7bc2f6dbc0aac5eddda2a9d2fb53 Reviewed-on: https://code.wireshark.org/review/17167 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19[LCS-AP] id-E-UTRAN-Cell-Identifier is sued also as an extension value.AndersBroman2-0/+4
Change-Id: I86c7ff51a16801c2995161c45cb3d8e6800f54c4 Reviewed-on: https://code.wireshark.org/review/17168 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19[Diameter] Ad dissetion of Access-Restriction-Data bitfield.AndersBroman1-0/+79
Change-Id: I3e751f07c540b056b55fc98fb9c26d23718bd8fc Reviewed-on: https://code.wireshark.org/review/17164 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-08-19NAS EPS: fix dissection of multiple partial tracking area identity listPascal Quantin1-64/+65
As reported on https://ask.wireshark.org/questions/54955/nas-tracking-area-identity-list-decoding-not-proper Change-Id: I8c4ed1982e1d72136558fb381d2d15b15c9e376c Reviewed-on: https://code.wireshark.org/review/17151 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-19Adjust to the split of the SocketCAN encapsulation.Guy Harris1-1/+2
Change-Id: Ibbe97f15854163163ad2bdf3b425c63d4cbfed50 Reviewed-on: https://code.wireshark.org/review/17158 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-19Add tools for setup macos dev environnement using brewAlexis La Goutte1-0/+51
Will be reused for Travis osx Change-Id: Ida905768efc4e48be9936b3113704dcb651d4ca0 Reviewed-on: https://code.wireshark.org/review/16495 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-19Handle the new LINKTYPE_CAN_SOCKETCAN_HOSTENDIAN.Guy Harris4-14/+152
Unfortunately, only one libpcap code path puts the CAN ID in the SocketCAN header in network byte order; the others leave it in host byte order. Therefore, a new LINKTYPE_/DLT_ value was introduced, and libpcap was changed to use that for the cases where the CAN ID is in host byte order. Support them both. This means we need to, when reading pcap and pcapng files, fix up the CAN ID if the host that wrote the file has a different byte order from ours (as libpcap also now does). This includes Linux "cooked" captures, which can include CAN packets. Change-Id: I75ff2d68d1fbdb42753ce85d18f04166f21736dd Reviewed-on: https://code.wireshark.org/review/17155 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-19fix endianess of rejoin source addressChris Brandson1-1/+1
Change-Id: I71e6e2f569524642a24778ceef81c03fdc0f54c5 Reviewed-on: https://code.wireshark.org/review/17149 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18etypes: Add ETHERTYPE_LINK_CTLStig Bjørlykke2-0/+5
The definition was found in the Linux kernel source code. Change-Id: I41d1435497042bc5905efc7e1af3941b9e8808e2 Ping-Bug: 12759 Reviewed-on: https://code.wireshark.org/review/17148 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18SEL Protocol - Fix 'Fast Meter Config' sub-tree addition typo & 'if (tree)' ↵Chris Bontje1-5/+4
usage - The proto_tree_add_subtree call was previously using the length of the full tvb, instead of len-2 like all other calls. This typo did not previously cause an issue, but in newer versions of Wireshark it causes an assert. - When I created the selfm dissector 4-5 years ago, I used packet-synphasor.c as a template and there was an 'if (tree)' wrapper around several initial GUI calls including col_*** info column clear/set functions. It looks like in recent years this layout has been removed (for example, https://code.wireshark.org/review/#/c/6725/ ). I'm not sure of the exact reasoning behind this, but in Wireshark 2.x (QT), there are several conditions where in the SEL protocol dissector the info column will be cleared and not repopulate - I can only assume because col_clear has been called with no col_add's. Removal of this 'if' condition does correct the issue with no immediate ill effects.. Change-Id: I4c619cb320cd2152e1d4d1b76c809b1498dfda61 Reviewed-on: https://code.wireshark.org/review/17147 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-08-18QUIC: Add detection of server portAlexis La Goutte1-4/+9
Some debug tools don't use the standard 443 Change-Id: I5826de69afe343e4c112ecb78ffa1e26bd35b242 Reviewed-on: https://code.wireshark.org/review/17069 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18TCP: fix no previous prototype for ↵Alexis La Goutte1-2/+2
'exp_pdu_tcp_dissector_data_size/exp_pdu_tcp_dissector_data_populate_data' [-Wmissing-prototypes] Change-Id: I259f457868f4b8cde7e188d88d3d55f97070ee3b Reviewed-on: https://code.wireshark.org/review/17145 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18logcat (text): fix no previous prototype for ↵Alexis La Goutte1-2/+2
'logcat_text_init/logcat_text_cleanup' [-Wmissing-prototypes] Change-Id: I1c8462064e7c07ee7f626fb26ad6bb744a7fc5b3 Reviewed-on: https://code.wireshark.org/review/17144 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18ERF: fix no previous prototype for ↵Alexis La Goutte1-3/+3
'erf_ts_to_nstime/dissect_relative_time/dissect_ptp_timeinterval' [-Wmissing-prototypes] Change-Id: I21ee4f8850f63de3a7fa91ed9e8a426c82a9d62e Reviewed-on: https://code.wireshark.org/review/17143 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18btatt: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: I4c8d2fc74a84e4fe4a85efeb75f666f5402c6030 Reviewed-on: https://code.wireshark.org/review/17137 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18UDS: fix fix no previous prototype for ↵Alexis La Goutte1-0/+3
'proto_register_uds/proto_reg_handoff_uds' [-Wmissing-prototypes] Change-Id: I14567ea0142555aedb859e52eb4d92f89da8d695 Reviewed-on: https://code.wireshark.org/review/17142 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18iso15765: fix no previous prototype for ↵Alexis La Goutte1-0/+3
'proto_register_iso15765/proto_reg_handoff_iso15765' [-Wmissing-prototypes] Change-Id: Id563eb5c44a988a7ea5149e312f4033cd4ca31e9 Reviewed-on: https://code.wireshark.org/review/17141 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18gsm abis tfp: fix no previous prototype for ↵Alexis La Goutte1-0/+3
'proto_register_abis_tfp/proto_reg_handoff_abis_tfp' [-Wmissing-prototypes] Change-Id: I86d397e0fb37ff12e58c923a63fbb201934d0e66 Reviewed-on: https://code.wireshark.org/review/17140 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18gsm abis pgsql: fix no previous prototype for ↵Alexis La Goutte1-0/+3
'proto_register_abis_pgsl/proto_reg_handoff_abis_pgsl' [-Wmissing-prototypes] Change-Id: I6138ca727e6802bc2066bc1ecb8549365b588da2 Reviewed-on: https://code.wireshark.org/review/17139 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18QUIC: fix typo about stream offsetAlexis La Goutte1-4/+4
it is only Offset not Offset Length Issue reported by Lucas Change-Id: I3129d62a0601b896fd0d44d5ce4d32864afdd96e Reviewed-on: https://code.wireshark.org/review/17138 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18HTTP2: export dissect_http2_pduAlexis La Goutte3-1/+43
for used on another dissector... Change-Id: I7c27517ee26ee9f9384e22a83e547550863093d8 Reviewed-on: https://code.wireshark.org/review/17133 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18QUIC: Fix some minor typoAlexis La Goutte1-6/+5
Change-Id: I541cbfd133695e4856175eb8281f30d4c2dcaea1 Reviewed-on: https://code.wireshark.org/review/17132 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18PAPI: Add Port (src/dest) descriptionAlexis La Goutte1-2/+301
Change-Id: Iac6c550398f737200470505b4ed2dcffb24fa5fa Reviewed-on: https://code.wireshark.org/review/15573 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18pre-commit: Ignore missing pre-commit-ignore.pyJoão Valverde2-10/+5
Print error message to stderr and return non-zero exit status from child process. Change-Id: Icd433d79c5a7bf8b6ddd8e94e26695b353e34d1f Reviewed-on: https://code.wireshark.org/review/17116 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: João Valverde <j@v6e.pt>
2016-08-18xbxml: restore removed line.Dario Lombardo1-1/+2
This makes CID 1317251 obsolete. Change-Id: Id342b996268ac0734a52e93c02ae368960ee2294 Reviewed-on: https://code.wireshark.org/review/17027 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18Qt: fix crash on clearing dfilter after capture restartPeter Wu1-12/+24
Since v2.1.2rc0-1-gaf5daa6 ("Qt: Replace a QMap with a QVector."), the following error could be observed: ASSERT failure in QVector<T>::operator[]: "index out of range", file /usr/include/qt/QtCore/qvector.h, line 433 Aborted (core dumped) It happens when a capture filter is present and a live capture is restarted. Then the number_to_row_ structure would be truncated which results in an invalid access. Fix this by always checking the length before inserting a new mapping. Do it inside the loop to prevent an unlikely race condition where more than 10000 packets are received before the next iteration. Store "row number + 1" to avoid having to initialize the new elements from resize() with -1, the default value is 0 which is good now. Change-Id: I88ce955a3551508e773eeadddc6f89bbb583acaf Reviewed-on: https://code.wireshark.org/review/17111 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18ISAKMP: Fix Result of operation is garbage or undefined found by Clang AnalyzerPascal Quantin1-3/+9
Change-Id: I47233968dfc87494b3c959896622db5cd31244a7 Reviewed-on: https://code.wireshark.org/review/17065 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Mirko Parthey <mirko.parthey@web.de> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18Update the README.Gerald Combs3-101/+56
The formatting was mostly AsciiDoc-compliant. Take it the rest of the way. Update the list of supported operating sytems, along with other info. Use HTTPS URLs. Remove README.tru64 while we're here. Change-Id: Ibd9cac5d9f3cdcc7de9c9d7052c14e851e108cbe Reviewed-on: https://code.wireshark.org/review/17014 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18QUIC: Update error codeAlexis La Goutte1-2/+18
Also update link to source code Change-Id: I9afb72e477d11e3427cb43d574b2949bb8d777f9 Reviewed-on: https://code.wireshark.org/review/17091 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-18QUIC: Fix encoding arg from MIDS TagAlexis La Goutte1-1/+1
Change-Id: Ia1468c5f64b41452f373800af36c4c1fb4c58dbe Reviewed-on: https://code.wireshark.org/review/17092 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18BGP: Add no supported AFI/SAFI (Cisco) Open Message ErrorAlexis La Goutte1-0/+1
Bug:12601 Change-Id: I555ee8097ea81e1afa8f2f5b2aba8fce60742016 Reviewed-on: https://code.wireshark.org/review/17107 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18SEL Protocol - Correct dissection for 'SOE Present State Response' function codeChris Bontje1-17/+37
Change-Id: I53691344f22f7313242f31e0abce9af5a5dbf8be Reviewed-on: https://code.wireshark.org/review/17117 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-18Don't distinguish between PARSED_NONRECORD and PARSE_FAILED.Guy Harris1-21/+18
If we got no bytes of data from a putative packet, the file isn't a valid Ascend file, regardless of whether the parser failed or not. Just have parse_ascend() return a Boolean, TRUE if we got a packet and FALSE if not, and, in the case where we got no data but the parser didn't fail, provide "no data returned by parse" as the error string. (We weren't actually distinguishing between them when we called parse_ascend() - we were treating all non-PARSED_RECORD returns as an error.) Change-Id: I85a3e318015258f6a62c8d23ac2f906e28789982 Reviewed-on: https://code.wireshark.org/review/17130 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-18Make it a little clearer what ascend_open() is doing.Guy Harris1-11/+16
Expand comments, and merge two separate if checks. Change-Id: If339ce632ccc91c425ba6db4a32296c3038253ac Reviewed-on: https://code.wireshark.org/review/17128 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-18Just return the value of yyparse() from run_ascend_parser().Guy Harris1-3/+1
That's what we're doing already, but get rid of the variable to which we assigned the return value. Change-Id: I55e31664bc26bbfffe4a4ca764c917eefbb9a8f1 Reviewed-on: https://code.wireshark.org/review/17126 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-27 17:59:06 +0000