aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2015-05-18Bluetooth: HCI: Add command-event trackingMichal Labedzki8-152/+565
HCI Commands in most cases generate response in Event queue, so try to map event to command and give user response time information. Change-Id: Ib4956829b7d0064ab528aa3202f8f959d8d371b7 Reviewed-on: https://code.wireshark.org/review/8514 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: HCI: Add new LE Event numbersMichal Labedzki2-32/+107
New event will be added later, for now all number are useful. Change-Id: I83b77627dfb0c511710c3080aaac0f6857f76137 Reviewed-on: https://code.wireshark.org/review/8513 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: BTLE: Fix data handling from previous dissectorMichal Labedzki1-5/+24
Check previous dissector before cast data parameter. That also causes Head overflow too. Change-Id: I8f6ce2ec183e4c757613fd7e1959d9d0e4cfc89e Reviewed-on: https://code.wireshark.org/review/8512 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: Remove duplicates by default for ATT Server Attributes dialogMichal Labedzki1-0/+3
Change-Id: Ic833c800f599eed465eddc3d17ca07bdf3e83aba Reviewed-on: https://code.wireshark.org/review/8511 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: SCO: Add Stream Number generated fieldMichal Labedzki3-9/+102
It is used to distinguish SCO streams. Stream Number increase any time when new SCO connection is created. Change-Id: I6cf68914112980cdbad345e52469bf2baf214551 Reviewed-on: https://code.wireshark.org/review/8510 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: SCO: Add Connect/Disconnect trackingMichal Labedzki2-6/+48
Change-Id: I4db44628d60ec8ae22b625649e971b344f450ed9 Reviewed-on: https://code.wireshark.org/review/8509 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: SCO: Add Missing fieldsMichal Labedzki1-1/+23
Missing fields are: Reserved, Packet Status. Change-Id: Ia9edb23e3fc8c45d12931200dd02f0d3eef87c48 Reviewed-on: https://code.wireshark.org/review/8508 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: ATT: Enable UUID128 fieldMichal Labedzki1-2/+2
API used by this field is implemented, so field can be enabled now. Change-Id: Ifc8de81157c9b125ba769d14ec57a498d9810c5f Reviewed-on: https://code.wireshark.org/review/8507 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: OBEX: Add DecodeAs by Type aka MIME TypeMichal Labedzki1-13/+123
Also map some Types to Dissector Table dissectors. Change-Id: I1a1924924ac569368b3a4fafdc05c98e4a8d4841 Reviewed-on: https://code.wireshark.org/review/8506 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: OBEX: Add Current Path tracking infoMichal Labedzki1-7/+166
It will be useful for analysis. Also support partialy known path, unknown part is shown as "?". Change-Id: I0299e64d233022d1941b364afc4a6be0c9f4d23e Reviewed-on: https://code.wireshark.org/review/8505 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Add IP Detail Record dissector to the Release Notes.Jeff Morriss1-0/+1
Change-Id: I6c5405beef4e8d880d73d9706e61e953431cce4f Reviewed-on: https://code.wireshark.org/review/8504 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-18ntlmssp: swap bounds check and length for memcpyEvan Huus1-5/+4
The values make more sense swapped (and the code is super-old) so I'm assuming this was just a long-uncaught typo. Fixes a valgrind error at any rate. Also replace a malloc+memcpy with a memdup for simplicity. Bug: 11203 Change-Id: I74c0aff548b844cf90610db56a143f3eac172658 Reviewed-on: https://code.wireshark.org/review/8493 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-05-17Update some comments.Guy Harris2-1/+22
There's all sorts of interesting stuff out there on the Intertubes if you happen to be searching for the right thing. Change-Id: Ib5e18ece5dfaa284ece8cfda23887a9408c8318e Reviewed-on: https://code.wireshark.org/review/8503 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-17Add IPDR dissectorMichael Mann3-0/+395
Bug: 2771 Change-Id: Ic2904c981a182be5859c3840025e7ffa9ea387ed Reviewed-on: https://code.wireshark.org/review/8501 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-17Fix some files to pass the pre-commit hook script.Joerg Mayer7-78/+88
Change-Id: I105bf4e03fcf95cf7541f6377215809759fd933e Reviewed-on: https://code.wireshark.org/review/8502 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-05-17Improve comments, fix capitalization of "Aruba".Guy Harris1-15/+29
Give better comments describing the 5 different formats Aruba equipment can use. It's "Aruba Networks", not "ARUBA" anything. Change-Id: I300d77375e8182b60e830cb545d8802c1a49569c Reviewed-on: https://code.wireshark.org/review/8500 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-17Make the human-readable names the same in the preferences and the packets.Guy Harris1-6/+6
Change-Id: Ie00c81e9893412cc322cfb08e8b5b5f4e5ce47e4 Reviewed-on: https://code.wireshark.org/review/8499 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-17Update a URL.Guy Harris1-1/+1
Change-Id: I51e884815a83bd44b528d5dd86f98d0ea51719f9 Reviewed-on: https://code.wireshark.org/review/8498 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-17[Automatic update for 2015-05-17]Gerald Combs17-2955/+3260
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ic345ff4e7b46ee43af35ebbdda32ffc25e793c65 Reviewed-on: https://code.wireshark.org/review/8495 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-17HTTP2: Update to final RFCAlexis La Goutte1-3/+2
Change-Id: I0b19d4576b652dc9dd94346c75945e0bdc554a0e RFC7540: Hypertext Transfer Protocol Version 2 (HTTP/2) RFC7541: HPACK: Header Compression for HTTP/2 Reviewed-on: https://code.wireshark.org/review/8478 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-17nghttp2: use <> for include glib.hAlexis La Goutte2-2/+2
Change-Id: I6fdb72322dca514a774ab074c26128f70992a8f7 Reviewed-on: https://code.wireshark.org/review/8476 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-17packet-skinny.c is a generated file nowadays.Joerg Mayer1-2/+2
Apply commit 0970872a4cfdba0d9de913da036717ac2167297a to the source file as well. Change-Id: I9cc69bf5de3318b9a930bde3455a320880976af7 Reviewed-on: https://code.wireshark.org/review/8492 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-05-16struct timeval not used, so no need for <sys/time.h>.Guy Harris1-4/+0
Change-Id: I5f635f354db68f1cff0874f3cd0ba09c87edad1d Reviewed-on: https://code.wireshark.org/review/8491 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-16Do all floating-point work in double-precision.Guy Harris2-5/+5
That squelches some double -> float warnings. Change-Id: I19b8049698c7931e8c146d9532fc65ee091e4c24 Reviewed-on: https://code.wireshark.org/review/8490 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-16Use nstime_t for time stamps.Guy Harris2-48/+30
Don't roll our own time stamp handling, use nstime_t. That also gives us nanosecond resolution, for what that's worth. Change-Id: Ib9945bdef5a70e1656b96995f510507da36b4b59 Reviewed-on: https://code.wireshark.org/review/8489 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-16SIP: Fix typo lenght => lengthAlexis La Goutte1-2/+2
Change-Id: Ib533bd2526c27cf5f1161616fcf52136e40c827a Reviewed-on: https://code.wireshark.org/review/8484 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-16megaco: handle missing tokensEvan Huus1-1/+1
Fix an infinite loop when no transaction end offset is present and `megaco_tvb_find_token` returns -1. Bug: 11193 Change-Id: I82c7b795e522efca674787e504427f64b8c28fc4 Reviewed-on: https://code.wireshark.org/review/8483 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-16Have per-queued-packet flags, including "is a packet in error".Guy Harris1-2/+31
The contents of the packet_info structure change during the dissection process, so you can't rely on its contents when running tap listeners. Bug: 11184 Change-Id: I52fc45774add56ee2bcb5faef2af7c731b4304fd Reviewed-on: https://code.wireshark.org/review/8486 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-16Remove odd charactersGraham Bloice1-5/+4
Change-Id: Ie861badb555e235199549ee27ca374feb6356be6 Reviewed-on: https://code.wireshark.org/review/8482 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-05-16tap: Add ability to reject/ignore "error" packets in tapEvan Huus2-9/+14
ICMP (and a few other protocols) can carry "error packets" as payloads in certain cases. In the same way that we don't (by default) call TCP reassembly code on TCP packets we know are out-of-order, we also shouldn't call tap code on frames carried in ICMP error packets. Bug: 11184 Change-Id: Ie83dbb505c8fdc15c5554705488c16fa0274a06a Reviewed-on: https://code.wireshark.org/review/8446 Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-05-16Main (menubar): fix C++ style comments are not allowed in ISO C90Alexis La Goutte1-1/+1
Change-Id: Ia8ae6780027a63c4a88ea8d2a10ba1e0f8931f25 Reviewed-on: https://code.wireshark.org/review/8472 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-15Qt: Stop tapping when the I/O Graph dialog closes.Gerald Combs8-1/+37
Add a setCaptureStopFlag function to ProgressBar. Add a stopTapping function and setCaptureStopFlag signal to CaptureFile. Use the new plubming to stop tapping when the IO Graph dialog closes. Bug: 10116 Change-Id: Ic46814eed18933f511d9d1ff37e2e7918741f353 Reviewed-on: https://code.wireshark.org/review/8480 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-15Qt: Make sure we can fetch ExportDissectionDialog's layout.Gerald Combs2-1/+4
Make sure ExportDissectionDialog is a non-native, funny-looking file dialog so that we can fetch its layout. Fix and add some URLs while we're here. Bug: 11122 Change-Id: Icf62f7a436c7ba27ec20f84e7c1af1a5d7c9b949 Reviewed-on: https://code.wireshark.org/review/8479 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-15MBIM: add checks on the maximum string or PDU size allowedPascal Quantin1-57/+186
Change-Id: I10912bbe5a4ee38732a200b595b8d34dfa40c698 Reviewed-on: https://code.wireshark.org/review/8475 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-05-15Qt: Fixup sequence dialog buttons.Gerald Combs1-1/+1
Switch from "Save As" + Cancel + OK to "Save As" + Close. Change-Id: I6f1093965f90fe9cbbfbf053779c05388c897641 Reviewed-on: https://code.wireshark.org/review/8474 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-15Qt: Fix packet deselection.Gerald Combs1-5/+14
When no packets are selected, clear the related item delegate, packet detail, and byte view. Also, don't crash. Bug: 10529 Change-Id: I1f46d0d60d060d517f1ee2f8b5a9124bc1fad00e Reviewed-on: https://code.wireshark.org/review/8470 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-15ui/mcast_stream.c: Add dependency on sys/time.h for struct timevalEdwin Groothuis1-0/+4
Needed to compile on FreeBSD. Bug: 11199 Change-Id: I6b10a0954020d58dcec93364ebecc8a7069ac8f3 Reviewed-on: https://code.wireshark.org/review/8467 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-05-15androiddump: fix compilation under FreeBSDEdwin Groothuis1-0/+4
Bug: 11200 Change-Id: Ic46b235c84488bb8537ec3c2605e6770eb843795 Reviewed-on: https://code.wireshark.org/review/8469 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-05-15Qt: Implement "Apply as Column" for packet contextRoland Knall6-11/+39
Implement the same functionality for "Apply as Column" as it exists in the GTK version of Wireshark. Especially for the context menu in the packet view panel. Change-Id: Id25b7797616ff3b3acf7aa920395516c8a4e9bf9 Reviewed-on: https://code.wireshark.org/review/7604 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-14Pop the display filter status when it loses focus.Gerald Combs2-0/+8
Change-Id: I7878fd99f8b773f8c550a6d2416e9e2d44abd321 Reviewed-on: https://code.wireshark.org/review/8466 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-14Don't complete the current field.Gerald Combs1-2/+4
Change-Id: If2b16783d08d23df427ac9b9c86984245db56d53 Reviewed-on: https://code.wireshark.org/review/8465 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-14Fix display filter completion behavior.Gerald Combs1-9/+5
Allow completion for mismatched protocol and filter names. Change-Id: I1d1e6b8f16d4d2d331b915c199f857835dcc1c53 Ping-bug: 11187 Reviewed-on: https://code.wireshark.org/review/8464 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-14Fix packet list font zooming.Gerald Combs1-2/+2
Change-Id: I376fc3b41e9ebbe1353527d8d3bbf8d4b86cc29a Reviewed-on: https://code.wireshark.org/review/8463 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-14USB COM: add dissection of Ethernet Networking Functional DescriptorPascal Quantin1-3/+216
Change-Id: Id5023090b5b80ca12695fc9e012a59f53b30479c Reviewed-on: https://code.wireshark.org/review/8461 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-05-14Qt: Apply protocol preferences.Gerald Combs1-0/+8
Make sure we call prefs_apply_all when saving preferences. Bug: 11119 Change-Id: Iacf1e28e69c2aebcbbd7dceaa210c8219663665f Reviewed-on: https://code.wireshark.org/review/8462 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-14Qt: Column preference fixes.Gerald Combs5-18/+19
Don't call redrawVisiblePackets in PacketList::sectionResized. Otherwise we trigger the crash in bug 11179. Call recent_set_column_width instead. Clean up the slots called when column preferences change and when recent column widths change. Update our column visibility in redrawVisiblePackets. Use recent_get_column_width when writing the recent file. columnWidth doesn't return a valid value when we're not visible. Bug: 11179. Change-Id: I34ab93d944b341e42129a1c8ff94ba8f7ad4f5fc Reviewed-on: https://code.wireshark.org/review/8457 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-14Add a comment explaining completion misbehavior.Gerald Combs1-0/+5
Note that field name completion won't work correctly if a field's abbrev doesn't match its protocol filter name. Fixing this is left as an exercise for the reader. Change-Id: Ia9b55f20bf58b8252e27506bcce4a0dd71cc199c Reviewed-on: https://code.wireshark.org/review/8460 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-05-14GSM A RR: fix 'packet channel description' dissectioncff3391-16/+36
It should support decoding 'MA_NUMBER_IND' and 'CHANGE_MARK_1'. Signed-off-by: cff339 <cff339@gmail.com> Change-Id: I634f326b4741b8853a631e6da2e9c056f60781ef Reviewed-on: https://code.wireshark.org/review/8458 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-05-14Register the IPv4 and IPv6 dissectors directly with WTAP_ENCAP_RAW_IP{4,6}.Guy Harris3-11/+2
No need to run them through the "raw IP" dissector. Change-Id: I63639651873f00326a20b88a08ecb4ab3b9a83b3 Reviewed-on: https://code.wireshark.org/review/8459 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-05-14Don't put an expert info on every single raw frame (even if it was just a Note).Jeff Morriss1-14/+1
It's completely normal that there's no link information when you're dissecting raw packets. This does leave the Raw protocol tree without any children (which looks a little funny) but I don't want to take it out and I don't see anything useful to put under it. Also change the Raw protocol item to cover all the bytes of the TVB (like the frame item). Change-Id: I44c1ac954c9989273d0c461ba366caba0a480ea6 Reviewed-on: https://code.wireshark.org/review/8454 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-24 03:28:44 +0000