aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2000-03-21Some cleanup of the RADIUS AVP output (Tunnel Tagging Tag), and a bit ofGuy Harris2-52/+80
Vendor-specific decoding (shows at least the Vendor), from Florian Lohoff. svn path=/trunk/; revision=1739
2000-03-21Andreas Sikkema's patch to make the SMB dissector not blithely pass aGuy Harris1-3/+4
null "request_val->last_transact_command" to "col_add_fstr()". svn path=/trunk/; revision=1738
2000-03-21Paul Welchinski's changes to, on Win32 systems:Guy Harris4-15/+58
properly handle ASCII vs. Unicode in the list of interfaces; initialize Winsock before starting a capture, so that the code in the Win32 libpcap to get the IP address and netmask by translating the host name to an IP address works. svn path=/trunk/; revision=1737
2000-03-21Create the tree entry for resource records in DNS replies, and add theGuy Harris1-152/+137
record type to the info column, before parsing the reply; add the text for the entry, and any additional information for the info column, in the code that handles the reply. Don't use stuff from the resource record if you ran past the end of the packet. Fix some bit-scanning code. svn path=/trunk/; revision=1736
2000-03-21Add support for TXT and WKS records to the DNS dissector.Guy Harris3-20/+139
Add EIGRP and VINES to the list of protocols "ipprotostr()" knows about. Get rid of the "proto_vals" table in "packet-ip.c" - it's not used, and the two entries it had that weren't in the table in "ipproto.c" have been moved there. svn path=/trunk/; revision=1735
2000-03-21Jochen Friedrich's fix to IPv6 fragment handling.Guy Harris3-9/+26
svn path=/trunk/; revision=1734
2000-03-20Change dfilter_init() to check for empty-string abbreviations and forGilbert Ramirez10-44/+44
duplicate abbreviations. All mods to packet-*.c files are fixes to remove those cases. svn path=/trunk/; revision=1733
2000-03-20Add fields tr.addr, fddi.addr, and isl.addr that act like eth.addr, matchingGilbert Ramirez3-3/+26
either *.src or *.dst svn path=/trunk/; revision=1732
2000-03-20Added Novell option decoding patch from Fredrik Sorensson <fsn@volvo.se>.Gerald Combs1-5/+104
svn path=/trunk/; revision=1731
2000-03-20Added Jeff Foster's patch to add an eth.addr field.Gilbert Ramirez1-2/+15
svn path=/trunk/; revision=1730
2000-03-20Florian Lohoff's changes for RADIUS tunnel attributes and for theGuy Harris3-2/+95
Internet Draft for RADIUS tunnel attribute tagging. svn path=/trunk/; revision=1729
2000-03-20In "add_packet_to_packet_list()", always use the "buf" argument to referGuy Harris1-5/+5
to the raw packet data, don't use "cf->pd" - "cf->pd" doesn't contain the packet data when the file is being read in, it only contains it when we're re-reading packets. svn path=/trunk/; revision=1728
2000-03-17Change the type of the "v120.control" protocol field from FT_STRING toGuy Harris1-14/+21
FT_UINT16; the xDLC code requires control fields to be FT_UINTn, as it uses "proto_tree_add_uint_format()" to add that field to the protocol tree. Always pass TRUE as the "is_extended" argument to "dissect_xdlc_control()" - the V.120 spec says "The data link control sublayer provides the procedures and formats of fields for data link layer peer-to-peer communication. ... For formats and the elements of procedures, see Recommendation Q.922", and Q.922 seems to at least allow for modulo 128 operation; it also speaks of SABME, as does V.120, and I *think* the "extended" in "Set asynchronous balanced mode extended" means "modulo 128". Dissect the terminal adaptation sublayer header field after dissecting the control field, so that the V.120 tree shows the data in sequential order. Calculates the length of the V.120 header based on the control field type (using the "XDLC_CONTROL_LEN()" macro) and the length of the terminal adaptation sublayer header ("dissect_v120_header()" now returns the length of what it dissects). Call "dissect_data()" on the V.120 payload, so you at least know how much data there is, and can click on an item to see it highlighted. svn path=/trunk/; revision=1727
2000-03-16Put the EIGRP packet type into the INFO column in the packet list entryGuy Harris1-13/+13
for an EIGRP packet. svn path=/trunk/; revision=1726
2000-03-15Changed the type of the lapb.control protocol field from FT_STRING toOlivier Abad1-2/+2
FT_UINT8. The lapb dissector was broken by the changes to `proto_tree_add_uint_format' in xdlc.c because of the type of this field. svn path=/trunk/; revision=1725
2000-03-15Give all the Ethereal APIs available to plugins their own functionGuy Harris5-235/+212
pointers, and call the APIs by calling through the function pointers - the old technique of using wrappers didn't work, as the underlying function they all called no longer exists. svn path=/trunk/; revision=1724
2000-03-15Rename the local variable "pi" to "ti" in several places - "pi" is alsoGuy Harris1-10/+10
the name of the global variable containing packet information, and, on platforms where dynamically-loaded code can't access global variables and functions in the main program, we #define "pi" in plugins to be "(*p_pi)", which causes problems even if a plugin with a local variable named "pi" *isn't* accessing the global "pi". svn path=/trunk/; revision=1723
2000-03-15Give the entry box in the "Find Frame" and "Go To Frame" dialog boxesGuy Harris2-2/+8
the initial focus, so you can start typing immediately. svn path=/trunk/; revision=1722
2000-03-15Treat the two integers after the request ID in a BulkPDU asGuy Harris1-13/+25
"non-repeaters" and "max-repetitions" rather than as "error status" and "error index". svn path=/trunk/; revision=1721
2000-03-15Dietmar Petras' fix to the handling of SNMPv2 TRAP PDUs.Guy Harris2-2/+5
Fix a comment. svn path=/trunk/; revision=1720
2000-03-14Sigh. OpenBSD defines "HAVE_UNISTD_H" in the Makefile for zlib, so,Guy Harris1-11/+28
unlike FreeBSD and older versions of NetBSD, which give "gzseek()" and "gztell()" signatures with "long" file-offset arguments, and thus, on some versions, requires that "HAVE_UNISTD_H" *not* be defined before including "zlib.h" if you want the functions declared with a signature that matches what's actually in the library, it requires that it *be* defined before including "zlib.h" if you want the functions declared with a signature that matches what's actually in the library. svn path=/trunk/; revision=1719
2000-03-14On Windows, when getting the user's home directory, don't look at theGuy Harris1-18/+56
HOME environment variable; instead, look at HOMEDRIVE and HOMEPATH. svn path=/trunk/; revision=1718
2000-03-14Convert two instances of proto_tree_add_uint_format() toGilbert Ramirez1-5/+5
proto_tree_add_protocol_format(). I had converted them incorrectly when I changed them from their original proto_tree_add_item_format(). svn path=/trunk/; revision=1717
2000-03-14Fix some errors discovered by making GCC do format string/argumentGuy Harris7-30/+31
cross-checking, and by replacing "proto_tree_add_item_format()" by multiple routines to add items of various types. Make the arguments of "proto_tree_add_bytes_format()" and "proto_tree_add_string_format()" that specify the bytes or the string be "const" pointers, so that one can pass a "const" pointer without complaints from the compiler. Squelch a (bogus, but the compiler isn't in a position to know that) complaint about an uninitialized variable. svn path=/trunk/; revision=1716
2000-03-13Remove the proto_tree_add_text() and proto_tree_add_item_hidden() callsGilbert Ramirez1-11/+10
for mpls.label and replace them with proto_tree_add_uint_format() and proto_tree_add_item(). In the mpls proto_registration, associated the val_string with mpls.label. svn path=/trunk/; revision=1715
2000-03-13New workaround for not using (ulong *) to dereference memory in RSVP.Ashok Narayanan1-7/+17
Here's the email I wrote to Guy with info on this: Subject: Re: [ethereal-dev] Checked in support for MPLS From: Ashok Narayanan <ashokn@cisco.com> To: gharris@flashcom.net Cc: ethereal-dev@zing.org Date: Mon, 13 Mar 2000 00:10:38 -0500 X-Mailer: Mew version 1.94.1 on XEmacs 21.1 (Biscayne) Guy, > The code in that was fetching some fields by casting pointers into the > packet to "ulong *" and dereferencing the resulting pointer - this is > bad for three reasons: > > "ulong" is not a system-declared data type on all platforms > (it's not on FreeBSD 3.4, at least, for example); > > casting an arbitrary pointer into a frame to point to something > longer than 1 byte, and dereferencing it, is dangerous, as > there's no guarantee that said pointer is properly aligned on > machines that require alignment (such as SPARC, Alpha, and MIPS, > and possibly at least some other RISC processors); I agree with both these points. > the data in an RSVP packet is presumably big-endian in any case, > so you should use "pntohl()" to access it, rather than just > blithely dereferencing it; This is the exact problem which a direct cast attempts to work around. A tree of type FT_IPv4 apparently has a network-to-host conversion built into the proto_tree_add_item call. When you added the pntohl, you inserted a second network-to-host conversion - the result is that all the IP addresses are reversed. Here's an excerpt from tethereal.... 1) ~/sniffer/test/ethereal> ./tethereal -n -r ../../sniffs/mpls_te.cap -R 'rsvp.path' 3 8.024159 17.3.3.3 -> 16.2.2.2 RSVP PATH Message 15 31.589751 17.3.3.3 -> 16.2.2.2 RSVP PATH Message 22 47.072205 17.3.3.3 -> 16.2.2.2 RSVP PATH Message <snip> 2) ~/sniffer/test/ethereal> ./tethereal -n -r ../../sniffs/mpls_te.cap -R 'rsvp.path' -V Frame 3 (306 on wire, 306 captured) <snip> Ethernet II <snip> Internet Protocol <snip> Source: 17.3.3.3 (17.3.3.3) Destination: 16.2.2.2 (16.2.2.2) <======== Destination is 16.2.2.2 Options: (4 bytes) Unknown (0x94) (4 bytes) Resource ReserVation Protocol (RSVP) RSVP Header RSVP Version: 1 Flags: 00 Message Type: PATH Message (1) Message Checksum Sending TTL: 254 Message length: 264 SESSION: 1 Length: 16 Class number: 1 - SESSION object C-type: 7 - IPv4 LSP Destination address: 2.2.2.16 (2.2.2.16) <======== Destination is reversed Tunnel ID: 1 Extended tunnel ID: 285410051 I'm looking around in the filtering code (which I don't really understand), to see if I can find a quick fix to the problem. If you or Gilbert knows what's happening, you may want to fix it. But as it stands now, using pntohl() in a proto_tree_add_item() call is broken. A slightly better workaround is to do something like this: memcpy(&ip_addr, pd[offset2], 4); proto_tree_add_item(....., ip_addr); but this is still ugly. I'll implement this workaround and check in the code (since as it stands now, RSVP decoding is broken). However, the underlying issue needs to be resolved. -Ashok svn path=/trunk/; revision=1714
2000-03-12Break proto_tree_add_item_format() into multiple functions:Gilbert Ramirez55-508/+1068
proto_tree_add_protocol_format() proto_tree_add_uint_format() proto_tree_add_ipxnet_format() proto_tree_add_ipv4_format() proto_tree_add_ipv6_format() proto_tree_add_bytes_format() proto_tree_add_string_format() proto_tree_add_ether_format() proto_tree_add_time_format() proto_tree_add_double_format() proto_tree_add_boolean_format() If using GCC 2.x, we can check the print-format against the variable args passed in. Regardless of compiler, we can now check at run-time that the field type passed into the function corresponds to what that function expects (FT_UINT, FT_BOOLEAN, etc.) Note that proto_tree_add_protocol_format() does not require a value field, since the value of a protocol is always NULL. It's more intuitive w/o the vestigial argument. Fixed a proto_tree_add_item_format-related bug in packet-isis-hello.c Fixed a variable usage bug in packet-v120.c. (ett_* was used instead of hf_*) Checked in Guy's fix for the function declearation for proto_tree_add_text() and proto_tree_add_notext(). svn path=/trunk/; revision=1713
2000-03-12In the TCP stream following code, we don't use the time stamp field inGuy Harris3-20/+24
the stuff we write to the temporary file, so don't bother writing it. Keep track of the two sides of the TCP stream by keeping track of the source address *and* port, so that we correctly handle connections between two ports on the same machine. svn path=/trunk/; revision=1712
2000-03-12Making the "frame_data" structure for a frame the data associated withGuy Harris1-13/+56
the row for that frame, and using that to get the frame for the selected row in "select_packet()", revives the crash caused by the GtkCList selecting the first row added to the list as it's added, i.e. before we get a chance to set the data for that row, in this case. Introduce a workaround for this instance of that crash. svn path=/trunk/; revision=1711
2000-03-10Fix some typos.Guy Harris1-13/+54
Get rid of the paragraph about C++-style comments at the beginning of the document, as it also appears in section 1.1.1 "Comments". Add a section on how to extract data from packets, which explains the "pd" and "offset" arguments to a dissector, and notes that you should not just blithely cast pointers into the packet data to 2-byte or 4-byte integral types and dereference them, as the pointer may not be aligned, and the field may not have the same byte order as the processor on which Ethereal is running (in fact, it's probably *guaranteed* not to on at least one machine, as Ethereal runs on both big-endian and little-endian platforms...). svn path=/trunk/; revision=1710
2000-03-10 "ulong" is not a system-declared data type on all platforms;Guy Harris1-6/+6
casting an arbitrary pointer into a frame to point to something longer than 1 byte, and dereferencing it, is dangerous, as there's no guarantee that said pointer is properly aligned on machines that require alignment; the data in an RSVP packet is presumably big-endian in any case, so you should use "pntohl()" to access it, rather than just blithely dereferencing it; so use "pntohl()" to extract fields from an RSVP packet rather than casting pointers to "ulong *" and dereferencing them. svn path=/trunk/; revision=1709
2000-03-09- Jeff Foster's documentation for conversations and coding styleOlivier Abad1-20/+243
- Documentation for plugins. svn path=/trunk/; revision=1708
2000-03-09Support for MultiProtocol Label Switching (MPLS). The following supportAshok Narayanan11-142/+1082
is being added - MPLS Traffic Engineering extensions for RSVP - MPLS-encapsulated IP packets on Ethernet - OSPF Extensions for MPLS (including generic opaque LSA support for OSPF) THe following features will be committed at a later date (if I get around to writing them :-) - Label Distribution Protocol (LDP) - IS-IS Extensions for MPLS svn path=/trunk/; revision=1707
2000-03-09New dissector functions for mount DUMP and EXPORT replies.Uwe Girlich1-11/+163
svn path=/trunk/; revision=1706
2000-03-09New generic function dissect_rpc_list() for variable length RPC lists.Uwe Girlich1-2/+30
svn path=/trunk/; revision=1705
2000-03-09Prototype for new dissect_rpc_list() function.Uwe Girlich1-1/+3
svn path=/trunk/; revision=1704
2000-03-08We already set the foreground and background color for every frame,Guy Harris3-58/+47
which means we're already doing a "do something to the last row in the packet list" operation on every frame we add to the list, so adding a call to "gtk_clist_set_row_data()" won't make matters worse. In addition, we already set one column in a row on a "change time format" operation, so finding the row for a frame by calling "gtk_clist_find_row_from_data()" doesn't turn a constant-time operation into a linear-time operation, it just cranks the proportionality constant up - it was quadratic before, alas, and it's still quadratic. Adding calls to "gtk_clist_find_row_from_data()" to the "Find Frame" and "Go To Frame" code does add an extra linear operation there, but those operations shouldn't be common - and "Go To Frame", going to the last frame on an ~100,000-frame big capture file, was quick, at least on my 450 MHz Pentium II machine, so maybe it won't be too bad. And "select_packet()" either has to search the frame table for the frame with the specified row number, or has to call "gtk_clist_get_row_data()" to do that - the first is linear in the position of the frame in the frame table, and the latter is linear in its position in the CList, and the latter is less than or equal to the former, so the only thing making it worse would be a change in the proportionality constant. So it probably won't hurt performance by much. Furthermore, if we add the ability to sort the display on an arbitrary column, or to delete frames from the display - both of which are in the wish list - storing the row number of the frame in the "frame_data" structure won't necessarily work, as the row number can change out from under us. Therefore, reinstate the old way of doing things, where we associate with each row a pointer to the "frame_data" structure for the row, using "gtk_clist_set_row_data()". svn path=/trunk/; revision=1703
2000-03-07Note that the "-T" flag doesn't cause "editcap" to translate link-layerGuy Harris1-1/+7
headers, it just causes it to force the encapsulation type of the output file to the specified type. svn path=/trunk/; revision=1702
2000-03-07Fix some "proto_tree_add_text()" calls.Guy Harris1-80/+80
svn path=/trunk/; revision=1701
2000-03-07Make "name_length" and "value_length" universally "int"s - the valuesGuy Harris1-16/+16
they get from the packets are 16-bit unsigned quantities, which fit comfortable within an "int" on all platforms we support. That eliminates the some additional format/argument mismatches. svn path=/trunk/; revision=1700
2000-03-07Fix some "proto_tree_add_text()" calls.Guy Harris1-28/+24
Use "proto_tree_add_notext()" and "proto_tree_set_text()" for some resource records. svn path=/trunk/; revision=1699
2000-03-07Declare "proto_item_set_text()" in such a fashion as to make GCC 2.x andGuy Harris2-7/+10
later check the format string against the arguments. svn path=/trunk/; revision=1698
2000-03-07Fix some "proto_tree_add_text()" calls.Guy Harris1-64/+73
Reorganize "icqv5_cmd_send_text_code()" a bit so that it only puts an item into the tree if it's present in the packet. svn path=/trunk/; revision=1697
2000-03-07Fix some "proto_tree_add_text()" calls.Guy Harris6-38/+38
svn path=/trunk/; revision=1696
2000-03-06Fix some "proto_tree_add_text()" calls.Guy Harris4-27/+27
svn path=/trunk/; revision=1695
2000-03-06Correctly dissect integer values, using the correct offset.Guy Harris1-3/+3
svn path=/trunk/; revision=1694
2000-03-06Fix a call to "proto_tree_add_text()", and declare "name_length" in suchGuy Harris1-13/+13
a fashion as not to cause GCC to whine about format/argument mismatches if "proto.h" is tweaked to declare "proto_tree_add_text()" with an "__attribute__((format (printf, ...))" clause. svn path=/trunk/; revision=1693
2000-03-04Fix for reading toshiba trace files that were created by using theGilbert Ramirez1-11/+23
"save session" feature in many Windows-based telnet apps. CRT, by VanDyke, in particular, will put in newlines at 80 columns. svn path=/trunk/; revision=1692
2000-03-03Add config.nmake and two Makefile.nmake's to the list of deliverables.Gilbert Ramirez3-4/+9
svn path=/trunk/; revision=1690
2000-03-03Fix a typo.Guy Harris1-2/+2
svn path=/trunk/; revision=1689
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-24 23:07:02 +0000