aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-03-26GSS-API: Make sure we call a valid dissector.Gerald Combs1-8/+26
Make our unknown dissector handle logic conistent with other parts of the code. Bug: 15613 Change-Id: Id0daf9bf0be14b99ec592f4f561cc8935d5cb4a6 Reviewed-on: https://code.wireshark.org/review/32576 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-03-25export giop_add_CDR_string for use in pluginsYannik Enss1-1/+1
idl2wrs generates code calling this function, loading a plugin build using that code leads to an error. Making giop_add_CDR_string public enables loading generated plugin dissector using idl2wrs Change-Id: I6f4da12b3aa34d94dbf933957f1865aeaaf93ead Reviewed-on: https://code.wireshark.org/review/32574 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-25NAS 5Gs: SUCI dissectionSwapnil Roy1-11/+90
Change-Id: I572f0d909bf8d91eedb82fc4c9889fc1e8a4d1b7 Reviewed-on: https://code.wireshark.org/review/32557 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-25gtp: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I5b74036383f6e53f1deaed32cd7858edf3feeda0 Reviewed-on: https://code.wireshark.org/review/32550 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-25gssapi: fix indentation in function dissect_gssapi_work().Dario Lombardo1-69/+66
Change-Id: I48f331a0e572ce8b9b6b3fbe9eb45b7e2ba2b33a Reviewed-on: https://code.wireshark.org/review/32572 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-03-24iseries: fix wrong indentation.Dario Lombardo1-32/+32
Change-Id: I4d6e145412037e4a3a40688139b12ada0f36e413 Reviewed-on: https://code.wireshark.org/review/32556 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-03-24Revert "iseries: stop scanning a unicode string when the null terminator is ↵Guy Harris1-1/+1
hit." This reverts commit c599e490281b523df23010ae25307ff002068e17. Reason for revert: This completely fails to recognize Unicode iSeries dumps. Change-Id: Ie31141879b1bc3608a5dfdcba6887bb6f0018a47 Reviewed-on: https://code.wireshark.org/review/32568 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-24travis: Allow Windows builds to failPeter Wu1-0/+3
Travis CI builds for Windows are still experimental with no sign of improvement for caching, pre-installed packages and other issues. Allow it to fail such that Linux/macOS builds determine the build result. Change-Id: I146e829bd89ab4f0e7bc9e1f1b89803c2294b75d Reviewed-on: https://code.wireshark.org/review/32566 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-03-24iseries: stop scanning a unicode string when the null terminator is hit.Dario Lombardo1-1/+1
Bug: 15614 Change-Id: I1df4992dcd10e7d9a66fc88a0269b70fc065b079 Reviewed-on: https://code.wireshark.org/review/32514 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-03-24dof: don't use src/dst addresses if they don't exist.Dario Lombardo1-0/+4
Bug: 15617 Change-Id: I1177e704d33626d126b7e835e5a8db3162847fbf Reviewed-on: https://code.wireshark.org/review/32442 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-03-24ieee80211: Fix Dead Store (Dead assignement/Dead increment) Warning found by ↵Alexis La Goutte1-1/+0
Clang Change-Id: Ie03b269c67a31638b5fd8e709ea839456db41fbf Reviewed-on: https://code.wireshark.org/review/32551 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Mikael Kanstrup <mikael.kanstrup@sony.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-03-24[Automatic update for 2019-03-24]Gerald Combs16-115/+782
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ib05f06638757aa7d96f6ebfd4cfb5baaf347bf99 Reviewed-on: https://code.wireshark.org/review/32552 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-24gitlab-ci: fix asciidoctor version in opensuse.Dario Lombardo1-1/+1
openSUSE now ships with 2.0.0 which is incompatible. Use 1.5.8 instead. Disable ri and rdoc while here. Change-Id: I40766ae4377f5998dcd58d02ecbdac665f78222a Reviewed-on: https://code.wireshark.org/review/32547 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-03-24Add routines to return "Please report this as a bug" message strings.Guy Harris5-24/+81
(Routines, so that if we internationalize strings not in the Qt code, this can return the appropriately translated version.) Change-Id: I1c169d79acde2f0545af7af2a737883d58f52509 Reviewed-on: https://code.wireshark.org/review/32549 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-23wsgcrypt: fix wrong double assignment (CID: 1444233).Dario Lombardo1-2/+1
Change-Id: Iaff0f7c6cc24286dcf48330088b1ba9a3f5dd18e Reviewed-on: https://code.wireshark.org/review/32541 Petri-Dish: Dario Lombardo <lomato@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-23Bluetooth HCI: Rename LE Read Remote Used Features commandAllan Møller Madsen2-10/+10
The command name was changed between core spec 4.2 and 5.0, it is now: LE Read Remote Features Bug: 14582 Change-Id: Ia64db822e680263d9e4fef9d6c466e128597a13f Signed-off-by: Allan Møller Madsen <almomadk@gmail.com> Reviewed-on: https://code.wireshark.org/review/32540 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-23Clean up IPMB/I2C link-layer header types.Guy Harris6-49/+100
209 is LINKTYPE_IPMB_LINUX; add _LINUX/_linux to the WTAP_ENCAP_ name and function/structure names, to clarify that it's not I2C in general, it's I2C with a particular pseudo-header. 199 is now LINKTYPE_IPMB_KONTRON, not LINKTYPE_IPMB, as it doesn't have raw I2C packets, it has I2C packets with a pseudo-header. Change the WTAP_ENCAP_ name, and add a dissector for it. Change-Id: Ie097f4317b03d2b2adfd9b81a4b11caf6268399e Reviewed-on: https://code.wireshark.org/review/32539 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-23Restore pinfo->match_uint after the topmost dissector returns.Guy Harris1-0/+3
That's what dissector_try_uint_new() does, and some tests depend on it. Bug: 15630 Change-Id: I57934a5e90f83ee6ea0eb539a91826c950530ad3 Reviewed-on: https://code.wireshark.org/review/32542 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-23Qt: Fix our Expert Info foreground color logic.Gerald Combs2-4/+23
Set the foreground color of an expert info item only when we set its background color, otherwise we show black text on a dark background. Remove an unneeded include while we're here. Change-Id: Ibb835d26d7aa18bfb406b7820b321dc372aed599 Ping-Bug: 15511 Reviewed-on: https://code.wireshark.org/review/32534 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-23ieee80211: Add version and subtype field for Aerohive IEAlexis La Goutte1-8/+18
Change-Id: Icd0b04ca9d5fce6ff30c030b1a3d8b60f903e40a Reviewed-on: https://code.wireshark.org/review/32499 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-23Clean up the new-file selection criteria in the GUI.Jeff Morriss4-17/+101
Inspired by looking into https://ask.wireshark.org/question/8009/wireshark-ring-buffer-settings-from-command-line/ ... in which the user was confused because a duration set on the command line was not reflected in the GUI. That's because I0180c43843f5d2f0c2f50153c9ce42ac7fa5aeae added the `interval` ring-buffer option and made the GUI use this rather than `duration`. This was not at all clear in the GUI, though. Since `duration` and `interval` have quite different use cases, expose both in the GUI. Try to clean up and unify the tooltips at the same time. I'm not entirely convinced the tooltips need to be on the checkbox, the spinbox, and the combobox but leave it that way for now. Add some to the man page description of the interval option to hopefully make it clearer what the option does. Change-Id: I3b45fe71c33af64d980dffb5e5ba93e2a15a6b96 Reviewed-on: https://code.wireshark.org/review/32526 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-23print: don't ignore FT_NONE fields in ek.Dario Lombardo1-3/+8
The 'null' placeholder has been used in such a fields. Otherwise the json dumper would complain for the lack of a value, getting confused by a double name add without values. Bug: 15628 Change-Id: I016325790f8d4a02ed9288225e861ba2d23a82f9 Reviewed-on: https://code.wireshark.org/review/32532 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-03-22json_dumper: flush dumper before printing an error.Dario Lombardo1-0/+1
This helps the developer in the debug phases. Change-Id: I85558334b5d618219a48a6c00129cd36a6ab0b10 Reviewed-on: https://code.wireshark.org/review/32531 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-03-22Mark IPMB packets as IPMB in the protocol column.Guy Harris1-0/+2
Change-Id: I21ff235ddeac7abf16fa75e925e7328d60b8a281 Reviewed-on: https://code.wireshark.org/review/32533 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-22krb5: dissect padata PA-PAC-OPTIONSIsaac Boukris4-38/+124
Roughly based on MS-KILE and MS-SFU. Change-Id: Ia88d5279963619ada82a5f45c1393f6cbfcfd7c9 Signed-off-by: Isaac Boukris <iboukris@gmail.com> Reviewed-on: https://code.wireshark.org/review/32519 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22Don't use dissector_try_uint_new() to call the subdissector.Guy Harris1-10/+34
See bug 15630 for details. Bug: 15630 Change-Id: Ib7c9defae77ef8901ff2c8ef91dc50761f6924f2 Reviewed-on: https://code.wireshark.org/review/32527 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-22bthci_evt: add BASE_UNIT_STRING to bthci_evt.max_encryption_key_size.Dario Lombardo1-1/+1
Required when using units. Change-Id: Icd6ab5ac28b0766deca801ad00da895dc0dadfe4 Reviewed-on: https://code.wireshark.org/review/32518 Reviewed-by: Vasil Velichkov <vvvelichkov@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-03-22randpkt: fix indentation.Dario Lombardo1-15/+14
Change-Id: Ie999c50ef97476a8d389be45e2f12046d20273bd Reviewed-on: https://code.wireshark.org/review/32512 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22GTP:Dissect more IEsAnders Broman4-127/+223
Bug: 15626 Change-Id: I39f37c3ca7f5f56946a21b5cc1a4c2d3b39d381d Reviewed-on: https://code.wireshark.org/review/32521 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22Rbm: Be more strict about unknown object types.Gerald Combs2-2/+7
Stop dissection if we encounter an unknown object type. Update .editorconfig while we're here. Bug: 15612 Change-Id: I91c0868c376c2b50645af997e0bf84e5c90a512b Reviewed-on: https://code.wireshark.org/review/32523 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-03-22wsgcrypt: fix build with older gcrypts.Jeff Morriss1-2/+6
Fixes 9cf77ec5e12e24f1a8c6eb9fa14c015b830f066b. Change-Id: Ie90ce25995707d88995c243cb7b2d5013c3a4c28 Reviewed-on: https://code.wireshark.org/review/32522 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2019-03-22Fix order of ring buffer and auto-stop items on the Capture Options page.Jeff Morriss1-148/+148
Apparently the order of the items defined here affects the order in which order tab will cycle through them. See: https://ask.wireshark.org/question/8010/wireshark-ring-buffer-settings-page-tab-sequence/ Sort the items by row and then by column; this gives a natural order when tabbing through. Change-Id: I1137ef59a3fbf506734d828d9bdfa87bddb96c3b Reviewed-on: https://code.wireshark.org/review/32500 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> (cherry picked from commit 19bdf734f753713241adeccf7de0934a2d0c5032) Reviewed-on: https://code.wireshark.org/review/32516
2019-03-22ITS: Fix decoding of messages using ITS-Container V2 ts (102637).Anders Broman7-520/+612
This semms to be a bit messy as some sub protocols points to a different spec (EVCSN ts (101556)) Bug: 15624 Change-Id: I60d8adc92f6b16b564e9d9d1a6dc46302c32b748 Reviewed-on: https://code.wireshark.org/review/32502 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22Bluetooth HCI: Core spec 5.1 supportAllan Møller Madsen3-45/+920
Dissection added for HCI commands/events: Read Local Simple Pairing Options LE Receiver Test [v3] LE Transmitter Test [v3] LE Set Connectionless CTE Transmit Parameters LE Set Connectionless CTE Transmit Enable LE Set Connectionless IQ Sampling Enable LE Set Connection CTE Receive Parameters LE Set Connection CTE Transmit Parameters LE Connection CTE Request Enable LE Connection CTE Response Enable LE Read Antenna Information LE Set Periodic Advertising Receive Enable LE Periodic Advertising Sync Transfer LE Periodic Advertising Set Info Transfer LE Set Periodic Advertising Sync Transfer Parameters LE Set Default Periodic Advertising Sync Transfer Parameters LE Generate DHKey [v2] LE Modify Sleep Clock Accuracy LE Connectionless IQ Report LE Connection IQ Report LE CTE Request Failed LE Periodic Advertising Sync Transfer Received The following HCI commands have been renamed: LE Receiver Test -> LE Receiver Test [v1] LE Transmitter Test -> LE Transmitter Test [v1] LE Enhanced Receiver Test -> LE Receiver Test [v2] LE Enhanced Transmitter Test -> LE Transmitter Test [v2] LE Generate DHKey -> LE Generate DHKey [v1] LE Periodic Advertising Create Sync command added CTE type field. Version, feature bits and event mask fields updated. Change-Id: I9ecf2749c718023e7f9a762ebfc0263da78e5c0d Signed-off-by: Allan Møller Madsen <almomadk@gmail.com> Reviewed-on: https://code.wireshark.org/review/32492 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22Qt: Welcome page dark mode fixes.Gerald Combs1-2/+2
Adjust the welcome page helpLinks colors. Change-Id: I2befee142253c7f38aa1976f024c97bbc212cb8f Ping-Bug: 15511 Reviewed-on: https://code.wireshark.org/review/32507 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22Qt: Fix our ColorUtils::themeIsDark comparison.Gerald Combs2-1/+7
Change-Id: Ice109cdd5451b67651f10da7e4001d6d4cb0c7f0 Reviewed-on: https://code.wireshark.org/review/32506 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22macOS: Restore dark mode support.Gerald Combs1-0/+2
Comment out the NSRequiresAquaSystemAppearance key in Info.plist under the assumption that both we and Qt will have dark mode support in usable shape by the next release. Ping-Bug: 15511 Change-Id: Ic5960034ce302d81dcc624cbd0e2c017865f44e2 Reviewed-on: https://code.wireshark.org/review/32504 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22sbus: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: If9f4b218869e52877171397b412de74b2fa8def4 Reviewed-on: https://code.wireshark.org/review/32435 Reviewed-by: Christian Durrer <christian.durrer@sensemail.ch> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22BGP: Add LS Advertisment of IGP TE Metric (RFC8571)Uli Heilmeier1-1/+142
Adding support for RFC8571 (BGP - Link State (BGP-LS) Advertisement of IGP Traffic Engineering Performance Metric Extensions) Change-Id: I2f0b415a1a5c3e5f0eb79a6e3758b17c5beba851 Reviewed-on: https://code.wireshark.org/review/32497 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-22randpkt: restore produce_filename in random generation.Dario Lombardo1-0/+1
Bug: 15627 Change-Id: Iac267a679ca3f935f0e165880bb3127a8715b81c Reviewed-on: https://code.wireshark.org/review/32503 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-21packet-ip: Add codepoint LE as per draft-ietf-tsvwg-le-phb.Loganaden Velvindron1-0/+3
From the I-D: This document defines a Differentiated Services per-hop behavior [RFC2474] called "Lower Effort" (LE), which is intended for traffic of sufficiently low urgency that all other traffic takes precedence over the LE traffic in consumption of network link bandwidth [snip] Example uses for the LE PHB: o For traffic caused by world-wide web search engines while they gather information from web servers. o For software updates or dissemination of new releases of operating systems. o For reporting errors or telemetry data from operating systems or applications. o For backup traffic or non-time critical synchronization or mirroring traffic. o For content distribution transfers between caches. o For preloading or prefetching objects from web sites. o For network news and other "bulk mail" of the Internet. o For "downgraded" traffic from some other PHB when this does not violate the operational objectives of the other PHB. o For multicast traffic from untrusted (e.g., non-local) sources. Change-Id: I90b2a08332943daf8349826eaa0862f0c12d6a05 Reviewed-on: https://code.wireshark.org/review/32427 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-03-21ieee80211: Support decrypting WPA3-Personal / SAE capturesMikael Kanstrup10-29/+521
Add support for decrypting IEEE 802.11 WPA3-Personal / SAE traffic. SAE uses AES encryption but a different key derivation function (KDF) making Wireshark fail to decrypt such captures. Also both KDF and decryption method is determined based only on EAPOL key description version. This is not enough to figure out that SAE is being used. Implement the alternative KDF needed to derive valid PTK. Also implement a function to parse pairwise + group cipher suites and auth key management type from RSNE tag. Using this new function together with a number of new cipher and AKM lookup functions correct KDF for SAE can be selected. Bug: 15621 Change-Id: I8f6c917af1c9642c276a244943dd35f850ee3757 Reviewed-on: https://code.wireshark.org/review/32485 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-21NAS-5GS: Dissect Packet filter contents Single remote port type.Anders Broman1-0/+13
Change-Id: I77c79d477af3575428d9d6816f07b54c3302b513 Reviewed-on: https://code.wireshark.org/review/32496 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-21NSIS: Add logic to package Qt debug DLLsJoão Valverde2-3/+12
Bug: 15623 Change-Id: I4898fe2797d987e35bc334211ece8f2f58c562c7 Reviewed-on: https://code.wireshark.org/review/32493 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-21TSDNS: Add more wmem_strsplit return checks.Gerald Combs2-1/+4
wmem_strsplit might return NULL, or it might return fewer tokens than requested. Add checks accordingly. Update the API documentation while we're here. Bug: 15619 Change-Id: I55ae05a36d05252cf57e5c7047a441ef1b438a81 Reviewed-on: https://code.wireshark.org/review/32494 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-21Get rid of unnecessary include.Guy Harris1-1/+0
Change-Id: Ie33b8335acd84d32d282ea8eedac3f5d06f2c5d3 Reviewed-on: https://code.wireshark.org/review/32495 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-20WiX: Fix another libxml2 variable.Gerald Combs1-1/+1
Change-Id: If032c0876ab2ba80b8df7b84e1e1c8e8f1ac425c Reviewed-on: https://code.wireshark.org/review/32490 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-20Clean up comments and white space.Guy Harris1-4/+4
This is a collection of routines, not a program. Change-Id: I76296576443602b7ea016c5311e66a52a73ee941 Reviewed-on: https://code.wireshark.org/review/32491 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-03-20ipp: fix field types.Dario Lombardo1-8/+2
Change-Id: I7867f6f2f0c4d12a898e59e18639d44f0585ece8 Reviewed-on: https://code.wireshark.org/review/32446 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-20Put back EOF rule, but without exporting write_current_packet().Guy Harris3-4/+19
Instead, add a new T_EOF token type, call parse_token() with it when we get an EOF, and, in parse_token(), write the current packet if we get a T_EOF token. That's a bit simpler, and would let us treat EOFs in different places differently, if, for example, we want to report warnings for half-finished packets. Change-Id: Ie41a8a1dedf91c34300468e073f18bf806e01892 Reviewed-on: https://code.wireshark.org/review/32489 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 07:18:24 +0000