aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-06-25.mailmap: update of June (2018)Alexis La Goutte2-2/+4
Change-Id: I5dbebce0dd27c6f6867db61e6b0b0aa6b0d3e36f Reviewed-on: https://code.wireshark.org/review/28285 Reviewed-by: Disha <ddaniel@empirix.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-25RTP: Common functions for allocation/deallocation of rtpstream_info_tJiri Novak11-57/+153
Change-Id: I9a0a11d238473a7c57d85547dca0713ed421a500 Reviewed-on: https://code.wireshark.org/review/28417 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-24gtpv2: extend msgs supported in request/reply matching algorithmIvan Nardi1-0/+26
Change-Id: Iff01f427738faccbf02401760b608dfdd4729f25 Reviewed-on: https://code.wireshark.org/review/28413 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-24gtpv2: all teid header fields should have the same type (like in gtp)Ivan Nardi1-4/+4
Change-Id: Ia793d66c00ee8fdfe2d51da5b569658fd5966e8e Reviewed-on: https://code.wireshark.org/review/28414 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-24USB: Dissect URB transfer flagsLars Christensen3-3/+145
Change-Id: I52cbafe519bbdb46961748a84db4f2db0bbe3c2d Reviewed-on: https://code.wireshark.org/review/28411 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-24Add support for Cisco ACIJoerg Mayer1-3/+215
Experiment with a generic way of adding values to the parent tree Change-Id: I50dc44da3cafac79a0ac100121c83f8d0ff28457 Reviewed-on: https://code.wireshark.org/review/28395 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-06-24[Automatic update for 2018-06-24]Gerald Combs3-6/+83
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I72dd2309fb948662e58b0c5373aa1abd27f3b146 Reviewed-on: https://code.wireshark.org/review/28406 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-24F1AP: upgrade dissector to v15.2.0Pascal Quantin12-963/+6657
Change-Id: Ic2aaf834f702a8d754909d3eff376b71df721093 Reviewed-on: https://code.wireshark.org/review/28405 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-23Don't pass an un-initialized dummy structure to dissect_cip_io_generic().Guy Harris1-16/+14
If we know the information that belongs there, we should fill it in. Otherwise, we should just pass a null pointer, meaning "we don't know what this information is", and we should check for the null pointer and not check the information in question. Bug: 14894 Change-Id: I4f5249855330db65242d8b6eb6b5bda3af3a1925 Reviewed-on: https://code.wireshark.org/review/28404 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-23RTP: code cleanup 3Jiri Novak11-55/+55
*rtp_stream* -> rtpstream to follow common name Change-Id: I381bc1cdb8206c5cfe67e94dd7fb1a5cb25f9c16 Reviewed-on: https://code.wireshark.org/review/28394 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-22enip: fix no previous prototype for ↵Alexis La Goutte1-2/+2
‘dissect_item_sequenced_address/dissect_item_connected_address’ [-Wmissing-prototypes] Change-Id: Ie0b46e49122197a51a916cc70324c1d80936cac9 Reviewed-on: https://code.wireshark.org/review/28384 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-06-22NR RRC: register dissectors for UE-NR-Capability and UE-MRDC-Capability IEsPascal Quantin2-2/+4
Change-Id: I99864ac7aae5e868d8827eb2ac851b22f7c516a6 Reviewed-on: https://code.wireshark.org/review/28392 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-22NAS EPS: fix wrong operator.Dario Lombardo1-1/+1
Change-Id: I50f9c1762338f081ff75b2981e8f49010948580c Reviewed-on: https://code.wireshark.org/review/28391 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-22drb: fix no previous prototype for ↵Alexis La Goutte1-0/+3
‘proto_register_drb/proto_reg_handoff_drb’ [-Wmissing-prototypes] Change-Id: Ib42c8cc9fa04bace49905c7f6cbc49b673376bdf Reviewed-on: https://code.wireshark.org/review/28385 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-06-22NAS EPS: upgrade dissector to v15.3.0Pascal Quantin2-38/+484
Change-Id: I85c3defb81eb65622e0bd124fc4aef4bdbc89822 Reviewed-on: https://code.wireshark.org/review/28390 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-22NGAP: add dissection of DataCodingScheme and WarningMessageContents IEsPascal Quantin3-83/+153
Change-Id: I68346ef9988f5fe2dfe0961debf1c359269e7d32 Reviewed-on: https://code.wireshark.org/review/28387 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-22S1AP: fix a copy/paste error in a field namePascal Quantin2-2/+2
Change-Id: I3c602deaaeffa6738f325df5e4abda7b8214f560 Reviewed-on: https://code.wireshark.org/review/28386 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-22Try to make sure we don't overrun sub-tlvsJoerg Mayer1-28/+58
Change-Id: Idde2861ecdd1edc8f84488361695dc8d5b38d51d Reviewed-on: https://code.wireshark.org/review/28383 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-06-22S1AP: update version info in headerPascal Quantin2-2/+2
Change-Id: I8bd5021786006e08391d885137e7aa5778c9118f Reviewed-on: https://code.wireshark.org/review/28382 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-22S1AP: upgrade dissector to v15.2.0Pascal Quantin16-484/+1649
Change-Id: I53feb77f91ac72f4e5f18c56453f2974b8b426be Reviewed-on: https://code.wireshark.org/review/28376 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-22The fractional part of a secs+nsecs time adjustment must be < 10^9.Guy Harris1-3/+3
One billion nanoseconds is 1 second, so that should just be expressed as 1 second. Change-Id: I0d49838141fa877168d068a2e27b3dcc104c0cef Reviewed-on: https://code.wireshark.org/review/28380 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-22editcap: ifix time shift with useconds carryYour Name1-3/+3
time shift to a whole number of seconds need to carry the seconds Change-Id: I188d915bca8f86a2cc19fc603bf472f461e8beea Reviewed-on: https://code.wireshark.org/review/28372 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-22Declare lead_surrogate only in the block where it's used.Guy Harris1-3/+5
That makes it a bit clearer that we don't need to initialize it to zero before the loop. This fixes a Dead Store (Dead assignement/Dead increment) Warning found by Clang. Change-Id: Iabfc4b47a3c6300814492c37ccfb321afd0c54ea Reviewed-on: https://code.wireshark.org/review/28374 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-22Include <stdlib.h>, to declare exit().Guy Harris1-3/+4
Move the standard C includes up to the top, while we're at it. Change-Id: I627536097955d96e7e5dcd48d9c1cc38a221fefb Reviewed-on: https://code.wireshark.org/review/28375 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-22PER: fix decoding of bit strings with an upper bound >= 64KPascal Quantin1-1/+1
Change-Id: Ibe10f172a9758afd5d38a78e2613f97b04d9c8ee Reviewed-on: https://code.wireshark.org/review/28371 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-22tshark/RTP: GUI dependency removed from register_tap_listener_rtpstream. As ↵Jiri Novak6-92/+98
consequence of it a few functions were moved from ui/rtp_stream to ui/tap-rtp-common. Change-Id: I9dd0603a9742eb374e71e84d1380083d6c861166 Reviewed-on: https://code.wireshark.org/review/28368 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21XRA: HCS check for docsis segmentsBruno Verstuyft1-4/+35
Change-Id: Iff44a3b13c13ba43442f3c3e6b186be6cd9fdcb5 Reviewed-on: https://code.wireshark.org/review/28364 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-21WSUG: Update the Follow Stream documentation.Gerald Combs4-60/+76
Update the Follow Stream documentation and screenshot. Change-Id: I55e5e552d23b9676b23959ac07a480e0c7809ac4 Reviewed-on: https://code.wireshark.org/review/28366 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-21Indicate why we ahve to check the address type.Guy Harris1-1/+2
Change-Id: I223eba466680e7ef6003e3412084eb1009d8d38d Reviewed-on: https://code.wireshark.org/review/28369 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-21Squelch a warning from MSVC.Guy Harris1-1/+1
Cast the result of a floating-point calculation to guint32; presumably it will have no fractional part or we're deliberately discarding the fractional part, and will never be greater than 2^32-1, so tell the compiler we mean to discard the fractional part and have no need to worry about the integral part being too large. Change-Id: I432df46b59fe3192cd0a804d3d1db1f95983abe2 Reviewed-on: https://code.wireshark.org/review/28367 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-21rtps: Fixed min_length in rtps_data dissectionIsmael Mendez Matamoros1-1/+1
Change-Id: I46402f714d70466cafbe736baf570149c78c6dbf Reviewed-on: https://code.wireshark.org/review/28363 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21 RTP: Stats calculation unificationJiri Novak5-109/+173
Changes: - rtpstream_info_calc_t created - rtpstream_info_calculate and rtpstream_info_calc_free functions created - RTP code updated to use such functions Change-Id: I1053a46cbd0cdef9d70382135da46e732b5af8b8 Reviewed-on: https://code.wireshark.org/review/28361 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21lwm2mtlv: Show object name in a generated itemStig Bjørlykke1-0/+8
Change-Id: I38e044abd3fee94be0903131b9847af27b31c516 Reviewed-on: https://code.wireshark.org/review/28365 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-06-21DHCPv4: Fix dissection of packets using HMAC-MD5 authenticationDhiru Kholia1-4/+4
See https://tools.ietf.org/html/rfc3118#section-5.2 (Authentication for DHCP Messages) for more details. Sample DHCPv4 authentication .pcap file can be found at, https://wiki.wireshark.org/SampleCaptures Without this patch, Wireshark shows "Expert Info (Error/Protocol): length isn't >= 31" error message in the Authentication section of the packet dissection. Change-Id: I2af5c7d18f0497a131b1d2dc50ee6e4708c34e28 Signed-off-by: Dhiru Kholia <dhiru.kholia@gmail.com> Reviewed-on: https://code.wireshark.org/review/28360 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21Add dissector for Exablaze timestamping trailersKa-Shu Wong3-0/+208
Change-Id: I2953b7441b5f55f653e93e066f1c23fdcb5be7c5 Reviewed-on: https://code.wireshark.org/review/28265 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21Fix in CRC checker for FPPErika Szelleova1-23/+35
fix in the computation of CRC + little change in the dissector - now it shows the fields SMD and FRAG_COUNT in the tree correctly Bug: 14610 Change-Id: I74982ff836f02803843f6b44a0955a4b20f48e43 Reviewed-on: https://code.wireshark.org/review/28286 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21DHCPv6: Improve dissection of packets using HMAC-MD5 authenticationDhiru Kholia1-2/+21
See https://tools.ietf.org/html/rfc3315#section-21.4.1 (Use of the Authentication Option in the Delayed Authentication Protocol) for more details. Sample DHCPv6 authentication .pcap files can be found at, https://github.com/kholia/my-pcaps Change-Id: Ife252c4e3c114c865324df26313c6b7d57988e5a Signed-off-by: Dhiru Kholia <dhiru.kholia@gmail.com> Reviewed-on: https://code.wireshark.org/review/28334 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21OpcUa: fix in function getExtensionObjectTypeErika Szelleova1-1/+1
The function getExtensionObjectType was not reading the corrects bytes, this sometimes ended in reading outside the buffer and that way exception was raised even for correct packets. Bug: 14465 Change-Id: I5d7d9ca5f43f0afbc93f40487a78709c52f0658a Reviewed-on: https://code.wireshark.org/review/28328 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21Fix build paths for cmake's Xcode project generator on macOS.David Kreitschmann8-48/+116
Multi-configuration generators (such as Xcode or VS) append the current build configuration to most paths (eg. Debug/Release). Currently this results in inconsistent paths for the application bundle and the included command line tools. This commit sets the correct path information for multi-configuration generators for macOS application bundles. The standard Makefile behaviour is untouched. One Windows specific configuration was changed, as it was conflicting with these changes. This needs to be checked before merging. Additionally the wrapper scripts are omitted for Xcode, as the path to the binaries depends on the configuration chosen in Xcode. Therefore it is not viable to create these scripts in the cmake run. Bug: 11816 Change-Id: Ib43d82eb04600a0e2f2b020afb44b579ffc7a7c9 Reviewed-on: https://code.wireshark.org/review/28291 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21CMake+macOS: Make sure we're using the right Qt tools.Gerald Combs2-36/+42
Qt5CoreConfigExtras.cmake sets Qt5::qmake. Use it to find the corresponding path to macdeployqt and use those in osx-app.sh. Change-Id: I2e67f0126e272fc95d40476b9bfc83ab38d73cee Reviewed-on: https://code.wireshark.org/review/28359 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21NR RRC: upgrade dissector to v15.2.0Pascal Quantin6-7840/+7376
Change-Id: Ie7509984d17bf761e96a1d0d079720e91a6a75cf Reviewed-on: https://code.wireshark.org/review/28355 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21WSUG: Document the use of CMake when building on UnixJaap Keuter1-19/+24
Change-Id: Ie1781144856ed544736f092abcafa7c08f74c4b0 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/28347 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21Test: Add sharkd tests.Gerald Combs4-2/+76
Change-Id: I0e5049700ab9285196ce6b4567bd2d034529e763 Reviewed-on: https://code.wireshark.org/review/28327 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-20HTTP: fix in desegmentation of HEAD requests and responsesErika Szelleova1-1/+1
Previously HTTP message bodies following a HEAD request in the same conversation were not desegmented, resulting in spurious "Continuation" messages and failure to reassemble HTTP bodies. Fix this by properly taking the current HTTP message type (request or response) into account. Bug: 14793 Change-Id: I1ffb052468cf414b73243447138466aca47db3e6 Reviewed-on: https://code.wireshark.org/review/28312 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-06-20travis: remove unnecessary qt5 in PATH for macOSPeter Wu1-1/+0
Since v2.5.0rc0-1101-ged15895221 ("cmake: look for Qt5 from Homebrew on macOS"), qt5 no longer needs to be in the PATH. Change-Id: I1edadcb0eec8a38c4f7364353e57f92c80ca400f Reviewed-on: https://code.wireshark.org/review/28352 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-06-20Check the address type, not the address length, in multicast/broadcast tests.Guy Harris1-3/+3
The tests assume an IPv4 address; check for IPv4 addresses. They're always 4 octets long, so no need to check the length. Change the XXX comment to ask whether the check for an IPv4 address is even necessary. Change-Id: Ic55d2c208d5472ec995aa0c150b09a2118f04a76 Reviewed-on: https://code.wireshark.org/review/28353 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-20MAC NR: upgrade dissector to v15.2.0Pascal Quantin1-41/+650
Change-Id: Id7e7bf6b06f029d162666928a39362e685a8b747 Reviewed-on: https://code.wireshark.org/review/28350 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-20lwm2mtlv: Add Object name tablesStig Bjørlykke1-0/+107
Change-Id: I719194743dad0af12ba2e7c722eeddc3ca46b318 Reviewed-on: https://code.wireshark.org/review/28349 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-06-20RTP: Code cleanup 2Jiri Novak2-15/+1
Removed unused items. Change-Id: Ic83d7bfae12424f11e3fc2a9a678c28a0ff6b72e Reviewed-on: https://code.wireshark.org/review/28345 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-20PDCP NR: upgrade SDAP dissection to v15.0.0Pascal Quantin1-26/+33
Change-Id: I590ff86fd0964715ece691adbb7f475ff6662d81 Reviewed-on: https://code.wireshark.org/review/28348 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 22:25:28 +0000