aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-01-13[Automatic update for 2019-01-13]Gerald Combs16-426/+502
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ic7f6b5dd91ca6404909b941c0b4844cb17ef4820 Reviewed-on: https://code.wireshark.org/review/31522 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-13CMake: Don't go on about "custom files"João Valverde1-3/+1
For each call of add_custom_cmake_include() CMake prints STATUS "No custom file found in <full_path>". This is noisy, not to mention confusing. Print output only if a custom include is found, be silent otherwise. Change-Id: If603d206486354993ebac8e4c61f6876a26223d3 Reviewed-on: https://code.wireshark.org/review/31517 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-13tools/gitlab-ci: add missing packages for rpm builds.Dario Lombardo2-0/+4
Change-Id: I04e3414ff27e18db8c83581116f4099bbb696a08 Reviewed-on: https://code.wireshark.org/review/31516 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-13proto: ensure valid width through assert.Dario Lombardo1-1/+4
Found by scan-build. Change-Id: I467e56bfa4f20f5c87efa47823d54691503de318 Reviewed-on: https://code.wireshark.org/review/31486 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-13proto.h: fix indentation and add modeline.Dario Lombardo1-347/+353
Change-Id: I1d1adb6456c4a80f2a157cb29dc19c63755ee3fd Reviewed-on: https://code.wireshark.org/review/31485 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-12gitlab-ci: upgrade before anything else in fedora28.Dario Lombardo1-1/+2
Fix a bug in linking: /usr/lib/gcc/x86_64-redhat-linux/8/../../../../lib64/libgnutls.so: undefined reference to `nettle_rsa_sec_decrypt@HOGWEED_4' Change-Id: Icc85813bd72274e448667bab4a80037ec5bdd48d Reviewed-on: https://code.wireshark.org/review/31519 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-01-12ftype: rework val_from_unparsed to avoid double free.Dario Lombardo1-6/+6
Found by scan-build. Change-Id: I07e8bf2099e08f3f544dd846572717044aa95f7c Reviewed-on: https://code.wireshark.org/review/31487 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-12travis: initial Windows support with non-interactive Qt installerPeter Wu2-3/+152
The current preview release of Windows support on Travis lacks many packages (like Qt and Python 3) and is very much tied to git-bash (unlike AppVeyor which has a more native Windows experience). Several workarounds were necessary, such as reimplementing refreshenv, setting CMAKE_PROGRAM_PATH) and setting a supported language. See also https://travis-ci.community/t/feedback-from-windows-integration-for-a-cmake-qt-c-python-perl-project/1706 I wrote the Qt installer script originally for Qt 5.6, ported it to Qt 5.9.5 and finally updated it for 5.12, some comments could be outdated. Duration as measured for one x64 build: - 3m00s - restore cache (Qt and wireshark-libs) - 2m22s - choco install - 0m8s - pip install - 2m20s - cmake - 18m5s - build all - 0m20s - build test-programs - 5m34s - pytest -v - 2m46s - store cache (Qt and wireshark-libs) - (total duration about 36m) - (installing Qt 5.12.0 from scratch would add 7m) Cache size for extracted x64 build: wireshark-libs is 187M, Qt 604M. (179M and 516M for 32-bit respectively.) Change-Id: I9881ab6439e9ca99efad16a6c861862ab9d35252 Reviewed-on: https://code.wireshark.org/review/31454 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-12wiretap: remove dependency on version_infoPeter Wu2-4/+3
Avoid including the precise version string in the pcapng file that is created for 3GPP TS 32.423 formats. This avoids unnecessarily relinking of applications depending on wiretap. Change-Id: Ida1f3c0c998d811cbf85734bd83438bcbfc39cf4 Reviewed-on: https://code.wireshark.org/review/31513 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-12Fix copy-and-pasteo.Guy Harris1-2/+2
Change-Id: Ib31602f79203a6bd3313b55ea9d83cf56933c171 Reviewed-on: https://code.wireshark.org/review/31514 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-12CMake: change static qtui library into an object libraryPeter Wu2-5/+3
Save 800ms and avoids a synchronization point (improves build parallelism) by directly adding object files to the wireshark binary. Change-Id: I7d1484c65a26f3f6874474b61d38ba474aba8347 Reviewed-on: https://code.wireshark.org/review/31512 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-12CMake: use object libraries to avoid redundant buildsPeter Wu6-83/+89
Some source files are duplicated via add_executable. Assuming that these are not affected by target-specific preprocessor macros, they can be built only once and shared among executables. In one configuration, this reduces the number of object files by 55 (cli_main.c and version_info.c alone were built 15 times each). Removes the version dependency from each target since the 'version_info' target can now declare this dependency. Remove CLEAN_C_FILES from extcap since it is not used to set -Werror. Due to removing some files from wireshark_FILES (and others), these are no longer part of checkAPIs though. Hopefully that is acceptable. Change-Id: I0a3f1ffb950e70a6176c96d867f694fbc6476f58 Reviewed-on: https://code.wireshark.org/review/31509 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-12CMake: Fix inconsistent find_package() report outputJoão Valverde9-9/+9
Most CMake find modules report the binary found, the modules fixed by this change represent an inconsistent exception. The first REQUIRED_VAR argument to find_package_handle_standard_args() is the one used by CMake to report on the result of find_package(). Compare (master) -- Found SNAPPY: /usr/include to (this change) -- Found SNAPPY: /usr/lib/x86_64-linux-gnu/libsnappy.so This convention of using XXX_LIBRARY matches upstream practice. Change-Id: Iaa0ec644e963430d73722354f6ee2a3694906ba7 Reviewed-on: https://code.wireshark.org/review/31498 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-12CMake: Remove legacy workaround for GTK+ZlibJoão Valverde1-5/+0
Right now only the GTK+ 2.24.23 and GnuTLS 3.4.11 packages in trunk contain include/zconf.h, these are used by master-2.6 but not current master. Change-Id: If4e0407c83432fa0780e0ac8a2e15b92dbca8f17 Reviewed-on: https://code.wireshark.org/review/31505 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com>
2019-01-12Use sentence case for the title, as we do for other documents.Guy Harris1-1/+1
Change-Id: I72b1676bdc2af41031535e75189c0c15fdf7e551 Reviewed-on: https://code.wireshark.org/review/31506 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-11Fix up the lists of binaries and man pages in dpkgs.Guy Harris2-13/+18
Sort both lists; for the man pages, sort the extcap man pages after the regular command-line tool man pages. Add the captype and randpkt programs and man pages, and the udpdump man page. Change-Id: I0244013f8d08685d61ba70274185cb5539ff0545 Reviewed-on: https://code.wireshark.org/review/31503 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-11Add captype and reordercap to the list of command-line binaries.Guy Harris1-0/+2
Change-Id: I7e9460960b83d673727aca1783c03952622aabb5 Reviewed-on: https://code.wireshark.org/review/31500 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-11Add randpkt to the Windows installers.Guy Harris3-0/+27
Bug: 15395 Change-Id: Ic0c28b42a5e70edc5eb6441f71b6b614deae9d9f Reviewed-on: https://code.wireshark.org/review/31497 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-11Include the reordercap and dftest documentation in Windows packages.Guy Harris2-0/+10
We package the documentation for other programs we supply, so we should package the documentation for them as well. Change-Id: I37854631bad4aa799fb6ebb009bea3f4692fe530 Reviewed-on: https://code.wireshark.org/review/31492 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-11Unit tests for ASTERIX I048Atli Guðmundsson1-0/+1707
Change-Id: I0138681650dcabb01e08f3d25817b5fdd30f45e8 Reviewed-on: https://code.wireshark.org/review/31380 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-11quic: fix compilation without libgcrypt aead.Dario Lombardo1-2/+10
When that version isn't available, we still need to have this function available. Make it always available, then, with empty implementation. Change-Id: Ia827922c181676bbb2ba4a02dc09290b8cdb1a5c Reviewed-on: https://code.wireshark.org/review/31491 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-11mas5gs: Add dissection of IE 9.11.3.10 ABBAAnders Broman2-132/+193
Change-Id: Id1d0641bfbee94a62a6b7296dd7cc02680bdd5a6 Reviewed-on: https://code.wireshark.org/review/31490 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-11F1AP: upgrade dissector to v15.4.0Pascal Quantin9-542/+2065
Change-Id: I568a5f27c8be6b172856d908da6aa4f2782136d9 Reviewed-on: https://code.wireshark.org/review/31489 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-11nettrace: Fix missing tag length for IPV4_DST.Anders Broman1-7/+14
Change-Id: I00564adaef2922ff991887f0ee5c04a3c7307019 Reviewed-on: https://code.wireshark.org/review/31488 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-11XnAP: upgrade dissector to v15.2.0Pascal Quantin26-2375/+3409
Change-Id: Ie26f8918aff20ade21eda611950795a320a417f2 Reviewed-on: https://code.wireshark.org/review/31483 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-11dissectors: remove unused assignments.Dario Lombardo5-7/+0
Found by clang-scan. Change-Id: I46d3be9032c8d34a76ecd844287c36aff733ea2d Reviewed-on: https://code.wireshark.org/review/31482 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-01-11QUIC: initial support for new header protection cipher (draft -17)Peter Wu1-110/+105
The old packet number encryption method was replaced by a new header protection mechanism which also encrypts some bits of the first byte. Patch the old code to support this byte. Future patch should clean up this messy code, but at least (Initial) packet decryption works now. Bug: 13881 Change-Id: Ia0f40614c1084ba6f7fc597b8f6dc85845ea1fbd Reviewed-on: https://code.wireshark.org/review/31480 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-11MPLS Echo: Additional downstream mappings RFC8287Uli Heilmeier1-1/+2
Add additonal protocols as defined in RFC8287 section 6 Bug: 15410 Change-Id: I2254cda6031c85d103b85f47604265d80a54f436 Reviewed-on: https://code.wireshark.org/review/31478 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-10QUIC: update flag on long packet headers (draft-17)Alexis La Goutte1-7/+7
Bug: 13881 Change-Id: I3e92ec8cba3482ab9d13f1102425a7b9ec7ccd76 Reviewed-on: https://code.wireshark.org/review/31407 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-10dfilter: remove size() function.Dario Lombardo1-58/+3
It is overlapping to len(), then they've been merged into len() that now gives the length of any field. Change-Id: I8e39536a4d15eff4c4b44bb39fd965729cc46951 Reviewed-on: https://code.wireshark.org/review/31462 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-01-10CMake: try harder to find the right Python versionPeter Wu3-6/+17
The FindPythonInterp module does not verify that a discovered 'python' program is actually Python 3. Replace this deprecated module by a modern version that was introduced with CMake 3.12. Remove PYTHON_EXECUTABLE from WSDG now that it is much more likely that CMake discovers the right version. Change-Id: I1f8438baced3d5bf9e1e2732980ad177d3257ca3 Reviewed-on: https://code.wireshark.org/review/31468 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-10Move make-version.pl to tools.Gerald Combs8-37/+38
Move make-version.pl to the tools directory. Change-Id: I7c3ec8951a682d45d650e3fdb1580d90bf19e8b4 Reviewed-on: https://code.wireshark.org/review/31473 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-10WSDG: Move README.packaging to the Developer's Guide.Gerald Combs2-109/+129
Move doc/README.packaging to the Developer's Guide and update the content. Change-Id: I25fda6cade8f3cfd11af865745bedd0fb5a7c86f Reviewed-on: https://code.wireshark.org/review/31474 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-10debian: Fixup symbols.Gerald Combs1-4/+4
Change-Id: I544220cdcc43b20b4f6b663e28039804cd6d3619 Reviewed-on: https://code.wireshark.org/review/31475 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-09Clarify the name and description for a link-layer encapsulation type.Guy Harris10-256/+257
What we were calling the "name" is actually a description to show to users; what were calling the "short name" is just the name to use on the command line. Rename some routines and structure members, and put the name first and description second in the table. Expand some descriptions to give more details (e.g., to be more than just a capitalized version of the name). Fix the CamelCase capitalization of InfiniBand. Change-Id: I060b8bd86573880efd0fab044401b449469563eb Reviewed-on: https://code.wireshark.org/review/31472 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-09E1AP: upgrade dissector to v15.2.0Pascal Quantin9-468/+1248
Change-Id: Ieafe6558e54a04ce7004c4005f646cea88ac9e5d Reviewed-on: https://code.wireshark.org/review/31469 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-09NGAP: use extended value_string for CauseRadioNetworkPascal Quantin2-119/+122
Change-Id: Ie32c8c63e26a31c1fd76cf8f1e7d6ef9103c5960 Reviewed-on: https://code.wireshark.org/review/31470 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-09NGAP: upgrade dissector to v15.2.0Pascal Quantin9-436/+1700
Change-Id: Id050878d8d18fda321304ce5dd2d7842e66cfa93 Reviewed-on: https://code.wireshark.org/review/31463 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-09zbee: zbee_zdp.profile wrong data typeDana Sy1-1/+1
Fixed the data type for zbee_zdp.profile to use the proper data type of UINT16. Change-Id: I20bac57ec3a0a7261aeb65333d9dd4b5bdb4a85c Reviewed-on: https://code.wireshark.org/review/31458 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09rdp: add parsing MONITOR_DEF fields [1]Mariusz Zaborski1-8/+75
[1] https://msdn.microsoft.com/en-us/library/dd342324.aspx Change-Id: I671ebdd5900a0cd409159388e2f72e6e5fbfd6a2 Reviewed-on: https://code.wireshark.org/review/31390 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09dissectors: j1939: Use raw id to filter packetsMaksim Salau1-23/+30
Using raw CAN id allows us to drop error frames and frames with standard ids since J1939 work only with extended ids. Also if allows us to not to decode payload of RTR frames. Change-Id: I06cec52176be79028f9ac5bce2017907c06aacfb Reviewed-on: https://code.wireshark.org/review/31449 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09Add validate-clang-check script for Petri DishAlexis La Goutte1-0/+19
Launch clang-check -analyze for each file... Change-Id: Ic4132d563ccaa5d375f27d08366ba6fc052f095c Reviewed-on: https://code.wireshark.org/review/30482 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-01-09dissectors: socketcan: Pass raw ids to dissectorsMaksim Salau2-10/+13
In the current implementation only masked id is provided to subdissectors, which doesn't allow to filter packets effectively. E.g.: J1939 should dissect only extended frames. Without EFF flag, the subdissector is unable to filter out frames with 11-bit ids. Also J1939 tries to dissect pyaload of RTR of ERR frames, which obviously doesn't make sense. The change exports raw id alongside the masked one for backwards compatibility. Once all the CAN dissectors are updated to use the raw variant (if necessary) the masked variant may be dropped. Change-Id: I52df5673ecfd53d2e65790c4187ea129e67a88e9 Reviewed-on: https://code.wireshark.org/review/31448 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09Qt: Cleanup deletion of CopyFromProfileMenuStig Bjørlykke10-35/+19
Set the push button as parent to the profile list menu so it will be deleted when that parent is destroyed. Change-Id: Ide4a234e039a3e27d9ee4732a3800906c80be173 Reviewed-on: https://code.wireshark.org/review/31446 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09valgrind-wireshark: default to looking in run/ for our binaries.Jeff Morriss1-2/+2
If33a39c26714ebe699463d1c8c67469025767efb made this change for the other scripts. Change-Id: I158c1c2d0b564a115443e96a6d90733c2ffff071 Reviewed-on: https://code.wireshark.org/review/31459 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09CMake: remove LocatePythonExecutable.cmake for WindowsPeter Wu2-25/+0
Cygwin is now unsupported, so remove special handling for it and rely on FindPythonInterp.cmake to locate an appropriate version. This patch can only cause issues if the PATH environment variable contains the Cygwin binary directory without any native Python version appearing before that. In that case, either remove Cygwin from PATH or add the native Python (e.g. C:\Python37) earlier in PATH. Change-Id: Ia5554e5a83d06a941dacf4a28d41d84fca4fe99d Reviewed-on: https://code.wireshark.org/review/31453 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09CMake,WSDG: Remove Cygwin supportPeter Wu10-299/+20
Declare Cygwin as unsupported and remove all supporting code. Simplify some Chocolatey notes in the WSDG. Remove FindPerl.cmake as it only existed to force use of Wireshark's bundled FindCygwin.cmake (bug 13922). FindXSLTPROC.cmake special handling for Cygwin was also removed, in theory this could cause issues when the PATH contains a Cygwin xsltproc, but it's unsupported anyway. Change-Id: Iabfac2b4a9fd930530505d27bdba618bdb8f7f34 Reviewed-on: https://code.wireshark.org/review/31452 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-09dissectors: socketcan: Fix indentationMaksim Salau1-5/+5
Change-Id: I4b9023a812e7f24a8980abe871f7fa28f60cefec Reviewed-on: https://code.wireshark.org/review/31447 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-01-08Qt: Fix copy ASCII characters from ByteViewStig Bjørlykke2-7/+8
Only copy ASCII characters when doing "Copy Bytes as Hex + ASCII Dump" from the ByteView. This is what we do in all other Hex Dumps. Also change the parameter name to reflect this. Change-Id: I63cc79ffa014fd9aa50c84d765ee168f0b1ea44a Reviewed-on: https://code.wireshark.org/review/31442 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-08mas5gs: Fix dissection of QoS flow descriptions and QoS rules.Anders Broman1-108/+152
Change-Id: Ie4b9fcf0afdea19ba6f2fb531e84096ac103c99b Reviewed-on: https://code.wireshark.org/review/31443 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-21 04:51:52 +0000