aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-11-04TCP: cleanup Riverbed optionUli Heilmeier1-10/+1
Remove duplicate length field to adjust to the other options. tcp.options.rvbd.probe.len has already reported by tcp.option_len Add missing space between "Transparency" and IP address. Change-Id: I8b4260b34d760b73ee529a687418c4b6adcfaa0e Reviewed-on: https://code.wireshark.org/review/24239 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-04Better instructions on building with Qt on macOS.Eliot Lear1-3/+16
Change-Id: I23bb91970dd7e3f59166310114cca84846d7164d Reviewed-on: https://code.wireshark.org/review/24165 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-11-04oss-fuzzshark: force direct mallocMichael Mann1-0/+3
Set two environment variables (needs to be done before epan_init and before the first g_slice_alloc call) to force direct memory allocation without another layer that could hide bugs. Change-Id: I0d72092c239e2e7f42b0b7849c01471407e785e2 Reviewed-on: https://code.wireshark.org/review/21195 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-04TCP: Fix Riverbed probe option tvb handlingUli Heilmeier1-21/+60
With commit f30b1e3b3bc4cec85296c280cdae88d3d17fae04 TCP options are handled in an own dissector table. Therefore we can't read ahead or behind to get the SYN flag or the CFE flag. Bug: 14150 Change-Id: Ibbf1836104d32216ddfa2d4e07dccbcf948bb26c Reviewed-on: https://code.wireshark.org/review/24181 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Uli Heilmeier <openid@heilmeier.eu> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-04packet-infiniband: SM class does not support ClassPortInfo or InformInfo ↵Hal Rosenstock1-2/+0
attributes Change-Id: I1fbe7a93e8a208a1a4abaf0b64e674536b642733 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24229 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-11-04packet-infiniband: Make unknown GS class attributes show up in wireshark ↵Hal Rosenstock1-0/+6
Info column The following GS classes are now displayed there: BM DEV_MGT SNMP VENDOR APP RESERVED Change-Id: I94822784a7027afa1d5e99ca20467721a98cfe0a Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24234 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-11-04packet-infiniband: Better variable namingHal Rosenstock1-18/+18
Rather than use PERF_header_item for all classes, use acronym for class appended with _header_item Change-Id: I52ac46000c20b7f51c87c8dc4a8dfc85c20f31f3 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24233 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: DETH Queue Key should be hex rather than decimalHal Rosenstock1-1/+1
as it is in other places where there is Q_Key Was: DETH - Datagram Extended Transport Header Queue Key: 2147549184 Now: DETH - Datagram Extended Transport Header Queue Key: 0x0000000080010000 Change-Id: I64d4b485e2a511c30b0e4a2849f529438591a122 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24232 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Make unknown PerfMgt attributes show up as PERF in ↵Hal Rosenstock1-0/+1
wireshark Info column Change-Id: I9f6a60adaa0744d13d6c000d1a4e20f3b526355b Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24231 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Fix commentary typo (for consistency)Hal Rosenstock1-2/+2
Change GuidInforecord -> GuidInfoRecord Also, change VLArbitrationTableRecord comment to be consistent Change-Id: Ia7cc844779a8751bd7675354b71239922327d0e8 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24230 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Add missing SA methods into mad_method_strHal Rosenstock1-0/+7
so they are not indicated as Method: Unknown under MAD Header - Common Management Datagram Change-Id: I8e8fe918eea86e7095967d0b82772a813eafe2a5 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24228 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Fixed some PortInfo:CapabilityMask bit namesHal Rosenstock1-10/+10
to be consistent with IBA volume 1 spec IsOptionalIPDSupported IsCommunicationManagementSupported Change-Id: I55b29b7f291f49a9d0c3e104bda4d7d7aa78b42b Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24227 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Add first and last to RMPP_FlagsHal Rosenstock1-0/+1
RMPP flags 7 indicates that packet is both first and last packet in transfer Change-Id: Idf0e8783372296a7c276c8c0c80e4905afbe6c9a Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24226 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Fix some SM class attribute IDsHal Rosenstock1-4/+4
LinkSpeedWidthPairsTable is 0x001C SMInfo is 0x0020 VendorDiag is 0x0030 LedInfo is 0x0031 Change-Id: I93197590930a97c8538ef69d08213b1076a9f66a Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24225 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Fix SA MCMemberRecord attribute nameHal Rosenstock1-1/+1
rather than MCMembersRecord Change-Id: I96bf3ac45255295cf85b9faf0547df4df26f11c3 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24222 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Use SA rather than SMA as Subnet Administration headerHal Rosenstock1-1/+1
SMA is acronym for Subnet Management Agent not Subnet Administration so change this from SMA to SA Change-Id: I1a293fff5de4796fe337daa133943bfa059cc9ff Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24224 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Removed erroneous MadHeader commentsHal Rosenstock1-50/+26
as it is not parameter in these APIs Also, fixed commentary typo Change-Id: I1ce53b9aae9837688e756b2e665f3b1df74b572c Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24223 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04Add Decode As support for RTP payloadMichael Mann1-8/+54
Change-Id: I568c0e6980d7649f9cd82ac46420e7db70722fc6 Reviewed-on: https://code.wireshark.org/review/24150 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-04Add backslashes to definition of WSUG_TOOLS_HELP_FILES in docbook/Makefile.amThomas Dreibholz1-9/+9
Bug: 14152 Change-Id: If1d89afd5dbf62adae4cd84e3fc44bd37a8a2176 Reviewed-on: https://code.wireshark.org/review/24221 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-04DOCSIS: RNGRSP: formatting of equalization coefficientsBruno Verstuyft1-6/+10
Change-Id: I6745bee84b096a7008d258a39d99370b1fea29a0 Reviewed-on: https://code.wireshark.org/review/24217 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-03Exported PDU: apply EXP_PDU_TAG_COL_PROT_TEXT whatever the next_prot_type tagPascal Quantin1-4/+13
The include file suggests that it will always fill the protocol column if present. Let's make that happen. Change-Id: I265e2f4d1c2dcd7cf2ff121499694cde14a595f3 Reviewed-on: https://code.wireshark.org/review/24220 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-11-03Ensure endpoint members of packet_info structure are initialized in packet.cMichael Mann1-0/+4
Change-Id: I4c7a4f9888c8bdc87ded88fa997aa2aad9530fd7 Reviewed-on: https://code.wireshark.org/review/24218 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-03mqtt: Simplify message decode matchingStig Bjørlykke1-38/+20
Change-Id: I93da46808de8a978d49ad0aa3f78c4a1790e7952 Reviewed-on: https://code.wireshark.org/review/24210 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-02Fix Elasticsearch hex dumpChristoph Wurm1-1/+1
Change-Id: I5b2006a74e95759afce518aaadfe47c54978476a Reviewed-on: https://code.wireshark.org/review/24215 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-02Remove eroneous DoD association by deleting IANA entry.Eliot Lear1-1/+0
Change-Id: Ib623391235c1cbbfadd540d2ae24fdc36c2b0b96 Reviewed-on: https://code.wireshark.org/review/24214 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-02Do not register proto_reg_handoff_XXX callback when not requiredPascal Quantin2-2/+2
None of those protocols need to be notified of a preference change and their proto_reg_handoff_XXX functions do not differentiate the initial call from susequent ones, leading to an assert Bug: 14157 Change-Id: Iac4d88ebef7688bced8daae857eb5c836a6babd6 Reviewed-on: https://code.wireshark.org/review/24211 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-02ZigBee ZCL Sub-Ghz Cluster dissectorIvan Ermakov4-0/+260
Added Sub-Ghz cluster dissector. Change-Id: I6d189400298def693969004b6fc2942fd8b70ba0 Reviewed-on: https://code.wireshark.org/review/24199 Reviewed-by: Martin Boye Petersen <mbpflonidan@gmail.com> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-01[GTPv2] Add dissection of 8.127 Header Compression Configuration.Anders1-4/+106
Change-Id: Iace27ebf536cad73d9aaf4abceb6d235f34d68f6 Reviewed-on: https://code.wireshark.org/review/24208 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-01ZigBee ZCL Keep-Alive Cluster DissectorIvan Ermakov4-0/+156
Added Keep-Alive Cluster dissector. Change-Id: I5a2c24a4f13171b26efc860470b4d9c42f54ef89 Reviewed-on: https://code.wireshark.org/review/24198 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-11-01ZigBee ZCL MDU Pariring Cluster dissectorIvan Ermakov2-0/+317
Added dissectors for commands and payloads of MDU Pairing cluster. Change-Id: I842ddf50f91d0ecc46605325048971d1eeba6df6 Reviewed-on: https://code.wireshark.org/review/24200 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-11-01FTP: links between setup and command framesMartin Mathieson1-31/+78
Change-Id: I8a231f8616952ed119b85126d6d25af7512e6cd8 Reviewed-on: https://code.wireshark.org/review/24194 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-01Add ability to create endpoints through conversationsMichael Mann8-25/+67
Add endpoint information to the packet_info structure for dissectors to potentially use as their data to create conversations. This patch includes a simple "example" of using conversation_create_endpoint with TDMoP. The assignment of the PT_TDMOP "port type" has been replaced by setting ENDPOINT_TDMOP within the endpoint structure. Then when subdissectors of TDMoP call find_or_create_conversation(), it implicitly picks up the conversation information set by TDMoP Change-Id: I11dc29989cccd3b0f0349ee901babb455ca02d19 Reviewed-on: https://code.wireshark.org/review/24190 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Andrew Chernyh <andrew.chernyh@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-01configure: Fix pcap-config --cflags command substitutionJoão Valverde1-1/+1
Change-Id: I654dd34d229b4cd69b5e3a0c77d8958d12bceead Reviewed-on: https://code.wireshark.org/review/24207 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-10-31DOCSIS: add burst descriptor types. Fixed some bugs.Bruno Verstuyft1-18/+22
Change-Id: I9f7df2f62197c574087dbcce2c7b0ba7e6c8c56b Reviewed-on: https://code.wireshark.org/review/24197 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-31mqtt: Add message decodingStig Bjørlykke1-1/+201
Add support for configuring message decoding based on topic. Matching criteria is equal-to, contains, starts-with, ends-with or regular expression. Change-Id: I677d869716eb1d2798974e2c65605a454421a66c Reviewed-on: https://code.wireshark.org/review/24196 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-10-31s7comm: Several minor improvementsThomas Wiens1-85/+170
This patch includes several minor improvements: - Special (only for Sinumerik NC): allow NCK address description in data-part - Userdata parameter part: add text definition for second req/res - Don't add data tree in userdata telegrams, when there is no data in there - Cyclic functions: add new subfunction - Alarming: add SCAN message decoding - Improve info column display when there are multiple PDUs in one frame Change-Id: Ib9afd0c6b14cf97ed645084e095f79fb40b07f43 Reviewed-on: https://code.wireshark.org/review/24170 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-31HTTP: Update status codesUli Heilmeier2-0/+24
Updated status codes to include "103, Early Hints". s. https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml Change-Id: Ic00285c0ffafeb689bbc30533fcbdeb688528c62 Reviewed-on: https://code.wireshark.org/review/24203 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-31Qt: ByteViewTab Fix tabs creationRoland Knall1-0/+2
Fix creation of tabs Change-Id: I11b22a3964f7c25c0c88b8ecd4eec1ad480fe800 Reviewed-on: https://code.wireshark.org/review/24202 Reviewed-by: Roland Knall <rknall@gmail.com>
2017-10-31ByteViewText: Remove epan dependancyRoland Knall10-344/+393
Remove all dependancy for the byte_view_text from the epan system, and therefore cleanly separate data and display for further separation of dissection and view Change-Id: Id1ee91b93da4511afa95f24da4cbbf39cbb89b1f Reviewed-on: https://code.wireshark.org/review/24050 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-10-31conversation_table(.h): fix parameter 'ptype/port_type_val' not found in the ↵Alexis La Goutte1-3/+3
function declaration [-Wdocumentation] Change-Id: Iea18cc73d28af68e14f7b9516b630b0987fe5731 Reviewed-on: https://code.wireshark.org/review/24195 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-31Deduplicate Elasticsearch outputChristoph Wurm1-24/+56
Collects multiple values of the same field into an array. Empty protocols are now written as empty objects to not conflict with the same protocols in other packets. Remove _score since it has no effect. Bug: 12958 Change-Id: Ibe8ea9bc1e3e63dea1fe4eaf522fa38cad88a17f Reviewed-on: https://code.wireshark.org/review/24171 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-31.mailmap: update (of October)Alexis La Goutte2-4/+4
Change-Id: I3b8d693c288edd61ec1bd9e9161919ac3ab35f52 Reviewed-on: https://code.wireshark.org/review/23850 Reviewed-by: Florian Fainelli Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-31Fix segfault in Elasticsearch outputChristoph Wurm1-15/+19
When using the Elasticsearch output but only printing the packet summary with -P a segfault will occur because the empty packet tree is not properly handled in this case. Change-Id: I0c91314ae013785ae6dceabd6af33db4b836d1b2 Reviewed-on: https://code.wireshark.org/review/24153 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-31Remove unused netdb.h #includesJoão Valverde3-12/+0
Change-Id: Ia46903586219ee79210a980a04024af02acb0db0 Reviewed-on: https://code.wireshark.org/review/24189 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-31[BSSMAP-LE] Correct dissection of 10.20 Positioning Data.Anders1-6/+62
Change-Id: Ia0c3b688dfdcd9fdad4f65df12ef97db99bdb095 Reviewed-on: https://code.wireshark.org/review/24192 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-30[BSSGP] Add PEIAnders1-1/+15
Change-Id: I64d1924aba3c11fa72fbb12121bd09bcf21d598d Reviewed-on: https://code.wireshark.org/review/24193 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-30[BSSGP] Fix IE numbering in PERFORM-LOCATION messages.Anders1-4/+4
Change-Id: If767d905177b8d78f6b5d3c4e7b8d32a9e8a596a Reviewed-on: https://code.wireshark.org/review/24191 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-30Avoid asserting with EAFNOSUPPORTJoão Valverde1-9/+34
We require support for AF_INET/AF_INET6 to run and assume this is available on all supported platforms. If and when reality clashes with that assumption just avoid aborting. Errors are to be expected as long as they don't produce a crash. Change-Id: I5c107b1a8fd64441eb96f48381412e180b66feb7 Reviewed-on: https://code.wireshark.org/review/24187 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-10-30tshark doc updatesGraham Bloice1-0/+5
After other changes, add info about -G help and update output from -G dissector-tables. Change-Id: I339d5c31a606720ef92e641e59ec5a45114321a8 Reviewed-on: https://code.wireshark.org/review/24188 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2017-10-30FT_IPv4 fields' values are 4-byte integers, not structures with a pointer.Guy Harris1-2/+1
Fix a tpyo while we're at it. Change-Id: I1bde763ec2bd188c0f8afd1069db5a9f23963e8e Reviewed-on: https://code.wireshark.org/review/24186 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 03:15:33 +0000