aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-06-13use #include <file.h> for generated include filesMartin Kaiser3-3/+3
the same mechanism as described in 7c40de5c38ac71323455c51dcc14a5eb385ce718 could trick us into using the wrong config.h fix this for some occassions where config.h is included before we include zlib.h I saw compile errors on windows where we picked up config.h from a linux build and zlib failed because of a mission unistd.h Change-Id: I91cf73b96c9e1b6f009fb2376fabfe973d1ac941 Reviewed-on: https://code.wireshark.org/review/15874 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13qt: use #include <file.h> for generated include filesMartin Kaiser16-16/+16
make sure that generated include files are picked up only from the directories set by -I (or /I), not from the current directory if we use #include "file.h", Visual Studio searches for file.h in the same diretory as the source file that includes file.h if we do an out-of-tree build with cmake and the source directory contains files from an in-tree build (done with autotools), we might end up including the wrong file Change-Id: Iaaed2626258b6ff0c12485fe3f436bd03bbb5adf Reviewed-on: https://code.wireshark.org/review/15873 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13IPv6: Add text marker for SRH next segmentJoão Valverde1-1/+10
Change-Id: If13ffe4ddb9ae08e738ccf0c715dc12ce7a076e8 Reviewed-on: https://code.wireshark.org/review/15834 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13sip: remove some unnecessary if (tree) checksMartin Kaiser1-15/+9
which shouldn't have any impact on performance we should not remove the chcks around blocks where vb_format_text() is called Change-Id: Idc191cc70e7458225bbc5dfececb3c88c83ab5f1 Reviewed-on: https://code.wireshark.org/review/15879 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13Move inclusion of CmakeListsCustom to the end of the file in order to haveAndersBroman1-1/+2
all defines in place. Change-Id: I190257e9b833c409921bbca74c8ab531b632c60d Reviewed-on: https://code.wireshark.org/review/15878 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13isns: fix dead codeMartin Kaiser1-9/+9
do the special handling for len==0 and tag==ISNS_ATTR_TAG_PORTAL_GROUP_TAG before going into the different attributes Bug: 12503 Change-Id: I4dd6dcea25aba2e4963811a7a85f1eed1b906bcd Reviewed-on: https://code.wireshark.org/review/15875 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13tvbparse: change g_strdup_printf to wmem_strdup_printf.Dario Lombardo1-2/+2
Change-Id: I57ff604d23967eb1f6481c7019e3eab0389dc3a5 Reviewed-on: https://code.wireshark.org/review/15257 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-06-13Qt: Fix a Windows version check.Gerald Combs1-1/+1
Fetch the version using QSysInfo::windowsVersion. Ping-Bug: 12010 Change-Id: If63c576ec4f56f34b76f320cdd927bee427c8cb7 Reviewed-on: https://code.wireshark.org/review/15876 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-13Qt: Main window tab behavior.Gerald Combs4-1/+23
Make the main window tab order more closely match the GTK+ UI. Draw a focus rect in the byte view text while we're here. Change-Id: I04212c14ea7f0d6865b709533246760adc02f45a Reviewed-on: https://code.wireshark.org/review/15862 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-13Cisco Diameter: move the XML declaration to the top of the file.Jeff Morriss1-1/+2
... That's where it's supposed to be. Change-Id: I0ec68dc8757776bf757b52e75bc156acc7264ee5 Reviewed-on: https://code.wireshark.org/review/15877 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-06-13Diameter (NSN): the attribute name is 'mandatory' not 'mandatory-flag'.Jeff Morriss1-10/+10
Change-Id: Ifa19b59e23278abf332d8ab06dd5ad2059f3e679 Reviewed-on: https://code.wireshark.org/review/15872 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-06-13Diameter: close command elements.Jeff Morriss1-4/+4
... in order to make the XML (more) valid. Change-Id: Iefffff3208c98d6ea55d509ed35b57abd268baf3 Reviewed-on: https://code.wireshark.org/review/15871 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-06-13Convert AT_SS7PC to a "dissector address type"Michael Mann17-101/+149
The formatting of the address type is determined by a preference in packet-mtp3.c, so just make MTP3 register the address type. Use address_type_get_by_name in other dissectors (and export_pdu) to use the address type. Change-Id: Ifb32d7de27aeaa23cee8e803e25ffb3c905547b5 Reviewed-on: https://code.wireshark.org/review/15856 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13Use getc_unlocked in a few places.Gerald Combs5-15/+17
Use getc_unlocked or _fgetc_nolock instead of getc in a few places. This reduces startup time by about 100ms here. Change-Id: I59ceb09678457c871cce79fcc3ce71998fe4f5af Reviewed-on: https://code.wireshark.org/review/14518 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13GSM RLC/MAC: add dissection of EC-GSM-IoT control messagesAnton Thomasson2-36/+1306
Change-Id: Ib7096039aa9761fda96ed8552899833597ba70a6 Reviewed-on: https://code.wireshark.org/review/15812 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-13GSM RR: add dissection of EC-GSM-IoT ccch control messagesAnton Thomasson2-9/+909
Change-Id: Ib40f78a0d1822bf216af0911f9672c750a78b265 Reviewed-on: https://code.wireshark.org/review/15813 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-13Diameter: free the diameter directory variable.Jeff Morriss1-1/+2
It's only needed for a few milliseconds--there's no need for it to stick around until the epan scope ends. As discussed on I51813815babb4c40722c38459139ab9e3e3ccb42. Change-Id: I81fef351ef2d700cc5ec5866340605704173fbdb Reviewed-on: https://code.wireshark.org/review/15861 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-13Qt: Make the capture filter read-only only in main welcome.Gerald Combs2-3/+6
As noted in gb7897dd, CaptureFilterCombo needs to be read-only until the app is initialized. Move the code to do so to MainWelcome, otherwise the capture filter entry in CaptureInterfacesDialog starts out read-only and stays that way. Disable / enable the entire CaptureFilterCombo instead of setting its lineEdit read-only status, which provides a stronger visual indicator. Change-Id: Ic7bf5b5631b861ecf4dc8cca67beb5bf4ed27510 Reviewed-on: https://code.wireshark.org/review/15859 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13Qt: Add the Info column contents to Expert Info.Gerald Combs1-9/+20
When "group by summary" is enabled, packet items contain a packet number followed by a lot of empty space. Fill it with the contents of the Info column. Set the first column title to "Severity" or "Packet" depending on the item selection. Change-Id: Iff96ab2ec631300ec8f08e55019e191e88cff84a Reviewed-on: https://code.wireshark.org/review/15814 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13Indent register.c and other cosmetic changesJoão Valverde1-13/+31
Change-Id: I06e863e0b87118047f4c3b7618df02b9c7384a34 Reviewed-on: https://code.wireshark.org/review/15836 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13Added Diameter 3GPP decoding of AVP 1404 - QoS-SubscribedBinh Trinh1-0/+626
(removed spaces) (removed C++ style comments) Change-Id: I0f6c7586486b48eab8659a048be451ce3fe1c72b Reviewed-on: https://code.wireshark.org/review/15850 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-13Qt: Multi line import from hex dump without offsetsStig Bjørlykke1-0/+6
Fix importing hex dump without offsets with multiple lines. Change-Id: I7a7339e375b3125688f5b5d29f493704c7b9944a Reviewed-on: https://code.wireshark.org/review/15868 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-06-13RADIUS: Add Sangoma dictionaryAlexis La Goutte4-0/+115
From FreeRADIUS master commit ba4b4402588ae87497a0b7c87e26eb5cb433c8a7 Author: Alan T. DeKok <aland@freeradius.org> Date: Fri Jun 10 14:38:55 2016 -0400 Added dictionary.sangoma from http://wiki.sangoma.com/files/NSC-Radius-Support/dictionary.sangoma.txt Change-Id: Ie51ea6343a2a8a5b286d70451abce81ca920261f Reviewed-on: https://code.wireshark.org/review/15823 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-13Add address_type_get_by_nameMichael Mann4-1/+20
This allows the decoupling of a dissector registering an address type so it doesn't need to export the returned registered type. Change-Id: I49c913d042e70bd4b7ea1e964ba9511bb27304f5 Reviewed-on: https://code.wireshark.org/review/15855 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-13Completely remove dissector_add_handle.Michael Mann3-8/+5
It has been deprecated and replaced with dissector_add_for_decode_as. Change-Id: I5a4976f83951f749e70b5267570fca188daa7a07 Reviewed-on: https://code.wireshark.org/review/15854 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-13USB: fix dissection of URB setup when the payload was claimed by a sub dissectorPascal Quantin1-2/+2
Bug: 12511 Change-Id: Ic9af8358e2a8110f53c587201cafc337630c302a Reviewed-on: https://code.wireshark.org/review/15858 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-13USB HID: add dissector to USB Device 'Decode As' listPascal Quantin1-0/+2
Ping-Bug: 12511 Change-Id: I6193e3bb084adf9925bb6800a756804164030630 Reviewed-on: https://code.wireshark.org/review/15857 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-13Rename a variableJoão Valverde1-10/+10
Change-Id: Ie5d859e166fbc8073be88cbbd96bffa877e6b654 Reviewed-on: https://code.wireshark.org/review/15865 Reviewed-by: João Valverde <j@v6e.pt>
2016-06-13Finish moving the parenthesis.Guy Harris1-1/+1
Change-Id: I02f099ef198e360663b03857bdf9538bb63a7de8 Reviewed-on: https://code.wireshark.org/review/15864 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-13Fix a compile error.Guy Harris1-1/+1
(Perhaps the Petri dish buildbots should, if a build fails, immediately mark the change as failing the Petri dish build, without waiting for the other build(s), so that you don't have to, for example, wait for the Ubuntu buildbot to finish doing a test build for a change that doesn't affect code built on UN*X.) Change-Id: I89ee1616d35c186fcabc0ec989936fa94116df70 Reviewed-on: https://code.wireshark.org/review/15863 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-13Don't assume we can get a module handle for kernel32.dll.Guy Harris1-1/+10
A failure "shouldn't happen", but check anyway; if nothing else, that squelches some complaining from the VS Code Analysis tool. Change-Id: I9b06db399741176d0e9f859eb650bed8a2f96d9c Reviewed-on: https://code.wireshark.org/review/15860 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-12Qt: Add import from hex dump without offsetsStig Bjørlykke4-1/+41
Added support for importing from hex dump without offsets. This will create one packet with all hex values found in the file. Change-Id: I0414441721078befeb59aa6a87b9412646cfcf5c Reviewed-on: https://code.wireshark.org/review/15743 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-12Fix typo in dissector docLéo Gaspard1-1/+1
Change-Id: I5ca20080f99905ab23d484d0be054a89c406c583 Reviewed-on: https://code.wireshark.org/review/15852 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-12expert_info_dialog (Qt): fix Uninitialized members (UNINIT_CTOR) reported by ↵Alexis La Goutte1-0/+1
Coverity (CID 1362692) Change-Id: I1bc71ac7b9c08a9a5749aa9bc88863fa10eb27c7 Reviewed-on: https://code.wireshark.org/review/15848 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-06-12IPv6: Add dissection for SRH flagsJoão Valverde1-5/+51
Change-Id: I535aba36cc906e8d78cb594900e9a7fdcbd26c83 Reviewed-on: https://code.wireshark.org/review/15828 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-06-12IPv6: Add support for Segment Routing (Type 4) Extension HeaderThibault Gerondal1-1/+98
Bug: 12512 Change-Id: I5672ff3b8c4e8afcc82e957933330e0bf9454b08 Reviewed-on: https://code.wireshark.org/review/15593 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-06-12CMake: Make PROJECT_VERSION_EXTENSION code simplerJoão Valverde2-13/+6
The intent was to allow all sorts of overrides but, ugly. I don't think we need $cmake_package_string either, at least with these changes. Follow-up to 7c6e859ccf210a45e1cc0f6da17692845e6b5a23. (And bdec712166ba924a2cdeaaca8ae580c343eaf02c). Change-Id: I808b6bd3a3c64d2a67165344e8fe23e8314c27db Reviewed-on: https://code.wireshark.org/review/15835 Reviewed-by: João Valverde <j@v6e.pt>
2016-06-12Have MemoryCheck() directly incorporate the error message and exit.Guy Harris1-13/+3
Manually inline memory_error() in MemoryCheck(), so that static analyzers know that, if MemoryCheck() sees a null pointer, it exists, and the null pointer isn't subsequently used. Use MemoryCheck() instead of the one place where we manually checked for a null pointer and called memory_error(). Change-Id: Id6b0328cfd17cb14ec9d1e461420896a31573c71 Reviewed-on: https://code.wireshark.org/review/15851 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-12Add more memory checks, and use MemoryCheck() for some existing checks.Guy Harris1-31/+14
Always check for malloc() and realloc() failing. Use MemoryCheck() for most of the checks - it's a bit cleaner and makes the error message the same for those checks. Change-Id: I533153c697b37b85adfa0259c1352efece0b0486 Reviewed-on: https://code.wireshark.org/review/15849 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-12Qt: Draw a border around inactive+selected packet list items.Gerald Combs1-0/+59
Try to make inactive+selected packet list items more visible by drawing a border around them. Make an exception for Windows 7 and Vista if a theme is active. Bug: 12010 Change-Id: I974069dda92588b80772f577f319569751ff3347 Reviewed-on: https://code.wireshark.org/review/15816 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-12[Automatic update for 2016-06-12]Gerald Combs18-447/+2049
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I14deff6b9a13a51d66ebdea361686822583b07c0 Reviewed-on: https://code.wireshark.org/review/15843 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-06-12mongo: don't THROW() an exception from a dissectorMartin Kaiser1-3/+3
just return the overall length even if the value is not in line with the protocol specification Change-Id: Ieeb5d1d265acb6de807a1175f07c7981db4b6c2b Reviewed-on: https://code.wireshark.org/review/15833 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-12Actually progress through the command data (CID-281394)Jaap Keuter1-1/+2
The loop reading through the command data doesn't progress through it, it just reads until the available data (represented by max_length) runs out. It therefore: - doesn't present the commands - doesn't detect a missing final marker bit (CID-281394) This change does make the code progress through the command data, fixing both issues in the process. Change-Id: I61ba8b56b4a153affe9b4f9a574267f981ef0594 Reviewed-on: https://code.wireshark.org/review/15825 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-12debian: Regenerate ASN.1 dissector code during package buildBalint Reczey1-0/+1
Change-Id: I3f7378ae5c048d3f954238bd04c707f039401ea1 Reviewed-on: https://code.wireshark.org/review/15161 Petri-Dish: Balint Reczey <balint@balintreczey.hu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-12Move Gateway Control Protocol (Context Tracking) into packet-h248.hMichael Mann14-1041/+1849
The Gateway Control Protocol (Context Tracking) is used by both H248 and MEGACO, so the functionality was refactored to epan, but should really be kept in the dissector directory to minimize (and eventually completely remove) the epan directory's dependence on it. Change-Id: I387b46aecde97234086bfdb7d8c546854fa301cd Reviewed-on: https://code.wireshark.org/review/15798 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-12Add missing scale in TDS type infoMichael Vigovsky1-1/+2
Change-Id: I6734fe448e4ee6f20a0d57b1aaae5e7e61f0cb5c Reviewed-on: https://code.wireshark.org/review/15811 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-12Handle zero-length addresses in cmp_address().Guy Harris1-0/+8
Don't compare the data if there's none to compare. Change-Id: Ib0e3541e448127869d19afddfc71bb441dba5874 Reviewed-on: https://code.wireshark.org/review/15840 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-12Add checks to address setting routines.Guy Harris6-30/+43
Fail if: 1) you have an AT_NONE address with data; 2) you have a non-AT_NONE address with a zero length and a non-null data pointer, or with a non-zero length and a null data pointer. When comparing addresses for equality, just make sure the types are the same, the lengths are the same and, if the lengths are non-zero, the data is the same; don't treat AT_NONE specially - the "lengths are non-zero" check will make sure we do the right thing. Make sure when we create an AT_NONE address it has a zero length and null data pointer. Change-Id: I5c452ef0d140c2d9aef3004f1cfd124a95b78fb2 Reviewed-on: https://code.wireshark.org/review/15839 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-12Store the tree item to add to later (CID-1159152)Jaap Keuter1-1/+1
The tree item needed to test and append to isn't being stored, so the items are never amended with notes, resulting in dead code. Change-Id: Ib1a9b7994ad12a9a9013d1bc1e1e4c165f34f20f Reviewed-on: https://code.wireshark.org/review/15826 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-12H225: Replace globals that track packet data with ↵Michael Mann3-262/+526
p_add_proto_data/p_get_proto_data. Change-Id: I0380151fb0f45063b81bc55dd5b8dc4add99ad30 Reviewed-on: https://code.wireshark.org/review/15794 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-23 05:31:14 +0000