aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2003-04-23Add a routine to create a new menu item under "/Tools/Statistics" forGuy Harris2-3/+49
taps. (It has to be called after we've created the main menu, but GUI taps are registered before that so that they can be referred to by command-line arguments, so that routine will only be usable if we have a "register menu item" routine for all GUI taps.) Disable the entire "/Tools/Statistics/MGCP" menu item, not just the "RTD" item under it, if we don't have an "mgcp" tap. svn path=/trunk/; revision=7539
2003-04-23From Duncan Laurie: IPMI-over-LAN support.Guy Harris7-2/+996
svn path=/trunk/; revision=7538
2003-04-22Remove signal (old debuging code)Laurent Deniel1-4/+1
svn path=/trunk/; revision=7537
2003-04-22Remove undefined code.Laurent Deniel1-2/+2
svn path=/trunk/; revision=7536
2003-04-22Get rid of C++ comments.Guy Harris3-14/+19
Fix up some comments, and eliminate a compiler warning. Make the "iac_found" variable Boolean, and get rid of a redundant initialization. Give David Yon credit for the recent Telnet updates. svn path=/trunk/; revision=7535
2003-04-22Get rid of C++ comments.Guy Harris1-3/+3
svn path=/trunk/; revision=7534
2003-04-22Apply the patches from David Yon from tacticalsoftware.com with a smallRichard Sharpe1-8/+332
change to get rid of C++isms. svn path=/trunk/; revision=7533
2003-04-22Eliminate the packet_info pointer argument from routines that don't useGuy Harris1-30/+28
it. svn path=/trunk/; revision=7532
2003-04-22From Mike Frisch: additional NFSv4 status codes.Guy Harris1-1/+10
svn path=/trunk/; revision=7531
2003-04-22- handle the col_set_fence stuff for upper layers.Michael Tüxen1-96/+15
- the control chunk info in the info column can be suppressed by using an option in the protocol preferences menu. The default is to show always control chunks in the Info column which is the old behaviour. svn path=/trunk/; revision=7530
2003-04-22- get rid of col_set_fence: it will be called in packet-sctp.c only.Michael Tüxen13-73/+31
- replace DATA1 by DATA in packet-m3ua.c (typo) svn path=/trunk/; revision=7529
2003-04-22Update to smb rtt stat for ethereal so that we can provide a filter for whichRonnie Sahlberg1-3/+66
packets we have data. Similar to oncrpc rtt stats smb rtt stats will also open a small window where a filter string can be specified. Only those packets matching the filter will be considered in calculating the rtt statistics. svn path=/trunk/; revision=7528
2003-04-22Update to the io,stat tethereal tap.Ronnie Sahlberg2-13/+31
Make it possible to use subsecond granularity for the measurement intervals. io,stat is updated to accept the interval to be specified with ms resolution. Example -z io,stat,0.001,smb to generate 1ms statistics for all SMB traffic. svn path=/trunk/; revision=7527
2003-04-22Add the Ethernet type for the Vines Echo protocol.Guy Harris3-8/+15
svn path=/trunk/; revision=7526
2003-04-22SAP_VINES1 (0xba) doesn't appear to be used for Vines-IP-over-LLC; it'sGuy Harris2-3/+29
used for some other protocol. Put in some information about an RMON draft that gives some information about various protocol numbers in various protocols. svn path=/trunk/; revision=7525
2003-04-22From Akira Endoh:Guy Harris2-73/+200
- fix the bug by dissecting the Flags field in RRO IPv4/IPv6/label sub-object (The 1.80 version of packet-rsvp.c dissects the wrong field in a packet.) - erase unnecessary commas when displaying RRO IPv4 sub-object - add support for displaying the error value, written explanation in ERROR object - add support for draft-ietf-mpls-nodeid-subobject-00.txt svn path=/trunk/; revision=7524
2003-04-22The main menu "/Display/{Match,Prepare}" menu items, and the tree viewGuy Harris1-8/+4
"{Match,Prepare}" pop-up menu items, should be enabled only if we have a field selected. The main menu item "/Tools/Statistics" should be enabled only if we have a capture. The packet list "Show Packet In New Window" pop-up menu item should be enabled only if there's a packet selected. svn path=/trunk/; revision=7523
2003-04-22"gtk_item_factory_get_widget()" returns, for a menu item with a submenu,Guy Harris1-4/+17
the submenu widget, not the menu item widget. For items with submenus, set the sensitivity on the menu item widget, not the submenu widget, so that the menu item is grayed out when not sensitive. svn path=/trunk/; revision=7522
2003-04-22Have "set_menu_sensitivity()" take, as an argument, a pointer to theGuy Harris1-98/+130
GtkItemFactory for the item it's modifying, with NULL meaning "all pop-up menus". Use the full path for the menu item in all such calls; have separate calls for the main menu item and pop-up menu items as necessary. svn path=/trunk/; revision=7521
2003-04-21Add the usual .cvsignore file.Guy Harris1-0/+19
svn path=/trunk/; revision=7520
2003-04-21From Greg Morris:Guy Harris2-2588/+3329
1. Add definitions for Novell defined Object ID's 2. Cleanup displayed information 3. Object ID's no longer displayed by default. To enable then set option in the NDPS preferences to "Display NDPS Details" 4. Value Syntax no longer displayed by default. To enable then set option in the NDPS preferences to "Display NDPS Details" 5. Utilize SPX End of Message within NDPS/SPX Fragment packets 6. Numerous Bug fixes 7. Add Print Program Function 0x23 (Add Event Profile 2) 8. Add Print Program Function 0x24 (List Event Profiles 2) 9. Create consolidation functions to elliminate redundant code 10. Remove some unused variable definitions svn path=/trunk/; revision=7519
2003-04-21From Erwin Rol: ArtNET support.Guy Harris18-11/+2541
svn path=/trunk/; revision=7518
2003-04-21From Brad Hards: don't mention the "Add Expression" button in theGuy Harris1-6/+12
message box popped up if you try to add a new capture filter but haven't specified a filter name or string, as there is no such button for capture filters. svn path=/trunk/; revision=7517
2003-04-21Make "first_pdu" an argument rather than a global in the ONC RPCGuy Harris3-50/+49
dissector - including the ONC RPC-over-TCP record marking code, which is also used by NDMP. That means that the NDMP dissector can, like the ONC RPC dissector, put into the Info column items for all the NDMP messages dissected for a frame; make it do so. svn path=/trunk/; revision=7516
2003-04-21From Jean-Baptiste Marchand: put the LDAP message ID and message typeGuy Harris1-4/+4
into the protocol tree as visible fields. svn path=/trunk/; revision=7515
2003-04-21The DCE RPC dissector puts "request in" and "reply in" information intoGuy Harris1-119/+1
the protocol tree, and no other dissector for a DCE RPC-based protocol does to itself - get rid of the code to do so here. svn path=/trunk/; revision=7514
2003-04-20Add a pointer to an hf_ value for a "reassembled_in" field (which can beGuy Harris18-75/+139
null) to the "fragment_items" structure, and don't pass that value into "process_reassembled_data()", just have it use the value in the "fragment_items" structure passed to it. Make "process_reassembled_data()" capable of handling reassembly done by "fragment_add_seq_check()", and use it in the ATP and 802.11 dissectors; give them "reassembled_in" fields. Make "process_reassembled_data()" handle only the case of a completed reassembly (fd_head != NULL) so that we can use it in those dissectors without gunking the code up too much. svn path=/trunk/; revision=7513
2003-04-20 change LITTLE_ENDIAN to LITTLE_ENDIAN_BYTE_ORDERMichael Tüxen1-9/+11
svn path=/trunk/; revision=7512
2003-04-20Put entries for a reassembled packet into the appropriate hash table forGuy Harris1-41/+20
all of the frames that make it up, so Ethereal can show, for all but the final frame, the frame in which it was reassembled. (Tethereal can't, as it's a one-pass program.) svn path=/trunk/; revision=7511
2003-04-20Pull much of the processing done after a call to "fragment_add_check()"Guy Harris6-117/+124
into a subroutine, for use in other dissectors. Use it in the IPv6 and CLNP dissectors. svn path=/trunk/; revision=7510
2003-04-20Under Solaris, strlen() segfaults if you pass it a NULL. Replace all of theGerald Combs1-5/+5
NULL blurbs in the hf_register_info definition with empty strings. svn path=/trunk/; revision=7509
2003-04-20Add a "fragment_add_multiple_ok()" routine that skips the check for aGuy Harris3-13/+42
fragment having been added already. In protocols using the ONC RPC-over-TCP record-marking mechanism (RPC-over-TCP and NDMP), there can be more than one record-marking-layer fragment in a single TCP segment, and thus can be more than one fragment in a frame being added to a given higher-level packet. svn path=/trunk/; revision=7508
2003-04-20Use "fragment_add_check()" for IPv6 and CLNP reassembly. (Possibly anGuy Harris2-5/+11
issue for CLNP, with its 16-bit IDs, which could be duplicated in a sufficiently large capture even if CLNP implementations don't deliberately reuse IDs; less of an issue for IPv6, with its 32-bit IDs and with its prohibition on reuse: For every packet that is to be fragmented, the source node generates an Identification value. The Identification must be different than that of any other fragmented packet sent recently* with the same Source Address and Destination Address. If a Routing header is present, the Destination Address of concern is that of the final destination. * "recently" means within the maximum likely lifetime of a packet, including transit time from source to destination and time spent awaiting reassembly with other fragments of the same packet. However, it is not required that a source node know the maximum packet lifetime. Rather, it is assumed that the requirement can be met by maintaining the Identification value as a simple, 32- bit, "wrap-around" counter, incremented each time a packet must be fragmented. It is an implementation choice whether to maintain a single counter for the node or multiple counters, e.g., one for each of the node's possible source addresses, or one for each active (source address, destination address) combination. but perhaps we'll ultimately be able to get rid of the old "fragment_add()" entirely and rename "fragment_add_check()" to "fragment_add()"). svn path=/trunk/; revision=7507
2003-04-20We can't use the frame_data structure as a key structure when lookingGuy Harris3-140/+304
for reassembled frames - in Tethereal, there's only one frame_data structure used for all frames. Instead, use the frame number itself as the key. Add a "fragment_add_check()" routine, for fragments where there's a fragment offset rather than a fragment sequence number, which does the same sort of thing as "fragment_add_seq_check()" - i.e., once reassembly is done, it puts the reassembled fragment into a separate hash table, so that there're only incomplete reassemblies in the fragment hash table. That's necessary in order to handle cases where the packet ID field can be reused. Use that routine for IPv4 fragment reassembly - IP IDs can be reused (in fact, RFC 791 suggests that doing so might be a feature: It is appropriate for some higher level protocols to choose the identifier. For example, TCP protocol modules may retransmit an identical TCP segment, and the probability for correct reception would be enhanced if the retransmission carried the same identifier as the original transmission since fragments of either datagram could be used to construct a correct TCP segment. and RFC 1122 says that it's permitted to do so, although it also says "we believe that retransmitting the same Identification field is not useful": 3.2.1.5 Identification: RFC-791 Section 3.2 When sending an identical copy of an earlier datagram, a host MAY optionally retain the same Identification field in the copy. DISCUSSION: Some Internet protocol experts have maintained that when a host sends an identical copy of an earlier datagram, the new copy should contain the same Identification value as the original. There are two suggested advantages: (1) if the datagrams are fragmented and some of the fragments are lost, the receiver may be able to reconstruct a complete datagram from fragments of the original and the copies; (2) a congested gateway might use the IP Identification field (and Fragment Offset) to discard duplicate datagrams from the queue. However, the observed patterns of datagram loss in the Internet do not favor the probability of retransmitted fragments filling reassembly gaps, while other mechanisms (e.g., TCP repacketizing upon retransmission) tend to prevent retransmission of an identical datagram [IP:9]. Therefore, we believe that retransmitting the same Identification field is not useful. Also, a connectionless transport protocol like UDP would require the cooperation of the application programs to retain the same Identification value in identical datagrams. and, in any case, I've seen that in at least one capture, and it confuses the current reassembly code). Unfortunately, that means that fragments other than the last fragment can't be tagged with the frame number in which the reassembly was done; see the comment in packet-ip.c for a discussion of that problem. svn path=/trunk/; revision=7506
2003-04-19change my e-mail address.Michael Tüxen1-1/+1
svn path=/trunk/; revision=7505
2003-04-19- a 'quick hack' for col_set_fence support for better INOF column handling ↵Michael Tüxen1-55/+88
(a new version of the SCTP dissector is in development...) - change of my e-mail address. svn path=/trunk/; revision=7504
2003-04-19- added better handling of the INFO column using col_set_fence.Michael Tüxen1-4/+4
- changed my e-mail. svn path=/trunk/; revision=7503
2003-04-19- add better INFO column handling using col_set_fence.Michael Tüxen7-124/+76
- change my e-mail. svn path=/trunk/; revision=7502
2003-04-19- add a col_set_fence callMichael Tüxen1-2/+4
svn path=/trunk/; revision=7501
2003-04-19- add INFO column stuff using fence.Michael Tüxen6-133/+114
- change my e-mail address svn path=/trunk/; revision=7500
2003-04-19Run strings through "format_text()" before putting them into items inGuy Harris1-44/+68
the protocol tree. Give SMUX filterable fields for the version and PDU type. svn path=/trunk/; revision=7499
2003-04-19The first element in a fragment list isn't a fragment, it's a specialGuy Harris1-14/+26
entry for the reassembled packet; don't look at it when checking to see if we've already seen a fragment (its "frame" field isn't initialized, so we shouldn't check it in any case). svn path=/trunk/; revision=7498
2003-04-19Squelch a compiler warning.Guy Harris1-7/+8
svn path=/trunk/; revision=7497
2003-04-19Fix a typo.Guy Harris1-2/+2
svn path=/trunk/; revision=7496
2003-04-18From Thierry Andry: more filterable fields in SNMP.Guy Harris2-23/+60
svn path=/trunk/; revision=7495
2003-04-18Show metrics in ARP and RTP as ticks and seconds.Guy Harris1-34/+63
An RTP information type of 0 is an update. The compatibility flags are a bunch of flag bits; show them as such. Fix some bitfield strings. Sequence numbers in RTP are 4 bytes, not 2 bytes. svn path=/trunk/; revision=7494
2003-04-18Add some comments about the 0x10 bit in the Flags field of an NTcreate&X.Richard Sharpe1-2/+24
svn path=/trunk/; revision=7493
2003-04-180x06 appears to be an opcode for VRTP redirects.Guy Harris1-55/+15
SRTP requests don't look the way the stuff I found appears to say they look. Fix some incorrect uses of "tvb_get_ntohl()" to fetch 16-bit values to use "tvb_get_ntohs()" instead. Fix some strings for flag bits. svn path=/trunk/; revision=7492
2003-04-18Dissect non-sequenced RTP and ARP, and dissect more of sequenced RTP.Guy Harris1-119/+677
Add Vines Echo. Add some additional class values. Use the length field in the Vines IP header to set the length of the packet. Adjust the byte order of all multi-byte integer fields in the IPC and SPP headers. svn path=/trunk/; revision=7491
2003-04-18Fix a problem where the RPC tap would not be calledRonnie Sahlberg1-2/+9
if the PDU was short. This was most noticeable in NFS Read Replies not generating tap events and thus NFS RTT statistics did not count the Read procedure. svn path=/trunk/; revision=7490