aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-07-20If we have fseek/ftell variants with 64-bit offsets, use them.Guy Harris3-2/+16
Or, at least, use them in the libwiretap file-writing code; we can change other places to use them as appropriate. Change-Id: I63af2267a22a158ee23f3359b043913dac0e285b Reviewed-on: https://code.wireshark.org/review/28783 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-20CMake: Fixup our tools help dependencies.Gerald Combs9-25/+21
Make sure each tools help target is generated by and depends on its generating executable. Change-Id: I716c0db23b297e2d2692b72a47259c40aa0c52fa Reviewed-on: https://code.wireshark.org/review/28780 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-20Clean up tests.Guy Harris1-91/+102
On Windows with MSVC, just assume we have 64-bit file offset support, including _fseeki64() and _ftelli64(). On UN*X, test for Large File Support and for fseeko()/ftello(), and for what #defines are needed to enable them. On Windows without MSVC, test for Large File Support, but assume we have _fseeki64() and _ftelli64(); what *should* we be doing? Clean up indentation and else()/endif() arguments while we're at it. Change-Id: I801d1f4059abbed2d5123d2375a560634a9ee056 Reviewed-on: https://code.wireshark.org/review/28781 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-20CMake: Don't bother testing for _fseeki64 on Windows.Gerald Combs3-31/+4
We don't appear to use it and if we ever do need it it's been available since Visual Studio 2005 / MSVCR80. Change-Id: Ifd44d78b96a21577ceea635653517a348ded50f7 Reviewed-on: https://code.wireshark.org/review/28778 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-20WSUG: Added placeholders for missing documentationMoshe Kaplan5-70/+291
Change-Id: I93b118964b0296bd32627439f8ae3c13169b1d5e Reviewed-on: https://code.wireshark.org/review/28772 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-20AsciiDoctor markup updates.Gerald Combs2-0/+20
Separate includes by blank lines as recommended in https://asciidoctor.org/docs/user-manual/#include-directive. Separate block attributes as well. Change-Id: I933917a14eae6d1fe1879372917ab2208755f470 Reviewed-on: https://code.wireshark.org/review/28769 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-20Lua: Switch from disable_lua to enable_lua.Gerald Combs5-18/+31
Deprecate "disable_lua" in favor of "enable_lua". Configuration options typically use "true" or a similar value to enable features. Using "disable_lua = false" to enable Lua seems odd. Change-Id: I224acad0559d409ea0a28b5555d1eb898564328c Reviewed-on: https://code.wireshark.org/review/28773 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-19WSUG: Update the Statistics chapter to match current Qt UIMoshe Kaplan5-50/+101
Hide the Compare option, reorder the chapters to match the current Qt order and move the Wireless menu to a new chapter. Change-Id: I7f0eeb45f4894f66a9c91d62d7d43db775f469e5 Reviewed-on: https://code.wireshark.org/review/28761 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-19stun: fix typo found by lintianAlexis La Goutte1-2/+2
adress -> address (on display filter) Change-Id: I36fb6c897e76b6a1465a840f1a0aa8f640bc09f8 Reviewed-on: https://code.wireshark.org/review/28763 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-19ISAKMP: Incorrect presentation of NETMASK for INTERNAL_IP4_SUBNET Config ↵Alexis La Goutte1-1/+2
Attribute Bug: 14987 Change-Id: I03c29026ec5c2d4b172bb49aff3f6877a9b9ab10 Reviewed-on: https://code.wireshark.org/review/28747 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-19PTP: Don't interpret UDP packets as 802.1asDylan Ulis1-4/+7
Some fields were excluded/included when 802.1as is enabled. But, this transportSpecific flag only applies over Ethernet, and not UDP. Bug: 14990 Change-Id: I9d914ae3ee3ac15e81e79e9ea81b9449210ea01a Reviewed-on: https://code.wireshark.org/review/28762 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-07-19Extcap programs must write to the packet pipe in binary mode.Guy Harris3-3/+3
It doesn't matter on UN*X, but it definitely matters on Windows; we're writing a pcap file, not a text file, so every byte we write should go down the pipe as is. Bug: 14989 Change-Id: I26c067b8ff5dba644a579846dd97b568a81c7053 Reviewed-on: https://code.wireshark.org/review/28764 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-18WSUG: Update docs for 'Export Object'Moshe Kaplan3-28/+26
Change-Id: Ifab1a0d76d3ba81585d557a8a8b49351cdc6a002 Reviewed-on: https://code.wireshark.org/review/28734 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2018-07-18H.265: Parsing media format specific parameter from SDP.Asaf Kave4-1/+106
Change-Id: I2607068671f370517b1f0a2f65f47a221b630d91 Reviewed-on: https://code.wireshark.org/review/28725 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-17Tools: Remove parentheses around bug notes.Gerald Combs1-1/+1
Change-Id: Ib2eb24d769dceb6eaab152290e719ae35cad4dcb Reviewed-on: https://code.wireshark.org/review/28742 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-17Qt: Remove an unneeded function.Gerald Combs2-8/+1
Remove MainWindow::createByteViewDialog, which was called once and contained one line. Change-Id: Ibe03db2c527b0a817d8b99df87d161405805bac3 Reviewed-on: https://code.wireshark.org/review/28733 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-17Qt: update to QCustomPlot 1.3.2Peter Wu2-422/+518
QCustomPlot 1.3.1 includes a fix for a crash ("Fixed potential crash in QCPGraph::pointDistance if getScatterPlotData returns empty list"). Full changelog: http://www.qcustomplot.com/release/1.3.2/changelog.txt The new files are based on QCustomPlot-source.tar.gz (1.3.2) with Alexis' typo and license header changes from v1.99.2rc0-479-gc411029a3c ("Update to QCustomPlot 1.3.0") applied. All successive Wireshark patches up to v2.5.0rc0-854-g6f28f1a59e ("Fix MacOS build") were applied. The Retina patches ("Fix QCustmPlot retina problems." and "QCP: Fix retina label calculations.") gave conflicts due contextual changes which I resolved by renaming newCachedLabel to cachedLabel (following the change in upstream commit baaad24706187f5be0a68011c780b51c4de11558). Bug: 14971 Change-Id: I5012cb5a867891b466cbf1898fe4c28cbd11ba20 Reviewed-on: https://code.wireshark.org/review/28732 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-17Tests: add minimal pytest supportPeter Wu3-4/+49
pytest is a powerful test framework. The initial motivation is to have much better detailed reporting when a test fails, see for example https://docs.pytest.org/en/latest/ Additionally, it has full parallelization support at the test level (via the pytest-xdist plugin) instead of being limited to the suite level (which currently has to be hard-coded via CMakeLists.txt). Usage with the build dir in /tmp/wsbuild and src dir in /tmp/wireshark: export WS_BIN_PATH=/tmp/wsbuild/run pytest /tmp/wireshark/tests For parallelization support and verbose printing: pip install pytest-xdist pytest -nauto -v /tmp/wireshark/tests To limit yourself to a case based on a pattern: pytest -nauto -v /tmp/wireshark/tests -k test_unit_ctest_coverage Tested on Arch Linux with Python 3.6.5, pytest-3.6.2, xdist-1.22.2. pytest -n8 finished in 82 seconds while ctest -j8 required 87 seconds. Change-Id: I832f4dd9f988d6656df795327e81610accf54b9f Reviewed-on: https://code.wireshark.org/review/28651 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-17wmem: make wmem_strsplit behave more like g_strsplitPeter Wu3-58/+58
In the past "g_strsplit" users were converted to use "wmem_strsplit" to avoid memory leaks when dissection fails. The semantics were slightly different though. When the DNS dissector tried to split the string "." using delimiter ".", it would previously (unexpectedly) receive an empty vector (and crash). Now it will receive a vector with one element. Additionally, suggest that users of wmem_strsplit with a NULL allocator use g_strsplit instead, otherwise it will leak the elements. Bug: 14980 Change-Id: I408dfdb0ffa9e24ccdba69c8ee095abea72f6feb Reviewed-on: https://code.wireshark.org/review/28724 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-17LPP: upgrade dissector to v15.0.0Pascal Quantin6-193/+5719
Change-Id: I8cb04749a772d9ed5fb191f584505d4b3096aa5e Reviewed-on: https://code.wireshark.org/review/28735 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-16Qt: Create the main display filter combo sooner.Gerald Combs1-7/+7
Construct MainWindow::df_combo_box_ in our initializer list, otherwise anything that triggers a resizeEvent early on might result in an NPE. Wait until everything is in place before calling setMinimumWidth. Bug: 14979 Change-Id: I78b349f9c3ea53d8b1399a77169bbbd0a4a69191 Reviewed-on: https://code.wireshark.org/review/28728 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-16Lua: add include/lua-5.1 and include/lua-5.2 to CMake path suffixesPascal Quantin1-1/+1
Bug: 14983 Change-Id: I8be206ace7f61c62e2e42bc53841067ec39e3a0a Reviewed-on: https://code.wireshark.org/review/28726 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-16extcap: Correct doc structureRoland Knall1-6/+6
Some issues in the developer doc have been corrected Change-Id: I0d60e9080ef582dafa12607fb5ea43a8ae5d2d0f Reviewed-on: https://code.wireshark.org/review/28727 Reviewed-by: Roland Knall <rknall@gmail.com>
2018-07-16DOCSIS: fix null-pointer crash in OPT-RSP TLVs decodingPeter Wu1-14/+10
"tmp_fh->next" is NULL on the initial visit and thus "tvb_get_guint8(tmp_fh->tvb_data,1)" crashes. It is not entirely clear to me how reassembly should work in this DOCSIS message, but based on the description in "6.4.45 OFDM Downstream Profile Test Response (OPT-RSP)" in the DOCSIS MAC and Upper Layer Protocols Interface Specification (CM-SP-MULPIv3.1-I07-150910), I suppose that it was trying to support decoding of (a sequence of) TLVs where the value is too large for a single frame. Bug: 14954 Change-Id: I2eec91d0ca6356b2af61bfe55381c300c8872039 Fixes: v2.9.0rc0-1171-g738818fe4d ("DOCSIS: Added decoding for OPT (OFDM Downstream Profile Test) messages") Reviewed-on: https://code.wireshark.org/review/28712 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-16Supply a 0s/0ns value for invalid time value lengths.Guy Harris1-17/+68
Other routines that fetch values and can report a type/length error without throwing an exception return a value, even if it's not the appropriate value (as there is no appropriate value); make get_time_value() do the same. Ideally, we'd mark the protocol tree item, and the value, as being invalid, and treat invalid values specially, but that's a bigger change that would involve significantly more mucking about in the innards of epan/proto.c as well as in code that looks at the protocol tree and at field values, as well as deciding what the appropriate thing to do is with a field with no value when, for example, -T {fields,pdml,json,ek,etc.} is used. Bug: 14957 Change-Id: Iab91198e560f52809d989cfce8b51b1b027cff73 Reviewed-on: https://code.wireshark.org/review/28722 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-15Update the comment giving I-D URLs.Guy Harris1-4/+3
Change-Id: Id2ec0092369083b7bd6951c7121ac885c067ac1f Reviewed-on: https://code.wireshark.org/review/28715 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-15[Automatic update for 2018-07-15]Gerald Combs3-3/+95
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie42a61986a8001c57d04e62ba09f4c13e03d295f Reviewed-on: https://code.wireshark.org/review/28704 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-07-15ZBEE-NWK_GP: add key decryption during commissioning processJulien Staub1-69/+167
Decrypt the key in commissioning and commissioning reply commands user keys. The user must add the default TC-LK (as described in doc-09-5499-26) into the key list for this feature to be visible. Keys found in commissioning and commissioning reply commands are automatically used for the reset of the capture Use the SRC column to display the ZGP srcID Bug: 13919 Change-Id: I90a7a7d1cdd003672bb2bd78e8ed76e1475d1208 Reviewed-on: https://code.wireshark.org/review/28084 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-15DHCPv6: device type is not mandatory for ecm.Bruno Verstuyft1-4/+2
Change-Id: I295ff4e4225cdedc8928710002a042151a845514 Reviewed-on: https://code.wireshark.org/review/28686 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-14The maximum offset in an IP option dissector is the length of the option.Guy Harris1-1/+1
It's *not* the sum of the length of the option and the length of the option header. Change-Id: I0b5ab0e35ca33dc02a0bc2501e0f0f531ec3f376 Reviewed-on: https://code.wireshark.org/review/28701 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-14wmem_tree: describe tree traversal orderMatthieu Coudron2-6/+8
it is an inorder traversal (left/parent/right). Change-Id: Ia83efdfd45dab8c8386d84b3050af081312fde85 Reviewed-on: https://code.wireshark.org/review/28688 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-14wmem_itree:update children max_edge after rotationMatthieu Coudron1-3/+11
After a rotation, the post_rotation callback was just updating the root tree max_edge when it should also update its children since some of them might have lost or changed children. Any change in max_edge will bubble up/propagate to the parent. Change-Id: Ia6705d71de5c85847d51f97f86fd35f4da20c03a Reviewed-on: https://code.wireshark.org/review/28687 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-14PROFINET: Refactoringgizem.yurdagul3-1070/+1080
According to the prediction, some new features will be added in the future. I'm working on the implementation of these new features. dissect_PNIO_status is updated as "extern" and transferred to the packet-pn.c. Because upcoming feature will have own c file and it will use this dissection. Thus, dependence between classes will be decreased and duplicated code lines will be prevented. So that future changes will be easier. Change-Id: I067d9582dcc8b9909e5a9bc3ab5f30d3c879b226 Reviewed-on: https://code.wireshark.org/review/28677 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-14Qt: try to sort numeric columns (such as ports) as numberPeter Wu1-21/+49
Ensure that columns with numbers are sorted according to their numeric value instead of their alphabetical order. Bug: 11460 Change-Id: I6ccfb9d3699c7e95de4ed31eb9424c5687661593 Reviewed-on: https://code.wireshark.org/review/28652 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-14mptcp: Correctly find mappings and reinjectionsMatthieu Coudron3-74/+88
- removed mptcp.duplicated_dsn in favor of mptcp.reinjection_of/mptcp.reinjected_in reinjected_in lists the packets where the DSN was later reinjected in. reinjection_of lists the packets in which this DSN was already transmitted. - There was a bug where the max_edge property of the interval tree was not correctly updated. Right now wireshark gives a dsn for every TCP frame (even empty packets). - Now displays mappings only for packets with data (seglen > 0). - Renamed dsn_map to dsn2packet_map and mappings to ssn2dsn_mappings. - precises the complexity of enabling certain MPTCP options so that the user better understand their impact on processing speed. Change-Id: I24adc3161021b7f6a084763a74dc580f1c1f2c2e Reviewed-on: https://code.wireshark.org/review/28326 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-14gprscdr: Update to 3GPP TS 32.298 V15.3.0Joakim Karlsson3-81/+282
Change-Id: I48a02ab0321abbe793b7769e03e86c658c81499d Reviewed-on: https://code.wireshark.org/review/28689 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-14pfcp: Update to 3GPP TS 29.244 V15.2.0Joakim Karlsson1-24/+392
Change-Id: I019b6b57156cc50bcf8b6462451932469e2c8fa1 Reviewed-on: https://code.wireshark.org/review/28685 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-14pfcp: update Enterprise IEJoakim Karlsson1-7/+9
Missunderstanding of Length, Enterprise ID is not excluded in Length. Remove removal of 8bit in IE type since Enterprise IE shall start with value 32768. Change-Id: Ie5c2e972cd893e41382ef9f07a5327ec05cf4141 Reviewed-on: https://code.wireshark.org/review/28680 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-13extcap: Create docbook documentationRoland Knall2-428/+443
Move the information from README.extcap into docbook. Change-Id: Ic6504787750d04fe6c66479896cba8d6148d804d Reviewed-on: https://code.wireshark.org/review/28690 Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-07-13CIP Motion: Update attribute service handlingDylan Ulis3-68/+131
1. Get/Set Axis Attribute List: Display the attribute name, and dissect where appropriate. 2. Minor: Cleanup exported functions/variables. Bug: 14958 Change-Id: I2ff6883e66068472ac5ded0172f51575f5e20a21 Reviewed-on: https://code.wireshark.org/review/28660 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-07-13LTE RRC: upgrade dissector to v15.2.2Pascal Quantin10-325/+341
Change-Id: I405379c0a36e46e27ca9bcfc89c557b2e4ee9e0e Reviewed-on: https://code.wireshark.org/review/28695 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-13CoAP: handle per packet data properlyJaap Keuter1-3/+4
Bug: 14966 Change-Id: I9c5c1da923a0cc2881465bcc484850d042a314d6 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/28694 Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-07-12COPS: fixed error codesBruno Verstuyft1-3/+3
Change-Id: If18f380fa813e1df234d5fd3bced806c419d154a Reviewed-on: https://code.wireshark.org/review/28691 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-07-12Add time_micros field to the riemann dissectorRomain Tartière1-0/+11
This field was added in Riemann 0.2.13 and Riemann client 0.4.4: https://github.com/riemann/riemann-java-client/commit/797e8db998dee01f98ae49848da016682a33250d Change-Id: I132155d090725461f0e7df3d203dbe3d4a215f75 Reviewed-on: https://code.wireshark.org/review/28692 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2018-07-12Fix URL to Riemann protobuf structures layoutRomain Tartière1-1/+1
Change-Id: I77693ccfdaac7be7bac7aa210b0984e196b73063 Reviewed-on: https://code.wireshark.org/review/28693 Reviewed-by: Roland Knall <rknall@gmail.com>
2018-07-11Qt: make "Save As" in Follow Streams usablePeter Wu2-52/+22
For formats other than "Raw" and "UTF-8", the written file does not match the actual stream data. It would be duplicated in strange ways. Executing the "Save As" action twice while the dialog is open would also write two different files (huh?). As a quick fix, just replace the strange save logic by writing the text field contents. A functional difference is that previously it would write data while parsing the "follow data" list, now it uses the text field contents. That data will now be truncated after 500 MB. Bug: 14933 Change-Id: I498676389d0da3ac070346d6903bd2e6b0fc7674 Fixes: v1.11.0-rc1-2538-g80f9326b2f ("Add TCP/UDP/SSL Follow feature to QtShark") Reviewed-on: https://code.wireshark.org/review/28663 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-07-11DeviceNet: Add reference to spec nameDylan Ulis2-1/+5
Change-Id: Ibe7179ee58c7be2be223dd1ff11833fc86198d08 Reviewed-on: https://code.wireshark.org/review/28681 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-07-10btatt: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+0
Change-Id: I1be03f0cadfe1a62ee5136daf8f5b875a983e5be Reviewed-on: https://code.wireshark.org/review/28607 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-07-10GTPv2: Added missing string for value 1 of Secondary Rat Usage Report TypeMatej Tkac1-0/+1
Reference: 3GPP TS 29.274 V15.3.0 (2018-03), Table 8.132-1 Change-Id: Ibce9f8e2f2502a085d1368cacd0eaf6b8f5ef068 Reviewed-on: https://code.wireshark.org/review/28676 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-07-10If we explicitly started a new page, print a column header line if necessary.Guy Harris1-0/+7
Change-Id: I9be7b41ce5ec5ece502035d0ca7c0fbb3eb3b37d Ping-Bug: 14960 Reviewed-on: https://code.wireshark.org/review/28672 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-29 11:15:35 +0000