aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-09-19TDS: Fix some URLs and add a note about our heuristic check.Gerald Combs1-2/+7
Wayback-ize a couple of URLs. Note that we might be able to improve our heuristic check by checking various string lengths. (I didn't add the checks myself because I don't have any TDS captures with login packets.) Change-Id: I3d67c66a292fd02035a15e1e047227f55314737a Reviewed-on: https://code.wireshark.org/review/23612 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-09-18sharkd: support flows (sequence analysis)Jakub Zawadzki1-0/+151
Change-Id: Ie85295dbcfab3efe7ba05c5c9c7ae22d0c6eedec Reviewed-on: https://code.wireshark.org/review/23572 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-18Move most of sequence analysis code from ui/ to epan/Jakub Zawadzki15-557/+819
Create registration system to allow creation of analysis items to be localized to the dissector. For now only frame (all) and TCP are supported. VOIP functionality will be covered in a separate patch. Change-Id: I5b05ef6d5afff8d0b162b03a0f451ab810602e81 Reviewed-on: https://code.wireshark.org/review/23571 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-18Update list of symbols for Debian.Guy Harris1-0/+5
Change-Id: I4ba02f37fcfbae01d43d7fdf5e5361373a2b0391 Reviewed-on: https://code.wireshark.org/review/23611 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-18[PFCP] Dissect more IEs.AndersBroman1-43/+685
Change-Id: Ic3a32f3317af81289da0be73474f4a8882d4bf43 Reviewed-on: https://code.wireshark.org/review/23603 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-18Qt: Fix -Wimplicit-fallthrough with GCCJoão Valverde1-0/+1
../../../ui/qt/models/decode_as_model.cpp: In member function ‘virtual QVariant DecodeAsModel::data(const QModelIndex&, int) const’: ../../../ui/qt/models/decode_as_model.cpp:155:13: error: this statement may fall through [-Werror=implicit-fallthrough=] Change-Id: I29654a0f6ce6cce7bc778231bc8d6e602875104f Reviewed-on: https://code.wireshark.org/review/23589 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-18[PFCP] Add more IE dissection.AndersBroman1-31/+1168
Change-Id: I26a75055d0a4fee209d2d118dd9403d614739d76 Reviewed-on: https://code.wireshark.org/review/23525 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-18TLS13: restore draft -18 support for HRRPeter Wu2-10/+23
Draft 18 is still the most current boringssl version, avoid a malformed packet exception by recognizing a draft -18 HelloRetryRequest. Change-Id: I43cf91350a8a2ebfad6c1e0e35eb9621a3b3e44b Fixes: v2.3.0rc0-2789-g18c4d1bb1f ("TLS13: update HRR for draft -19") Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23544 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-09-18TLS13: restore draft -18 support for CertificateRequestPeter Wu1-10/+24
Prevent a malformed packet exception with draft -18 CertificateRequest message which would break further decryption. Tested with tls13-18-certreq.pcap from the linked bug. Change-Id: I00be21935370d0f0be66d2dbc87ee9fea3bb889a Fixes: v2.3.0rc0-2761-g0e244e01fe ("TLS13: update CertificateRequest dissection for draft -19") Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23543 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-09-18Qt: Improved ColumnEditorFrame validation checksStig Bjørlykke2-16/+12
Use common validation checks for fieldsNameLineEdit and occurrenceLineEdit. No need to check for COL_CUSTOM and empty occurrence because this will give a valid value anyway. Change-Id: I8981a15954e9a55a9a43e4a5760b34d83aa2e1ca Reviewed-on: https://code.wireshark.org/review/23584 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-18Update ldp TLVs from iana webpage (scripted).Joerg Mayer1-276/+450
Change-Id: I1cb4210d4af93303298485c86627027adecd6052 Reviewed-on: https://code.wireshark.org/review/23578 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-09-17ZigBee: fix buffer overrun in zbee_sec_add_key_to_keyringPeter Wu1-1/+1
"key" is a guint8 array of ZBEE_APS_CMD_KEY_LENGTH, compare its value and not the pointer. Bug: 14070 Change-Id: I8add2bbcc04f9bbbc9502a07aa34d35b5a67e1c1 Fixes: v2.5.0rc0-1007-gf63fc33362 ("ZigBee: implemented a dissector for ZBOSS key dump") Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3408 Reviewed-on: https://code.wireshark.org/review/23588 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-17DMP: check 7bit string length before decoding itPascal Quantin1-11/+16
Bug: 14068 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3372 Change-Id: Ib9ff63e2ef8d3c2546f357534c374a662e70e43c Reviewed-on: https://code.wireshark.org/review/23591 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-09-17RRC: check wmem_strbuf_t pointer before using itPascal Quantin2-47/+53
Digit field is also ussed by other fields than PLMN-Identity and IMSI-GSM-MAP Bug: 14069 Change-Id: Ic8cf4dc148fecf24e28ef1be21c3968d46e4b456 Reviewed-on: https://code.wireshark.org/review/23590 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-17cmake: Add option to disable -Wframe-larger-thanStig Bjørlykke2-1/+2
In some editors (like Xcode) it's possible to turn on and off ASAN and UBSAN independent of the settings in CMake. This option will disable the -Wframe-larger-than= flag even if ASAN or UBSAN are not turned on in CMake. Change-Id: I70b1ae544fe87093d0f5ce7ceb191f33399191ea Reviewed-on: https://code.wireshark.org/review/23567 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-17Add comment to docinfo.xml to note make-version.pl updateJoão Valverde2-0/+2
Change-Id: I71e4352c94515e4edc3a7bda6851ecfd404800ef Reviewed-on: https://code.wireshark.org/review/23586 Reviewed-by: João Valverde <j@v6e.pt>
2017-09-17plugins: Change personal plugin dir path on UnixJoão Valverde3-4/+6
Installing machine code to XDG_CONFIG_HOME is problematic. Use ~/.local/lib/wireshark/plugins instead. XDG_CONFIG_HOME should be architecture independent. This allows copying the configuration between different architectures safely. Reference: https://www.freedesktop.org/software/systemd/man/file-hierarchy.html Change-Id: I1b18f64aab4dd351d611cfbea3b9333f23c98bfa Reviewed-on: https://code.wireshark.org/review/23498 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-17plugins: Use minor version number for plugin install pathJoão Valverde4-5/+7
Wireshark patch releases (X.Y.Z) are binary compatible so reflect that in the plugin installation path. By installing to $pkglibdir/plugins/X.Y out-of-tree plugins don't need to be reinstalled with every patch release. Change-Id: I9d1728e6fb12bcb51d2a723af22c750cb7a966cf Reviewed-on: https://code.wireshark.org/review/23497 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-17plugins: Fix paths to match WSUGJoão Valverde6-8/+16
The Wireshark User Guide seems to say: Global lua plugins are in $pkglibdir/plugins Personal lua plugins are in XDG_CONFIG_HOME/plugins Global binary plugins are in $pkglibdir/plugins/$version Personal binary plugins are in XDG_CONFIG_HOME/plugins/$version Fix code to match that. This is a backward-incompatible change for global lua plugins and personal binary plugins. Adds a version subfolder to the personal plugin folder for binary plugins. This allows for safe upgrades and side-by-side installations with different prefixes (they no longer use the same personal dir). Change-Id: Ie0f039113628a257625a9a9fb2cb30e532f5dd47 Reviewed-on: https://code.wireshark.org/review/23516 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-17[Automatic update for 2017-09-17]Gerald Combs9-122/+100
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0b157ca377ef2e8f1a2502e51b542322dc0d36b2 Reviewed-on: https://code.wireshark.org/review/23580 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-09-17CMake: Initial work to install headers for the benefit of pluginsJoão Valverde8-5/+633
To be continued incrementally to fix gaps and omissions. If we are willing to reorganize the source tree to have one or two header include folders this could be simplified considerably. It would also force developers to give more consideration to API issues, which is a good thing. See also e7ef19efc0e928b50644b37772ccbf176e74f766. Bug: 14062 Change-Id: I0759da2f9793cfb5cf92c9e231457bba43df4353 Reviewed-on: https://code.wireshark.org/review/23548 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-17Fix the trivial fix.Joerg Mayer1-2/+2
Change-Id: I95743eb53a3f30206a496163dea3b79f92a54b4e Reviewed-on: https://code.wireshark.org/review/23579 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-09-17ieee802.11: Add Element ID Extension dissector frameworkMasashi Honma1-5/+125
The IEEE Std 802.11ai-2016 and 802.11-2016 defines Element ID Extensions. This patch add the dissector framework of it. Change-Id: I47b21959cc115743d6b2f0c691bc41f3059d45cd Signed-off-by: Masashi Honma <masashi.honma@gmail.com> Reviewed-on: https://code.wireshark.org/review/23577 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-17ieee802.11: Add FILS authentication algorithm numberMasashi Honma1-0/+3
The IEEE Std 802.11ai-2016 defines new algorithm number for FILS(IEEE 802.11ai) at "9.4.1.1 Authentication Algorithm Number field" section. Change-Id: I4351682d38efab2727e3a36741fe2f49508bba14 Signed-off-by: Masashi Honma <masashi.honma@gmail.com> Reviewed-on: https://code.wireshark.org/review/23576 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-16Inquire what frame_size < msdu_length means.Guy Harris1-1/+6
Change-Id: Ie618ed61fb098bfe55529e31e9cc3f6bfe7d4ac0 Reviewed-on: https://code.wireshark.org/review/23575 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-16_U_ is wrong in c++, as is Q_UNUSED (in most cases).Joerg Mayer1-6/+6
The correct way is to not name the variable. interface_tree_cache_model.cpp is one of the exceptions: Use Q_UNUSED in a conditional compile, instead of unconditionally. Change-Id: If561e632a3a60d2424f454202f233e9a63926e78 Reviewed-on: https://code.wireshark.org/review/23570 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-09-16_U_ is wrong in c++, as is Q_UNUSED (in most cases).Joerg Mayer1-2/+1
The correct way is to not name the variable. Change-Id: Ic016f1b9161db6b4cc3f6534c853a1f50e31aa2b Reviewed-on: https://code.wireshark.org/review/23569 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-09-16make-version.pl: Update Wireshark version in User/Developer GuidesJoão Valverde3-2/+29
Change-Id: I5b14a6ae815e9e6e9c1705a8e38945e19dba479a Reviewed-on: https://code.wireshark.org/review/23554 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-16GTPv2: improve APN restriction IEJoakim Karlsson1-4/+24
Change-Id: Id5fd2a0c6b09a1127ab867bf2e5bc44a0cd2acd6 Reviewed-on: https://code.wireshark.org/review/23565 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-16cmake: Add -Wcomma as a warning flag.Stig Bjørlykke1-0/+1
Change-Id: I90827ac2cd2277a969d25996392ad1627fc6c530 Reviewed-on: https://code.wireshark.org/review/23566 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-16Add support for dissector tables of type FT_NONE.Michael Mann8-29/+185
This is for dissectors that have "payloads" that don't have a unique identifier to determine a sub dissector. For the command line parameter -d, specifying a selector is no longer required for dissector tables of type FT_NONE. Change-Id: I3370d9e0dc147deeca4f26b842fe35dc3bda876e Reviewed-on: https://code.wireshark.org/review/22574 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-16Have register_decode_as_next_proto create dissector table.Michael Mann17-108/+52
For protocols that have don't have a unique identifier for their payload, have register_decode_as_next_proto be a one stop shop to create Decode As functionality and a dissector table of type FT_NONE. Change-Id: Ic1f2e9ed0aee0554a4eb8f232630b99c0604dfc0 Reviewed-on: https://code.wireshark.org/review/22575 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-16Refactor Decode As dialog to use a model/delegateMichael Mann9-635/+1306
The model provides a lot more flexibility and abstracting the data from the view (dialog) Noticeable changes from user perspective: 1. Value column doesn't always have a combobox. If registered decode as structure doesn't support multiple values, a simple edit box is used. 2. Existing value will always be a choice (default) in the Value combobox. 3. Duplicate values in Value combobox have been removed (for things like UDP port where source port and dest. port are same) 4. When adding/copying a decode as item, only first column (table) is editable, not the whole column. 5. Separator always present in Current protocol column to distinguish "none" from rest of protocols. 6. "Current" protocol defaults to "default value" when first added to the list instead of "none". Noticeable changes from developer perspective: 1. Code is much more spread out, but most new additions (like DCE/RPC support) should be limited to the model class (maybe delegate). The dialog class probably won't change much anymore. 2. decode_as_dialog.ui is much less useful because information is provided through model and delegate. Change-Id: I70a667cab2c07d251ab370430bc51e5c1f4a3a02 Reviewed-on: https://code.wireshark.org/review/22625 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15gtp: add readable numbersJoakim Karlsson1-8/+8
Change-Id: I95f814d2a92d8c585db57f8ab32e6a84a8eeeb6d Reviewed-on: https://code.wireshark.org/review/23564 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15gtp: correct order of eARPJoakim Karlsson1-14/+14
Change-Id: Idc6d4d9c7f12521fa878f25ef66187fd286f017b Reviewed-on: https://code.wireshark.org/review/23563 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15gtp: update of MS Not Reachable ReasonJoakim Karlsson1-2/+5
Change-Id: I48c056ba7a532148275f6c1cea9cd3a916c70952 Reviewed-on: https://code.wireshark.org/review/23562 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15wireless-timeline: handle generators that report incorrect MCS for some framesSimon Barber2-8/+43
Macbook and QCA generators sometimes report the minimum MCS for subframes in an aggregate that have FCS errors. Change-Id: I77d1a81f5b3d0e3d0755adcb889f1237b0257814 Reviewed-on: https://code.wireshark.org/review/23521 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15btle: Add Bluetooth 5.0 LL Control PDUsStig Bjørlykke1-31/+269
* Dissect LL_PHY_REQ, LL_PHY_RSP, LL_PHY_UPDATE_IND and LL_MIN_USED_CHANNELS_IND. * Add Control Feature Set values. * Change Advertising Header Length from 6 bits to 8 bits (and removed RFU). * Change Data Header Length from 5 bits to 8 bits (and removed RFU). Change-Id: I453583fbb8c36dc87642c3c5087ab6dd77c46e45 Reviewed-on: https://code.wireshark.org/review/23536 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15wslua: Disable -Wunreachable-code in lua_bitop.cStig Bjørlykke1-0/+3
Some code is unreachable in some configurations. Change-Id: I23ff9a6032f4f7f6eb8e6607c6473a77a8bb6ac6 Reviewed-on: https://code.wireshark.org/review/23561 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15UMTS RRC: Call E.212 DissectorDarien Spencer3-37/+250
Calling E.212 dissector for MCC-MNC pairs/IMSIs found in RRC messages Change-Id: I1cbb4fe552323b65c761cdf7a721e8b93f297106 Reviewed-on: https://code.wireshark.org/review/23520 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-15wslua: Avoid possible misuse of comma operator warningStig Bjørlykke3-12/+24
Change-Id: I441359741332aa49fb91ded438cf2ec3d70b5e0f Reviewed-on: https://code.wireshark.org/review/23560 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15epan: Fix misuse of comma operatorStig Bjørlykke9-24/+42
Change-Id: I349dc9896db0bd306bc92f92eb9d4a65d98d309c Reviewed-on: https://code.wireshark.org/review/23558 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-15Qt: Use Q_UNUSED macro for unused argumentsStig Bjørlykke1-1/+2
Change-Id: I4bf7fe4ba3e3e6575e6537a8ec2b6024c253e776 Reviewed-on: https://code.wireshark.org/review/23559 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-15TLS13: add ticket_early_data_info extension (draft -18)Peter Wu2-0/+3
Code point 46 was used for "ticket_early_data_info" in draft -18 but removed in draft -19 since it was merged into "early_data". Change-Id: Ic382c697b55424fd4eb90f9a3d59b76ac0a2dd8a Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23542 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15Qt: initialize srt_data_ in constructor (CID 1417727)Pascal Quantin1-0/+3
Change-Id: I4977ff102f1ffb11a5ea956537dde3230b4323f7 Reviewed-on: https://code.wireshark.org/review/23550 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15epan: Avoid possible misuse of comma operator warningStig Bjørlykke2-3/+6
Change-Id: I73044cd71d21b5eef2e8350cf034f7801e169c16 Reviewed-on: https://code.wireshark.org/review/23552 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-09-15epan: Fix misuse of comma operatorStig Bjørlykke4-7/+7
Change-Id: Ie088dea1239286cb413ddcfc2a82e4a5e3fb9e0f Reviewed-on: https://code.wireshark.org/review/23551 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-15Fix compilation errors when configured --without-plugins and without lua.Jakub Zawadzki1-1/+6
filesystem.c: In function ‘init_plugin_pers_dir’: filesystem.c:1041:5: error: ‘plugin_pers_dir’ undeclared (first use in this function) plugin_pers_dir = get_persconffile_path(PLUGINS_DIR_NAME, FALSE); ^~~~~~~~~~~~~~~ filesystem.c:1041:5: note: each undeclared identifier is reported only once for each function it appears in filesystem.c: In function ‘get_plugins_pers_dir’: filesystem.c:1062:10: error: ‘plugin_pers_dir’ undeclared (first use in this function) if (!plugin_pers_dir) ^~~~~~~~~~~~~~~ Change-Id: I9ace17da42665d135b9432b1f19970491589e3bf Reviewed-on: https://code.wireshark.org/review/23545 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-15Qt: Don't show text as invalid in disabled widgetsStig Bjørlykke1-1/+1
In Interface Toolbar the text widget should not be shown as invalid when the widget is disabled. Change-Id: I100a338216b34874064cb9f808a36703157811a4 Reviewed-on: https://code.wireshark.org/review/23549 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-15autotools: Initial work to install headers for the benefit of pluginsJoão Valverde8-56/+82
Install public headers required to build plugins for libwireshark (taps and dissectors). The source tree is organized to serve the CLI/GUI parts of wireshark. Plugins are built in tree. This change is intende to allow plugins to be built out-of-tree but we want to avoid dumping all headers into /usr/include. To be continued incrementally to fix errors and omissions. Change-Id: Iaa0def0ba3de4b456a29114c315544d2d64fa748 Reviewed-on: https://code.wireshark.org/review/23374 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-29 05:30:11 +0000