aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-11-29tls-utils: use GnuTLS for RSA decryptionPeter Wu1-41/+54
Switch from RSA decryption using Libgcrypt to GnuTLS. This prepares for decryption using a PKCS#11 token. Requires GnuTLS 3.0.2 (or newer). Change-Id: Ic42d84c825488e1f45b443a3e56d01600dd594c9 Reviewed-on: https://code.wireshark.org/review/30833 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29Drop support for GnuTLS 2.12.x, require GnuTLS 3.2 or newerPeter Wu4-10/+9
Upcoming changes need GnuTLS >= 3.0.2. Require GnuTLS 3.2 (or newer) for licensing reasons. The Debian control file still mentions 3.2.14 because older packages linked with a GMP library that was not GPLv2+ compatible. RHEL6 only has 2.12.23, but is already unsupported anyway. Change-Id: I024b2a734ebb16b73a624bb2435c254e963d8b7d Reviewed-on: https://code.wireshark.org/review/30832 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29(D)TLS: defer RSA private key lookup until it is really neededPeter Wu4-67/+104
RSA private keys can only be used for decrypting TLS sessions with a full handshake that use the RSA key exchange. However currently the RSA private key is always looked up even if it cannot be used (for example, due to an (EC)DHE cipher or due to a resumed session). Defer lookup of these private keys and make some more code conditional on the availability of GnuTLS at compile time since future changes switch to GnuTLS for RSA decryption. Change-Id: I31dfd6cdfbd733818c798b1fb0e895cf5a987c5a Reviewed-on: https://code.wireshark.org/review/30831 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29Add sip_call_id filter to RTP stream.Anders Broman15-30/+95
Change-Id: Ia525fa74457eef03a3a8bc85905036c19693cfbb Reviewed-on: https://code.wireshark.org/review/30830 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29Win32: change DLL search path to accomodate extcap and NpcapPeter Wu2-34/+34
Extcap executables require libwsutil.dll from the program directory. These were loaded by setting the PATH environment variable, but this is not thread-safe (and caused sporadic tests failures as a result). Use SetDllDirectory instead, this also prevents loading DLL files from arbitrary directories in PATH. To make this work, the search logic for Npcap has to be modified to avoid relying on SetDllDirectory. This implies that Npcap cannot be used on Windows 7 anymore until KB2533623 (July 2011) is applied. Change-Id: I3fc42ff76e75ae162b6dd31103451fb8f71c09e6 Reviewed-on: https://code.wireshark.org/review/30804 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29DOCSIS: Added Downstream Resequencing TLV (25.17)Bruno Verstuyft2-0/+25
Change-Id: I496130e8abf6fe9996d886cd8ad7231005edf91a Reviewed-on: https://code.wireshark.org/review/30822 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29CMake: Change some install() paths to match NSIS packageJoão Valverde2-9/+36
Currently our Windows code looks for data files in the same folder as the binary executable (presumably to make the application relocatable, although it should be possible to improve this with relative paths?). Ping-Bug: 15301 Change-Id: I0fef4e87dc9d1d8edef81dd11755761fddd0fd12 Reviewed-on: https://code.wireshark.org/review/30819 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-11-29CMake: Enable install target on Windows (missing DLLs)João Valverde1-0/+8
Ping-Bug: 15301 Change-Id: I3146f43bcbae1abe566d96c8e9196019931474e2 Reviewed-on: https://code.wireshark.org/review/30818 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: João Valverde <j@v6e.pt>
2018-11-29CMake: Fix some transitive link dependenciesJoão Valverde6-46/+49
libwireshark and libwiretap have their INTERFACE link dependencies changed to the required set. libwsutil keeps a default public visibility. Further work may show some unneeded link requirements. The executable dependencies are adjusted accordingly. Change-Id: I3a534f72403819cac136ae47a3d80acee76e0fb3 Reviewed-on: https://code.wireshark.org/review/30815 Reviewed-by: João Valverde <j@v6e.pt>
2018-11-27IxVeriWave: Fix a buffer boundary.Gerald Combs1-2/+3
Pass the correct buffer size to find_signature so that we don't read past it. Bug: 15279 Change-Id: I822ed0fe8b48196dadd9c0062ed53fa1c4f6f404 Reviewed-on: https://code.wireshark.org/review/30809 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-27Fixup the "No Reassembly" profile.Gerald Combs2-5045/+103
Fix the pattern match in make-no-reassembly-profile.py. Have it only write changed preferences. Change-Id: I14f23a56f9ec598930591fae9eac2f14747c55bb Reviewed-on: https://code.wireshark.org/review/30805 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-27pvfs2: Add a pointer check.Gerald Combs1-0/+6
Make sure a pointer isn't NULL before trying to dereference it. Bug: 15280 Change-Id: If2686940a0347154d9a59f5e2141511e7e1f49a4 Reviewed-on: https://code.wireshark.org/review/30807 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27ZigBee ZCL: Fix a divide-by-zero.Gerald Combs1-1/+5
Fix a divide-by-zero in decode_color_temperature. Bug: 15281 Change-Id: I9460ffc85f6fe6b954c1810c3a80588c1aa4fec2 Reviewed-on: https://code.wireshark.org/review/30806 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27DOCSIS: Added Energy Management TLVsBruno Verstuyft2-6/+61
Change-Id: I2b1f71a0adb2e16a2b03fdc2138024773b1d792e Reviewed-on: https://code.wireshark.org/review/30802 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27TFTP: export object with correct tftp object dataJaap Keuter1-0/+1
Due to the lack of setting the size of the data objects, the exported objects file contains junk data. Set the actual size of the object data feed to the tap. Patch originally from Darius Davis <darius@vmware.com> Bug: 15304 Change-Id: I020a9f010e97f960e8a60b4c991acd0f678ec39c Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30803 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27Test: Look up our encoding name before checking it.Gerald Combs1-3/+3
Resolve our output encoding name to something that's hopefully the same on all platforms so that we don't print Warning: Output encoding is utf-8 and not UTF-8. on Windows. Change-Id: I9c7703eac6e12f5a95f701e8a9bea7d17a513fef Reviewed-on: https://code.wireshark.org/review/30795 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27Dumpcap: Adjust pcapng headers when we write them.Gerald Combs1-31/+25
When we capture from multiple interfaces, we won't necessarily write our IDBs in the same order we read them. This means that we need to call pcapng_adjust_block when we write packets, not when we read them. Otherwise we might map a given capture source's local interface number to the wrong global IDB entry. Bug: 15311 Change-Id: Ia787d7f167dcd18d432020a715e2321f4060b851 Reviewed-on: https://code.wireshark.org/review/30798 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27Add a "No Reassembly" profile.Gerald Combs5-0/+5176
Add a script that disables all of our desegmentation and reassembly preferences and use it to create a "No Reassembly" profile. Change-Id: Icd0b72e9e271a511e637acde9018f3aae018e589 Reviewed-on: https://code.wireshark.org/review/30799 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27nl80211: display interface name as a stringMartin Kaiser1-0/+6
The attribute value of the ifname attribute is a 0-terminated string that contains the interface name. Add an hf variable for this name and display it as a string. Change-Id: I0bd4caae49274f3e471a6eefb210db8d56f020f7 Reviewed-on: https://code.wireshark.org/review/30789 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27test: lua: add a test for invalid ethernet addressMartin Kaiser1-1/+5
Wslua converts an invalid ethernet address to all 0's. Add a test for this case. Change-Id: I59bd1f9e0b94805c563fe891b22cadd32ae054d8 Reviewed-on: https://code.wireshark.org/review/30791 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27nl80211: update fields to Linux v4.20-rc4Peter Wu2-3/+13
Fix `tools/generate-nl80211-fields.py --update` to match the output from v2.9.0rc0-1896-g43134ae252 ("netlink-*: fix various VALS/TFS misuse"). Update to match nl80211.h from Linux v4.19-rc6-1865-g0d4e14a32dca. Change-Id: I101146867a62f2f881752c42229a218c12d6dda7 Reviewed-on: https://code.wireshark.org/review/30794 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27BGP: Fix dissection of MCAST-VPN NLRIJaap Keuter1-1/+12
Due to a incorrect check the details of MCAST-VPN NLRI were never dissected. Also the Originating Router's IP Addr of a S-PMSI A-D Route was not dissected. Bug: 15307 Change-Id: Ic7481ed034e4cbf0dcab4aa150f05da2f5aac508 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30796 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-26PCAP: Add expert info to too long framesJaap Keuter1-1/+13
When frame data exceeds the snap length given in the PCAP file header, add an expert item warning of this inconsistency. Change-Id: I700fd987320d7505aee33158895ba32ec2b480f6 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30788 Tested-by: Petri Dish Buildbot Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-26TFTP: Repair block numbers truncated at 16 bits.Darius Davis1-12/+63
The TFTP protocol uses 16-bit block numbers. After block 65535, the block number simply wraps back to zero. This change implements recovery of the bits lost from the upper end of the block number, allowing for correct tracking of block numbers in large TFTP transfers. The resulting "Full Block Number" is added to the TFTP tree, marked as GENERATED; The "Full Block Number" is now used in all places which previously received the truncated 16-bit block number. An expert note is added when the block number at the protocol level is about to wrap around to zero. I chose to use 32 bits for the block numbers... even with the absolute-minimum blocksize (8 bytes), that allows for 32 GByte files to be correctly handled; With a more reasonable blocksize, it theoretically allows for files on the order of terabytes. Testing Done: On macOS 10.12.6, built Wireshark, and examined a handful of TFTP packet captures in the GUI, including the transfer of a large file (115,836 blocks of 1,456 bytes each). Observed that the packet info shows untruncated block numbers where previously the displayed block numbers would wrap back to zero after block number 65,535. Constructed a few packet captures with bizarre sequences of block numbers, and observed that they were dissected as expected. Checked that a display filter for "tftp.block" and "tftp.block.full" worked as expected. Bug: 15305 Change-Id: Ic72ca49c975b1db76e8c5653e64e2a7c34eede5d Reviewed-on: https://code.wireshark.org/review/30775 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-26CMake: Fix runtime destination for our librariesJoão Valverde4-4/+4
Ping-Bug: 15301 Change-Id: I7d461c696ce096b7687f71277a33295eb43ff8fc Reviewed-on: https://code.wireshark.org/review/30792 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-11-25test: lua: (trivial) fix indentationMartin Kaiser1-1/+1
Replace a TAB with spaces. Change-Id: I3d5c79af4116614ef78dd8a71eb42e93875c0637 Reviewed-on: https://code.wireshark.org/review/30790 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-11-25[Automatic update for 2018-11-25]Gerald Combs10-119/+86
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I4dbb483a58c10480b30da38ba234707344671222 Reviewed-on: https://code.wireshark.org/review/30785 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-11-25packet-icmp.c: Add some unused fields and fix a logic errorJoerg Mayer1-73/+46
- Adding rfc4884 support failed to properly add the unused fields if no length field was present. - The was a logic error when both length and MTU size were present. - reformat the lines in that section to no longer adhere to 80 columns Change-Id: I3bcca25cc7d5e866a040c5c6a8011144ebc3370e Reviewed-on: https://code.wireshark.org/review/30781 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-25Set direction correctly for Bluetooth H1 packetsAllan Møller Madsen1-1/+2
Fixes a bug where the packet direction was reversed for WTAP_ENCAP_BLUETOOTH_HCI (aka raw HCI or H1). Change-Id: I2f404ed543062818ac6a8c6ca58d5ecfd7644bc8 Signed-off-by: Allan Møller Madsen <almomadk@gmail.com> Reviewed-on: https://code.wireshark.org/review/30778 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-25[zigbee] add Daily Schedule (0x070d) cluster dissectorsNikolay Kovtun4-0/+522
Change-Id: I99b9b517ed534e4b9b7a148d384c55406174d024 Reviewed-on: https://code.wireshark.org/review/30771 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-25ws_pipe_spawn_*: fix deadlock in g_spawn on Linux with threadsPeter Wu1-2/+96
The deadlock can be observed with a slow malloc implementation, e.g. ASAN_OPTIONS=fast_unwind_on_malloc=0 tshark --version (This calls extcap_run_all which uses threads and ws_pipe_spawn_sync.) Change-Id: Iff329c465c53ed177980368cd645f59222f88dd3 Reviewed-on: https://code.wireshark.org/review/30777 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-25extcap: run --extcap-config in parallel to reduce startup timePeter Wu1-59/+257
While --extcap-interfaces is now run in parallel, --extcap-config (for each discovered interface) would only run sequentially after that. Make sure that the latter command also fully parallel and do not wait for all extcap interfaces to be discovered first. This saves another 80ms startup time on Linux (unoptimized ASAN+Debug). Change-Id: I303fd8fda647b304d5bdaf048a3d1628ec9e02b4 Ping-Bug: 15295 Reviewed-on: https://code.wireshark.org/review/30773 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-25diameter: remove message length limiterJoakim Karlsson1-10/+1
RFC 6733, ch3. specifies message length field as three octets and indicates the length of the Diameter message including headers and padding. Change-Id: I73694a085bbafb3ae280e02fa4c9e26868b31f76 Reviewed-on: https://code.wireshark.org/review/30772 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-25CMake: Workaround for broken install target on Windows (help)João Valverde1-1/+9
The installation step cannot depend on CMAKE_CFG_INTDIR. This step is executed in a cmake script without the build tool so variables like $(Configuration) of Visual Studio don't get substituted, breaking the installation. Ping-Bug: 15301 Change-Id: Idc0c48b6dc440ad1d9b2d6a2824cc89190997b60 Reviewed-on: https://code.wireshark.org/review/30784 Reviewed-by: João Valverde <j@v6e.pt>
2018-11-25Remove a stale FIXMEJoão Valverde2-4/+1
While at it prefer to use add_definitions() instead of config.h. This puts all definitions in the same place and limits the scope to the respective wsutil API. Change-Id: Idc30914220b876865e0ae47709e6f17eb9b0fc2c Reviewed-on: https://code.wireshark.org/review/30782 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-11-24Install development headers on all platformsJoão Valverde9-48/+27
Install headers to support plugins development on Windows. Change-Id: I3161bd2f730edf62ab44fee6ce4fedbb9aee0d31 Reviewed-on: https://code.wireshark.org/review/30776 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2018-11-24plugins.example: Fix build on WindowsJoão Valverde2-8/+9
Change-Id: I30798a697bc14076cc3bd9e224714a6a3567046b Reviewed-on: https://code.wireshark.org/review/30774 Reviewed-by: João Valverde <j@v6e.pt>
2018-11-23text2pcap: cleanup type usageJaap Keuter1-18/+12
The glib gboolean and integer types are used interchangably, while a proper use is easily achievable. While at it, replace the duplicate definition of the IPv4 source and destination addresses (endian sensitive). Change-Id: I5378544f370dc41962eb6303ddeeecb184db14f4 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30770 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-23TFTP: Improve dissection of ERROR packets.Darius Davis1-10/+79
Instead of annotating every TFTP ERROR packet as "TFTP blocksize out of range", let's flag them as TFTP error packets using their own expert info type. Let's also try to figure out whether an ERROR packet represents a "close" operation after a transfer-size ("tsize") query. Such ERROR packets aren't really errors, so we can use a separate expert info type to report those with lower severity. Testing Done: On macOS 10.12.6, built Wireshark, and examined a handful of TFTP packet captures in the GUI, including tsize probes and real errors (file not found, permission denied). From the menu, chose Analyze > Expert Information, and saw the tsize probes listed together at "Chat" severity, and actual errors reported at "Warning" severity, all appropriately labeled. Change-Id: I5605ce00559264ed94a47435c8f6d253f143fefb Reviewed-on: https://code.wireshark.org/review/30760 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-23RTPS: Extra fields dissected in RTI DDS field PID_TYPE_CONSISTENCY.ismaelrti1-3/+81
In RTI Connext DDS 5.3.3 and later PID_TYPE_CONSISTENCY has six new fields: Ignore Sequence Bounds, Ignore String Bounds, Ignore Member Names, Prevent Type Widening, Force Type Validation, Ignore Enum Literal Names. Change-Id: I456097a3baf733351dcb86f2cba0a3f03d2fc100 Reviewed-on: https://code.wireshark.org/review/30753 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-23RTPS: Topic Information Feature used with APP_ACK and APP_ACK_CONFismaelrti1-9/+16
packets. Topic Information Feature used to link packets belonging to the same topic now is used in APP_ACK and APP_ACK_CONF packets. Change-Id: Ib4e1dd4dfed41962bc76e8600a1213247a3bf588 Reviewed-on: https://code.wireshark.org/review/30752 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-23addr_resolv: fix crashes in parse_ether_address_fastPeter Wu1-10/+11
When no mask is allowed, reject addresses like "aa:bb:cc:...". Fix the type of 'cp' to avoid reading from a negative array index. Fix parsing, a nibble is four bits, not eight. Bug: 15297 Change-Id: Ibb0d0c17005b1e6213c09092e4b3c888a9024304 Fixes: v2.9.0rc0-2629-g3bb32ede26 ("addr_resolv: add fast path for parsing addresses from manuf") Reviewed-on: https://code.wireshark.org/review/30768 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-22text2pcap: make ethernet dummy header direction awareJaap Keuter1-4/+11
When giving the command line option '-D' and having 'I' and 'O' markers in the hexdump to import the IP addresses are adjusted, transport layer ports are adjusted, the TCP window information is adjusted, but still the frames originate from the same interface and go to the other interface. This changes makes it so that the Ethernet destination and source address is also adjusted with the direction indicated, to match the other adjusted addressing used. Bug: 15287 Change-Id: I762f195ece206ed14e6bca1c1160055df7c4dac1 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30767 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-22systemd Journal: More UTF-8 fixes.Gerald Combs1-58/+88
Display string fields as Unicode. Add more missing fields. Change-Id: I55f878ace7ccd6a66e3bac1e3fd2e388045ae3d8 Reviewed-on: https://code.wireshark.org/review/30765 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-22extcap: discover interfaces in a parallelPeter Wu2-132/+106
Split interface discovery in three stages: discover available programs (extcap_get_extcap_paths), obtain outputs for each (extcap_run_all) and processing of the output (process_new_extcap). The second step is most expensive, do it in parallel in multiple threads. extcap_foreach used to call extcap_if_exists, but as "cb_info.ifname" is always NULL for interface discovery, it would always pass. Remove this check and all other unused functions. This saves 100ms startup time on Linux with 7 extcap tools. Change-Id: I511e491d3b23c0a7f2fe2447842e87a9bd75adbe Ping-Bug: 15295 Reviewed-on: https://code.wireshark.org/review/30766 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-22extcap: simplify execution of single extcap programsPeter Wu1-30/+33
extcap_foreach has two purposes: discovery of all interfaces for each tool and querying info for an extcap interface. Observe that the latter requires extcap_if_exists(ifname) to be true. This makes extcap_foreach match exactly one interface, so we can avoid some complexity. Change-Id: I1842f50aa19553608ee5f2bb7bd8d94bba9629f2 Reviewed-on: https://code.wireshark.org/review/30764 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-22ws_pipe_spawn_sync: mark arguments as const where possiblePeter Wu3-6/+6
This avoids an unnecessary explicit cast. For clarity, rename the working directory argument to match g_spawn_sync. Change-Id: Idf7072cd590e686294d953f77da2a52c861a89c0 Reviewed-on: https://code.wireshark.org/review/30763 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-22ieee1609dot2: Call the j2735 dissector if it exists.Anders Broman3-5/+25
Change-Id: I80155d67e88f4f31ea688ed27d8eb5ab122a65e4 Reviewed-on: https://code.wireshark.org/review/30762 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-22oer: Octet string, value tvb was not returned in all cases if requested.Anders Broman1-0/+4
Change-Id: I57b8e4cb2dc4f16bee653872c3a71cbd09953107 Reviewed-on: https://code.wireshark.org/review/30761 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-11-22ws_pipe_spawn_sync: debug log elapsed timePeter Wu1-0/+4
Tested with `G_MESSAGES_DEBUG=all tshark --version`. Change-Id: Iae525b9de197f012c21693a91155f931d4dcc1f7 Ping-Bug: 15295 Reviewed-on: https://code.wireshark.org/review/30759 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 18:01:08 +0000