aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2012-12-26Eliminate multiple "const"s.Guy Harris1-1/+1
svn path=/trunk/; revision=46753
2012-12-26Widen an argument to match its (theoretical) widest possible width. SeeGuy Harris1-5/+6
if that squelches a loop-optimization warning. svn path=/trunk/; revision=46752
2012-12-26Squelch a (Y2.038K) warning.Guy Harris1-1/+1
svn path=/trunk/; revision=46751
2012-12-26OK, fine, maybe sometimes it's used; flag it with _U_ while we're at it.Guy Harris1-1/+1
svn path=/trunk/; revision=46750
2012-12-26If a parameter might be unused, mark it with _U_; don't stick in a fakeGuy Harris1-1/+1
usage. svn path=/trunk/; revision=46749
2012-12-26Fix a bunch of warnings.Guy Harris289-2464/+2352
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-25bssmap_msg_fcn[] is a dense array, not a sparse array, so *every* entryGuy Harris1-6/+7
must be filled in - even if we don't happen to have dissectors for particular message types. Just put NULL in there, so we don't index past the end of the array, grab a random location in memory's contents as a function pointer, and crash when we call through that pointer. svn path=/trunk/; revision=46747
2012-12-25More checks to make sure pinfo->private_data is not null.Guy Harris1-68/+71
svn path=/trunk/; revision=46746
2012-12-25Add some additional sanity checks.Guy Harris2-0/+8
svn path=/trunk/; revision=46745
2012-12-25Add support for -D option. The preamble will start withMichael Tüxen2-3/+43
an I or O indicating the direction of the packet. This will be stored in the generated file if the pcap-ng format is used. Thanks to Jaap for suggesting to integrate this into the preamble! svn path=/trunk/; revision=46744
2012-12-25In dissect_bthci_evt_command_complete():Guy Harris1-42/+45
Make a loop counter a full-width integer, just to be sure. Do *NOT* assume that pinfo->private_data is non-null; I have at least one capture where it is null when dissect_bthci_evt_command_complete() is captured. svn path=/trunk/; revision=46743
2012-12-25Fix writing of PCAP-NG files when flags are provided.Michael Tüxen1-3/+0
svn path=/trunk/; revision=46742
2012-12-25Remove current version of -D option, because:Michael Tüxen1-11/+1
* it is off by default * not documented * makes text2pcap to coredump when used * its goal is not clear (to me). I'm willing to reimplement it under a different option name if I understand what it should do. Then I can fix and test it. svn path=/trunk/; revision=46741
2012-12-25Add some debug output regarding preamble processing.Michael Tüxen1-4/+7
svn path=/trunk/; revision=46740
2012-12-25set the dtls record length for reassembly _before_ adding a fragmentMartin Kaiser1-2/+2
this is a workaround for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8111 it does not fully fix the underlying issue svn path=/trunk/; revision=46739
2012-12-25Clear preamble if no timespec is given.Michael Tüxen1-1/+4
svn path=/trunk/; revision=46738
2012-12-25Add support of -m option for SCTP.Michael Tüxen1-12/+23
svn path=/trunk/; revision=46737
2012-12-25Fix SCTP packet generation if DATA chunk headers needMichael Tüxen1-11/+18
to be generated. svn path=/trunk/; revision=46736
2012-12-25Fix bugs I introduced. NowMichael Tüxen1-6/+6
od -Ax -tx1 -v stream | text2pcap -m1460 -T1234,1234 - stream.pcap does work again. svn path=/trunk/; revision=46734
2012-12-25If there's no packet data, there's nothing to check to see whether thisGuy Harris1-3/+12
is an MPEG-2 transport packet, so don't treat it as one. svn path=/trunk/; revision=46733
2012-12-25Show the Vines Fragmentation Protocol control flags field as bitflags,Guy Harris1-37/+66
rather than as a single field. If bits other than the two defined bits are set in the first byte of the packet, don't dissect UDP packets as Vines FRP, so that other dissectors get a chance to look at the packet. svn path=/trunk/; revision=46732
2012-12-25Improve description.Michael Tüxen1-1/+1
svn path=/trunk/; revision=46731
2012-12-25Add option to suppress duplicate suppression.Michael Tüxen1-1/+1
svn path=/trunk/; revision=46730
2012-12-24The inverse of GINT_TO_POINTER() is GPOINTER_TO_INT(); use it. ThatGuy Harris1-5/+5
squelches some warnings. svn path=/trunk/; revision=46729
2012-12-24The inverse of GINT_TO_POINTER() is GPOINTER_TO_INT(); use it (thisGuy Harris1-1/+1
squelches some warnings). svn path=/trunk/; revision=46728
2012-12-24Cast away warnings implicit 64-bit-to-32-bit conversions. (We shouldGuy Harris2-9/+10
probably have routines that convert strings to numbers and do range checks, and should also ignore values in the recent and preferences files that are out of range.) Cast a string to "char *" to squelch an otherwise-unavoidable warning about qualifiers being ignored. The media type for raw binary data is application/octet-stream, not application octet_stream. svn path=/trunk/; revision=46727
2012-12-23From report of Elavarasan via ↵Alexis La Goutte1-23/+155
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8099 Named field for each item in Selected Registrar Config methods is not available The structure of both the Config Methods and Selected Registrar Config Methods are the same. Display filters such as "wps.config_methods.pushbutton", "wps.config_methods.display", etc are available for the different methods in the Config methods whereas the display filters for the elements in the Selected Registrar Config methods are found to be the same as the Config method Display filters. From me : add new filter for selected_registrar config method bitmask (and also permitted config method) svn path=/trunk/; revision=46725
2012-12-23Wireshark Aruba Dictionary is sync with FreeRadius Aruba DictionaryAlexis La Goutte1-4/+4
svn path=/trunk/; revision=46724
2012-12-23From Francesco Fondelli via ↵Alexis La Goutte2-7/+70
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8128 Add TCP Fast Open This patch provides i) support for Shared Use of Experimental TCP Options (draft-ietf-tcpm-experimental-options-03) ii) support for TCP Fast Open (draft-ietf-tcpm-fastopen-02). A new 'TFO=R' string is appended at the column info in case a client sends a SYN packet with a Fast Open Cookie Request. Moreover, if the server responds with a SYN-ACK containing a Fast Open Cookie option a 'TFO=C' is shown (as well as in any subsequent client attempt to send SYN + DATA). tcp.options.tfo display filter can be used in order to easily select the complete TFO three-way handshake. Chrome (and I think also Firefox) has support for client-side TFO. Linux 3.7 got both client and server-side support. svn path=/trunk/; revision=46723
2012-12-23Update Dictonary from FreeRadius(-server) Master branch ↵Alexis La Goutte6-0/+55
https://github.com/FreeRADIUS/freeradius-server Add RFC 5447 dictionary https://github.com/FreeRADIUS/freeradius-server/commit/9b988303148c024ac742536fe6e5e041abfdc9c6 Add RFC 6519 dictionary https://github.com/FreeRADIUS/freeradius-server/commit/383a99718178a597ef0d7a0b90add79e60b7a1cf Add RFC 6572 dictionary https://github.com/FreeRADIUS/freeradius-server/commit/8cc6e5a04d6a7f74b532920258b14f0f18ace002 svn path=/trunk/; revision=46722
2012-12-23[Automatic manuf, services and enterprise-numbers update for 2012-12-23]Gerald Combs3-22/+290
svn path=/trunk/; revision=46719
2012-12-23In nlsp_dissect_clvs(), count len down at the same time we increment theGuy Harris1-5/+5
offset, and do the bounds checking on the length before we count len down. svn path=/trunk/; revision=46718
2012-12-23Use the types that PortAudio specifies for values passed to or returnedGuy Harris1-14/+11
from PortAudio; that squelches some implicit 64-bit-to-32-bit conversion warnings. Mark unused arguments with _U_ rather than adding fake usages for them. svn path=/trunk/; revision=46717
2012-12-23More whitespace cleanups.Guy Harris1-82/+77
svn path=/trunk/; revision=46716
2012-12-23Add support for writing per packet comments when using pcapng.Michael Tüxen4-2/+32
Not actually used with this commit, which just brings in the infrastructure. svn path=/trunk/; revision=46715
2012-12-23When using pcapng, provide input file name as comment.Michael Tüxen1-3/+4
svn path=/trunk/; revision=46714
2012-12-23Fix syntax error showing up when using debug ouput.Michael Tüxen1-1/+1
svn path=/trunk/; revision=46713
2012-12-23Fix indentation.Guy Harris1-58/+54
svn path=/trunk/; revision=46712
2012-12-23Add ui_packet_comment_dialog.h and ui_time_shift_dialog.h.Gerald Combs1-1/+3
svn path=/trunk/; revision=46711
2012-12-23Qt .ui files are XML. Set their SVN properties accordingly.Gerald Combs0-0/+0
svn path=/trunk/; revision=46710
2012-12-23Qt: Implement packet comments. Fix packet detail updates.Gerald Combs18-17/+309
GTK+: Shorten the packet comment menu item name. Remove a couple of unneeded includes. Both: Add an arbitrary 20 MB limit when fetching all packet comments. Use a color from the Tango palette for comments. svn path=/trunk/; revision=46709
2012-12-23Add the time shift dialog.Gerald Combs3-0/+11
svn path=/trunk/; revision=46708
2012-12-22revert r46678Martin Kaiser1-2/+1
now that tvb_get_ephemeral_unicode_string() throws an exception for invalid length parameters, there's no point in doing an explicit check beforehand (when I added the check, there were many places that I missed) svn path=/trunk/; revision=46707
2012-12-22trivial: clean up epan/strutil.cMartin Kaiser1-767/+772
replace TABs with spaces add editor modelines svn path=/trunk/; revision=46706
2012-12-22check the length parameter for tvb_get_unicode_string() andMartin Kaiser1-0/+4
tvb_get_ephemeral_unicode_string(), throw an exception for invalid lengths (including -1, but length==-1 does not work for other tvb string functions either) I believe this is the proper fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8112 svn path=/trunk/; revision=46705
2012-12-22Define GTK_SCHEMAS_DIRAnders Broman1-1/+1
svn path=/trunk/; revision=46704
2012-12-22Put back the 'right' GTK3 bundlesAnders Broman1-4/+2
svn path=/trunk/; revision=46703
2012-12-22Remove unneeded initializations, and one redundant if condition.Evan Huus17-31/+31
svn path=/trunk/; revision=46702
2012-12-22Fox copy-and-paste error.Michael Tüxen1-2/+2
svn path=/trunk/; revision=46701
2012-12-22Remove one unneeded initializer and add one missing initializer, as foundEvan Huus2-2/+2
by CppCheck. svn path=/trunk/; revision=46700