aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-10-07typo: is require --> is requiredJeff Widman6-6/+6
2020-10-07LTE RRC: update message identifier value_string arrayPascal Quantin2-4/+68
2020-10-07NGAP: dissect some PWS related fieldsPascal Quantin3-161/+289
2020-10-07NGAP: Change "encyption" -> "encryption".Martin Mathieson3-32/+32
2020-10-07LTE RRC: upgrade dissector to v16.2.0Pascal Quantin14-1767/+1952
2020-10-07MC-NMF: Fix a couple of spelling errors.Martin Mathieson1-2/+2
2020-10-07BGP: remove useless assignmentsPascal Quantin1-2/+0
Closes #16896
2020-10-07E212: fix a test when checking MCC digitsPascal Quantin1-1/+1
Closes #16895
2020-10-07file-pcapng - Dissect the Darwin flags optionJim Young1-0/+82
2020-10-07Update some field names to match what's in RFCs.Gerald Combs4-25/+29
Update some field names and capitalization in the IPv4, IPv6, ICMPv4, and TCP dissectors to match the names documented in their respective RFCs. This is in no way comprehensive, but it ensures that the packet diagram more closely matches the RFC diagrams for those protocols. (I haven't found a document that explitly says so, but protocol field names in IETF RFCs seem to follow Chicago Manual of Style capitalization recommendations in section 3.4 of the RFC Style Guide[1] for the most part.) [1]https://tools.ietf.org/html/rfc7322#section-3.4
2020-10-06Update .mailmap after g2402521aPascal Quantin1-0/+1
Gitlab squash commits function did not pick the right user name
2020-10-06BSSAP: fix dissection of Control Channel bits in DLCIVadim Yanitskiy1-2/+2
According to 3GPP TS 48.006, section 9.3.2, Data Link Connection Identifier (DLCI) is coded as follows: .... .SSS - SAPI value used on the radio link; CC.. .... - control channel identification: 00.. .... - indicates that the control channel is not further specified, 10.. .... - represents the FACCH or the SDCCH, 11.. .... - represents the SACCH, other values are reserved. The following values in value_string 'bssap_cc_values': { 0x80, "FACCH or SDCCH" }, { 0xc0, "SACCH" }, are valid before applying CC_MASK (0xc0) mask, but not after.
2020-10-06Qt: Handle dark mode in syntax highlighting.Gerald Combs5-34/+71
Add ColorUtils::contrastingTextColor, which chooses an appropriate text color from the current application palette for a given background. Use it in SyntaxLineEdit and FontColorPreferencesFrame for each state background color. Fixes #15840.
2020-10-06SCTP: update PPI valuesEd2-1/+17
2020-10-06STUN: add an option to auto-detect STUN protocol versionNardi Ivan1-7/+36
Commit 3a5d0569d7 added support for different STUN protocol versions; a global preference allows the user to select the desired flavour. Unfortunately, it is pretty common to have different flavours in the same capture file, or even in the same packet (with STUN messages encapsulated in a TURN tunnel), so a global preference applied to the entire file might not provide enough flexibility. Add a basic auto-detect algorithm to identify the STUN version specific to each STUN message (the users will still have the option to force a global version)
2020-10-06MC-NMF: change get_size_length() signature to get rid of multiple castsPascal Quantin1-35/+30
2020-10-06MC-NMF: add some missing casts to please MSVCPascal Quantin1-6/+6
2020-10-06MC-NMF/MS-NNS: New dissector .NET Message Framing ProtocolUli Heilmeier3-0/+686
New dissector for MC-NMF (.NET Message Framing Protocol) and MS-NNS (.NET NegotiateStream Protocol). TLS implementation is not tested due to the lack of a sample capture. Fixes: wireshark/wireshark#16861
2020-10-05XnAP: fix the dissection of some NR and E-UTRA cell identity fieldsPascal Quantin2-116/+126
2020-10-05X2AP: upgrade dissector to v16.3.0Pascal Quantin19-317/+647
2020-10-05XnAP: upgrade dissector to v16.3.0Pascal Quantin9-292/+672
2020-10-05E1AP: upgrade dissector to v16.3.0Pascal Quantin9-156/+550
2020-10-05NGAP: upgrade dissector to v16.3.0Pascal Quantin9-351/+826
2020-10-05Only parse CRangeCategSpec record for CATEGORIZE_UNIQUE typeNoel Power1-1/+8
parse_CCategSpec was incorrectly always parsing the CRangeCategSpec record, this record however is optional depending on the value of CategType. (see MS-WSP 2.2.1.21) Signed-off-by: Noel Power <noel.power@suse.com>
2020-10-05S1AP: upgrade dissector to v16.3.0Pascal Quantin9-23/+28
2020-10-05[Automatic update for 2020-10-04]Gerald Combs25-1205/+2823
Update manuf, services enterprise numbers, translations, and other items.
2020-10-04Add some comments noting changes that should probably be made.Guy Harris1-0/+6
2020-10-04g_mallocate all strings returned from topic_action_url().Guy Harris2-15/+15
Callers assume it's been g_mallocated and attempt to free it.
2020-10-04Windows: fix WiX installerPascal Quantin1-1/+1
2020-10-04TLS: remove support for deprecated QUIC key formatPeter Wu1-7/+5
Since draft-ietf-quic-tls-17, QUIC uses TLS 1.3 base secrets for decryption, so no separate key label is necessary. Applications should not generate such non-standard key log entries. quiche has already been updated, picoquic will presumably follow soon if it has not already.
2020-10-04Fix a Coverity complaint.Guy Harris1-13/+14
For all cases in topic_action_url(), set url and break out of the switch statement. For the default case, set the URL to WS_HOME_PAGE_URL - we should never get there, as here's a g_assert_not_reached() call before that, but this should squelch Coverity's complaint. Should fix Coverity CID 1467697.
2020-10-03fbzero: do more detailed tag value offset checks.Guy Harris1-72/+171
Check the tag end offset - the offset in the packet of the tag's value's end - to make sure that 1) it's at or after the offset of the *beginning* of the tag's value and 2) that it's not past the end of the packet; in either case, report an error with an expert info, and do not show the value of that tag or any subsequent tags, as we don't have a valid value for the length of this tag's value or even the *offset* of subsequent tags' values. For tags whose values have a fixed length, report an error, with an expert info, if the tag value length isn't the expected value, and don't dissect it. For tags whose values have a minimum length, report an error, with an expert value, if the tag value length isn't at least the minimum value, and don't dissect it. For tags whose values consist of a sequence of zero or more fixed-length items, report an error, with an expert value, if there's leftover data after processing those items. Add some comments while we're at it.
2020-10-04Last batch of filter field string fixes.Martin Mathieson10-13/+13
There may still be some cases seen by ./toos/check_typed_item_calls.py --consecutive that ought to be fixed, but wasn't sure so left.
2020-10-03Fix more filter field strings.Martin Mathieson29-39/+39
These appear to be copy/paste errors detected by running ./tools/check_typed_item_calls.py --consecutive Quite a few issues still remain after this batch.
2020-10-03RTP: opus playbackLin Sun16-6/+328
It's possible to play opus payload with libopus (https://opus-codec.org/). Closes #16882. Helped-by: Pascal Quantin <pascal.quantin@gmail.com> Signed-off-by: Lin Sun <lin.sun@zoom.us> Signed-off-by: Yuanzhi Li <ryanlee@mail.ustc.edu.cn>
2020-10-03ICMP: Fix dissection of Interface Information Objectishaangandhi1-0/+2
If an address subobject was included, all subsequent subobjects (eg, interface name or MTU subobjects) would read from the same offset.
2020-10-03Update URLs pointing to the bug database.Guy Harris37-52/+53
Switch from bugs.wireshark.org to the GitLab issues list.
2020-10-03Nettrace: Fix fix to calculation of changetimeGuy Harris1-1/+1
A long time ago, in a galaxy far far away, C had arithmetic/logical- plus-assignment operators, so that a = a {op} x; could be written as a ={op} x; Unfortunately, if {op} is -, that meant that you could have, for example: a =- 17; which could be interpreted as a = -17; so they changed the operators to be a {op}= x; I.e., if you want to subtract 1000 from a variable, do elapsed_ms -= 1000; not elapsed_ms =- 1000;
2020-10-03Nettrace: Fix calculation of changetimeAnders Broman1-11/+17
Closes #16869 (closed)
2020-10-03FBZERO: Make sure our offset advances.Gerald Combs1-2/+12
Make sure our offset advances so that we don't infinitely loop. Fixes #16887.
2020-10-02Clean up URLs.Guy Harris84-198/+218
Add ui/urls.h to define some URLs on various of our websites. Use the GitLab URL for the wiki. Add a macro to generate wiki URLs. Update wiki URLs in comments etc. Use the #defined URL for the docs page in WelcomePage::on_helpLabel_clicked; that removes the last user of topic_online_url(), so get rid of it and swallow it up into topic_action_url().
2020-10-02LBMSRS: Break out of a loop.Gerald Combs1-1/+1
Break out of a loop if our offset advances. Fixes #16886.
2020-10-02Qt: point to Lua wiki page now on GitlabChuck Craft1-1/+1
2020-10-02QUIC: fix dissection of Short Header packets with Grease QUIC bitPeter Wu1-1/+1
The condition aimed to avoid interpreting padding bytes after the Initial Packet as Short Header to avoid breaking decryption. However it also prevents actual Short Header packets from being matched that have the QUIC bit cleared. To avoid breaking the latter, strengthen the condition to match the former only. Tested with quic-31_grease_quic_bit__with_keys.pcapng (from !429). Regression tested against a private Firefox Nightly trace.
2020-10-02TECMP: Adding CAS flag for FlexRayDr. Lars Völker1-0/+5
This adds the CAS (Collision Avoidance Symbol) to the TECMP dissector. Signed-off-by: Dr. Lars Völker <lars.voelker@technica-engineering.de>
2020-10-01Version: 3.3.1 → 3.3.2.Gerald Combs4-3/+7
2020-10-01Build: 3.3.1.Gerald Combs4-14/+128
2020-10-01EAP: Fix Dead StoreAlexis La Goutte1-4/+10
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
2020-10-01Qt: Use … instead of UTF8_HORIZONTAL_ELLIPSIS in translated strings.Gerald Combs33-70/+70
Run $ gsed -i -e 's/\(tr *(.*".*\)" *UTF8_HORIZONTAL_ELLIPSIS/\1…"/' $( ag -l 'tr *\(.*" *UTF8_HORIZONTAL_ELLIPSIS' ) $ gsed -i -e 's/\(tr *( *\)UTF8_HORIZONTAL_ELLIPSIS *"/\1"…/' $( ag -l 'tr *\( *UTF8_HORIZONTAL_ELLIPSIS *"' ) in ui/qt. As discussed in #16812, the UTF8_ macros were required at one time because we only allowed ASCII in our source code. However, that requirement has since been relaxed and Qt's translation framework doesn't handle concatenating strings and macros very well.
2020-10-01http: don't try to dissect zero-length bodiesRonnie Sahlberg1-0/+3
Closes #16844 Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 01:39:59 +0000