aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-12-14Use "(void) <variable/>" to avoid unused variable warnings similar toGerald Combs3-3/+10
Qt's Q_UNUSED macro. svn path=/trunk/; revision=54110
2013-12-14Fix some warningsJakub Zawadzki7-17/+15
svn path=/trunk/; revision=54109
2013-12-14sock diag netlink: dissect requests, stub for 'padding dissection'.Jakub Zawadzki1-14/+348
svn path=/trunk/; revision=54108
2013-12-14Rework code slightly to prevent VS Code Analysis warning:Bill Meier1-3/+5
C6326: Potential comparison of a constant with another constant svn path=/trunk/; revision=54107
2013-12-14More shorten-64-to-32 warnings.Gerald Combs4-25/+25
svn path=/trunk/; revision=54106
2013-12-14Use proto_tree_add_item() rather than fetching a string an adding it, ifGuy Harris1-9/+5
possible. If (possibly) not possible, use tvb_get_string_enc() rather than tvb_get_unicode_string(). svn path=/trunk/; revision=54105
2013-12-14Fix (I think) VS Code Analyzer warnings:Bill Meier1-2/+2
C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value svn path=/trunk/; revision=54104
2013-12-14Create/use several extended value-strings;Bill Meier3-206/+243
(Sort & remove dups from underlying value_string arrays); Reformat a few long lines; Add editor modelines; svn path=/trunk/; revision=54103
2013-12-14Fix VS Code Analysis warning:Bill Meier1-28/+41
C6297: Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. \ Results might not be an expected value 'offset++' --> 'offset += 1' for consistency; Add/adjust whitespace; Add editor modelines svn path=/trunk/; revision=54102
2013-12-14Cast away shorten-64-to-32 warnings.Gerald Combs1-5/+5
svn path=/trunk/; revision=54101
2013-12-14Squelch a bunch of shorten-64-to-32 warnings by parsing all of ourGerald Combs1-14/+16
numeric values using strtoul and casting it the result to a guint32. Hopefully no user or session IDs are negative or greater than 32 bits. svn path=/trunk/; revision=54100
2013-12-14Fix bug found by VS Code Analysis:Bill Meier1-101/+101
warning C6385: Invalid data: accessing 'tag_to_type', \ the readable size is '136' bytes, but '140' might be read svn path=/trunk/; revision=54099
2013-12-14Take a preemptive strike at some likely future VS Code Analyzer warnings ↵Chris Maynard1-3/+10
about strings possibly not being zero-terminated. svn path=/trunk/; revision=54098
2013-12-14xmpp_attr_info, xmpp_attr_info_ext: Pass pointer to hfJakub Zawadzki7-399/+398
This should fix most of warnings: initializer element is not computable at load time svn path=/trunk/; revision=54097
2013-12-14Prevent VS Code Analyzer warning; (AFAICT: not an actual bug).Bill Meier1-0/+3
svn path=/trunk/; revision=54096
2013-12-14Fix [-Wmissing-prototypes]Jakub Zawadzki103-74/+284
svn path=/trunk/; revision=54095
2013-12-14Set Proto col & Clear Info col before fetching data from the tvb;Bill Meier1-23/+23
Almost all of the dissection code can be under 'if (tree)'; Do some whitespace changes. svn path=/trunk/; revision=54094
2013-12-14Add a cast to silence an unnecessary warning.Evan Huus1-1/+1
svn path=/trunk/; revision=54093
2013-12-14Fix const warnings.Jakub Zawadzki29-46/+49
svn path=/trunk/; revision=54092
2013-12-14From Peter Paluch via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9158Evan Huus1-15/+61
Currently, the LLC dissector in packet-llc.c displays the values of DSAP IG bit and SSAP CR bit as separate items in the proto tree. This gives an impression that these entries are separate fields in the LLC header while in reality, they are only the least significant bits in DSAP/SSAP octets. In addition, the importance of these bits is relatively low in today's LLC-based protocols (they are mostly set to 0), so having them always displayed in the proto tree is somewhat of a luxury. Modify the LLC dissector by having added a subtree to both DSAP and SSAP items that displays the IG and CR bits as bits in a bitfield, and moved the display of IG and CR bits into these subtrees. It may seem that adding a text item instead of a FT_UINT8 value is not a sensible approach because such item is not filterable. However, if filtering by the entire DSAP/SSAP value (which is the typical way of filtering on SAPs), this value is always added to the tree in its entirety and indexed by "llc.dsap" and "llc.ssap" filter strings. If the GI or CR bit are to be matched, "llc.dsap.ig" and "llc.ssap.cr" filter strings are available. Searching for the value of the DSAP/SSAP & 0xFE which would be the value currently added by the proto_tree_add_text() is not done and should not be done, as IEEE stipulates: "An individual actual address value does not necessarily have any relationship with a group address of the same actual address value." (http://standards.ieee.org/develop/regauth/tut/llc.pdf) Following this consideration, the choice of displaying the SAP "actual address" using proto_tree_add_text() is acceptable. svn path=/trunk/; revision=54091
2013-12-14rdp_field_info_t struct: Pass pointer to hfJakub Zawadzki1-233/+233
This should fix most of errors: warning: initializer element is not computable at load time [enabled by default] svn path=/trunk/; revision=54090
2013-12-14Fix warningsJakub Zawadzki75-40/+204
svn path=/trunk/; revision=54089
2013-12-14Remove not needed ';'Jakub Zawadzki20-27/+27
svn path=/trunk/; revision=54088
2013-12-14Fix constiness of GET_VALSP() macro.Jakub Zawadzki1-1/+2
svn path=/trunk/; revision=54087
2013-12-14Allow -Wmissing-prototypes only for CJakub Zawadzki1-1/+1
It should fix: cc1plus: warning: command line option `-Wmissing-prototypes' is valid for Ada/C/ObjC but not for C++ [enabled by default] (only g++ complains, clang is OK with -Wmissing-prototypes) svn path=/trunk/; revision=54086
2013-12-14Fix some trivial warnings.Jakub Zawadzki58-24/+163
svn path=/trunk/; revision=54085
2013-12-14Use proto_tree_add_item() for UTF-16 strings when dissecting stringGuy Harris2-24/+23
descriptors. Make sure the length in string descriptors is at least 2, so that we have a valid string or string-list length. svn path=/trunk/; revision=54084
2013-12-14Fix string length typo causing unitialized-value warnings caught by valgrindEvan Huus1-1/+1
fuzzing. svn path=/trunk/; revision=54083
2013-12-14It seems sscanf requires the input string to be null-terminated, even if it isEvan Huus1-23/+17
longer than the maximum possible amount to read based on the format string. For this reason, don't use sscanf on tvb_get_ptr directly, copy and null-terminate the bytes we want. Fixes an uninitialized value caught by valgrind fuzzing. svn path=/trunk/; revision=54082
2013-12-14Add a bunch of tooltips.Gerald Combs1-7/+30
svn path=/trunk/; revision=54081
2013-12-13Pass the information from ATP to the conversation dissector.Guy Harris1-1/+1
svn path=/trunk/; revision=54080
2013-12-13It should halve warnings count in tn5250 dissector.Jakub Zawadzki1-378/+378
svn path=/trunk/; revision=54079
2013-12-13Fix warnings + remove some v. old comment from strutil.hJakub Zawadzki5-14/+16
svn path=/trunk/; revision=54078
2013-12-13Make sure all unused bits are 0 in bacapp, fixes uninitialized memory found byEvan Huus1-0/+1
valgrind. svn path=/trunk/; revision=54077
2013-12-13Rename spotlight_get_utf16_string_encoding() toGuy Harris1-19/+27
spotlight_get_utf16_string_byte_order(), and have it return ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN if it finds a BOM and 0xFFFFFFFF if it doesn't, to make it a bit clearer what it's doing. Use tvb_get_string_enc() rather than tvb_get_unicode_string(). svn path=/trunk/; revision=54075
2013-12-13In tvb_get_unicode_string(), if the byte count is odd, ignore the lastGuy Harris1-1/+5
byte. (We should perhaps add an expert info indication in those cases.) svn path=/trunk/; revision=54074
2013-12-13netlink: updateJakub Zawadzki4-72/+204
- set pinfo->p2p_dir based on portid - check for nlmsg type in dissect_netlink_sock_diag() - sock diag support LINUX_AF_INET6, LINUX_AF_PACKET - naming cleanup svn path=/trunk/; revision=54073
2013-12-13Change the exit status of a fuzz failure to 255 so that if you use it with xargsEvan Huus1-1/+1
the failures don't get suppressed. svn path=/trunk/; revision=54071
2013-12-13Note that apparently some BACnet implementations misuse the "ANSI X3.4"Guy Harris1-1/+3
encoding for ISO 8859-1; this means that those strings won't be correctly interpreted if they're interpreted as UTF-8. svn path=/trunk/; revision=54069
2013-12-13Simplify column sizing.Gerald Combs1-10/+5
svn path=/trunk/; revision=54068
2013-12-13Fix various issues:Bill Meier1-123/+128
- Display of header bit fields was incorrect; - Computation of the data length was incorrect; - Display of trailer 'indicator enable' & 'indicator' bit fields was incorrect; - 'Display' field of certain hf[] entries was incorrect. - Pedantic: Use ENC_BIG_ENDIAN instead of ENC_NA in certain places. See Bug #9539 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9539 svn path=/trunk/; revision=54067
2013-12-13Replace wmem_alloc with wmem_new in a few places, and wmem_new with wmem_new0 inEvan Huus1-16/+5
a few places to avoid uninitialized memory found while fuzz-testing with valgrind. svn path=/trunk/; revision=54066
2013-12-13Return FALSE from dissect_iwarp_mpa() if data is NULL. Note that this is ↵Chris Maynard1-1/+5
the conservative/safest approach since there do appear to be some code paths that don't rely on the data. svn path=/trunk/; revision=54065
2013-12-13Return FALSE from dissect_zbee_nwk_heur() if data is NULL.Chris Maynard1-1/+2
svn path=/trunk/; revision=54064
2013-12-13Add data arg to dissect_wassp_heur() in case it's ever used.Chris Maynard1-1/+1
svn path=/trunk/; revision=54063
2013-12-13Return FALSE from dissect_tapa_heur() if data is NULL.Chris Maynard1-1/+1
svn path=/trunk/; revision=54062
2013-12-13Add data arg to dissect_skype_heur() so it compiles cleanly if/when ↵Chris Maynard1-1/+1
SKYPE_HEUR is ever defined. svn path=/trunk/; revision=54061
2013-12-13Handle NFS4_OP_ILLEGAL (and other potential array bounds errors).Guy Harris1-4/+6
svn path=/trunk/; revision=54058
2013-12-13Remove _U_Chris Maynard1-1/+1
svn path=/trunk/; revision=54057
2013-12-13Add another check to radiotap-iter initialization to catch another out-of-boundsEvan Huus1-0/+2
read found while fuzzing with valgrind. Hopefully doesn't break valid captures. svn path=/trunk/; revision=54056
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-21 18:48:41 +0000