Age | Commit message (Collapse) | Author | Files | Lines |
|
There are some lines that show as changed in 'git gui', will see how
they look in gitlab..
|
|
From https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-smb2/16693be7-2b27-4d3b-804b-f605bde5bcdd
|
|
|
|
|
|
|
|
|
|
Remove the --check-addtext and --build flags. They were used for
checkAddTextCalls, which was removed in e2735ecfdd.
Add the sources in ui/qt except for qcustomplot.{cpp,h}. Fix issues in
main.cpp, rtp_audio_stream.cpp, and wireshark_zip_helper.cpp.
Rename "index"es in packet-usb-hid.c.
|
|
Fix support for Q050 and add support for T050 and T051.
For these 3 versions, add dissection of (at least) Initial Packets.
For salts and other info, see:
"A Guide to Parsing QUIC Client Hellos for Network Middlebox Vendors"
https://docs.google.com/document/d/1GV2j-PGl7YGFqmWbYvzu7-UNVIpFdbprtmN9tt6USG8/preview
Note these versions are actively used by Chrome right now.
Based on https://code.wireshark.org/review/#/c/37492/ done by @alagoutte
|
|
Done by scanning the asan1 template files. If there are spelling
mistakes in the specifications, we should ignore. Note that for z3950, I had
already found and accidentally fixed the same errors in the generated
file (before I taught my script to ignore gnerated dissector files).
|
|
|
|
|
|
|
|
Type 2 (Assistance Information Data) is still missing.
|
|
In the T11 version of FCOE, the length field was removed. If the last
four reported bytes don't look like the EOF plus padding, but the four
bytes before that do, then the Ethernet FCS is almost surely present so
treat it that way. Closes the other case of #4594
|
|
This is useful to dump the RTP payload using tshark without the need to
deactivate the sub dissector
|
|
Downgrade winflexbison3 to 2.5.18.20190508.
Related: #16824.
|
|
We started allowing source files to be encoded as UTF-8 in April 2019 in
bd75f5af0a. Update README.developer to match.
README.developer no longer has a "Code style" section, so update the
Developer's Guide to point to the "Portability" section.
|
|
Add ANSI codes and emoji so that the error stands out in the pipeline
output. Clarify the text.
|
|
|
|
|
|
|
|
|
|
Use UTF8 middle dot for non-printable characters in ShowPacketBytes to
clearly show the difference between a non-printable character and '.',
and to align with the PacketBytes view.
|
|
Closes #16822
|
|
|
|
Recommend checking "Allow commits from members..." when creating merge
requests.
|
|
Add a verify_merge_request routine to validate-commit.py. If the
required CI_MERGE_REQUEST_XXX environment variables are set it uses them
to query the GitLab API to see if "allow_collaboration" is true in the
current merge request.
This is a ham-fisted way of ensuring that committers can rebase and can
be removed if and when https://gitlab.com/gitlab-org/gitlab/-/issues/23308
is fixed.
|
|
Make sure we don't pass a huge number to wmem_array_grow. Closes #16809.
|
|
Git is currently broken in gitlab-runner 13.3.0 + Windows + Docker...
https://gitlab.com/gitlab-org/gitlab/-/issues/239013
...but it appears to work fine in gitlab-runner 13.2.0. I reverted the build machine to that version, so we can enable the merge-request:windows build.
|
|
Fetch time zone names using _tzname.
|
|
Set up a per-job cache directory and enable ccache as described at
https://gould.cx/ted/blog/2017/06/10/ccache-for-Gitlab-CI/
and
https://docs.gitlab.com/ee/ci/yaml/README.html#cache
Enable ccache in the merge-request steps.
Export DEB_BUILD_OPTIONS=nocheck while we're here.
|
|
Fixes #16741
|
|
|
|
|
|
Now that we're setting the C-language locale to use the UTF-8 code page,
they're already *in* UTF-8; g_locale_to_utf8() doesn't treat the
C-language locale's code page as the "locale" code page, it uses the
system code page, so it reads a UTF-8 string as being in some local code
page's encoding and proceeds to mangle it in the process of converting
it to UTF-8.
Closes #16811 (closed)
|
|
Make sure we allocate a new field.usages array for
USBHID_MAINITEM_TAG_OUTPUT as we do for USBHID_MAINITEM_TAG_INPUT.
Closes #16818.
|
|
Ignored "st_sort_casesensitve", as it will not normally be seen by users,
and changing it would lose the previous setting (if set).
|
|
Otherwise it triggers an assert when adding the column as the field is
defined as BASE_NONE and not BASE_DEC or BASE_HEX. Thus an unknown value
(not in proto_checksum_vals[)array) cannot be represented.
Mark the checksum as bad even if we process the packet.
Closes #16816
|
|
MBIM_CID_MS_UICC_APP_LIST
MBIM_CID_MS_UICC_FILE_STATUS
MBIM_CID_MS_UICC_ACCESS_BINARY
MBIM_CID_MS_UICC_ACCESS_RECORD
|
|
Portcontrol: Added support for option code 130 / Port-Set (RFC 7753)
Portcontrol: Made info column for Map Request / Response more helpful
|
|
|
|
Install lintian instead of devscripts (which pulls in lintian + many
other packages) in .gitlab-ci.yml. Add lintian to DEBDEPS_LIST in
debian-setup.sh.
|
|
Add an Expert info for zero length 8.76 CSG Information Reporting Action
IE.
|
|
The pre-T11 (pre August 2007) version of FCOE has a frame length, so it's
possible to set the length in order to help the Ethernet dissector determine
if a capture includes the Ethernet FCS, like how other dissectors do it.
This isn't possible in the standardized version, since the length field
was removed. Closes #4594.
|
|
|
|
Fix the following compiler warnings
packet-cl3.c:120:39: warning: 'tree' was marked unused but was used [-Wused-but-marked-unused]
ti = proto_tree_add_protocol_format(tree, proto_cl3, tvb, 0, header_length, "CableLabs Layer-3 Protocol (CL3) Version %u", (guint)version);
packet-cl3.c:136:32: warning: 'tree' was marked unused but was used [-Wused-but-marked-unused]
dissect_cl3_v1(tvb, pinfo, tree, ti, cl3_tree, header_length);
|
|
|
|
There will likely be one for for this pass. Further improvements to the
script are possible, i.e. filtering out (usually filter) strings such
as 'onetwothree' - may not be worth it though.
|
|
|
|
Added new CAN and TS packet dissectors, ETH dissector updated with the latest EBHSCR changes,
each protocol is handled in a separate function
|