aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-06-15gsm-a, nas-eps: enhance handling of missing mandatory i.e.Ivan Nardi8-453/+510
When a mandatory information element is missing, try to report an expert info, instead of throwing a fatal malformed exception (or of reporting nothing at all). According to TS 24.007 11.2.3, a mandatory i.e. may be part of the imperative part of the message, so that expert info should be at PI_ERROR level Change-Id: Id399c236f2923db36540bbda0d29d666548f7cbd Reviewed-on: https://code.wireshark.org/review/22134 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-15Add a comment indicating what releasw we're testring for.Guy Harris1-3/+3
This makes those tests more like other such tests. Change-Id: Ide920d4083f6092ce5892adf4fc178236c49729f Reviewed-on: https://code.wireshark.org/review/22150 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-15Make the short names for USB encspsulation types more regular.Guy Harris1-2/+2
Have them all be "usb-XXX", where XXX indicates the type of header. Change-Id: I7f1bfea7e264b17c57f94c484d64d1cce91b9b78 Reviewed-on: https://code.wireshark.org/review/22147 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-15Better names for various USB headers.Guy Harris1-2/+2
Change-Id: Iec2126fa1b71d9923ef0fb9ca2a027f7752d71f3 Reviewed-on: https://code.wireshark.org/review/22144 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-15Miscellaneous texual corrections and additionJaap Keuter3-3/+8
Correct some symbolic references in source file comments and add a note about the CMake configuration options. Change-Id: Idb670a2c798c2a52cdce142340ce8fc5a2022508 Reviewed-on: https://code.wireshark.org/review/22138 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-15udpdump.c: Don't include epan headers.Michael Mann1-3/+0
udpdump has local copies of the tag values from exported_pdu.h, so the dependency isn't needed. exported_pdu.h required tv_buff.h and packet_info.h, whose inclusion caused link errors on SPARC. Bug: 13801 Change-Id: Icbf7b59b8af0d3a0fc73599baad6932e76dc3462 Reviewed-on: https://code.wireshark.org/review/22131 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-15packet-btrfcomm.c: Prevent over bit shift in get_le_multi_byte_value.Michael Mann1-1/+1
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2163 Bug: 13783 Change-Id: I92cefec86f9545345d00cf28e32ef7c05064417c Reviewed-on: https://code.wireshark.org/review/22141 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-15packet-x11.c: Sanity check BIG-REQUEST lengthMichael Mann1-3/+3
Bug: 13793 Change-Id: I8863da14f889c68d161f4e53aa6a4e0d2636ba48 Reviewed-on: https://code.wireshark.org/review/22140 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-15TCP Analysis: Update the spurious retransmission check.Gerald Combs4-22/+37
The spurious retransmission check operates on the last-seen acknowledgment in the reverse direction. Adjust the analysis logic so that it is checked independently of the forward sequence number. Update the documentation accordingly. Change-Id: I3714f44398501a581f967c61e119fe95f90209b1 Reviewed-on: https://code.wireshark.org/review/21769 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-15infiniband: add RETH remote key to infinibandinfo structNitzan Carmi2-15/+19
RETH remote key might be needed in protocol's dissectors. Remote access key is shared out of band usually via RDMA send operation. This key sharing is upper layer protocol specific and protocol dissector knows about the key. infiniband layer do not know about which rkey is shared. For protocol dissectors to associate data packets with past command packets, infiniband needs to provide the rkey. Change-Id: I927116d649ed2b01c388afbcdb924cb7e5128e12 Signed-off-by: Nitzan Carmi <nitzanc@mellanox.com> Reviewed-by: Parav Pandit <parav@mellanox.com> Tested-by: Nitzan Carmi <nitzanc@mellanox.com> Reviewed-on: https://code.wireshark.org/review/22123 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-14RADIUS: Fix dissection for non-default VSA lengthsJoão Valverde1-7/+11
Ping-Bug: 13745 Change-Id: I1c9f69d0015ba9bea16d8300fbfd85abe110f829 Reviewed-on: https://code.wireshark.org/review/22136 Reviewed-by: João Valverde <j@v6e.pt>
2017-06-14IEEE 802.15.4: Fix IE/MIC handling of secured packets without payloadRobert Sauter1-7/+6
Change-Id: Icdcb770723e3783013f525524c3fe745d5dd862d Reviewed-on: https://code.wireshark.org/review/22122 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-14packet-lorawan.c: get_encryption_keys_app_eui must be included in ↵Michael Mann1-1/+1
GCRYPT_VERSION_NUMBER check Change-Id: I35d4ab99690839c3999e3fb5b471027271a81042 Reviewed-on: https://code.wireshark.org/review/22132 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-14[tap-rtp-common] Add EVS to mimetype_and_clock_mapAnders1-0/+1
Change-Id: I21b3d023c8644421059d84b0905ff264e991c8a8 Reviewed-on: https://code.wireshark.org/review/22127 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-14LoRaWAN: Use proto_tree_add_checksum for MIC verificationErik de Jong1-37/+51
Change-Id: Iaf705172496e26f571f77902bcc1a95f3b817c80 Reviewed-on: https://code.wireshark.org/review/22098 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-14DOCSIS: Prevent infinite loop from unknown FCParm.Michael Mann1-0/+4
concatlen was not updated if FCParm was unknown, leading to an infinite loop. Bug: 13797 Change-Id: I1b64d757a369183a711f01b0b5cd1ba7aa0787bc Reviewed-on: https://code.wireshark.org/review/22120 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-14WBXML: Fix some more potential infinite loops.Michael Mann1-5/+11
tvb_get_guintvar can generate some unrealistic values so do some sanity checking on them. Bug: 13796 Change-Id: I2d5f7a48c2e982a419ea6ab3ac0000be3b6bcbc7 Reviewed-on: https://code.wireshark.org/review/22121 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-14SMB2: Improve FILE_ALL_INFORMATION query response.Richard Sharpe1-3/+98
Add support for the fields Position Information, Mode Information and Alignment Information in the FILE_ALL_INFORMATION query response. Bug: 13800 Change-Id: I838fba1df26fe0f65394f0fe31b83645a707c166 Reviewed-on: https://code.wireshark.org/review/22117 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2017-06-14RADIUS: Add comment explaining WiMAX non-standard VSA formatJoão Valverde1-0/+14
Change-Id: I5b3417c94ab10d4ed22258bdb2ef0f670dd2b995 Reviewed-on: https://code.wireshark.org/review/22118 Reviewed-by: João Valverde <j@v6e.pt>
2017-06-13Don't use frame_length at all if we don't have libgcrypt >= 1.6.0 and ↵Guy Harris1-2/+1
encryption keys. Change-Id: Ia82fa67bbb9056204ed70b150f3d1e6db9ceed25 Reviewed-on: https://code.wireshark.org/review/22116 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-13Fix automatic name resolution not saved to NRBAnthony Coddington1-0/+4
Clear DUMMY_ADDRESS_ENTRY when add_ipv4_name/add_ipv6_name. This flag is checked in ipv4_hash_table_resolved_to_list(). TODO: clean up these flags as they are confusing and DUMMY appears somewhat redundant. Change-Id: I81d40cc778cbe5c36314631d3fa0997cee409368 Bug: 13798 Reviewed-on: https://code.wireshark.org/review/22109 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-13time() is a system routine; don't call a variable by that name.Guy Harris1-5/+6
That squelches a compiler warning. Change-Id: Ia39a9e5fe54a03e813bc3b82088ddf5de4a19c72 Reviewed-on: https://code.wireshark.org/review/22113 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-13[MEGACO] Add tman/sdr as an integer with a unit string.Anders4-5/+21
Change-Id: I987b4a9a86b0000b726f7e514be741e713b6ec5a Reviewed-on: https://code.wireshark.org/review/22112 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2017-06-13file-pcapng: fix capture filter dissectionPeter Wu1-2/+9
The pcapng spec[1] suggests that the first octet marks the filter type, but it is not clear whether this other types are implemented. Just skip over the byte for now. [1]: https://github.com/pcapng/pcapng/blob/c0dd7a7391/draft-tuexen-opsawg-pcapng.xml#L1083 Change-Id: I272dac55ea9ca3798e1fea45ce92023f7aa82564 Reviewed-on: https://code.wireshark.org/review/22043 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-06-13Fix isobus-vt warning when compiling using checkhf-conflicts.Jeroen Sack1-1/+1
Bug: 13772 Change-Id: I9690b88096bbd4a3dc8f082f9f485166e517a4a6 Reviewed-on: https://code.wireshark.org/review/22111 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-13fixed integer overflow in zigbee timestamp conversionMartin Boye Petersen1-5/+5
Change-Id: Ibc9e0a9285692ff95d28faf272c25d0e452f359c Reviewed-on: https://code.wireshark.org/review/22094 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-13Add support for dissecting FIND responses of FileIdFullDirectoryInfo type.Richard Sharpe1-0/+97
Simply had to copy an existing one and remove unneeded field etc. Fix bug 13795. Attached a capture showing the problem to the bug report. Change-Id: I93d5cdac3f336cbe0bd93db76a84bf97cbfa00ac Reviewed-on: https://code.wireshark.org/review/22106 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-13ssl: fix duplicate heuristics dissector registrationPeter Wu1-0/+12
Whenever a SSL preference is set (e.g. through tshark -ossl.psk:x), proto_reg_handoff_ssl is invoked. This is currently necessary for registering ports from the RSA keys table, but things like heuristics dissectors should be registered only once. Fixes warning during tests: "Protocol Secure Sockets Layer is already registered in "tcp" table Change-Id: I08fc9da524888e00eea7b0d0df54f3f0a3f08eb5 Fixes: v2.5.0rc0-109-ge815bbb2e6 ("ssl: add heuristics to detect SSL/TLS on non-standard TCP port") Reviewed-on: https://code.wireshark.org/review/22105 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-13Improve the HTTP2 dissector by not inserting empty padding, which looks ugly.Richard Sharpe1-9/+17
Change-Id: Ia01ae12fc9a22a7d0031c4580bbafe09f75881b5 Reviewed-on: https://code.wireshark.org/review/22104 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-13Fix the display of the IPv4 Hash Table in Resolved Addresses Dialog QT UIsfd1-2/+2
Was sign extending the key to 64-bit in Linux. GPOINTER_TO_UINT should not be stored in 'int', use guint. Change-Id: Ib4a994fdda5d69a589d3cffce644584103f2cd1d Reviewed-on: https://code.wireshark.org/review/22107 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-13Don't assume we have the libgcrypt MAC functions.Guy Harris1-3/+14
Not all the versions we support have them. Change-Id: I7851db692a0bff0fb22ab9d40c8d5f9dc3730fef Reviewed-on: https://code.wireshark.org/review/22108 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-12ieee802154: fix parameter 'p_inf_elem_tree_mlme' not found in the function ↵Alexis La Goutte1-1/+1
declaration [-Wdocumentation] Change-Id: I43eadb4be618163255297bb8a54bde4d6e537747 Reviewed-on: https://code.wireshark.org/review/22101 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12EPL (profiler parser): fix redundant redeclaration of ↵Alexis La Goutte1-2/+0
‘epl_wmem_iarray_is_empty/sorted’ [-Wredundant-decls] Change-Id: Ia969ffddc0035b18e7a4afc67d0c830f082938ea Reviewed-on: https://code.wireshark.org/review/22103 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12EPL: fix redundant redeclaration of ↵Alexis La Goutte1-2/+0
‘epl_profile_uat_fld_fileopen_check_cb’ [-Wredundant-decls] Change-Id: I44ba825648eb707942c4ea576c850c94f4891fb1 Reviewed-on: https://code.wireshark.org/review/22102 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12Add ISOBUS dissector to release notes.Jeroen Sack1-0/+1
Bug: 13772 Change-Id: I13726ec22fcec523fc837655fe5124a600639e39 Reviewed-on: https://code.wireshark.org/review/22095 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-06-12IEEE 802.15.4: Fix double offset increment for Time Correction Header IERobert Sauter1-10/+6
Regression by https://code.wireshark.org/review/21890/ Change-Id: Ieb90672dc2181f5951a8a4165e2676b7882282e5 Reviewed-on: https://code.wireshark.org/review/22087 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-06-12Extract errno value_strings from usb codePeter Wu7-149/+195
The convention of returning negative errno codes from the Linux kernel is not just limited to usb/usbip, it is also needed by netlink. Now netlink error codes are properly dissected. Also add ERFKILL and EHWPOISON (since 2009 and 2011) and change ESTALE and ENOSYS to match the current description as of Linux 4.7. Fixed header paths in comments too. Used this command to generate the table (with fixups for gaps): cpp -dM -CC include/uapi/asm-generic/errno.h | perl -ne '/^#define (E[A-Z0-9]+) ([0-9]+) \/\* (.+) \*\// && printf " { -%-4s \"%s (-%s)\" },\n", "$2,", $3, $1' | sort -k2 Change-Id: I16fa41a42bd4201a8383ea8e70a0aa8a597b311d Reviewed-on: https://code.wireshark.org/review/16952 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12ssl: add heuristics to detect SSL/TLS on non-standard TCP portPeter Wu1-0/+49
TLS is quite easy to identify. When you see prefix "17 03 01" (Application Data, TLS 1.0) or "15 03 01" (Handshake, TLS 1.0), it is likely TLS. Rather than requiring manual Decode As, add a heuristic. Note that the Application Data protocol might still require a manual Decode As if the ALPN extension is missing or if the protocol (like HTTP) is not registered as SSL/TLS heuristics dissector. Change-Id: I2eac2aded821d3fd100bc5627850b936fadb63f7 Ping-Bug: 13743 Reviewed-on: https://code.wireshark.org/review/22083 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12print_stream.c: Fix compile error on Windows regressionRobert Sauter1-1/+1
Put closing #endif inside function body. Regression by https://code.wireshark.org/review/22086/ Change-Id: I6f49dd45598c77c0a10c62f18f85fd7b99aba975 Reviewed-on: https://code.wireshark.org/review/22088 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12Dissector for LoRaWANErik de Jong4-0/+1374
Initial implementation of LoRaWAN dissector based on LoRa Alliance specification. Features: - Frame dissection for fields as per documentation - Payload decryption - MIC verification Not implemented: - Region specific information (frequencies etc) - Statistics Bug: 13775 Change-Id: I6031755dfd582dd78ed7c2566cdb390c577c9078 Reviewed-on: https://code.wireshark.org/review/22017 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12Add isobus dissectorJeroen Sack4-0/+6916
Bug: 13772 Change-Id: If7ddb10bfc8a1756e8ed00baaa8a28a7e2840a37 Reviewed-on: https://code.wireshark.org/review/21594 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12Add support for color xml attributes in psml and pdml formats.Michael Mann7-12/+37
Bug: 6682 Change-Id: I19330d06aa3d5692503c61369c3c650d595971f5 Reviewed-on: https://code.wireshark.org/review/22077 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stephen Donnelly <stephen.donnelly@endace.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-11Add a big comment about the ISO 8613-6/T.416 SGR support.Guy Harris1-9/+31
Also, the signature of print_color_escape() must be the same on Windows and UN*X; put the function body, but not the opening part of the definition, inside #ifdefs. Change-Id: I060e01d3280bfc4596a852211f5ab3c58d1e8642 Reviewed-on: https://code.wireshark.org/review/22086 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-11netflow: fix typo adresses => addressesAlexis La Goutte1-1/+1
Change-Id: I8578f86f75b1a7278ad71d8671ce4e2dbc4f0c82 Reviewed-on: https://code.wireshark.org/review/22081 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-11address(.h): fix typo adresses => addressesAlexis La Goutte1-2/+2
Change-Id: Ibc787005bb7865da55d2d8257009bace1108f181 Reviewed-on: https://code.wireshark.org/review/22082 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-11Ranap: improve heuristic algorithmIvan Nardi2-5/+33
Strength the heuristic cheking PDU-Type and Criticality field values too Change-Id: Id95603634a93033664bdbd169880e6b411cfbc11 Bug: 13791 Reviewed-on: https://code.wireshark.org/review/22076 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-11Don't colorize a line if we have no color filter.Guy Harris1-1/+1
There's no guarantee that there's a color filter that matches, so the color filter pointer might be null. Change-Id: Ia11845824a4ca9c0cc153a89aa2fba876084a796 Reviewed-on: https://code.wireshark.org/review/22079 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-11print.c: Remove unused hf_ variablesMichael Mann1-8/+0
Some hf_ variables were "cached" in print.c to break dependency on (frame) dissectors. They are no longer used (and check*.pl scripts found them) Change-Id: Ib46e5f5e58da54b6d7a3f85586581507f653c55a Reviewed-on: https://code.wireshark.org/review/22078 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-11Fix airpdcap compilation on SunPetr Sumbera1-0/+4
Bug: 13786 Change-Id: Iaa3890610768605b5c579aaddc73124b9f85bdd9 Reviewed-on: https://code.wireshark.org/review/22074 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-11tshark: add "--color" option emulating wireshark colorsDave Goodell3-8/+57
With this commit, tshark will mimic the packet coloring present in the Wireshark GUI whenever "--color" is passed. This initial commit only adds such support for the standard text output format. A future commit could potentially broaden this support to other output modes (such as "-V" mode). Bug: 5158 Change-Id: I59329e32475b0c67e28802e79610544d4868ea2d Reviewed-on: https://code.wireshark.org/review/21325 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>