aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2005-01-01When computing a hash value based on, among other things, aGuy Harris1-1/+1
conversation, use the "index" member of the conversation_t - that lets you get a value that fits in a guint, but without provoking the warning you might get from a compiler if you cast a pointer to the conversation to a guint. svn path=/trunk/; revision=12916
2005-01-01The right way to check whether a pointer is null and get a Boolean is toGuy Harris3-11/+11
test it against null, not to cast it to a Boolean type - as Boolean types in C89/C90, at least, are just integral types, that cast might just throw away the upper 32 bits; that probably yields the results you want, but the compiler might well justifiably warn about that on an LP64 platform. svn path=/trunk/; revision=12915
2005-01-01Get rid of some warnings about variables whose values might be lost in aGuy Harris3-3/+4
longjmp, by properly qualifying those variables as volatile. svn path=/trunk/; revision=12914
2005-01-01Make the signatures of functions passed to "register_tap_listener()"Guy Harris30-216/+248
match what "register_tap_listener()" expects (rather than squelching warnings about the differences by casting function pointers to "void *"). Make static some functions not used outside the module in which they're defined. svn path=/trunk/; revision=12913
2005-01-01Throw in a cast to squelch an (unavoidable, and probably harmless -Guy Harris1-1/+1
GTK+'s function signatures aren't necessarily what they should be) warning. svn path=/trunk/; revision=12912
2005-01-01"address_to_str()" and "address_to_str_buf()" don't modify the "address"Guy Harris2-4/+4
structure pointed to them by reference, so make the argument a "const" pointer. svn path=/trunk/; revision=12911
2005-01-01As we've made the tap_specific_data field of a tap_packet_t structure aGuy Harris41-209/+181
const pointer (so that we don't get complaints when we make the tap-specific data argument to "tap_queue_packet()" a const pointer, allowing dissectors to hand const data to a tap without a complaint), we should make the tap per-packet function take a const pointer as an argument as well. Do so. In some taps, use _U_, or actually use the argument, rather than sticking in dummy "X = X" assignments to fake use of parameters. (This means that the tap functions in question no longer have the notion that they act on a particular static structure wired in.) svn path=/trunk/; revision=12910
2004-12-31Note what Fibre Channel spec documents this protocol.Guy Harris1-25/+28
Don't assign the const pointers passed to hash routines to non-const pointers. In "zonenm_to_str()", don't assume there's a null terminator in the packet - use "tvb_get_string()" so that the buffer into which it's copied is explicitly null-terminated. Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string, rather than as a string with one blank in it. svn path=/trunk/; revision=12909
2004-12-31Don't bother copying the switch name to a buffer - we can just useGuy Harris1-3/+1
"tvb_get_ptr()". svn path=/trunk/; revision=12908
2004-12-31Fix a bug introduced in the previous checkin.Guy Harris1-3/+3
Make the names for list record types match the names used before the previous checkin. svn path=/trunk/; revision=12907
2004-12-31FC-over-IP is now covered by RFCs; update the specification references.Guy Harris1-15/+8
Make the protcol/version information an array of 8 bytes, not 2 guints; not all the world's a (little-endian) PC! svn path=/trunk/; revision=12906
2004-12-31Note what Fibre Channel spec documents this protocol.Guy Harris2-76/+102
Don't assign the const pointers passed to hash routines to non-const pointers. Don't use "tvb_get_ptr()" to get a pointer to a data structure, and dereference that pointer - there's no guarantee that the structure in question will be located on an appropriate boundary in the data from the packet (regardless of whether it's properly aligned within the data for the protocol being dissected). Put the record length for an EFP request into the protocol tree. Check the sanity of the payload length for that request. In "zonenm_to_str()", don't assume there's a null terminator in the packet - use "tvb_get_string()" so that the buffer into which it's copied is explicitly null-terminated. Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string, rather than as a string with one blank in it. svn path=/trunk/; revision=12905
2004-12-31Note what Fibre Channel spec documents this protocol.Guy Harris1-40/+27
Don't assign the const pointers passed to hash routines to non-const pointers. Don't assume that strings the spec says are null-terminated are necessarily null-terminated in the packet - use "tvb_strsize()" to find the length of the purported null-terminated string; it'll throw the appropriate exception if no null is found. svn path=/trunk/; revision=12904
2004-12-31Update some function declarations in the plugin apiLars Roland2-5/+5
svn path=/trunk/; revision=12903
2004-12-31From Luis Ontanon for Mate:Lars Roland7-134/+265
- moved gop and gog indexes into gopcfgs, which is a propedeutic change for upcoming changes in the way gops are to be grouped - changed the way gog-keys are kept in memory - every gopkey attribute is copied into the gop->extras to avoid redundancy in the configuration - added timers to gogs mate.gog_type.StartTime and mate.gog_type.Time - fixed a bug in scs_subscribe that mangled some strings - minor interface improvement to scs propedeutic to having types avp values in a future - changed medium and large into mate_medium and mate_large in the scs_collection - fixed Mode=Replace in Transforms, now it works - fixed a crash at reinit due to impropper initialization of mate_items svn path=/trunk/; revision=12902
2004-12-31Fix from Luis Ontanon:Lars Roland1-1/+1
Bring tap-h225counter.c in sync with newest revision of the h225 dissector svn path=/trunk/; revision=12901
2004-12-31Use "proto_tree_add_item()" to add a chunk of bytes to the protocolGuy Harris1-2/+2
tree. svn path=/trunk/; revision=12900
2004-12-31Don't assign const pointers to non-const pointers, especially if theGuy Harris1-2/+2
object pointed to by the non-const pointer won't be modified. svn path=/trunk/; revision=12899
2004-12-31"string_to_hex()" doesn't modify its first argument, so make it aGuy Harris1-2/+2
"const" pointer, and don't cast away the constness of "tvb_get_ptr()"s result when passing it to "string_to_hex()". svn path=/trunk/; revision=12898
2004-12-31Don't cast away the constness of pointers passed to "ip_to_str()" -Guy Harris1-2/+2
"ip_to_str()" takes a "const guint8 *" argument. svn path=/trunk/; revision=12897
2004-12-31There are no guarantees that "strncasecmp()" works withGuy Harris1-3/+5
non-null-terminated strings, so be safe and fetch the metatag string with "tvb_get_string()". svn path=/trunk/; revision=12896
2004-12-31Use "tvb_memeql()" to check whether specified bytes in a packet have aGuy Harris1-6/+6
specified value. Make a constant array "const". svn path=/trunk/; revision=12895
2004-12-31Don't cast away the constness of argument pointers.Guy Harris1-8/+27
Don't supply our own definition of AF_INET or our own declaration of "inet_pton()" - use the system ones if they're available. "mkipv4_address()" doesn't modify the string passed to it - make it a const pointer. svn path=/trunk/; revision=12894
2004-12-31Don't roll our own code to display IPv4 or IPv6 addresses, useGuy Harris1-19/+41
"ip_to_str()" and "ip6_to_str()". Check the length of items for IPv4 and IPv6 addresses before displaying them as such. svn path=/trunk/; revision=12893
2004-12-31Don't assign the const pointers passed to hash routines to non-constGuy Harris1-8/+8
pointers. Now that "col_set_str()" takes a "const char *" as the second argument, we don't have to cast away the constness of strings passed to it. svn path=/trunk/; revision=12892
2004-12-31Don't assign a const pointer argument to a non-const pointer variable.Guy Harris1-1/+1
svn path=/trunk/; revision=12891
2004-12-31Don't assign the const pointers passed to hash routines to non-constGuy Harris6-18/+18
pointers. svn path=/trunk/; revision=12890
2004-12-31Properly cast the pointer assigned to col_info->col_data.Guy Harris1-1/+1
svn path=/trunk/; revision=12889
2004-12-31"proto_registrar_get_byname()" doesn't modify its argument, so make itGuy Harris2-2/+2
"const char *". svn path=/trunk/; revision=12888
2004-12-31Make arguments "const *" if the routine doesn't modify the object toGuy Harris2-10/+15
which they point. svn path=/trunk/; revision=12887
2004-12-31Make sure print_buff is \0-terminatedJörg Mayer1-0/+1
svn path=/trunk/; revision=12886
2004-12-31As pointed out by Guy: We should be able to filter on the original SSID,Jörg Mayer1-2/+5
so use a copy of the existing one for printing. svn path=/trunk/; revision=12885
2004-12-31In column sort routines, make the row pointers "const" pointers, as theGuy Harris8-16/+16
arguments passed in corresponding to those pointers are gconstpointers. svn path=/trunk/; revision=12884
2004-12-31As "get_persconffile_path()" doesn't return a "const char *", neitherGuy Harris2-9/+8
does "get_plugins_pers_dir()" - and "get_plugins_global_dir()" doesn't return one either. Both of them return mallocated data, and making them return a "const char *" just causes compiler whining when you try to free them. svn path=/trunk/; revision=12883
2004-12-31"get_persconffile_path()" doesn't return a "const char *", it justGuy Harris1-3/+3
returns a "char *", so don't assign its return value to a "const char *". svn path=/trunk/; revision=12882
2004-12-31"gtk_entry_get_text()" returns a "const char *" - assign the result toGuy Harris14-84/+79
one. "get_basename()" doesn't modify its argument, and its callers don't modify the substring pointed to by the result, so make it take a "const char *" as an argument and return a "const char *". "find_last_pathname_separator()" doesn't modify its argument, so make it a "const char *" - but some of its callers pass a non-"const" "char *" and modify the result, so don't make its return value a "const char *". And, as none of its callers are outside "filesystem.c", make it static. In "about_folders_page_new()", have separate variables for pathnames returned as "const char *" (which are cached by the routine that returns them, so you can't modify them - and can't free them, so get rid of the commented-out "g_free()" calls for them) and pathnames returned as "char *" (which are allocated anew for each call, and can be modified, but have to be freed). Clean up white space. svn path=/trunk/; revision=12881
2004-12-31Make the "col_data" field in a "column_info" structure a pointer to anGuy Harris2-2/+2
array of "const char *" rather than to an array of "char *", and make the second argument of "col_set_str()" a "const char *" - there's no guarantee that "col_data" points to something you're allowed to modify. svn path=/trunk/; revision=12880
2004-12-31Add a "tvb_bytes_to_str_punct()" routine, which wrapsGuy Harris1-0/+2
"bytes_to_str_punct()", and use it instead of extracting the bytes and formatting them by hand. Also, export "bytes_to_str_punct()". svn path=/trunk/; revision=12879
2004-12-30Make the "col_data" field in a "column_info" structure a pointer to anGuy Harris1-1/+1
array of "const char *" rather than to an array of "char *", and make the second argument of "col_set_str()" a "const char *" - there's no guarantee that "col_data" points to something you're allowed to modify. svn path=/trunk/; revision=12878
2004-12-30The first argument to "adler32_bytes()" is only passed on toGuy Harris2-3/+3
"update_adler32()", and the corresponding argument is a "const unsigned char *", so that argument can be a "const unsigned char *". svn path=/trunk/; revision=12877
2004-12-30Add a "tvb_bytes_to_str_punct()" routine, which wrapsGuy Harris3-6/+22
"bytes_to_str_punct()", and use it instead of extracting the bytes and formatting them by hand. svn path=/trunk/; revision=12876
2004-12-30Make the "col_data" field in a "column_info" structure a pointer to anGuy Harris4-25/+25
array of "const char *" rather than to an array of "char *", and make the second argument of "col_set_str()" a "const char *" - there's no guarantee that "col_data" points to something you're allowed to modify. svn path=/trunk/; revision=12875
2004-12-30We now require gint64/guint64 support to build Ethereal, so get rid ofGuy Harris1-56/+2
the #ifdefs. Don't use "%ll[doux]" - not all platforms use "ll" as the length specifier for 64-bit integers in formats. Use PRI[doux]64 instead, to handle platforms where some other length specifier is used. svn path=/trunk/; revision=12874
2004-12-30Change a function name in preparation for genereating H.245 and H.225 ↵Anders Broman2-4/+4
dissectors with asn2etrh svn path=/trunk/; revision=12873
2004-12-30Change a function name in preparation for genereating H.245 and H.225 ↵Anders Broman1-1/+1
dissectors with asn2etrh svn path=/trunk/; revision=12872
2004-12-30Change a function name in preparation for genereating H.245 and H.225 ↵Anders Broman1-1/+1
dissectors with asn2etrh svn path=/trunk/; revision=12871
2004-12-30Regenerate.Guy Harris5-6/+6
svn path=/trunk/; revision=12870
2004-12-30Fix the declaration of "tap_queue_packet()" to match its new signature.Guy Harris1-1/+1
svn path=/trunk/; revision=12869
2004-12-30From Vincent Jardin: Fix the dissection of relayed messages.Gerald Combs1-84/+58
svn path=/trunk/; revision=12868
2004-12-30Add "get_addr_name()" to the list of items exported by libethereal.Guy Harris1-0/+1
svn path=/trunk/; revision=12867
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-06 18:02:28 +0000