aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2005-09-15Add PRIX64, as we now use it.Guy Harris3-4/+14
svn path=/trunk/; revision=15811
2005-09-15Replace the spnego dissector with an asn2eth generated one.Anders Broman7-1015/+1915
svn path=/trunk/; revision=15810
2005-09-15Rename TLV_INFO_MASK to TLV_INFO_LEN_MASK, to match TLV_TYPE_MASK.Guy Harris1-68/+123
Use "tvb_format_stringzpad()" rather than "tvb_format_text()" on strings, as some of them are null-padded. (XXX - are they null-padded or null-terminated?) Clean up the TLV length checks, and do many more such checks. svn path=/trunk/; revision=15809
2005-09-15We already define ETHERTYPE_LLDP in "etypes.h" - use that, don't defineGuy Harris1-659/+594
our own. Get rid of MAC_to_str() - ether_to_str() suffices. Don't copy to on-the-stack fixed-size string buffers, just save the results of various formatting calls as pointers. Use tvb_format_text() to get displayable versions of text strings. Use tvb_get_ipv4() and tvb_get_ipv6(). Don't put an item into the protocol tree as text and then put in a hidden item that, if unhidden, would display the same or almost exactly the same; just put the item into the tree unhidden. svn path=/trunk/; revision=15808
2005-09-15Properly handle 64-bit integer constants (they don't happen by magic,Guy Harris1-23/+23
and the stuff you have to do is compiler-dependent, so use G_GINT64_CONSTANT()). Properly handle formatting 64-bit quantities (they don't format correctly by magic, and the stuff you have to do is compiler-dependent, so use PRI[duoxX]64). Don't copy the result of tvb_bytes_to_str() to a string buffer and then only use it as an argument to a "%s" - just use the result directly. Don't copy constant strings to a buffer - just use the strings directly. Fetch 64-bit integral quantities with tvb_get_ntoh64(); they're presumably in a standard byte order, which is probably big-endian for Internet-family protocols, and using tvb_memcpy() is *guaranteed* to be wrong on some platforms. Fix up a format string. Fix up indentation a bit. svn path=/trunk/; revision=15807
2005-09-15Squelch some warnings, fix some typoes.Guy Harris1-3/+3
svn path=/trunk/; revision=15806
2005-09-14fix wtap_dump_flush function name and don't check for it's return value. We ↵Ulf Lamping1-4/+1
don't do this check in Ethereal either and we will recognize problems at next write anyway ... svn path=/trunk/; revision=15805
2005-09-14added compression support for capture file output. The Save/As dialog now ↵Ulf Lamping14-123/+272
has a checkbox "Compress with gzip" currently limited to Ethereal and all the variants of libpcap filetypes only. We might want to add output compression support to the other tools as well (tethereal, mergecap, ...). We might also want to add support for the other filetypes, but this is only possible if the filetype functions doesn't use special output operations like fseek. One bug is still left: if the input and output filetypes while saving are the same, Ethereal currently optimizes this by simply copy the binary file instead of using wiretap (so it will be faster but it will ignore the compress setting). Don't know a good workaround for this, as I don't know a way to find out if the input file is currently compressed or not. One idea might be to use a heuristic on the filesize (compared to the packet size summmary). Another workaround I see is to remove this optimization, which is of course not the way I like to do it ... svn path=/trunk/; revision=15804
2005-09-14add E_OUTOFMEMORYUlf Lamping1-0/+1
svn path=/trunk/; revision=15803
2005-09-14From Peter JohanssonAnders Broman1-1/+1
I added a description for the call to DISSECTOR_ASSERT in proto.c to be printed to stderr. svn path=/trunk/; revision=15802
2005-09-14Fix a warning.Anders Broman1-1/+1
svn path=/trunk/; revision=15801
2005-09-14From Brian Bogora:Anders Broman3-0/+2203
Our company (Mitel) has developed an LLDP-MED plug-in for Ethereal. svn path=/trunk/; revision=15800
2005-09-14From Dinesh G DuttAnders Broman8-81/+808
Support some new messages and fix a couple of bugs. packet-fc.h - Added a #define for a Cisco MDS-specific frame called OHMS (online health mgmt srv) packet-fc.c - Support for OHMS frame, fixed an incorrect "malformed frame" error caused on ACK1 frames (they don't contain anything but (encap hdr + FC hdr + encap trailer), fixed incorrect detection of last-data-frame packet-fcct.h - Support for new service type, "Fabric Controller", used in conjunction with FC-SW3 ESS message, exported the service name value string definitions and packet-fcct.c - Support for recognizing "Fabric Controller" service type and "vendor-specific" service packet-fcswils.h - Support for ESS & MRRA messages, defined as part of FC-SW3 packet-fcswils.c - Support for ESS & MRRA messages, defined as part of FC-SW3 packet-scsi.c - Support for Verify and Write&Verify SBC commands. svn path=/trunk/; revision=15799
2005-09-14Do the variable binding with dissect_ber_x() routines rather than asn1 ones.Anders Broman1-63/+80
svn path=/trunk/; revision=15798
2005-09-14Dont't carsh if dissect_ber_null() isn't passed a hf_id.Anders Broman1-2/+2
svn path=/trunk/; revision=15797
2005-09-14Allow dissection of dcerpc of short frames instead of aborting as soon as ↵Ronnie Sahlberg1-68/+74
it is detected the pdu is "short" svn path=/trunk/; revision=15796
2005-09-14for octet strings that span beyond the end of a "short" tvb, create a new ↵Ronnie Sahlberg1-4/+7
subset tvb of what we have and use that instead of bailing out completely. svn path=/trunk/; revision=15795
2005-09-14when we have raw keberos inside the spnego blob, pass it as is over toRonnie Sahlberg1-2/+1
the kerberos dissector and do not strip the ber tag and lengths off svn path=/trunk/; revision=15794
2005-09-14Have cf_retap_packets() take an argument that indicates whether toGuy Harris29-42/+44
generate columns; use cf_retap_packets instead of cf_redissect_packets() when running taps (the general flow graph stat uses the Info column). svn path=/trunk/; revision=15793
2005-09-14fix #388: add /desktopicon and /quicklaunchicon command line options to the ↵Ulf Lamping2-6/+51
NSIS installer update the User's Guide accordingly svn path=/trunk/; revision=15792
2005-09-13Move "Expert Info" from "Statistics" to "Analyze" menu item.Ulf Lamping1-61/+142
*significantly* improve performance (100000 infos from ~5min to 25sec!) Add a simple severity based filter mechanism. replace // style comments by /**/ svn path=/trunk/; revision=15791
2005-09-13Turn around the sequence of PATH, so the former PATH will be in front of the ↵Ulf Lamping1-1/+10
newly added things. This way, the cygwin link.exe command will be behind the link.exe from MSVC. Also added a definition of the docbook dir, floating around in my personal file for a while. This will be needed if the User's Guide is included in the NSIS installer later. svn path=/trunk/; revision=15790
2005-09-13In smb_trans_defragment(), throw an exception if we encounter a too-largeGerald Combs2-0/+17
fragment size. The limit is conservatively set at 65536 bytes. It may have to be increased. Fixes bug 421. Add an entry to the release notes. svn path=/trunk/; revision=15789
2005-09-13implement a way to add menu items to the "Analyze" menuUlf Lamping2-1/+9
svn path=/trunk/; revision=15788
2005-09-13don't crash with a NULL pointer exception, if "do not decode as" is usedUlf Lamping1-5/+5
svn path=/trunk/; revision=15787
2005-09-13add to the protocol item a short description what a "Short Frame" isUlf Lamping1-1/+1
svn path=/trunk/; revision=15786
2005-09-13increment index of IID's in COL_INFOUlf Lamping1-1/+1
svn path=/trunk/; revision=15785
2005-09-13use the same name for menu item and dialog box title, use the right ↵Ulf Lamping1-2/+2
capitalization for both svn path=/trunk/; revision=15784
2005-09-13Get application ID from the packet.Anders Broman1-22/+22
svn path=/trunk/; revision=15783
2005-09-13From Peter JohanssonAnders Broman1-7/+10
PATH contents one had before starting the build, that PATH is added to the new PATH variable 5 additional times instead of 1. I have made changes (supplied) to config.nmake that takes care of this problem. svn path=/trunk/; revision=15782
2005-09-13don't simply remove the expert_info output at BoundsError, but add the ↵Ulf Lamping1-0/+5
comment from Guy why this (usually) isn't a bug (because of a short snapshot length). svn path=/trunk/; revision=15781
2005-09-13From Ankur Aggarwal:Anders Broman1-5/+5
First phase of testing revealed the following errors svn path=/trunk/; revision=15780
2005-09-13From Stefan MetzmacherAnders Broman1-18/+79
Some updates to the winsrepl-dssector to add COL_INFO strings... svn path=/trunk/; revision=15779
2005-09-13From Alejandro Vaquero.Anders Broman2-54/+69
svn path=/trunk/; revision=15778
2005-09-13From Piros Lucian:Anders Broman4-0/+1030
A new dissector - cimd dissector. CIMD stands for Computer Interface to Message Distribution and it's used to transfer short messages between applications and Nokia Short Message Service Center. svn path=/trunk/; revision=15777
2005-09-13Move the definition of GNUC_FORMAT_CHECK() to its own header, use it inGuy Harris6-32/+54
column-utils.h, and add it to expert.h, so we check the arguments to "expert_add_info_format()", at least if the format argument is a constant string. Fix some more calls to "expert_add_info_format()" to pass it a format string. Don't record BoundsError exceptions as expert events - they merely reflect a capture done with a snapshot length too short to capture all of the packet (any case where it's caused by something else is a bug). svn path=/trunk/; revision=15776
2005-09-13Don't pass an arbitrary string from a packet to a routine expecting aGuy Harris1-0/+1
format string - the arbitrary string might contain "%" characters, so the routine might then fetch arbitrary junk and try to use it as, for example, a string pointer. svn path=/trunk/; revision=15775
2005-09-13Convert some more "tvb_memcpy()"s fetching IPv4 and IPv6 addresses toGuy Harris5-54/+56
calls to "tvb_get_ipv4()" and "tvb_get_ipv6()". Fix a call in the BGP dissector to properly fetch an IEEE floating-point number. Update some I-D info. svn path=/trunk/; revision=15774
2005-09-12When jumping (e.g. using menu item Go/Go to Packet...) to a new packet which ↵Ulf Lamping1-3/+61
is currently not displayed, this newly selected packet will become the first in the packet list. This is inconvenient, as most of the time (at least) I'm interested not only in the packets behind the newly selected one, but also to have some history *before* it. So this change will scroll the packet list to have the selected packet after the first third of the packet list. This change won't take effect if the new packet is already visible (only the selection is changed) or it's near the beginning or end of the packet list (so the whole beginning/end of the list is shown). svn path=/trunk/; revision=15772
2005-09-12add number of defragmented bytes to the expert info outputUlf Lamping1-2/+3
svn path=/trunk/; revision=15771
2005-09-12Get rid of "dtd_grammar.out" on a "make distclean".Guy Harris2-9/+14
Get rid of all the Flex-generated (and Lemon-generated) files on a "nmake -f Makefile.nmake distclean". svn path=/trunk/; revision=15770
2005-09-12Add a header file to declare routines defined in lexer and used inGuy Harris4-8/+40
parser, or vice versa. svn path=/trunk/; revision=15769
2005-09-12Again, "g_strdown()" doesn't return a value in GLib 1.2[.x].Guy Harris1-6/+22
svn path=/trunk/; revision=15768
2005-09-12"g_strdown()" doesn't return a value in GLib 1.2[.x]; don't depend on itGuy Harris1-4/+7
doing so. svn path=/trunk/; revision=15767
2005-09-12The previous checkin for packet-isup.c was accidentally checked in alongGuy Harris3-46/+62
with some unrelated changes; it got rid of some calls to get IPv4/IPv6 addresses and add them to the protocol tree, replacing them with proto_tree_add_item() calls, and fixed up the length of one protocol tree item. Note that we have (at least) three count 'em three different routines for dissecting/displaying NSAPs (there might be more - I might have missed some), and suggest that we might want to reduce that to one. Update the URL for ICP values for IPv{4,6} addresses inside NSAPs. Fix the offset in the call to add the IPv6 address part of an NSAP containing such an address, and the length in the call adding the DSP for an NSAP containing an IPv4 address. Fix up indentation a bit. svn path=/trunk/; revision=15766
2005-09-12In now supports also:Michael Tüxen1-27/+83
- http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-sctpimpguide-15.txt - http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-addip-sctp-13.txt - http://www.ietf.org/internet-drafts/draft-stewart-sctp-pktdrprep-02.txt - http://www.ietf.org/internet-drafts/draft-ietf-tsvwg-sctp-auth-01.txt - http://www.ietf.org/internet-drafts/draft-ladha-sctp-nonce-02.txt svn path=/trunk/; revision=15765
2005-09-12Don't collide with the "regular" IPv6 defintions in at least someGuy Harris8-53/+30
platforms in ipv6-utils.h. svn path=/trunk/; revision=15764
2005-09-12fix fault defragmentation the same way as in the request/response pathUlf Lamping1-18/+7
Unfortunately, I don't have a capture file to test this... svn path=/trunk/; revision=15763
2005-09-12fix reassembling problem I've introduced yesterday, by using ↵Ulf Lamping3-68/+35
fragment_add_seq_next() function instead of fragment_add() in addition, I had to implement fragment_get_reassembled() in addition to fragment_get(), which works with reassembled_table svn path=/trunk/; revision=15762
2005-09-11Fix a typo.Guy Harris1-1/+1
svn path=/trunk/; revision=15761