aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-06-19batch of manual tvb_length conversionsEvan Huus19-36/+39
Change-Id: Ifea45514bdba8be5f62b9dc560027077297f631e Reviewed-on: https://code.wireshark.org/review/2456 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19gtk_table_new is deprecated in GTK3. Change to use grid instead, and usedameiss1-7/+9
ws_gtk_grid_attach_extended() to do the heavy lifting. Change-Id: I1c9d12556857196f53fadbce70f206a3cc41f7a5 Reviewed-on: https://code.wireshark.org/review/2433 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-06-19batch of manual tvb_length conversionsEvan Huus16-30/+30
Change-Id: Ib3a1ddc4342a7a8648d6ed8bfcb35aa229c56a27 Reviewed-on: https://code.wireshark.org/review/2445 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Removed SVN Id from epan dir.Dario Lombardo10-20/+2
Change-Id: I487a3451344796447f0d5621b993cc89c29e93b5 Reviewed-on: https://code.wireshark.org/review/2383 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Kerberos: fix dissection of packets when Record Mark is presentPascal Quantin2-2/+2
Bug: 10200 Change-Id: Ied8db64120131c029e276d66aeff8b81a45a7286 Reviewed-on: https://code.wireshark.org/review/2447 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19Long and short names are invertedPascal Quantin1-1/+1
Change-Id: Ief3c86562d5eadb845b5a32dc704a61ccd27fdf6 Reviewed-on: https://code.wireshark.org/review/2443 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19address_to_str() *does* take a const pointer.Guy Harris1-4/+1
At least now it does. (So does ep_address_to_str().) Change-Id: I5fdf15ca42faac802fd21b4b6f5b750ed402bd05 Reviewed-on: https://code.wireshark.org/review/2442 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Fix underflow causing infinite loop in openflow dissectorEvan Huus1-4/+9
Bug:10208 Change-Id: I8aff9523fd33cf9e0802153100ea032139966b26 Reviewed-on: https://code.wireshark.org/review/2440 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Those address_to_str() calls were in packet scope, and were safe.Guy Harris2-2/+2
Change-Id: Ic727eca800a1b8972cf1a09cf2cf4ef8cfe4d0ba Reviewed-on: https://code.wireshark.org/review/2439 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Use address_to_str(NULL, ...) for strings allocated outside dissectors.Guy Harris6-24/+81
ep_address_to_str() doesn't crash if called outside packet scope, but it's still not correct to use outside packet scope. Use address_to_str(NULL, ...) to allocate those strings, and then explicitly free them when we're done; exceptions don't get thrown between the allocate and free, so there's no risk of a leak. Change-Id: Iea2af93b0757e648d399e2ba64249224eb7e9e3c Reviewed-on: https://code.wireshark.org/review/2438 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Add sys/socket.h which should fix solarisEvan Huus1-0/+4
Change-Id: Ic6f9e8dce860c2bd54bb4c5e0f2d0526178fc720 Reviewed-on: https://code.wireshark.org/review/2437 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Revert "Update PIDL source files with the API changes done in g021e7af"Pascal Quantin4-7/+7
This reverts commit e09d127a9a08b587903a957145d3df655b190954. Change-Id: Id34b9f5875b1d63aaeed96b3ffdc8ece63ab4134 Reviewed-on: https://code.wireshark.org/review/2436 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19Revert "Update ASN.1 source files with the API changes done in g021e7af"Pascal Quantin95-405/+405
This reverts commit e308e7c4de81c2ff7159e444b865ac59de4faa2b. Change-Id: I079616d63f643f79f1bc03ef5fdf724f36df4071 Reviewed-on: https://code.wireshark.org/review/2435 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19rename variable to avoid shadow warningEvan Huus1-3/+3
Change-Id: I5934120da2dddf9076972ea3a471191f7dc9596a Reviewed-on: https://code.wireshark.org/review/2434 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Revert "Fixup: ep_address_to_str -> address_to_str"Michael Mann8-30/+24
Most (all?) of these functions are being called within GUI, so they can't have packet_scope, which is why they weren't already converted (I made this mistake once already) This reverts commit 7fea55a0541bcc5059f767970b6f6291f81d7b9c. Change-Id: I4bf29b206e5e1f5daefcec131309a8f6e78e1eb1 Reviewed-on: https://code.wireshark.org/review/2428 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann638-3408/+3408
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Fix warnings in test binariesEvan Huus2-19/+19
They aren't built with the same warning flags as normal, but if you add those flags a bunch of warnings show up. Change-Id: If3776fbd98cc45e473f055e07c86ea8f6a5034f7 Reviewed-on: https://code.wireshark.org/review/2432 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Add dissector for Generic Network Virtualization Encapsulation (Geneve).Jesse Gross4-0/+457
Change-Id: I3ecf655d8e49bb7b519c4ba95d4e45c7b114bdd6 Reviewed-on: https://code.wireshark.org/review/2359 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Dissectors for totemnet and totemsrp protocols implemented in corosync ↵Michael Mann8-0/+2655
cluster engine. Bug 3232. From Masatake YAMATO changes in patch3 (Masatake YAMATO): * Fix a typo(s/Sequnce/Sequence/) * Use variable len instead of a number literal * Put _U_ marker to length parameter of dissect_corosync_totemsrp_ip_address * Use tvb_report_length instread of tvb_length changes in patch5 (Masatake YAMATO): * packet-corosync-totemsrp.c: Adapt to new dissector_try_heuristic interface + pass hdtbl_entry argument to dissector_try_heuristic. * packet-corosync-totemnet.c: Initialize corosync_totemnet_port to 5405 changes in patch6 (Masatake YAMATO): * packet-corosync-totemsrp.c: Use tvb_reported_length instead of tvb_length. * packet-corosync-totemsrp.c: Remove unnecessary trailing space in string literals. * packet-corosync-totemnet.c: Remove SVN Id tag in a comment. changes in patch8 (Masatake YAMATO): * packet-corosync-totemnet.c: Remove SVN Id tag in comment(again). * packet-corosync-totemsrp.c: Use val_to_str_const instead of val_to_str. changes in patch9 (Masatake YAMATO): * wsutil/sober128.[ch]: New files derived from packet-corosync-totemnet.c. Decryption code is moved here. * packet-corosync-totemnet.c: Remove all decryption code from this file. Change-Id: Id832d9c5ce1be1668c857c9bbf39e8a84c31880c Reviewed-on: https://code.wireshark.org/review/725 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Use the same offset += rtnValue logic for all TLV types, instead of a ↵Anish Bhatt1-6/+16
special case for chassis, port & ttl. I've avoided using any mathematical checks even though tlv type vals increase linearly just in case they change in the future. Change-Id: I0ec7021df5b91543e12edf9ba8d9c4ac44ecb11c Signed-off-by: Anish Bhatt <anish@chelsio.com> Reviewed-on: https://code.wireshark.org/review/2193 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19To make a dissector available for Decode As, just use dissector_add_handle().Guy Harris6-14/+16
No need to use dissector_add_uint() with a bogus value. Change-Id: Ia5e51d199487ba14cd671c7df44231a0d407c50b Reviewed-on: https://code.wireshark.org/review/2431 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Fixup: tvb_ensure_length_remaining -> ↵Michael Mann23-78/+78
tvb_ensure_captured_length_remaining" See https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 021e7afc9fcba09094d0e2143cc434a34e3b09dc. Change-Id: I0640eabce5ce8c4ff3a88ebf848b499f8bb8ed2f Reviewed-on: https://code.wireshark.org/review/2429 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Add GTK modules for existing LBM dissectors.dameiss7-0/+1372
bug: 10204 Change-Id: Ie21cc07b0ac9a56648ec72062ce58a1ac800318e Reviewed-on: https://code.wireshark.org/review/2420 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Add the ability to dynamically add a new protocol to export PDU dialog boxPascal Quantin7-22/+54
Change-Id: I83012cc963d514982e40010e837e11a6fcf1bc3e Reviewed-on: https://code.wireshark.org/review/2423 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-19Generate xz compressed archives instead of .bz2-sBalint Reczey1-3/+6
Change-Id: Iad47516ae617f5ecac5b03f2d7e800208c499d4a Reviewed-on: https://code.wireshark.org/review/2403 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-06-19Add simple script to export release tarball right from GitBalint Reczey3-1/+41
The files not to be present in the release tarballs are filetered based on the contents of the .gitattributes files Change-Id: If12eb00cf174f5d5b6dfffd56685b078a4593bf8 Reviewed-on: https://code.wireshark.org/review/2402 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-06-19Update the sample code dealing with desegmentation to new style dissectorPascal Quantin1-2/+4
Change-Id: I2e9f6341138e7305b849a754e28edfd322d44160 Reviewed-on: https://code.wireshark.org/review/2415 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-19Optimize dissect_sip_uri()Jakub Zawadzki1-33/+30
- Combine tvb_find_guint8() for comma, semicolon into one tvb_pbrk_guint8() - Instead of fetching each character use tvb_pbrk_guint8() to fast forward. - Remove not needed tvb_find_guint8() call, as the result is discarded. Change-Id: I38d6775b187146656d47cea9b64f8e0ccad18d36 Reviewed-on: https://code.wireshark.org/review/2384 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18Remove svn $Id$ keyword in Lua scriptsPascal Quantin3-6/+0
Change-Id: I5c5f8659338aed36ba020a771a8b8222f2f7e025 Reviewed-on: https://code.wireshark.org/review/2416 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-06-18Sort the Ethernet pseudo-wire types so that they're together.Guy Harris1-24/+24
Separating the "try to guess whether there's a control word" type from the "yes, there's a control word" and "no, there's not a control word" types is just a huge UI botch. Make it clearer that the default is "Ethernet pseudo-wire, try to guess whether there's a control word". Change-Id: I91cc526fc709ad102b22ca67f5a9d7c98fffa0cc Reviewed-on: https://code.wireshark.org/review/2414 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-18Rename the filtername to initial_rttJoerg Mayer1-1/+1
Change-Id: I64af535dc07eb4310b212077bb4c52032e97ecdb Reviewed-on: https://code.wireshark.org/review/2413 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-18Get the handle for the pw_hdlc_nocw_hdlc_ppp dissector.Guy Harris1-0/+1
Change-Id: If7bc620c19e9c6511a724847e38cf0776d26b444 Reviewed-on: https://code.wireshark.org/review/2410 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-18Rename the Shortname of initial RTT to something short (iRTT)Joerg Mayer1-2/+2
Change-Id: I182f2cccae5a385572950f08fa0a6005dcf59ff1 Reviewed-on: https://code.wireshark.org/review/2409 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-18Change the indication for out-of-order packets. This is experimentalJoerg Mayer1-5/+7
and will be verified by Jasper next week Change-Id: I3cda397285e8174abb9c05b7aaf7c1bfabdfc71a Reviewed-on: https://code.wireshark.org/review/2408 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-18The data is actually http, call the http disector for it.AndersBroman1-4/+10
Change-Id: I58f63d79bc7f1838dd24a8dcd3e9c528648bdebd Reviewed-on: https://code.wireshark.org/review/2407 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18Undo more of Graham's changes:Joerg Mayer2-22/+6
- We don't expect to find all packages and it is normally OK for some to fail. Change-Id: I46c5edbf8ea3635fd703b222d4a9beb5ebb4745a Reviewed-on: https://code.wireshark.org/review/2406 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-18Only check for -msse4.2.Guy Harris1-30/+15
We don't care about instruction set extensions other than SSE 4.2, just check for that. Do so on all compilers other than MSVC. Change-Id: I227c31715aab6df0e020d6bc3e3aa41e1bc5cb7e Reviewed-on: https://code.wireshark.org/review/2405 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-18We don't need -Qunused-arguments with ClangGuy Harris1-4/+0
check_c_compiler_flag now checks for the message Clang prints for -f and -m flags it doesn't handle ("argument unused during compilation: '-{flag}'"), so the checks for it now should fail properly during testing, causing us not to use the flag in question. This means we don't need to suppress that warning, as we shouldn't be getting it. Change-Id: Ieb9657f9e2cee2f357acd52725199d78d2dad80f Reviewed-on: https://code.wireshark.org/review/2401 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-18We don't need -Werror=unknown-warning-option with Clang.Guy Harris1-6/+0
check_c_compiler_flag checks for the message Clang prints for an unknown warning option ("unknown warning option '-WXXX'"), and fails if it's produced, so we don't need to force the compiler to fail by passing it -Werror=unknown-warning-option. (Yes, the CMake way of handling those annoying options is different from the way we do that in autotools - autotools adds flags to force errors, CMake checks for the warning messages - but that's OK.) Change-Id: I5c2e5d6f4826eba7048736d5134d20417778276a Reviewed-on: https://code.wireshark.org/review/2400 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-18Another message from Clang for unknown -f and -m flags.Guy Harris1-0/+1
For -f and -m flags that don't apply to the target architecture(?), Clang doesn't fail but does print a warning "argument unused during compilation: '-{flag}'". Catch that and treat it as a failure indication, so we don't use that flag. Change-Id: I65948ada41fa44fb62f9a2b8b320f137a5902b8f Reviewed-on: https://code.wireshark.org/review/2399 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-18Check for lua by grepping the output of tshark -vEvan Huus1-2/+2
Grepping config.h doesn't work for out-of-tree builds. Change-Id: If3f551dffb04dd646f5adece57fac90dc48ff1c9 Reviewed-on: https://code.wireshark.org/review/2389 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-18Do C-Flags and CXX-Flags the same way.Guy Harris1-1/+2
It looks weird to have "-- " before C-Flags but not CXX-Flags. Change-Id: I95f309b60a45cbd4477c8ed6187b198ab9bac9d8 Reviewed-on: https://code.wireshark.org/review/2398 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-18Build unit test binaries with CmakeEvan Huus1-0/+15
That was surprisingly easy. Change-Id: Idda34580fd694cb0d253a121921f31d3731d3007 Reviewed-on: https://code.wireshark.org/review/2396 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-18Fix copy-paste probem in COAP dissectorShoichi Sakane1-3/+3
Bug:8070 Change-Id: I7a86a37f7de6b3e4e12fe1c47980a9a6604488d6 Reviewed-on: https://code.wireshark.org/review/2390 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Update ASN.1 source files with the API changes done in g971ffd6Pascal Quantin1-2/+2
Change-Id: Iac4952f64622cd28941f582adf54ecf7843f8c28 Reviewed-on: https://code.wireshark.org/review/2395 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Update PIDL source files with the API changes done in g021e7afPascal Quantin4-7/+7
Change-Id: I2917cbae077865f9ec171900810f85f54b349c2c Reviewed-on: https://code.wireshark.org/review/2394 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18PCLI: do not register UDP port 9000 by default as it is not allocated to ↵Pascal Quantin1-1/+1
this protocol by IANA Change-Id: I5f692ddf5ae5ba7366b34830bd9e99efacd66037 Reviewed-on: https://code.wireshark.org/review/2393 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Get rid of obsolete references to nettlePascal Quantin7-73/+8
Bug: 2089 Change-Id: Ie3337a1b750d8d95f6291c77dfd19cd1b0c57e83 Reviewed-on: https://code.wireshark.org/review/2388 Tested-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Get rid of some ancient qualityreview comments...Joerg Mayer1-7/+0
Change-Id: If25bdd594b20b656c345dcfe62765379f5dd9c5e Reviewed-on: https://code.wireshark.org/review/2392 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-18ssl_parse_key_list() gets called from the UI, so don't use packet scope.Guy Harris1-1/+8
Instead, explicitly allocate and free the address string. Using packet scope was causing test failures. Change-Id: Ie18d2da44d2eec8a92a6a86b0ba883a5525f49cd Reviewed-on: https://code.wireshark.org/review/2387 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-20 05:43:31 +0000